mirror of
https://github.com/garrytan/gstack.git
synced 2026-09-13 08:29:04 +02:00
Garry TanandClaude Fable 5.1
17733302cc
check-freeze.sh resolved its state dir as ${CLAUDE_PLUGIN_DATA:-$HOME/.gstack}
while every writer (/freeze, /guard, /unfreeze, /investigate) resolves through
bin/gstack-paths, GSTACK_HOME first. With GSTACK_HOME set, /freeze wrote
freeze-dir.txt under GSTACK_HOME, the hook read $HOME/.gstack, found no file,
and allowed everything — a deny-tier boundary failing open.
One resolver now: gstack_hook_state_root() in careful/bin/hook-extract.sh
(already sourced by both check-freeze.sh and check-careful.sh) implements the
exact gstack-paths chain, including the CLAUDE_PLUGIN_ROOT guard that keeps a
CLAUDE_PLUGIN_DATA leaked from another plugin from redirecting our state.
check-freeze.sh and gstack_hook_log_fire both call it; nothing spawns
gstack-paths from a hook.
Tests: the GSTACK_HOME deny regression, GSTACK_HOME-over-CLAUDE_PLUGIN_DATA
precedence, plugin-root guard both ways, and a byte-parity check against
bin/gstack-paths across six env combinations. Existing freeze tests now pass
CLAUDE_PLUGIN_ROOT like a real plugin install would.
Idea from PR #1509 (@NikhileshNanduri); implemented natively against the shared
resolver rather than a second fallback chain.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
105 lines
5.3 KiB
Bash
105 lines
5.3 KiB
Bash
#!/usr/bin/env bash
|
|
# hook-extract.sh — SHARED JSON helpers for gstack PreToolUse hooks.
|
|
# Sourced (never executed) by careful/bin/check-careful.sh and
|
|
# freeze/bin/check-freeze.sh via a path relative to each hook script.
|
|
#
|
|
# ONE copy on purpose. These two hooks previously carried separate extractor
|
|
# copies; the escaped-quote truncation bug got fixed in careful's copy while
|
|
# freeze silently kept the broken one. Any future parsing fix lands here and
|
|
# reaches both hooks by construction.
|
|
|
|
# gstack_hook_extract_field PAYLOAD FIELD
|
|
# Prints tool_input.FIELD when PAYLOAD is valid JSON and the field is a
|
|
# string ("" when absent or non-string). Returns 1 when no parser is
|
|
# available or the payload is not parseable JSON — the CALLER decides the
|
|
# polarity for that case (careful asks, freeze denies).
|
|
#
|
|
# python3 is tried first because it ships with macOS and most Linux distros
|
|
# and is reliably on PATH in a hook environment; node is the fallback.
|
|
gstack_hook_extract_field() {
|
|
_ghef_payload="$1"
|
|
_ghef_field="$2"
|
|
if command -v python3 >/dev/null 2>&1; then
|
|
printf '%s' "$_ghef_payload" | python3 -c 'import sys,json
|
|
field = sys.argv[1]
|
|
d = json.loads(sys.stdin.read())
|
|
c = d.get("tool_input", {}).get(field, "")
|
|
sys.stdout.write(c if isinstance(c, str) else "")' "$_ghef_field" 2>/dev/null && return 0
|
|
fi
|
|
if command -v node >/dev/null 2>&1; then
|
|
printf '%s' "$_ghef_payload" | node -e 'let s="";process.stdin.on("data",d=>s+=d).on("end",()=>{try{const j=JSON.parse(s);const c=(j&&j.tool_input&&j.tool_input[process.argv[1]])||"";process.stdout.write(typeof c==="string"?c:"")}catch(e){process.exit(3)}})' "$_ghef_field" 2>/dev/null && return 0
|
|
fi
|
|
return 1
|
|
}
|
|
|
|
# gstack_hook_json_string TEXT
|
|
# Prints TEXT as a JSON string literal (surrounding quotes included),
|
|
# encoding quotes, backslashes, control characters and newlines. Never build
|
|
# hook JSON with printf/sed interpolation: a path containing a quote or a
|
|
# newline produces malformed JSON, and Claude Code silently ignores the
|
|
# whole decision — a deny that no-ops exactly when it matters.
|
|
gstack_hook_json_string() {
|
|
_ghjs_text="$1"
|
|
if command -v python3 >/dev/null 2>&1; then
|
|
printf '%s' "$_ghjs_text" | python3 -c 'import sys,json; sys.stdout.write(json.dumps(sys.stdin.read()))' 2>/dev/null && return 0
|
|
fi
|
|
if command -v node >/dev/null 2>&1; then
|
|
printf '%s' "$_ghjs_text" | node -e 'let s="";process.stdin.on("data",d=>s+=d).on("end",()=>process.stdout.write(JSON.stringify(s)))' 2>/dev/null && return 0
|
|
fi
|
|
# Last-resort fallback (no parser on PATH): strip to a safe charset so the
|
|
# envelope stays valid JSON even if the message loses characters.
|
|
printf '"%s"' "$(printf '%s' "$_ghjs_text" | tr -cd 'a-zA-Z0-9 ._/:@=+-' )"
|
|
}
|
|
|
|
# gstack_hook_decision DECISION REASON
|
|
# Emits the full PreToolUse hookSpecificOutput envelope with REASON safely
|
|
# JSON-encoded. DECISION is "ask" or "deny". The decision MUST be nested
|
|
# under hookSpecificOutput — Claude Code ignores a top-level
|
|
# permissionDecision, which silently no-ops the block.
|
|
gstack_hook_decision() {
|
|
_ghd_decision="$1"
|
|
_ghd_reason="$2"
|
|
_ghd_encoded=$(gstack_hook_json_string "$_ghd_reason")
|
|
printf '{"hookSpecificOutput":{"hookEventName":"PreToolUse","permissionDecision":"%s","permissionDecisionReason":%s}}\n' "$_ghd_decision" "$_ghd_encoded"
|
|
}
|
|
|
|
# gstack_hook_state_root
|
|
# Print the gstack state root, resolved with EXACTLY the chain bin/gstack-paths
|
|
# uses (GSTACK_STATE_ROOT): GSTACK_HOME, then CLAUDE_PLUGIN_DATA only when
|
|
# CLAUDE_PLUGIN_ROOT names gstack (a CLAUDE_PLUGIN_DATA leaked from another
|
|
# plugin via CLAUDE_ENV_FILE must not redirect our state), then $HOME/.gstack,
|
|
# then a project-local .gstack. Hooks run on every Edit/Bash call, so this is
|
|
# pure bash — never spawn gstack-paths from a hook. The writers (/freeze,
|
|
# /guard, /unfreeze, /investigate) resolve through gstack-paths; a reader that
|
|
# used a different chain failed OPEN whenever GSTACK_HOME was set (#1459).
|
|
# test/hook-scripts.test.ts pins parity against gstack-paths.
|
|
gstack_hook_state_root() {
|
|
if [ -n "${GSTACK_HOME:-}" ]; then
|
|
printf '%s\n' "$GSTACK_HOME"
|
|
elif [ -n "${CLAUDE_PLUGIN_DATA:-}" ] && printf '%s' "${CLAUDE_PLUGIN_ROOT:-}" | grep -qi "gstack"; then
|
|
printf '%s\n' "$CLAUDE_PLUGIN_DATA"
|
|
elif [ -n "${HOME:-}" ]; then
|
|
printf '%s\n' "$HOME/.gstack"
|
|
else
|
|
printf '%s\n' ".gstack"
|
|
fi
|
|
}
|
|
|
|
# gstack_hook_log_fire SKILL PATTERN
|
|
# Append a hook_fire analytics record (pattern name only, never command
|
|
# content). Resolves the state root through gstack_hook_state_root so tests
|
|
# never pollute the operator's real analytics file. Best-effort: failures
|
|
# never affect the hook decision.
|
|
gstack_hook_log_fire() {
|
|
_ghlf_dir="$(gstack_hook_state_root)/analytics"
|
|
mkdir -p "$_ghlf_dir" 2>/dev/null || true
|
|
# Fields are JSON-encoded (a repo basename can carry quotes/backslashes) —
|
|
# same rule this file states for decisions: never raw-interpolate into JSON.
|
|
_ghlf_repo=$(basename "$(git rev-parse --show-toplevel 2>/dev/null)" 2>/dev/null || echo "unknown")
|
|
printf '{"event":"hook_fire","skill":%s,"pattern":%s,"ts":"%s","repo":%s}\n' \
|
|
"$(gstack_hook_json_string "$1")" \
|
|
"$(gstack_hook_json_string "$2")" \
|
|
"$(date -u +%Y-%m-%dT%H:%M:%SZ)" \
|
|
"$(gstack_hook_json_string "$_ghlf_repo")" >> "$_ghlf_dir/skill-usage.jsonl" 2>/dev/null || true
|
|
}
|