mirror of
https://github.com/garrytan/gstack.git
synced 2026-11-17 05:41:50 +01:00
* fix(ship): base merges, adjacent base edits, test-only and audit-requested fixes no longer force a second review loop (GST-407, GST-384, GST-391) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * ship driver: trim two phrases for headroom with #3662 Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * ship driver: keep the Next steps heading phrase the handoff check reads; trim elsewhere Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * test: regenerate ship goldens Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix: pre-landing review fixes comparePath returns same only when every hunk sits where the base change puts it (patch-ids ignore positions) and treats a file-mode change as changed; the scoped-review packet says when a fence is truncated; --docs-result must be the posted audit's result; the --context-reviewed record goes beside the packet, outside the worktree. Negative controls for each. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix: pass-2 review fixes A test edit routes as tests= only when it adds lines with no gate tag; a removed or changed line or an unreadable test diff goes through the full loop. Diffs skip textconv. A hunkless patch (binary, empty, mode-only) is same when its patch-id matches. Without --reviewed-base test files route as before. finish's packet path and attempt's state directory have fallbacks. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix: Step 11 review fixes; a version-only stamp_files edit after review is release metadata (GBRA-251) gateEditedPaths reads removed lines only inside hunks; carry refuses when a path listing fails; docs freshness stops on a failed listing; attempt counts an unreadable state file. releasePaths includes stamp_files paths whose edit is a version swap under stamp_patterns. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix: no test edit skips review; guard packet writes; exclusive attempt state A test-only edit with no gate tag gets the scoped fix-check of its test hunks instead of a lanes-only rerun. Packet write failures print a STOP or RECEIPT_CARRY_REFUSED. attempt's allowance uses an exclusive create. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix: attempt prints gstack's install command; carry checks the product diff outside context paths The attempt STOP no longer echoes the audit child's fix text. A scoped-review carry now requires the product patch-id without the context paths to match at both heads. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix: oversized packets take the full loop; exact --docs-requested match; name-only test globs only in test dirs A scoped-review packet section over 200 lines sends that path to the full loop instead of a truncated packet. The docs-result path match is exact. test_*.py, *Test.java and similar count as test code only under a test directory. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * docs(unattended): carry's scoped-review refusal and what it keeps Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * docs: carry's scoped-review route in ship-policy, review-policy and troubleshooting (docs-a-1) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * test(windows): curate ship-rereview-triggers out of the Windows lane like ship-release (run 41193336209) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix(review-log): record a notes-only /ship pass clean; name the cause and repair when a pass's tree moved (GST-430) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix(receipt): carry and write handle PRs with thousands of files; tree receipt fails closed on a failed diff (GST-448) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix(ship): preflight routes RECEIPT_CARRY_SCOPED_REVIEW to the scoped review; carry --dry-run writes no packet (GST-442) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * docs(ship): Step 1.4 and Step 16 route the scoped-review refusal and the --docs-requested fix; trims keep the cap (GST-442, GST-444) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix: /ship review pass 1: notes-only floor, scoped carry order, named temp and diff refusals - A notes-only pass is recorded clean only when every finding is fixed, or noted or deferred below the blocking floor (never CRITICAL or blocking), by its logger-stamped action, and the findings account for the claimed issue and critical counts (GST-430). - The preflight scoped carry route commits and pushes the base-merge fix before writing the packet (GST-442). - patchId refuses by name on an unwritable TMPDIR; the tree receipt names why its diff failed (GST-448). - Step 16 stage 3 spells out --docs-requested with its --docs-result (GST-444). Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * test: pin the Step 16 --docs-requested route with its --docs-result Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix: a claimed clean review row with a logger-stamped open gate finding reads UNVERIFIED (red-team, pass 1) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix: Step 11 findings: gate rows from --findings are stamped, one open rule, stale patch-id dirs swept - deriveFromFindings stamps gate rows with the session kind before deriving status, so a findings file cannot dispose of a gate finding the unattended logger forces open (outside-voice#1). - reviewFreshness reads a claimed row's findings with isOpenByAction, the rule the notes-only rewrite uses; noted and deferred clear a finding only when it is marked blocking: false and is not CRITICAL. - patchId sweeps gstack-patch-id-* directories over an hour old that a killed carry left in TMPDIR. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix: Step 11 round 2: stamped-open gates win over status and disposition; resolved gate, skipped and below-floor actions stay CURRENT - isOpenFinding treats action 'open' (the logger's forced-open stamp) as open before a row's status or disposition. - reviewFreshness flags a claimed clean row only for an 'open' action or a CRITICAL or blocking deferral or note, so interactive kept and restored gates, skipped advisories and INFORMATIONAL deferrals read CURRENT as before. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix: carry dry run offers the scoped route last; patch-id diff under the git dir; changelog matches the review-log floor Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix: a claimed clean review row with any unresolved non-gate CRITICAL finding reads UNVERIFIED (pass 2 red-team) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * docs: carry dry-run scoped route, patch-id directory, tree-receipt refusal (docs-d-1 audit) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix(ship): Step 3 names merge conflicts in its STOP sentence again (ship-workflow-clarity pin) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix(tree-receipt): keep the gated-to-current diff at the file helper timeout (60 s); pregate literals check Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * test(carry): large-diff fixture sets core.longpaths so Git for Windows can add its long receipt paths (windows-free-shard 1, run 41210080055) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix(review): a stale local base branch yields to its origin twin in gate-diff and diff-scope (GST-462) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix(ship): Step 11 saves the targeted record and the receipt writes carry it; Step 9 clears it (GST-464) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * changelog: GST-464 and GST-462 Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix(review): pass 1: ahead and diverged labels, diff-scope needs shared history; preflight refreshes origin/<base> and stops on a diff far beyond the PR (GST-462, HARN-15) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix: pass-2 review fixes for base twin, prSized stop and targeted record Resolve the tracking twin by refs/remotes/<remote>/<ref> and only for a bare branch name, keep a local base that is ahead or diverged, quote the prSized stop's base and name the fork case, and have every Step 9 entry create, exclude and clear .gstack/tmp/targeted.json. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix: origin's tracking base wins whenever related; prSized lower bound The fix-check found that keeping a local base ahead of origin left unpushed base commits out of the gate scan while review-plan listed them. The tracking branch now wins whenever it shares history with HEAD, an explicit origin/main reads refs/remotes/origin/main, the preflight also stops when the diff lists fewer files than the PR, and the Step 9 exclude line survives a missing .git/info and an exclude file without a final newline. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * changelog: the tracking-ref claim holds while the tracking branch exists Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * test: repin the two ship section briefs under no-loss replay GST-464 GST-464 brief-identity check: every reviewer brief lib/review-brief.ts cuts from ship/sections/review-army.md and adversarial.md stays byte-identical to the bodies the L and GST-257 replays admitted; only lead instructions outside the cut spans changed. The check is a test CI runs. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * ship: keep Step 9's PASS_HEAD sentence whole; repin review-army under GST-464 The targeted-record line follows the PASS_HEAD/RANGE_BASE sentence instead of splitting it (test/review-fix-range.test.ts pins that sentence). The brief-body check still holds: every reviewer brief is byte-identical. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix: restore bin/gstack-ship-receipt after the main merge The merge commitb10e2dbwrote a truncated copy of the file. This is the three-way merge of both sides with the refused() union: main's codes plus RECEIPT_CARRY_SCOPED_REVIEW. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * review-collect: narrow the consumer scan and give it one 300 s deadline (GST-544) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * review-collect: keep the consumer scan deadline under the 180 s plan timeout (review fix) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * review-collect: plain paths under --literal-pathspecs; whole-millisecond timeout override (review fix) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * review-collect: whole-tree grep for non-UTF-8 names, no argument spread, name spawn errors (review fix) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * review-collect: cap the consumer grep output at 256 MB across calls; per-scan deadline wording (review fix, cycle 4) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * review-collect: read a missing spawn status as null (Bun 1.4.2 returns undefined on ENOENT) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * test: review-collect whole-tree helper reads a null status as -1 (typecheck:test ratchet) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * review-bots: /review and /ship triage every configured review bot, not only Greptile (#3122) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix: pre-landing review fixes (gh before 2.48 pages without --slurp; driver routes Step 10; tests for guards, review-bot fence, REMOTE_SLUG owner) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix: drop the review-bot fence test that could not fail (the tool-fence WARN degrade is unreachable: placeholder spans are skipped first) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix: Step 11 review fixes (record by comment id so a filename never reaches a shell; lookup failures are errors; tojson pages; longest bot prefix wins) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix: pass-2 review fixes (record refuses * paths, colliding ids and a missing fetch dir; parent requires id and dir; botOwning doc) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * review: classify the PR type and always check repo conventions (#356) The checklist now opens with a PR-type line (application, CI/infra, scripts/tooling, docs-only or mixed). Application and mixed diffs run every category; other types always run five categories, including the new Repo Conventions & Platform Fit, and report the rest as not applicable in one line instead of skipping silently. No-loss replay: GSTA-224 H1 preregistered no-loss run (run id gsta224-h1-20261031, Opus 5.5, 81 calls, $9.53) against main's checklist with a no-gstack arm; every preregistered bar passed. The review/checklist.md pin in test/review-packets-removed.test.ts moves to a32963ef with replay 'GSTA-224 H1'. Refs GSTA-224 Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * review-bots: allowlist the record placeholders and match Step 10's id rule in tests The record fence uses <comment-id>, <fix|fp|already-fixed> and <category>, each with an enum or numeric grammar; <greptile-dir> becomes <bot-dir>. review/greptile-triage.md also lists every REVIEW_BOTS skip reason. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * docs: review-bot triage covers every configured bot (#3122) README, CONTRIBUTING, the contributor reference and standalone-binaries name gstack-review-bots and the review-bot fence; TODOS drops the #3122 item; the changelog fragment covers record-by-id and lookup errors. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * test: the PR-type test also pins the compose, Terraform and README/CHANGELOG phrases Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * test: follow the review-bot rename in the remote free tier's three reds The cross-skill consistency judge describes review-bot-history.md and its record helper; the tracker-guard exemption for the removed raw Greptile fetch in review/greptile-triage.md is dropped (the fetch now lives in gstack-review-bots, whose bodies still reach context only through gstack-issue-guard); the Step 10 PR-check test expects 'Review bots: not run'. HARNESS_VERSION stays 6: skill-fixture.ts and llm-judge.ts are recorded non-behavioral for every other case. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * test: keep the cross-skill judge's rubric to one renamed bullet Name review-bot-history.md beside the older greptile-history.md so the calibration corpus still matches, and keep the REMOTE_SLUG bullet. One live 3-sample panel at this tree: consistent 3/3, scores 4/4/4. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * changelog: H1 fragment passes prose lint Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * changelog: name the H1 fragment after its branch; TODOS drops #356 Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * docs: /review's PR type step in docs/skills.md (#356) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * ship-policy: review_exclude_paths key and loadPolicyAt (GST-508) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * review: apply the base policy's review_exclude_paths and the reviewer diff ceiling (GST-508) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * receipt: bind review_exclude in write, carry and the queue (GST-508) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * docs, tests and changelog for review_exclude_paths (GST-508) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix: pre-landing review fixes (binary by bytes, links kept, untracked files out of the selection) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix: keep binary files at code paths under review_exclude_paths Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * docs: name the reasons that keep a binary file under review_exclude_paths Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix: keep every review_exclude_paths candidate when the gate scan is unknown; docs example names its version Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * test: keep the NUL fixture clear of the sync-spawn tripwire Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * changelog: split the ceiling sentence Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix: keep a live binary file whose bytes cannot be read; tests render outside voices from a clean checkout and read the ship fixture text Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * test(review-exclude): explicit +x for the census script; skip the chmod-000 read case on Windows and root Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * refactor: move loadPolicyAt to lib/ship-policy-at.ts so lib/ship-policy.ts stays under the 800-line module cap Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix: refuse a base that contains HEAD; skip a self-pointing origin/HEAD (GST-774) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * chore: regenerate gstack-doctor-components.sh for BASE_CONTAINS_HEAD Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix: land resumes a merged merge-only PR instead of refusing BASE_CONTAINS_HEAD (GST-774 review) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * docs: changelog fragment for GST-774 Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * docs: troubleshooting names diff-scope base_contains_head and the self-pointing no_base case (GST-774 docs audit) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * test: repin the reviewer briefs to GST-508's no-loss-tested bytes ship/sections/review-army.md, ship/sections/adversarial.md and lib/review-depth.ts now pin the bytes the GST-508 preregistered no-loss replay ran atef2760f(handoffs/GSTA-202/noloss-results.md in the GStack Minder drive): Arm V 33/41 vs R 33/41, delta 4, exact sign flip, p_NI 0.0279 (pass). The merge of main83ae96eleaves these three files byte-identical toef2760f, and an Arm P unit (3593) renders byte-identical briefs atef2760fand at the merge. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix: GST-774 review round 1 — merged resume depth, aliased and detached PR checkouts, develop/trunk defaults Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * ship: Step 20 says a metrics row, keeping DRIVER.md at 12 KB after the main merge Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * test: ship-parts resend case leaves room for the first phase-3 part after the Step 9 targeted-record sentence Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix: /ship delivers review/checklist.md in two parts so checklist v1 fits the 24576-byte part cap (#3670) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * changelog: drop the GST-407 and GST-430 fragments, already released on main (stacked history) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * wave review-53cfb5bfe011: lib/ship-policy.ts back to 800 lines (module-size ratchet after merging #3744 and #3795) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * wave review-53cfb5bfe011: /ship pass 1 fixes - lib/ship-receipt-depth.ts: a merged resume (land after a true merge) no longer recomputes the review_exclude digest over the emptied range, so it lands instead of RECEIPT_INVALID (failing-first land test with review_exclude_paths active). - bin/gstack-review-dispatch render: a standalone targeted render under an active review_exclude_paths refuses and points at the pass manifest voices stage, instead of writing a brief with no selection that leaves verify dirty (failing-first test). - test/default-base.test.ts: #3795 expectations follow main R51 depth (light for an 80-line code diff; runtime_lines=80 still proves the real base). - test/review-dispatch.test.ts: the GST-897 fingerprint test renders from the clean checkout, like its neighbor, because CI rebuilds the tracked lib/diagram-render/dist/diagram-render.html and the reviewer diff ceiling refused the ROOT render. * wave review-53cfb5bfe011: /ship pass 2 fixes - lib/review-exclude.ts: binaryContent reads each blob's first 8,000 bytes (git cat-file blob, 8 KB buffer) instead of one --batch read capped at 256 MB, so head mode (receipt, carry, queue) and the plan agree past 256 MB of blobs; an unreadable blob is kept, as in live mode. Failing-first test with two 270 MB blobs. - lib/review-bots.ts: a file-level bot review comment (subject_type file, no line position) is triaged instead of read as outdated. Failing-first test. - test/ship-queue-land.test.ts: the merged-resume exclusion test runs its gate scan under the fixture state root, not the real home (CI free-suite 6 home containment). * fix: merge follow-ups for main3d99c22: origin/* stays qualified in diff-scope's twin step, retro skeleton back under its cap, combined no-loss pin GST-508+R51+GST-911 * fix(review): receipt write gate-scans whenever the base declares review_exclude_paths; collectLive never re-qualifies origin/<base> (#3852 /ship red-team#1, outside-voice#1) * test: the docs-only receipt digest test keeps its gate scan out of the real home (free-suite shard 5 FREE_SUBSHARD_REJECTED) * fix(mergefc292e22f): tentative REVIEW_EXCLUDE_KEY_VERSION, classify targeted.json, render main's new outside-voice test from a clean checkout - lib/ship-policy.ts: REVIEW_EXCLUDE_KEY_VERSION 1.93.0.0 -> 1.94.0.0, the next-minor tentative form stamp_paths moves (docs/ship-policy.md, #3512); 1.93.0.0 is a released heading that never names the key. - test/gstack-clean-producers.test.ts (new from main): KEPT gains targeted.json, the wave's --review-targeted input. - test/review-dispatch.test.ts: main's wrong-tree test rendered the outside voice from ROOT; a CI build that dirties ROOT pushes that diff past the wave's REVIEW_DIFF_MAX_BYTES ceiling, so render refused and verify saw no brief (exit 3). It now runs in cleanCheckout like the wave's other outside-voice tests. * test(merge68410828f): GST-967's brief-body pin carries the wave's GST-508 placeholders The merged sectionTexts differ from main's by exactly the wave's GST-508 exclude-pathspec lines (merged minus main equals wave minusfc292e22f); the 1,440-case plan grid still hashes to main's MAIN_PLANS. Checks: GStack Minder drive handoffs/GSTA-202/merge-6841-checks.md. * fix(mergee85005482): targeted classes since the read accept an empty range; the wave's receipt tests pass main's targeted record - lib/ship-receipt-depth.ts targetedClassesSince (main, GST-986) reads the range from the commit the targeted reader read to HEAD through headInputs, which since #3795 runs gstack-diff-scope's BASE_CONTAINS_HEAD check. When the reader read HEAD itself the range is empty, diff-scope reported base_contains_head, and every write with --review-targeted was refused (the product patch matched). It now passes merged=true (--merged), which skips only that check; an ancestor check already guards the range. - test/review-exclude.test.ts and test/review-targeted.test.ts: since #3887 write refuses a money head with no targeted record and requires the record's head, so the wave's two writes that must succeed pass one, as main's own tests do (targetedAtHead in test/ship-receipt-depth.test.ts). * test(mergee85005482): drop the wave's duplicate targeted.json KEPT entry Main (#3887) classified .gstack/tmp/targeted.json in KEPT too; the auto-merge kept both keys, which typecheck:test rejects (TS1117). Main's entry stays. * test(mergee85005482): ship size ledger entry for the merged tree (-232 B) Main's ship size ledger plus the wave's entries summed to 345,334 B; the merged tree measures 345,102 B because DRIVER.md takes main's shorter Step 19 line. Recorded with scripts/size-ledger.ts record ship. --------- Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
354 lines
21 KiB
TypeScript
354 lines
21 KiB
TypeScript
/**
|
||
* Review Army resolver — parallel specialist reviewers for /review
|
||
*
|
||
* Generates template prose that instructs Claude to:
|
||
* 1. Detect stack and scope (via gstack-diff-scope)
|
||
* 2. Select and dispatch specialist subagents in parallel
|
||
* 3. Collect, parse, merge, and deduplicate JSON findings
|
||
* 4. Feed merged findings into the existing Fix-First pipeline
|
||
*
|
||
* Shipped as Release 2 of the self-learning roadmap (SELF_LEARNING_V0.md).
|
||
*/
|
||
import type { TemplateContext } from './types';
|
||
import { CC_BACKGROUND_DEFAULT_SINCE, FOREGROUND_IF_AVAILABLE, BACKGROUND_RECOVERY } from './constants';
|
||
import { learningsCapture, LEARNINGS_VERDICT } from './learnings';
|
||
import { DEFENSIVE_REVIEW_FRAMING, fixtureSummaryMode } from './defensive-review';
|
||
|
||
function generateSpecialistSelection(ctx: TemplateContext): string {
|
||
const isShip = ctx.skillName === 'ship';
|
||
const stepSel = isShip ? '9.1' : '4.5';
|
||
const stepMerge = isShip ? '9.2' : '4.6';
|
||
const nextStep = isShip ? 'Step 9.3 (cross-review dedup)' : 'Step 4.8 (adversarial review), then Step 5';
|
||
return `## Step ${stepSel}: Review Army — Specialist Dispatch
|
||
|
||
### Detect stack and scope
|
||
|
||
\`\`\`bash
|
||
_SM=$(${ctx.paths.binDir}/gstack-state-matrix detect --base <base>) || _SM=SCOPE_STATE_MACHINE=unknown; source <(echo "$_SM")
|
||
source <(${ctx.paths.binDir}/gstack-diff-scope <base> 2>/dev/null) || true
|
||
set | grep '^SCOPE_'
|
||
STACK=""
|
||
[ -f Gemfile ] && STACK="\${STACK}ruby "
|
||
[ -f package.json ] && STACK="\${STACK}node "
|
||
[ -f requirements.txt ] || [ -f pyproject.toml ] && STACK="\${STACK}python "
|
||
[ -f go.mod ] && STACK="\${STACK}go "
|
||
[ -f Cargo.toml ] && STACK="\${STACK}rust "
|
||
[ -f pubspec.yaml ] && STACK="\${STACK}dart "
|
||
echo "STACK: \${STACK:-unknown}"
|
||
DIFF_BASE=$(git merge-base origin/<base> HEAD)
|
||
DIFF_LINES=$(git diff "$DIFF_BASE" --numstat | awk '{n+=$1+$2} END {print n+0}')
|
||
echo "DIFF_LINES: $DIFF_LINES"
|
||
# Detect test framework
|
||
TEST_FW=""
|
||
{ [ -f jest.config.ts ] || [ -f jest.config.js ]; } && TEST_FW="jest"
|
||
[ -f vitest.config.ts ] && TEST_FW="vitest"
|
||
{ [ -f spec/spec_helper.rb ] || [ -f .rspec ]; } && TEST_FW="rspec"
|
||
{ [ -f pytest.ini ] || [ -f conftest.py ]; } && TEST_FW="pytest"
|
||
[ -f go.mod ] && TEST_FW="go-test"
|
||
[ -f pubspec.yaml ] && TEST_FW="dart-test" && grep -qsE '^ +sdk: *.?flutter' pubspec.yaml && TEST_FW="flutter-test"
|
||
echo "TEST_FW: \${TEST_FW:-unknown}"
|
||
\`\`\`
|
||
|
||
### Read specialist hit rates (adaptive gating)
|
||
|
||
\`\`\`bash
|
||
${ctx.paths.binDir}/gstack-specialist-stats 2>/dev/null || true
|
||
\`\`\`
|
||
|
||
### Select specialists
|
||
|
||
Select specialists from the scope signals above.
|
||
|
||
**Always-on (every review with 50+ changed lines):**
|
||
1. **Testing** — read \`${ctx.paths.skillRoot}/review/specialists/testing.md\`
|
||
2. **Maintainability** — read \`${ctx.paths.skillRoot}/review/specialists/maintainability.md\`
|
||
|
||
**If DIFF_LINES < 50:** Skip all specialists except State Machines (item 9 decides it). Print: "Small diff ($DIFF_LINES lines) — specialists skipped." Continue to Step ${stepMerge} with the ${isShip ? 'core/design-lite' : 'core'} findings and an empty or State Machines-only specialist list, then the parent's Exploratory QA step and ${nextStep}. Small diffs skip fan-out, never the parent-owned smoke probes or core shared-code checks.
|
||
|
||
**Conditional (dispatch when its scope signal is true):**
|
||
3. **Security** — if SCOPE_AUTH=true, OR if SCOPE_BACKEND=true AND DIFF_LINES > 100. Read \`${ctx.paths.skillRoot}/review/specialists/security.md\`
|
||
4. **Performance** — if SCOPE_BACKEND=true OR SCOPE_FRONTEND=true. Read \`${ctx.paths.skillRoot}/review/specialists/performance.md\`
|
||
5. **Data Migration** — if SCOPE_MIGRATIONS=true. Read \`${ctx.paths.skillRoot}/review/specialists/data-migration.md\`
|
||
6. **API Contract** — if SCOPE_API=true. Read \`${ctx.paths.skillRoot}/review/specialists/api-contract.md\`
|
||
7. **Design** — if SCOPE_FRONTEND=true. Use the existing design review checklist at \`${ctx.paths.skillRoot}/review/design-checklist.md\` and run the mechanical pass at the top of that checklist (the user-installed design detector, when present) before the LLM items
|
||
8. **Simplification** — if DIFF_LINES > 100. Read \`${ctx.paths.skillRoot}/review/specialists/simplification.md\`. Advisory-only lens: hunts unrequested structure (hand-rolled stdlib, one-implementation abstractions, dependencies duplicating platform features), never coverage.
|
||
9. **State Machines** — if SCOPE_STATE_MACHINE is true or unknown: read \`${ctx.paths.skillRoot}/review/specialists/state-machines.md\`, run \`${ctx.paths.binDir}/gstack-state-matrix outfile\`, Read the file it prints, write the full output there, then run \`${ctx.paths.binDir}/gstack-state-matrix check <file>\` on it.
|
||
|
||
### Adaptive gating
|
||
|
||
After scope-based selection, apply adaptive gating based on specialist hit rates:
|
||
|
||
For each conditional specialist that passed scope gating, read the \`gstack-specialist-stats\` output:
|
||
- If tagged \`[GATE_CANDIDATE]\` (0 findings in 10+ dispatches): skip it. Print: "[specialist] auto-gated (0 findings in N reviews)."
|
||
- If tagged \`[NEVER_GATE]\`: always dispatch regardless of hit rate.
|
||
|
||
**Force flags:** \`--<specialist>\` (e.g. \`--simplification\`) or \`--all-specialists\` in the prompt force-includes it.
|
||
|
||
Print the selection:
|
||
"Dispatching N specialists: [names]. Skipped: [names] (scope not detected). Gated: [names] (0 findings in N+ reviews)."`;
|
||
}
|
||
|
||
/**
|
||
* The diff command every dispatched reviewer runs. In /ship the parent writes the
|
||
* base sha into the prompt (the merge base on pass 1, RANGE_BASE from pass 2 on):
|
||
* a reviewer is its own process and never sees the parent's shell variables, so a
|
||
* `$RANGE_BASE` reference there would silently fall back to the whole branch.
|
||
*/
|
||
function diffBase(ctx: TemplateContext): string {
|
||
return ctx.skillName === 'ship' ? 'DIFF_BASE=<diff-base>' : 'DIFF_BASE=$(git merge-base origin/<base> HEAD)';
|
||
}
|
||
|
||
function generateSpecialistDispatch(ctx: TemplateContext): string {
|
||
return `### Dispatch specialists in parallel
|
||
|
||
For each selected specialist, launch an independent subagent via the Agent tool.
|
||
**Launch ALL selected specialists in a single message** (multiple Agent tool calls)
|
||
so they run in parallel. Each subagent has fresh context — no prior review bias.
|
||
${ctx.skillName === 'ship' ? `
|
||
**Fan-out (\`--review-fanout auto|serial|parallel\` in the prompt; default \`auto\`).**
|
||
Under \`auto\`, when the host reports fewer free subagent slots than selected
|
||
specialists (Capy caps a thread at 8 running subagents, and waiting or idle ones hold
|
||
a slot), dispatch in batches of the free-slot count, at least one per batch, each
|
||
batch in one message, and start the next batch only after every reader of the
|
||
previous one has finished or is confirmed stopped; print \`Fan-out: N specialists in
|
||
M batches of K\`. A host that reports no slot count runs one parallel batch.
|
||
\`serial\` is batches of one; \`parallel\` is one batch regardless of slots (a refused
|
||
launch is a failed reader, never silently dropped coverage). Batching changes the
|
||
order, never the set: every selected specialist still runs before Step 9.2 merges.
|
||
` : ''}
|
||
**Each specialist subagent prompt:**
|
||
|
||
Each specialist prompt includes:
|
||
|
||
1. The specialist's checklist path from the selection above (the subagent reads it; never paste its content)
|
||
2. Stack context: "This is a {STACK} project."
|
||
3. Past learnings for this domain (if any exist):
|
||
|
||
\`\`\`bash
|
||
${learningsCapture(`${ctx.paths.binDir}/gstack-learnings-search --type pitfall --query "{specialist domain}" --limit 5`)}
|
||
${LEARNINGS_VERDICT}
|
||
\`\`\`
|
||
|
||
If learnings are found, include them: "Past learnings for this domain: {learnings}"
|
||
|
||
4. **Defensive framing (Security specialist and the Red Team below only).** Begin the prompt with:
|
||
"${DEFENSIVE_REVIEW_FRAMING}"
|
||
and replace its full-diff command with: "${fixtureSummaryMode(ctx.skillName === 'ship')}"
|
||
Every other specialist, including Testing, reads the full diff with fixtures.${ctx.skillName === 'ship' ? ' In that command `<exclude>` is the `:(top,exclude,glob)` items on the reader\'s `DIFF_CMD:` line (the base policy\'s review_exclude_paths), empty when it has none; gstack-review-dispatch fills it.' : ''}
|
||
|
||
5. Instructions:
|
||
|
||
"You are a specialist code reviewer. Read the checklist at {checklist path}, then run
|
||
\`${diffBase(ctx)} && git diff "$DIFF_BASE"${ctx.skillName === 'ship' ? ' <exclude>' : ''}\` to get the ${ctx.skillName === 'ship' ? 'diff (`<diff-base>`: write the sha in before dispatch, the merge base on pass 1 and `RANGE_BASE` from pass 2 on; never a shell variable; `<exclude>`: everything after `<diff-base>` on this reviewer\'s `DIFF_CMD:` line, verbatim; empty on `DIFF_EXCLUDE: none`)' : 'full diff'}. Apply the checklist against the diff.
|
||
|
||
\`NO FINDINGS\` alone is the expected, complete result for a clean diff; never invent an item. Otherwise output one JSON object per finding per line, 400 words at most:
|
||
{\\"severity\\":\\"CRITICAL|INFORMATIONAL\\",\\"confidence\\":N,\\"path\\":\\"file\\",\\"line\\":N,\\"category\\":\\"category\\",\\"summary\\":\\"description\\",\\"fix\\":\\"recommended fix\\",\\"fingerprint\\":\\"path:line:category\\",\\"specialist\\":\\"name\\"}
|
||
|
||
Required fields: severity, confidence, path, category, summary, specialist.
|
||
Optional: line, fix, fingerprint, evidence, test_stub, advisory, evidence_paths, helper_target, cause.
|
||
CRITICAL means a test that would fail, a production break, or a security or data-loss defect; everything else is INFORMATIONAL.
|
||
A defect the diff causes but that shows elsewhere (a caller broken by a changed signature, a consumer of a removed export) keeps the victim as \`path\` and names the changed line in \`cause\`: {\\"cause\\":{\\"path\\":\\"file\\",\\"line\\":N}}. Without it the finding reads as pre-existing code.
|
||
|
||
Leave extraction advice to the core shared-code check; report real defects in duplicated code independently, keep advisory metadata on structural advice, and never call a demonstrated defect advisory because a shared helper could fix it.
|
||
|
||
If you can write a test that would catch this issue, include it in the \`test_stub\` field.
|
||
Use the detected test framework ({TEST_FW}). Write a minimal skeleton — describe/it/test
|
||
blocks with clear intent. Skip test_stub for architectural or design-only findings.
|
||
|
||
Output nothing else: no preamble, no summary or commentary.
|
||
|
||
Stack context: {STACK}
|
||
Past learnings: {learnings or 'none'}"
|
||
|
||
**Subagent configuration:**
|
||
- Use \`subagent_type: "general-purpose"\`
|
||
- Pass ${FOREGROUND_IF_AVAILABLE} on every specialist Agent call — background is the default since ${CC_BACKGROUND_DEFAULT_SINCE}; omitting an available flag is not foreground. ${BACKGROUND_RECOVERY}
|
||
|
||
**Wait for readers before editing:**
|
||
- Confirm that each task has finished or is stopped. A timeout alone does not prove termination. If a reader or writer is still active, wait; if its state is unknown, inspect its task/process status. If you cannot confirm it stopped, use the parent's Fix-First stop path without edits.
|
||
- A failed task may be stopped without having completed its review. Record the failure and retain usable partial findings.
|
||
- Continue independent evidence collection after a terminal failure. Missing dispatched coverage remains incomplete, never completed or clean; successful peers cannot replace it.`;
|
||
}
|
||
|
||
function generateFindingsMerge(ctx: TemplateContext): string {
|
||
const isShip = ctx.skillName === 'ship';
|
||
const stepMerge = isShip ? '9.2' : '4.6';
|
||
const fixFirstRef = isShip ? 'Step 9.3 dedup, then Step 9.4 Fix-First' : 'Step 5 Fix-First';
|
||
const critPassRef = isShip ? 'the checklist pass (Step 9)' : 'the CRITICAL pass findings from Step 4';
|
||
const persistRef = isShip ? 'the review-log persist' : 'the review-log entry in Step 5.8';
|
||
return `### Step ${stepMerge}: Collect and merge findings
|
||
|
||
Follow these stages in order. Validate core and specialist findings alike, but keep
|
||
their source labels: specialist scoring is not the final review's defect count.
|
||
|
||
#### 1. Parse outputs
|
||
|
||
After specialist attempts settle, collect their outputs, tagged by actual source.
|
||
\`NO FINDINGS\` is a completed, clean result, never a failed reviewer. Otherwise parse
|
||
each JSON line and skip invalid lines. Missing or unusable output is incomplete
|
||
coverage, not an empty success. Keep each specialist's returned findings for activity stats.${isShip ? `
|
||
An output that carries a state-machine matrix record (State Machines, or a batched
|
||
reader that read its checklist) is parsed from \`${ctx.paths.binDir}/gstack-state-matrix findings <file>\`,
|
||
after \`check\` ran on the raw file: an untested cell that is the only finding on its
|
||
cell comes back INFORMATIONAL (\`"state_matrix":"untested-cell"\`), the test-gap ruling
|
||
in \`docs/review-policy.md\`; a wrong row or collapsed kinds stays CRITICAL.` : ''}
|
||
|
||
#### 2. Validate severity
|
||
|
||
For core and specialist findings with \`"severity":"CRITICAL"\` and \`"advisory":true\`,
|
||
remove \`advisory\` and retain its \`CRITICAL\` severity. Treat these as defects before
|
||
identity, merging, counting, scoring or Fix-First. Never downgrade severity to make
|
||
advisory metadata consistent. Valid INFORMATIONAL advisories remain advisory in
|
||
every category, including simplification.
|
||
|
||
#### 3. Identify and merge
|
||
|
||
Partition defects and advisories BEFORE grouping by fingerprint. Never merge a
|
||
defect with advice, even on a supplied-hash collision. Neither higher-confidence
|
||
advice nor a prior skipped extraction may replace, downgrade or suppress a defect.
|
||
|
||
Compute identities for both core and specialist findings:
|
||
- Shared-code advice (category \`shared-libs\` or fingerprint prefix \`shared-libs:\`):
|
||
call installed \`sharedLibsFingerprint\` from \`${ctx.paths.skillRoot}/lib/review-evidence.ts\`
|
||
with \`evidence_paths\` and \`helper_target\` as literal JSON on stdin, as in the core pass;
|
||
never trust a supplied hash or generate one yourself. Missing/malformed metadata
|
||
cannot deduplicate or reuse a saved decision.
|
||
- Other findings: use supplied \`fingerprint\`, else \`{path}:{line}:{category}\`
|
||
or \`{path}:{category}\` when no line exists.
|
||
|
||
Within the specialist list, merge matching identities in the same partition: keep
|
||
the highest confidence and all source names. Confirmation by distinct specialists adds +1 (cap at 10) and \`MULTI-SPECIALIST CONFIRMED ({specialist1} + {specialist2})\`.
|
||
Core findings never earn a specialist confidence boost. Preserve \`advisory\`,
|
||
\`evidence_paths\` and \`helper_target\` through every merge.
|
||
|
||
#### 4. Lead judgment
|
||
|
||
Reviewers fill the space they are given. Before a merged finding counts, the
|
||
parent reads it and drops or downgrades it on these grounds, saying so:
|
||
- **Nit gravity.** A reviewer whose whole return is style, naming and preference
|
||
found nothing; say so and count no defect.
|
||
- **Hypothetical, not actual.** A defect names the call site or input that reaches
|
||
it; one that does not is a note until someone traces it.
|
||
- **Structure for a case that does not exist.** Advice to abstract, generalize or
|
||
guard a path nothing takes is advisory.
|
||
- **A different design is not a defect.** "I would have done it differently" with
|
||
no failing case is dropped.
|
||
- **Missing context.** A finding that assumes a rule the repository documents
|
||
otherwise is dropped with the pointer.
|
||
- **On record.** A class \`docs/review-policy.md\` rules below the floor is a note,
|
||
named by its ruling.
|
||
Independent agreement between reviewers is the strongest signal (the
|
||
\`MULTI-SPECIALIST CONFIRMED\` boost records it). A reviewer that
|
||
returned \`NO FINDINGS\` was right until a traced defect says otherwise.
|
||
|
||
#### 5. Apply specialist confidence gates
|
||
|
||
- Confidence 7+: show normally in the findings output
|
||
- Confidence 5-6: show with caveat "Medium confidence — verify this is actually an issue"
|
||
- Confidence 3-4: move to appendix (suppress from main findings)
|
||
- Confidence 1-2: suppress entirely
|
||
|
||
Core findings keep the core Confidence Calibration gates.
|
||
|
||
#### 6. Score and present specialists
|
||
|
||
Only specialist findings enter this header and \`quality_score\`; core findings do not.
|
||
Use the merged NON-advisory specialist findings for both counts and score;
|
||
the header's N is X + Y, so advisory findings never add to it:
|
||
\`quality_score = max(0, 10 - (critical_count * 2 + informational_count * 0.5))\`
|
||
Cap at 10 and retain for ${persistRef}. These are not final unresolved-defect totals.
|
||
Print only this block: the stage 7 activity object and \`test_stub\` bodies are log and Fix-First data.
|
||
Validated \`"advisory": true\` findings from any source are excluded from score,
|
||
header, unresolved-defect totals and clean-status blockers. Show them separately;
|
||
they remain ASK-only, never auto-applied. Real defects follow normal Fix-First.
|
||
|
||
\`\`\`
|
||
SPECIALIST REVIEW: N findings (X critical, Y informational) from Z specialists
|
||
|
||
[For each finding, in order: CRITICAL first, then INFORMATIONAL, sorted by confidence descending;
|
||
advisory findings last, each rendered with an [ADVISORY] label in place of the severity]
|
||
[SEVERITY] (confidence: N/10, specialist: name) path:line — summary
|
||
Fix: recommended fix
|
||
[If MULTI-SPECIALIST CONFIRMED: show confirmation note]
|
||
|
||
PR Quality Score: X/10
|
||
\`\`\`
|
||
|
||
**Simplification footer (after the score line):**
|
||
- If the simplification specialist was dispatched and returned findings, sum
|
||
their \`lines_removable\` values and print: \`net: -N lines possible\` (omit
|
||
findings without the field from the sum).
|
||
- If it was dispatched and returned NO FINDINGS, print:
|
||
\`Simplification: lean already — nothing to cut.\`
|
||
- If it was not dispatched, print neither line.
|
||
|
||
Core shared-code savings never enter this footer; explain any overlap once in the core proposal.
|
||
|
||
#### 7. Save specialist activity
|
||
|
||
Compile a \`specialists\` object for ${persistRef}.
|
||
${isShip ? 'For each specialist' : 'For DIFF_LINES < 50, keep `specialists: {}` (or `state-machines` alone when it dispatched); do not manufacture per-specialist scope records. Otherwise record each considered specialist'} (testing, maintainability, security, performance, data-migration, api-contract, design, simplification, state-machines, red-team):
|
||
- If dispatched: \`{"dispatched": true, "findings": N, "critical": N, "informational": N}\`
|
||
- If skipped by scope: \`{"dispatched": false, "reason": "scope"}\`
|
||
- If skipped by gating: \`{"dispatched": false, "reason": "gated"}\`
|
||
- If not applicable (e.g., red-team not activated): omit from the object
|
||
|
||
Count only findings that specialist actually returned, before deduplication.
|
||
Advisory findings COUNT in the stats \`findings\` field, not its defect counts.
|
||
Include Design despite its different checklist. Preserve dispatch/failure status:
|
||
zero returned findings from a failed attempt is not a clean review.
|
||
|
||
#### 8. Hand off to Fix-First
|
||
|
||
Send these findings to ${fixFirstRef} alongside ${critPassRef}.
|
||
Consolidate equivalent shared-code advice under the core proposal, retaining all
|
||
sources and counting overlapping savings once. Keep actual specialist stats;
|
||
core-only advice must not create a specialist dispatch or finding.
|
||
Normal AUTO-FIX/ASK rules apply, with advice ASK-only. Missing coverage still blocks
|
||
completion. Advice never permits edits while readers are active or replaces a required review.`;
|
||
}
|
||
|
||
function generateRedTeam(ctx: TemplateContext): string {
|
||
const isShip = ctx.skillName === 'ship';
|
||
const stepMerge = isShip ? '9.2' : '4.6';
|
||
const fixFirstRef = isShip ? 'Step 9.3 dedup, then Step 9.4 Fix-First' : 'Step 5 Fix-First';
|
||
return `### Red Team dispatch (conditional)
|
||
|
||
**Activation:** Only if DIFF_LINES > 200 OR any specialist produced a CRITICAL finding.
|
||
|
||
If activated, dispatch one more subagent via the Agent tool (pass ${FOREGROUND_IF_AVAILABLE} — foreground; subagents default to background since ${CC_BACKGROUND_DEFAULT_SINCE}; ${BACKGROUND_RECOVERY})
|
||
|
||
The Red Team subagent receives:
|
||
1. The red-team checklist path \`${ctx.paths.skillRoot}/review/specialists/red-team.md\` (it reads the file)
|
||
2. The merged specialist findings from Step ${stepMerge}, one line each (so it knows what was already caught)
|
||
3. The git diff command
|
||
|
||
Prompt, after the defensive framing and fixture handling from item 4 of the specialist dispatch: "You are a red team reviewer. The code has already been reviewed by N specialists
|
||
who found the following issues: {merged findings summary}. Your job is to find what they
|
||
MISSED. Read the checklist at {red-team checklist path}, list changed files with \`${diffBase(ctx)} && git diff --name-status "$DIFF_BASE"${ctx.skillName === 'ship' ? '<list-exclude>' : ''}\`, read them as that fixture handling says, and look for gaps.
|
||
Output findings as JSON objects (same schema as the specialists), or \`NO FINDINGS\` alone, the expected result when they missed nothing. Focus on cross-cutting
|
||
concerns, integration boundary issues, and failure modes that specialist checklists
|
||
don't cover."
|
||
|
||
Tag Red Team findings \`"specialist":"red-team"\`.
|
||
Add them to the original specialist outputs and rerun stages 1–8 of Step ${stepMerge}
|
||
before ${fixFirstRef}; do not boost or count the earlier findings twice.
|
||
|
||
If the Red Team returns NO FINDINGS, note: "Red Team review: no additional issues found."
|
||
If the Red Team fails or times out, confirm it stopped and record its review as incomplete, just as for other specialists. ${isShip ? "Return to the parent's Exploratory QA step, then dedup and persistence; Step 9.4 cannot certify missing dispatched coverage as completed or clean." : 'Continue independent Step 4.7 QA and Step 4.8 adversarial review; Step 5.8 cannot certify missing dispatched coverage as completed or clean.'}`;
|
||
}
|
||
|
||
export function generateReviewArmy(ctx: TemplateContext): string {
|
||
// Codex host: strip entirely — Codex should not run Review Army
|
||
if (ctx.host === 'codex') return '';
|
||
|
||
const sections = [
|
||
generateSpecialistSelection(ctx),
|
||
generateSpecialistDispatch(ctx),
|
||
generateFindingsMerge(ctx),
|
||
generateRedTeam(ctx),
|
||
];
|
||
|
||
return sections.join('\n\n---\n\n');
|
||
}
|