mirror of
https://github.com/garrytan/gstack.git
synced 2026-11-17 05:41:50 +01:00
* fix(ship): base merges, adjacent base edits, test-only and audit-requested fixes no longer force a second review loop (GST-407, GST-384, GST-391) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * ship driver: trim two phrases for headroom with #3662 Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * ship driver: keep the Next steps heading phrase the handoff check reads; trim elsewhere Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * test: regenerate ship goldens Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix: pre-landing review fixes comparePath returns same only when every hunk sits where the base change puts it (patch-ids ignore positions) and treats a file-mode change as changed; the scoped-review packet says when a fence is truncated; --docs-result must be the posted audit's result; the --context-reviewed record goes beside the packet, outside the worktree. Negative controls for each. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix: pass-2 review fixes A test edit routes as tests= only when it adds lines with no gate tag; a removed or changed line or an unreadable test diff goes through the full loop. Diffs skip textconv. A hunkless patch (binary, empty, mode-only) is same when its patch-id matches. Without --reviewed-base test files route as before. finish's packet path and attempt's state directory have fallbacks. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix: Step 11 review fixes; a version-only stamp_files edit after review is release metadata (GBRA-251) gateEditedPaths reads removed lines only inside hunks; carry refuses when a path listing fails; docs freshness stops on a failed listing; attempt counts an unreadable state file. releasePaths includes stamp_files paths whose edit is a version swap under stamp_patterns. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix: no test edit skips review; guard packet writes; exclusive attempt state A test-only edit with no gate tag gets the scoped fix-check of its test hunks instead of a lanes-only rerun. Packet write failures print a STOP or RECEIPT_CARRY_REFUSED. attempt's allowance uses an exclusive create. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix: attempt prints gstack's install command; carry checks the product diff outside context paths The attempt STOP no longer echoes the audit child's fix text. A scoped-review carry now requires the product patch-id without the context paths to match at both heads. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix: oversized packets take the full loop; exact --docs-requested match; name-only test globs only in test dirs A scoped-review packet section over 200 lines sends that path to the full loop instead of a truncated packet. The docs-result path match is exact. test_*.py, *Test.java and similar count as test code only under a test directory. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * docs(unattended): carry's scoped-review refusal and what it keeps Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * docs: carry's scoped-review route in ship-policy, review-policy and troubleshooting (docs-a-1) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * test(windows): curate ship-rereview-triggers out of the Windows lane like ship-release (run 41193336209) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix(review-log): record a notes-only /ship pass clean; name the cause and repair when a pass's tree moved (GST-430) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix(receipt): carry and write handle PRs with thousands of files; tree receipt fails closed on a failed diff (GST-448) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix(ship): preflight routes RECEIPT_CARRY_SCOPED_REVIEW to the scoped review; carry --dry-run writes no packet (GST-442) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * docs(ship): Step 1.4 and Step 16 route the scoped-review refusal and the --docs-requested fix; trims keep the cap (GST-442, GST-444) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix: /ship review pass 1: notes-only floor, scoped carry order, named temp and diff refusals - A notes-only pass is recorded clean only when every finding is fixed, or noted or deferred below the blocking floor (never CRITICAL or blocking), by its logger-stamped action, and the findings account for the claimed issue and critical counts (GST-430). - The preflight scoped carry route commits and pushes the base-merge fix before writing the packet (GST-442). - patchId refuses by name on an unwritable TMPDIR; the tree receipt names why its diff failed (GST-448). - Step 16 stage 3 spells out --docs-requested with its --docs-result (GST-444). Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * test: pin the Step 16 --docs-requested route with its --docs-result Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix: a claimed clean review row with a logger-stamped open gate finding reads UNVERIFIED (red-team, pass 1) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix: Step 11 findings: gate rows from --findings are stamped, one open rule, stale patch-id dirs swept - deriveFromFindings stamps gate rows with the session kind before deriving status, so a findings file cannot dispose of a gate finding the unattended logger forces open (outside-voice#1). - reviewFreshness reads a claimed row's findings with isOpenByAction, the rule the notes-only rewrite uses; noted and deferred clear a finding only when it is marked blocking: false and is not CRITICAL. - patchId sweeps gstack-patch-id-* directories over an hour old that a killed carry left in TMPDIR. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix: Step 11 round 2: stamped-open gates win over status and disposition; resolved gate, skipped and below-floor actions stay CURRENT - isOpenFinding treats action 'open' (the logger's forced-open stamp) as open before a row's status or disposition. - reviewFreshness flags a claimed clean row only for an 'open' action or a CRITICAL or blocking deferral or note, so interactive kept and restored gates, skipped advisories and INFORMATIONAL deferrals read CURRENT as before. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix: carry dry run offers the scoped route last; patch-id diff under the git dir; changelog matches the review-log floor Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix: a claimed clean review row with any unresolved non-gate CRITICAL finding reads UNVERIFIED (pass 2 red-team) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * docs: carry dry-run scoped route, patch-id directory, tree-receipt refusal (docs-d-1 audit) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix(ship): Step 3 names merge conflicts in its STOP sentence again (ship-workflow-clarity pin) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix(tree-receipt): keep the gated-to-current diff at the file helper timeout (60 s); pregate literals check Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * test(carry): large-diff fixture sets core.longpaths so Git for Windows can add its long receipt paths (windows-free-shard 1, run 41210080055) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix(review): a stale local base branch yields to its origin twin in gate-diff and diff-scope (GST-462) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix(ship): Step 11 saves the targeted record and the receipt writes carry it; Step 9 clears it (GST-464) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * changelog: GST-464 and GST-462 Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix(review): pass 1: ahead and diverged labels, diff-scope needs shared history; preflight refreshes origin/<base> and stops on a diff far beyond the PR (GST-462, HARN-15) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix: pass-2 review fixes for base twin, prSized stop and targeted record Resolve the tracking twin by refs/remotes/<remote>/<ref> and only for a bare branch name, keep a local base that is ahead or diverged, quote the prSized stop's base and name the fork case, and have every Step 9 entry create, exclude and clear .gstack/tmp/targeted.json. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix: origin's tracking base wins whenever related; prSized lower bound The fix-check found that keeping a local base ahead of origin left unpushed base commits out of the gate scan while review-plan listed them. The tracking branch now wins whenever it shares history with HEAD, an explicit origin/main reads refs/remotes/origin/main, the preflight also stops when the diff lists fewer files than the PR, and the Step 9 exclude line survives a missing .git/info and an exclude file without a final newline. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * changelog: the tracking-ref claim holds while the tracking branch exists Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * test: repin the two ship section briefs under no-loss replay GST-464 GST-464 brief-identity check: every reviewer brief lib/review-brief.ts cuts from ship/sections/review-army.md and adversarial.md stays byte-identical to the bodies the L and GST-257 replays admitted; only lead instructions outside the cut spans changed. The check is a test CI runs. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * ship: keep Step 9's PASS_HEAD sentence whole; repin review-army under GST-464 The targeted-record line follows the PASS_HEAD/RANGE_BASE sentence instead of splitting it (test/review-fix-range.test.ts pins that sentence). The brief-body check still holds: every reviewer brief is byte-identical. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix: restore bin/gstack-ship-receipt after the main merge The merge commitb10e2dbwrote a truncated copy of the file. This is the three-way merge of both sides with the refused() union: main's codes plus RECEIPT_CARRY_SCOPED_REVIEW. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * review-collect: narrow the consumer scan and give it one 300 s deadline (GST-544) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * review-collect: keep the consumer scan deadline under the 180 s plan timeout (review fix) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * review-collect: plain paths under --literal-pathspecs; whole-millisecond timeout override (review fix) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * review-collect: whole-tree grep for non-UTF-8 names, no argument spread, name spawn errors (review fix) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * review-collect: cap the consumer grep output at 256 MB across calls; per-scan deadline wording (review fix, cycle 4) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * review-collect: read a missing spawn status as null (Bun 1.4.2 returns undefined on ENOENT) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * test: review-collect whole-tree helper reads a null status as -1 (typecheck:test ratchet) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * review-bots: /review and /ship triage every configured review bot, not only Greptile (#3122) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix: pre-landing review fixes (gh before 2.48 pages without --slurp; driver routes Step 10; tests for guards, review-bot fence, REMOTE_SLUG owner) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix: drop the review-bot fence test that could not fail (the tool-fence WARN degrade is unreachable: placeholder spans are skipped first) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix: Step 11 review fixes (record by comment id so a filename never reaches a shell; lookup failures are errors; tojson pages; longest bot prefix wins) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix: pass-2 review fixes (record refuses * paths, colliding ids and a missing fetch dir; parent requires id and dir; botOwning doc) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * review: classify the PR type and always check repo conventions (#356) The checklist now opens with a PR-type line (application, CI/infra, scripts/tooling, docs-only or mixed). Application and mixed diffs run every category; other types always run five categories, including the new Repo Conventions & Platform Fit, and report the rest as not applicable in one line instead of skipping silently. No-loss replay: GSTA-224 H1 preregistered no-loss run (run id gsta224-h1-20261031, Opus 5.5, 81 calls, $9.53) against main's checklist with a no-gstack arm; every preregistered bar passed. The review/checklist.md pin in test/review-packets-removed.test.ts moves to a32963ef with replay 'GSTA-224 H1'. Refs GSTA-224 Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * review-bots: allowlist the record placeholders and match Step 10's id rule in tests The record fence uses <comment-id>, <fix|fp|already-fixed> and <category>, each with an enum or numeric grammar; <greptile-dir> becomes <bot-dir>. review/greptile-triage.md also lists every REVIEW_BOTS skip reason. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * docs: review-bot triage covers every configured bot (#3122) README, CONTRIBUTING, the contributor reference and standalone-binaries name gstack-review-bots and the review-bot fence; TODOS drops the #3122 item; the changelog fragment covers record-by-id and lookup errors. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * test: the PR-type test also pins the compose, Terraform and README/CHANGELOG phrases Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * test: follow the review-bot rename in the remote free tier's three reds The cross-skill consistency judge describes review-bot-history.md and its record helper; the tracker-guard exemption for the removed raw Greptile fetch in review/greptile-triage.md is dropped (the fetch now lives in gstack-review-bots, whose bodies still reach context only through gstack-issue-guard); the Step 10 PR-check test expects 'Review bots: not run'. HARNESS_VERSION stays 6: skill-fixture.ts and llm-judge.ts are recorded non-behavioral for every other case. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * test: keep the cross-skill judge's rubric to one renamed bullet Name review-bot-history.md beside the older greptile-history.md so the calibration corpus still matches, and keep the REMOTE_SLUG bullet. One live 3-sample panel at this tree: consistent 3/3, scores 4/4/4. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * changelog: H1 fragment passes prose lint Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * changelog: name the H1 fragment after its branch; TODOS drops #356 Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * docs: /review's PR type step in docs/skills.md (#356) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * ship-policy: review_exclude_paths key and loadPolicyAt (GST-508) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * review: apply the base policy's review_exclude_paths and the reviewer diff ceiling (GST-508) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * receipt: bind review_exclude in write, carry and the queue (GST-508) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * docs, tests and changelog for review_exclude_paths (GST-508) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix: pre-landing review fixes (binary by bytes, links kept, untracked files out of the selection) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix: keep binary files at code paths under review_exclude_paths Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * docs: name the reasons that keep a binary file under review_exclude_paths Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix: keep every review_exclude_paths candidate when the gate scan is unknown; docs example names its version Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * test: keep the NUL fixture clear of the sync-spawn tripwire Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * changelog: split the ceiling sentence Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix: keep a live binary file whose bytes cannot be read; tests render outside voices from a clean checkout and read the ship fixture text Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * test(review-exclude): explicit +x for the census script; skip the chmod-000 read case on Windows and root Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * refactor: move loadPolicyAt to lib/ship-policy-at.ts so lib/ship-policy.ts stays under the 800-line module cap Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix: refuse a base that contains HEAD; skip a self-pointing origin/HEAD (GST-774) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * chore: regenerate gstack-doctor-components.sh for BASE_CONTAINS_HEAD Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix: land resumes a merged merge-only PR instead of refusing BASE_CONTAINS_HEAD (GST-774 review) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * docs: changelog fragment for GST-774 Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * docs: troubleshooting names diff-scope base_contains_head and the self-pointing no_base case (GST-774 docs audit) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * test: repin the reviewer briefs to GST-508's no-loss-tested bytes ship/sections/review-army.md, ship/sections/adversarial.md and lib/review-depth.ts now pin the bytes the GST-508 preregistered no-loss replay ran atef2760f(handoffs/GSTA-202/noloss-results.md in the GStack Minder drive): Arm V 33/41 vs R 33/41, delta 4, exact sign flip, p_NI 0.0279 (pass). The merge of main83ae96eleaves these three files byte-identical toef2760f, and an Arm P unit (3593) renders byte-identical briefs atef2760fand at the merge. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix: GST-774 review round 1 — merged resume depth, aliased and detached PR checkouts, develop/trunk defaults Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * ship: Step 20 says a metrics row, keeping DRIVER.md at 12 KB after the main merge Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * test: ship-parts resend case leaves room for the first phase-3 part after the Step 9 targeted-record sentence Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix: /ship delivers review/checklist.md in two parts so checklist v1 fits the 24576-byte part cap (#3670) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * changelog: drop the GST-407 and GST-430 fragments, already released on main (stacked history) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * wave review-53cfb5bfe011: lib/ship-policy.ts back to 800 lines (module-size ratchet after merging #3744 and #3795) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * wave review-53cfb5bfe011: /ship pass 1 fixes - lib/ship-receipt-depth.ts: a merged resume (land after a true merge) no longer recomputes the review_exclude digest over the emptied range, so it lands instead of RECEIPT_INVALID (failing-first land test with review_exclude_paths active). - bin/gstack-review-dispatch render: a standalone targeted render under an active review_exclude_paths refuses and points at the pass manifest voices stage, instead of writing a brief with no selection that leaves verify dirty (failing-first test). - test/default-base.test.ts: #3795 expectations follow main R51 depth (light for an 80-line code diff; runtime_lines=80 still proves the real base). - test/review-dispatch.test.ts: the GST-897 fingerprint test renders from the clean checkout, like its neighbor, because CI rebuilds the tracked lib/diagram-render/dist/diagram-render.html and the reviewer diff ceiling refused the ROOT render. * wave review-53cfb5bfe011: /ship pass 2 fixes - lib/review-exclude.ts: binaryContent reads each blob's first 8,000 bytes (git cat-file blob, 8 KB buffer) instead of one --batch read capped at 256 MB, so head mode (receipt, carry, queue) and the plan agree past 256 MB of blobs; an unreadable blob is kept, as in live mode. Failing-first test with two 270 MB blobs. - lib/review-bots.ts: a file-level bot review comment (subject_type file, no line position) is triaged instead of read as outdated. Failing-first test. - test/ship-queue-land.test.ts: the merged-resume exclusion test runs its gate scan under the fixture state root, not the real home (CI free-suite 6 home containment). * fix: merge follow-ups for main3d99c22: origin/* stays qualified in diff-scope's twin step, retro skeleton back under its cap, combined no-loss pin GST-508+R51+GST-911 * fix(review): receipt write gate-scans whenever the base declares review_exclude_paths; collectLive never re-qualifies origin/<base> (#3852 /ship red-team#1, outside-voice#1) * test: the docs-only receipt digest test keeps its gate scan out of the real home (free-suite shard 5 FREE_SUBSHARD_REJECTED) * fix(mergefc292e22f): tentative REVIEW_EXCLUDE_KEY_VERSION, classify targeted.json, render main's new outside-voice test from a clean checkout - lib/ship-policy.ts: REVIEW_EXCLUDE_KEY_VERSION 1.93.0.0 -> 1.94.0.0, the next-minor tentative form stamp_paths moves (docs/ship-policy.md, #3512); 1.93.0.0 is a released heading that never names the key. - test/gstack-clean-producers.test.ts (new from main): KEPT gains targeted.json, the wave's --review-targeted input. - test/review-dispatch.test.ts: main's wrong-tree test rendered the outside voice from ROOT; a CI build that dirties ROOT pushes that diff past the wave's REVIEW_DIFF_MAX_BYTES ceiling, so render refused and verify saw no brief (exit 3). It now runs in cleanCheckout like the wave's other outside-voice tests. * test(merge68410828f): GST-967's brief-body pin carries the wave's GST-508 placeholders The merged sectionTexts differ from main's by exactly the wave's GST-508 exclude-pathspec lines (merged minus main equals wave minusfc292e22f); the 1,440-case plan grid still hashes to main's MAIN_PLANS. Checks: GStack Minder drive handoffs/GSTA-202/merge-6841-checks.md. * fix(mergee85005482): targeted classes since the read accept an empty range; the wave's receipt tests pass main's targeted record - lib/ship-receipt-depth.ts targetedClassesSince (main, GST-986) reads the range from the commit the targeted reader read to HEAD through headInputs, which since #3795 runs gstack-diff-scope's BASE_CONTAINS_HEAD check. When the reader read HEAD itself the range is empty, diff-scope reported base_contains_head, and every write with --review-targeted was refused (the product patch matched). It now passes merged=true (--merged), which skips only that check; an ancestor check already guards the range. - test/review-exclude.test.ts and test/review-targeted.test.ts: since #3887 write refuses a money head with no targeted record and requires the record's head, so the wave's two writes that must succeed pass one, as main's own tests do (targetedAtHead in test/ship-receipt-depth.test.ts). * test(mergee85005482): drop the wave's duplicate targeted.json KEPT entry Main (#3887) classified .gstack/tmp/targeted.json in KEPT too; the auto-merge kept both keys, which typecheck:test rejects (TS1117). Main's entry stays. * test(mergee85005482): ship size ledger entry for the merged tree (-232 B) Main's ship size ledger plus the wave's entries summed to 345,334 B; the merged tree measures 345,102 B because DRIVER.md takes main's shorter Step 19 line. Recorded with scripts/size-ledger.ts record ship. --------- Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
319 lines
14 KiB
TypeScript
319 lines
14 KiB
TypeScript
/**
|
|
* Skill fixture extraction — enforces the CLAUDE.md rule "E2E test fixtures:
|
|
* extract, don't copy".
|
|
*
|
|
* Full SKILL.md files are 1000-1900 lines. When `claude -p` (or `codex exec`)
|
|
* reads a file that large, context bloat causes timeouts, flaky turn limits,
|
|
* and tests that take 5-10x longer than necessary. Every E2E fixture that
|
|
* needs skill content should extract ONLY the sections the test actually
|
|
* exercises, through one of the three helpers here:
|
|
*
|
|
* - extractSkillSections(skillDir, sections)
|
|
* frontmatter + the named `## <section>` blocks, concatenated in the
|
|
* order given. For tests that exercise specific workflow steps.
|
|
* - extractSkillBody(skillDir)
|
|
* frontmatter + intro + everything AFTER the generated preamble (tier 1:
|
|
* "## Preamble (run first)" or "## Preamble (after scope gate)" .. end of
|
|
* "## Plan Status Footer"; tier 2+: the shared-preamble pointer .. this
|
|
* skill's own preamble sections through Telemetry).
|
|
* For tests that exercise the skill's ENTIRE specific flow but never
|
|
* touch the generated preamble.
|
|
* - extractSkillHead(skillDir, bodyLineCount)
|
|
* frontmatter + the first N body lines. For ROUTING / discovery tests,
|
|
* where the agent only reads the frontmatter (name + description) to
|
|
* decide which skill to invoke.
|
|
*
|
|
* Failure polarity: every extraction failure (missing file, missing
|
|
* frontmatter, renamed section) THROWS with the offending name — a fixture is
|
|
* never silently written empty. test/skill-fixture.test.ts pins the exported
|
|
* section lists against the real generated SKILL.md files, so a section
|
|
* rename fails the FREE suite instead of a paid E2E run.
|
|
*/
|
|
|
|
import * as fs from 'fs';
|
|
import * as path from 'path';
|
|
import { SHARED_POINTER_HEADING, readSharedSections, readSkillEffective } from './skill-startup';
|
|
|
|
// ─── Section lists shared by E2E fixtures and the free pin test ────────────
|
|
// Keep these verbatim against the H2 headings in the generated SKILL.md files.
|
|
// If gen-skill-docs renames a heading, test/skill-fixture.test.ts fails free.
|
|
|
|
/** /review E2E (sql-injection, enum-completeness, design-lite): the core
|
|
* review workflow without the shared preamble, Review Army, or Fix-First. */
|
|
export const REVIEW_E2E_SECTIONS = [
|
|
'Step 0: Detect platform and base branch',
|
|
'Step 1: Check branch',
|
|
'Step 2: Read the checklist',
|
|
'Step 2.5: Check for review bot comments',
|
|
'Step 3: Get the diff',
|
|
'Step 4: Critical pass (core review)',
|
|
'Confidence Calibration',
|
|
'Important Rules',
|
|
];
|
|
|
|
/** Review Army E2E: core workflow + Scope Drift / Plan Completion Audit
|
|
* (delivery-audit test) + Step 4.5 specialist dispatch (quality score,
|
|
* JSON findings schema, MULTI-SPECIALIST consensus, Red Team). */
|
|
export const REVIEW_ARMY_E2E_SECTIONS = [
|
|
'Step 0: Detect platform and base branch',
|
|
'Step 1: Check branch',
|
|
'Step 1.5: Scope Drift Detection',
|
|
'Step 2: Read the checklist',
|
|
'Step 2.5: Check for review bot comments',
|
|
'Step 3: Get the diff',
|
|
'Step 4: Critical pass (core review)',
|
|
'Confidence Calibration',
|
|
'Step 4.5: Review Army — Specialist Dispatch',
|
|
'Important Rules',
|
|
];
|
|
|
|
/** /retro E2E (retro, retro-base-branch): the repo-scoped retro flow
|
|
* (Steps 0-14 live under Instructions/Prior Learnings/Capture Learnings)
|
|
* + the narrative report template. Global mode and Compare mode are not
|
|
* exercised by the E2E tests and are dropped. */
|
|
export const RETRO_E2E_SECTIONS = [
|
|
'Step 0: Detect platform and base branch',
|
|
'User-invocable',
|
|
'Arguments',
|
|
'Instructions',
|
|
'Prior Learnings',
|
|
'Capture Learnings',
|
|
'Engineering Retro: [date range]',
|
|
'Tone',
|
|
'Important Rules',
|
|
];
|
|
|
|
/** codex-review-findings E2E against the Codex host variant
|
|
* (.agents/skills/gstack-review/SKILL.md). Same core workflow as
|
|
* REVIEW_E2E_SECTIONS. */
|
|
export const CODEX_REVIEW_E2E_SECTIONS = [
|
|
'Step 0: Detect platform and base branch',
|
|
'Step 1: Check branch',
|
|
'Step 2: Read the checklist',
|
|
'Step 3: Get the diff',
|
|
'Step 4: Critical pass (core review)',
|
|
'Confidence Calibration',
|
|
'Important Rules',
|
|
];
|
|
|
|
// ─── Parsing internals ──────────────────────────────────────────────────────
|
|
|
|
/** First/last H2 headings of an inline (tier 1) preamble block. extractSkillBody
|
|
* drops this range; a hoisted tier 2+ preamble is bounded by its pointer instead. */
|
|
const SHARED_PREAMBLE_FIRST = ['Preamble (run first)', 'Preamble (after scope gate)'];
|
|
const SHARED_PREAMBLE_LAST = 'Plan Status Footer';
|
|
/** Preamble sections a hoisted SKILL.md keeps inline because they name the skill. */
|
|
const INLINE_PREAMBLE = [...SHARED_PREAMBLE_FIRST, 'Question Tuning', 'Repo Ownership', 'Search Before Building', 'Telemetry (run last)'];
|
|
|
|
interface H2Section {
|
|
heading: string;
|
|
/** index of the heading line within bodyLines */
|
|
start: number;
|
|
/** one past the last line of the section (start of next H2, or EOF) */
|
|
end: number;
|
|
}
|
|
|
|
/** Accept either a skill directory or a direct path to a .md file. */
|
|
function resolveSkillMd(skillDirOrFile: string): string {
|
|
const file = skillDirOrFile.endsWith('.md')
|
|
? skillDirOrFile
|
|
: path.join(skillDirOrFile, 'SKILL.md');
|
|
if (!fs.existsSync(file)) {
|
|
throw new Error(`skill-fixture: no SKILL.md at ${file}`);
|
|
}
|
|
return file;
|
|
}
|
|
|
|
function splitFrontmatter(raw: string, file: string): { frontmatter: string; bodyLines: string[] } {
|
|
const lines = raw.split('\n');
|
|
if ((lines[0] ?? '').trim() !== '---') {
|
|
throw new Error(`skill-fixture: ${file} does not start with YAML frontmatter ('---')`);
|
|
}
|
|
let close = -1;
|
|
for (let i = 1; i < lines.length; i++) {
|
|
if (lines[i].trim() === '---') { close = i; break; }
|
|
}
|
|
if (close === -1) {
|
|
throw new Error(`skill-fixture: ${file} frontmatter never closes ('---' missing)`);
|
|
}
|
|
return {
|
|
frontmatter: lines.slice(0, close + 1).join('\n'),
|
|
bodyLines: lines.slice(close + 1),
|
|
};
|
|
}
|
|
|
|
/**
|
|
* Scan body lines for H2 sections, fence-aware: `## `-prefixed lines inside
|
|
* ``` / ~~~ code fences are template content (e.g. the PLAN COMPLETION AUDIT
|
|
* output format, the /context-save checkpoint template), NOT section
|
|
* boundaries. Fences close only on a matching char of >= opening length,
|
|
* per CommonMark, so 4-backtick fences embedding 3-backtick blocks work.
|
|
* Standalone generated STOP-Read blocks between horizontal rules replace
|
|
* entire carved steps and end the preceding H2. Nested pointers stay inside it.
|
|
*/
|
|
function scanH2Sections(bodyLines: string[], stopAtH1 = false): H2Section[] {
|
|
const sections: H2Section[] = [];
|
|
let fence: { ch: string; len: number } | null = null;
|
|
|
|
for (let i = 0; i < bodyLines.length; i++) {
|
|
const line = bodyLines[i];
|
|
const m = line.match(/^ {0,3}(`{3,}|~{3,})(.*)$/);
|
|
if (m) {
|
|
const ch = m[1][0];
|
|
const len = m[1].length;
|
|
if (!fence) {
|
|
fence = { ch, len };
|
|
} else if (fence.ch === ch && len >= fence.len && m[2].trim() === '') {
|
|
fence = null;
|
|
}
|
|
continue;
|
|
}
|
|
if (!fence) {
|
|
const heading = line.startsWith('## ');
|
|
const title = stopAtH1 && /^ {0,3}#(?:[ \t]|$)/.test(line);
|
|
let carvedStep = /^> \*\*STOP\.\*\* Before .+, Read `[^`]+\/sections\/[^`]+\.md` and execute it$/.test(line)
|
|
&& bodyLines[i + 1] === '> in full. Do not work from memory — that section is the source of truth for this step.';
|
|
if (carvedStep) {
|
|
let preceding = i - 1;
|
|
while (preceding >= 0 && !bodyLines[preceding].trim()) preceding--;
|
|
let following = i + 2;
|
|
while (following < bodyLines.length && !bodyLines[following].trim()) following++;
|
|
carvedStep = bodyLines[preceding] === '---' && bodyLines[following] === '---';
|
|
}
|
|
if (heading || title || carvedStep) {
|
|
const previous = sections.at(-1);
|
|
if (previous) previous.end = Math.min(previous.end, i);
|
|
if (heading) sections.push({ heading: line.slice(3).trim(), start: i, end: bodyLines.length });
|
|
}
|
|
}
|
|
}
|
|
return sections;
|
|
}
|
|
|
|
function loadSkill(skillDirOrFile: string, stopAtH1 = false, effective = false): {
|
|
file: string;
|
|
frontmatter: string;
|
|
bodyLines: string[];
|
|
sections: H2Section[];
|
|
} {
|
|
const file = resolveSkillMd(skillDirOrFile);
|
|
const raw = effective ? readSkillEffective(file) : fs.readFileSync(file, 'utf-8');
|
|
const { frontmatter, bodyLines } = splitFrontmatter(raw, file);
|
|
return { file, frontmatter, bodyLines, sections: scanH2Sections(bodyLines, stopAtH1) };
|
|
}
|
|
|
|
function findSection(sections: H2Section[], name: string, file: string): H2Section {
|
|
const hit = sections.find((s) => s.heading === name)
|
|
?? sections.find((s) => s.heading.startsWith(name));
|
|
if (!hit) {
|
|
const available = sections.map((s) => ` ## ${s.heading}`).join('\n');
|
|
throw new Error(
|
|
`skill-fixture: section "## ${name}" not found in ${file}.\n`
|
|
+ 'The section may have been renamed — update the fixture section list '
|
|
+ '(see test/helpers/skill-fixture.ts).\n'
|
|
+ `Available H2 sections:\n${available}`,
|
|
);
|
|
}
|
|
return hit;
|
|
}
|
|
|
|
// ─── Public API ─────────────────────────────────────────────────────────────
|
|
|
|
/**
|
|
* Read the real SKILL.md under `skillDir` (or a direct .md path), slice each
|
|
* requested `## <section>` block, and return frontmatter + the sections
|
|
* concatenated in the order given. Throws loudly on a missing section.
|
|
*/
|
|
export function extractSkillSections(skillDir: string, sections: string[]): string {
|
|
const { file, frontmatter, bodyLines, sections: all } = loadSkill(skillDir, false, true);
|
|
const parts: string[] = [frontmatter, ''];
|
|
for (const name of sections) {
|
|
const hit = findSection(all, name, file);
|
|
parts.push(bodyLines.slice(hit.start, hit.end).join('\n').trimEnd(), '');
|
|
}
|
|
return parts.join('\n');
|
|
}
|
|
|
|
/**
|
|
* Frontmatter + intro/scope gate (everything before either exact preamble heading) + the
|
|
* full skill-specific body (everything after the "## Plan Status Footer"
|
|
* section; in a hoisted SKILL.md, the shared-preamble pointer through the
|
|
* skill's own preamble sections ending at Telemetry). Use when a test exercises the whole skill flow: this drops the
|
|
* generated preamble and nothing else.
|
|
*/
|
|
export function extractSkillBody(skillDir: string): string {
|
|
const { file, frontmatter, bodyLines, sections: all } = loadSkill(skillDir, true);
|
|
const boundary = (names: string[]): H2Section => {
|
|
const matches = all.filter(section => names.includes(section.heading));
|
|
const label = names.map(name => `"## ${name}"`).join(' or ');
|
|
if (!matches.length) throw new Error(`skill-fixture: section ${label} not found in ${file}.`);
|
|
if (matches.length !== 1) throw new Error(`skill-fixture: ambiguous section ${label} in ${file}.`);
|
|
return matches[0];
|
|
};
|
|
const pointer = all.findIndex(section => `## ${section.heading}` === SHARED_POINTER_HEADING);
|
|
let first: H2Section, last: H2Section;
|
|
if (pointer >= 0) {
|
|
// Hoisted preamble: the pointer, then this skill's own preamble sections up to Telemetry.
|
|
const shared = new Set(readSharedSections(file).map(section => section.split('\n', 1)[0]!.slice(3)));
|
|
let end = pointer;
|
|
while (end + 1 < all.length && (shared.has(all[end + 1].heading)
|
|
|| INLINE_PREAMBLE.some(name => all[end + 1].heading.startsWith(name)))) end++;
|
|
if (!all.slice(pointer, end + 1).some(section => section.heading === 'Telemetry (run last)')) {
|
|
throw new Error(`skill-fixture: no "## Telemetry (run last)" closes the preamble in ${file}.`);
|
|
}
|
|
[first, last] = [all[pointer], all[end]];
|
|
} else {
|
|
first = boundary(SHARED_PREAMBLE_FIRST);
|
|
last = boundary([SHARED_PREAMBLE_LAST]);
|
|
}
|
|
if (first.start >= last.start) {
|
|
throw new Error(`skill-fixture: "## ${last.heading}" precedes the preamble in ${file}.`);
|
|
}
|
|
const intro = bodyLines.slice(0, first.start).join('\n').trimEnd();
|
|
const tail = bodyLines.slice(last.end).join('\n').trimEnd();
|
|
if (!tail) {
|
|
throw new Error(
|
|
`skill-fixture: ${file} has no content after "## ${last.heading}" — `
|
|
+ 'refusing to write a preamble-only fixture.',
|
|
);
|
|
}
|
|
return [frontmatter, '', intro, '', tail, ''].join('\n');
|
|
}
|
|
|
|
/**
|
|
* Frontmatter + the first `bodyLineCount` body lines. For routing/discovery
|
|
* fixtures: skill selection reads the frontmatter name + description, so the
|
|
* body is intentionally truncated.
|
|
*/
|
|
export function extractSkillHead(skillDir: string, bodyLineCount = 30): string {
|
|
const { frontmatter, bodyLines } = loadSkill(skillDir);
|
|
const head = bodyLines.slice(0, bodyLineCount).join('\n').trimEnd();
|
|
return `${frontmatter}\n${head}\n\n<!-- body truncated by test/helpers/skill-fixture.ts — routing fixture needs frontmatter only -->\n`;
|
|
}
|
|
|
|
/**
|
|
* Slice a rendered skill between two literal markers. Both must exist: a
|
|
* missing END marker would silently hand the agent the rest of the file, which
|
|
* is exactly the "copied the whole SKILL.md" failure the E2E fixtures avoid.
|
|
*/
|
|
export function sliceBetween(text: string, start: string, end: string): string {
|
|
const i = text.indexOf(start);
|
|
if (i < 0) throw new Error(`skill fixture: start marker not found: ${start}`);
|
|
const j = text.indexOf(end, i + start.length);
|
|
if (j < 0) throw new Error(`skill fixture: end marker not found after start: ${end}`);
|
|
return text.slice(i, j);
|
|
}
|
|
|
|
export function extractDesignResearchContract(skill: string): string {
|
|
const setup = sliceBetween(skill, '## BROWSER SETUP', '### Rules for driving a real browser');
|
|
const probe = setup.match(/```bash\n[\s\S]*?\n```/)?.[0];
|
|
if (!probe) throw new Error('skill fixture: design research readiness probe missing');
|
|
const routing = sliceBetween(skill, '## Web research runs in Aside', '## Phase 2: Research');
|
|
const search = sliceBetween(skill, '**Step 1: Identify', '**Step 2: Visual research');
|
|
const prelude = search.match(/^_EG=.*_aside_exec\(\).*$/m)?.[0];
|
|
if (!prelude) throw new Error('skill fixture: design research egress prelude missing');
|
|
return ['Run this readiness probe once before research:', probe, routing,
|
|
'For each Aside research call, include this prelude before invoking `_aside_exec` with the requested query:',
|
|
'```bash', prelude, '```'].join('\n\n');
|
|
}
|