Garry Tan
be3d4c7171
fix(redact): reject malformed --max-bytes instead of silently disabling the size guard ( #1824 )
...
The oversize check is designed to fail CLOSED, but a malformed --max-bytes turned
it fail-OPEN. bin/gstack-redact did parseInt(maxBytes,10) and passed it straight
through; parseInt("foo") is NaN. The engine guarded with `opts.maxBytes ?? DEFAULT`,
and ?? does not catch NaN, so `byteLen > NaN` was always false and the fail-closed
block never fired. A negative value made `byteLen > -5` always true, blocking
everything.
Two layers:
- bin/gstack-redact validates the RAW string (parseInt accepts "123abc"->123,
"1.5"->1): require /^\d+$/ and > 0, else exit 1 with a clear message.
- lib/redact-engine.ts hardens the fallback to Number.isFinite && > 0 else the
default cap — a guardrail so the engine never silently runs uncapped even if a
bad value reaches it directly.
Tests: NaN and negative both fall back to the default cap (oversize still blocks);
CLI rejects garbage/negative with exit 1.
Reported by @jbetala7.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com >
2026-06-07 22:48:55 -07:00
..
2026-06-04 11:14:43 -07:00
2026-06-07 19:13:24 -07:00
2026-04-24 00:04:53 -07:00
2026-03-18 23:57:59 -05:00
2026-05-17 08:26:36 -07:00
2026-04-19 17:50:31 +08:00
2026-06-04 11:14:43 -07:00
2026-05-21 21:21:07 -07:00
2026-04-19 17:50:31 +08:00
2026-05-29 08:35:00 -07:00
2026-05-29 08:35:00 -07:00
2026-05-29 08:35:00 -07:00
2026-05-25 10:57:15 -07:00
2026-05-06 19:37:53 -07:00
2026-05-21 21:21:07 -07:00
2026-05-20 07:35:01 -07:00
2026-04-08 22:21:28 -10:00
2026-05-29 08:35:00 -07:00
2026-06-07 19:13:24 -07:00
2026-06-07 19:13:24 -07:00
2026-06-07 19:13:24 -07:00
2026-06-07 19:13:24 -07:00
2026-05-30 14:57:07 -07:00
2026-05-30 14:57:07 -07:00
2026-04-23 07:25:20 -07:00
2026-06-04 11:14:43 -07:00
2026-03-23 23:05:22 -07:00
2026-05-14 11:11:52 -04:00
2026-05-09 08:06:47 -07:00
2026-05-16 12:32:33 -07:00
2026-04-19 08:38:19 +08:00
2026-06-07 19:13:24 -07:00
2026-06-07 19:13:24 -07:00
2026-05-28 18:21:09 -07:00
2026-05-25 10:57:15 -07:00
2026-05-30 12:09:10 -07:00
2026-05-28 18:21:09 -07:00
2026-05-28 18:21:09 -07:00
2026-05-21 21:21:07 -07:00
2026-06-07 19:13:24 -07:00
2026-04-26 13:55:13 -07:00
2026-05-24 01:43:51 -07:00
2026-05-20 07:35:01 -07:00
2026-05-30 14:57:07 -07:00
2026-05-14 17:20:48 -07:00
2026-06-04 11:14:43 -07:00
2026-05-17 08:26:36 -07:00
2026-05-30 14:57:07 -07:00
2026-05-14 17:20:48 -07:00
2026-05-21 18:55:55 -07:00
2026-05-21 21:21:07 -07:00
2026-04-24 01:38:21 -07:00
2026-05-17 08:26:36 -07:00
2026-04-24 01:38:21 -07:00
2026-05-17 08:26:36 -07:00
2026-05-30 14:57:07 -07:00
2026-05-04 09:29:48 -07:00
2026-05-30 14:57:07 -07:00
2026-05-21 21:21:07 -07:00
2026-05-14 17:20:48 -07:00
2026-05-21 18:55:55 -07:00
2026-04-16 10:41:38 -07:00
2026-05-26 16:50:03 -07:00
2026-06-04 11:14:43 -07:00
2026-05-20 06:56:41 -07:00
2026-05-14 11:11:52 -04:00
2026-05-21 21:21:07 -07:00
2026-05-20 07:35:01 -07:00
2026-05-28 18:21:09 -07:00
2026-05-30 08:54:46 -07:00
2026-05-25 10:57:15 -07:00
2026-05-21 21:21:07 -07:00
2026-05-06 19:37:53 -07:00
2026-04-28 01:17:54 -07:00
2026-05-20 07:35:01 -07:00
2026-05-21 21:21:07 -07:00
2026-05-21 21:21:07 -07:00
2026-05-17 08:26:36 -07:00
2026-05-25 10:57:15 -07:00
2026-05-20 07:35:01 -07:00
2026-04-18 15:05:42 +08:00
2026-05-26 23:43:07 -07:00
2026-05-30 08:54:46 -07:00
2026-05-29 08:35:00 -07:00
2026-05-28 18:21:09 -07:00
2026-06-02 22:36:34 -07:00
2026-05-28 18:21:09 -07:00
2026-04-28 01:17:54 -07:00
2026-05-14 17:20:48 -07:00
2026-05-25 10:57:15 -07:00
2026-05-30 12:09:10 -07:00
2026-04-26 13:55:13 -07:00
2026-05-10 06:57:24 -07:00
2026-04-17 00:45:13 -07:00
2026-05-25 10:57:15 -07:00
2026-04-18 15:05:42 +08:00
2026-05-30 14:57:07 -07:00
2026-05-21 21:21:07 -07:00
2026-05-21 21:21:07 -07:00
2026-05-14 11:11:52 -04:00
2026-05-01 19:51:51 -07:00
2026-05-07 20:14:59 -07:00
2026-05-28 18:21:09 -07:00
2026-05-20 07:35:01 -07:00
2026-05-30 14:57:07 -07:00
2026-04-19 08:38:19 +08:00
2026-05-06 19:37:53 -07:00
2026-04-25 11:52:48 -07:00
2026-05-14 21:19:58 -07:00
2026-04-17 00:45:13 -07:00
2026-05-26 16:50:03 -07:00
2026-05-30 12:09:10 -07:00
2026-05-30 11:42:13 -07:00
2026-05-28 18:21:09 -07:00
2026-05-30 11:42:13 -07:00
2026-05-06 19:37:53 -07:00
2026-05-01 07:06:37 -07:00
2026-04-23 18:25:34 -07:00
2026-05-28 18:21:09 -07:00
2026-05-28 18:21:09 -07:00
2026-04-18 15:05:42 +08:00
2026-05-30 08:54:46 -07:00
2026-05-30 08:54:46 -07:00
2026-05-30 08:54:46 -07:00
2026-06-07 22:48:55 -07:00
2026-05-30 08:54:46 -07:00
2026-05-30 08:54:46 -07:00
2026-05-30 08:54:46 -07:00
2026-05-30 12:09:10 -07:00
2026-06-07 06:51:10 -07:00
2026-05-21 21:21:07 -07:00
2026-05-20 06:56:41 -07:00
2026-05-20 06:56:41 -07:00
2026-05-21 21:21:07 -07:00
2026-05-30 12:09:10 -07:00
2026-05-26 23:43:07 -07:00
2026-05-26 16:50:03 -07:00
2026-05-29 08:35:00 -07:00
2026-05-29 08:35:00 -07:00
2026-03-26 23:21:27 -06:00
2026-05-29 08:35:00 -07:00
2026-05-29 08:35:00 -07:00
2026-04-24 01:38:21 -07:00
2026-06-04 11:14:43 -07:00
2026-05-24 01:43:51 -07:00
2026-05-14 21:19:58 -07:00
2026-05-29 18:06:19 -07:00
2026-05-06 19:37:53 -07:00
2026-05-30 11:42:13 -07:00
2026-05-30 12:09:10 -07:00
2026-05-14 21:19:58 -07:00
2026-05-30 12:09:10 -07:00
2026-05-30 12:09:10 -07:00
2026-04-18 23:58:59 +08:00
2026-05-28 18:21:09 -07:00
2026-06-04 11:14:43 -07:00
2026-04-19 08:38:19 +08:00
2026-05-26 16:50:03 -07:00
2026-05-26 16:50:03 -07:00
2026-05-26 21:36:53 -07:00
2026-05-01 19:51:51 -07:00
2026-06-04 11:14:43 -07:00
2026-06-04 11:14:43 -07:00
2026-06-04 11:14:43 -07:00
2026-06-04 11:14:43 -07:00
2026-05-01 08:45:36 -07:00
2026-04-26 13:55:13 -07:00
2026-04-19 08:38:19 +08:00
2026-05-11 12:16:26 -07:00
2026-05-06 19:37:53 -07:00
2026-04-23 17:54:54 -07:00
2026-04-19 08:38:19 +08:00
2026-03-23 06:57:22 -07:00
2026-03-26 11:08:31 -07:00
2026-06-04 11:14:43 -07:00
2026-05-29 08:35:00 -07:00
2026-05-21 16:09:26 -07:00
2026-05-21 16:09:26 -07:00
2026-05-21 16:09:26 -07:00
2026-03-31 23:08:22 -06:00
2026-05-04 09:29:48 -07:00
2026-05-01 08:45:36 -07:00
2026-06-04 11:14:43 -07:00
2026-05-01 19:51:51 -07:00
2026-06-04 11:14:43 -07:00
2026-04-22 01:06:22 -07:00
2026-04-23 18:42:58 -07:00
2026-04-30 02:50:09 -07:00
2026-05-06 20:27:20 -07:00
2026-04-30 02:50:09 -07:00
2026-05-09 17:01:13 -07:00
2026-06-07 19:13:24 -07:00
2026-05-26 23:43:07 -07:00
2026-04-30 02:50:09 -07:00
2026-05-06 20:27:20 -07:00
2026-05-09 17:01:13 -07:00
2026-05-11 12:16:26 -07:00
2026-04-30 02:50:09 -07:00
2026-05-06 20:27:20 -07:00
2026-05-03 20:26:59 -07:00
2026-04-30 02:50:09 -07:00
2026-05-06 20:27:20 -07:00
2026-05-09 17:01:13 -07:00
2026-05-09 17:01:13 -07:00
2026-05-01 19:51:51 -07:00
2026-04-26 13:55:13 -07:00
2026-04-23 18:25:34 -07:00
2026-05-28 18:21:09 -07:00
2026-04-18 15:05:42 +08:00
2026-06-04 11:14:43 -07:00
2026-05-11 12:16:26 -07:00
2026-03-23 10:17:33 -07:00
2026-03-30 22:07:50 -06:00
2026-05-11 12:16:26 -07:00
2026-04-19 08:38:19 +08:00
2026-05-06 19:37:53 -07:00
2026-05-14 17:20:48 -07:00
2026-05-06 19:37:53 -07:00
2026-05-30 12:09:10 -07:00
2026-06-07 19:13:24 -07:00
2026-04-04 15:32:20 -07:00
2026-05-11 12:16:26 -07:00
2026-05-26 21:36:53 -07:00
2026-05-11 12:16:26 -07:00
2026-06-04 11:14:43 -07:00
2026-05-26 21:36:53 -07:00
2026-06-04 11:14:43 -07:00
2026-03-13 21:08:12 -07:00
2026-05-29 08:35:00 -07:00
2026-04-16 10:41:38 -07:00
2026-06-07 19:13:24 -07:00
2026-06-04 11:14:43 -07:00
2026-06-07 19:13:24 -07:00
2026-05-26 21:36:53 -07:00
2026-05-25 10:57:15 -07:00
2026-05-29 08:35:00 -07:00
2026-04-19 17:50:31 +08:00
2026-04-22 01:06:22 -07:00
2026-06-02 22:36:34 -07:00
2026-03-29 21:43:36 -06:00
2026-05-30 12:09:10 -07:00
2026-05-26 16:50:03 -07:00
2026-05-01 07:21:28 -07:00
2026-05-25 10:57:15 -07:00
2026-06-04 11:14:43 -07:00
2026-05-30 12:09:10 -07:00
2026-03-27 00:44:37 -06:00
2026-05-24 01:43:51 -07:00
2026-05-29 08:35:00 -07:00
2026-04-18 15:05:42 +08:00
2026-04-06 14:41:06 -07:00
2026-05-26 16:50:03 -07:00