mirror of
https://github.com/garrytan/gstack.git
synced 2026-10-31 22:14:25 +01:00
* fix(make-pdf,design): real TOC page numbers and anchors; design models move to gpt-5.5 + gpt-image-2 (#2903, #2807) * ci: pin every action to a SHA, Scorecard, checksummed Bun, scoped Codex CLI in the CI image, macOS named-regressions job (#1948, #1706, #1997) * fix(cso,browse): Windows/macOS lease identity, retention skips bad runs, truthful 'not assessed' reports, env.kv false positive, Windows browse spawn fixes (#2894, #2912, #2048, #2637, #2805) * fix(outside-voice): one Codex model precedence for probe and dispatch, bounded timeouts with KILL escalation, probe cache identity, guarded mktemp, skills hidden in nested Codex (#2776, #2914, #2787, #2881, #2847) * feat(setup): install registry, ./setup --status, staged activation, per-scope migrations, host tiers and conformance kit, OpenCode/Hermes fixes, Copilot CLI (experimental), disabled_skills, slimmer CLAUDE.md (#1925, #2879, #2347, #2338, #2626, #2629, #2825, #2015, #393, #1206, #2096) Co-authored-by: Andrey Esipov <61357035+andrey-esipov@users.noreply.github.com> Co-authored-by: Matthew Williams <5863886+ridermw@users.noreply.github.com> Co-authored-by: Rocky Wu <92764750+lolisaigao1234@users.noreply.github.com> * fix(preamble): skills start in worktree-isolated Claude Code sessions — one literal skill-start line, context-recovery helper, no eval in skill blocks, $N token tripwire, honest plan-mode precedence (#2763, #2896, #2851) * fix(setup): per-install renders for renamed, vendored and custom-config installs, space-safe alias roots, per-host /cso launcher path (#1882, #2906) * test: free tests never write the real HOME (home-write tripwire), no orphaned browse daemons, symlinked-TMPDIR (macOS) fixes, gbrain-on-PATH isolation (#2895, #2816, #2829, #2841, #2982, #2911, #2909, #2908, #2910) * chore: integrate wave follow-ups — regenerate all hosts, README model docs, TODOS, touchfiles, duration seeds, Bun 1.3 telemetry test fix, replay fixtures pinned to their recorded bytes * v1.91.14.0: release metadata * test(browse): group-kill cleanup falls back to the leader when macOS returns EPERM for a live group * ci: Codex login steps run under bash (the CI container's default sh rejects pipefail) * fix: full-suite repairs — private state roots for 7 real-HOME writers, truthful home-guard attribution with --attribute-home, gstack-paths shim in ship-hook fixtures, Copilot in team-init probes, test-of-test detector, cookie review fixture pinned to the approved excerpt * fix(windows): LF for Dockerfiles, normalized home-guard exclusions, path.relative fixture containment, ship push test spawn timeouts * test(design-detect): widen the whole-scan budget test's timing margins so a loaded macOS runner can't time out the single-batch call * fix(evals): qa protocol names defined for the judge, async PTY judge so overlapping sessions keep their cleanup deadline, bws setup cases use the standard JUDGE_MS tier * test(pty): the non-blocking judge case is POSIX-only (its fake judge is a shebang script, like the PTY harness it covers) * test(evals): ship-coverage-audit names absolute skill paths, uses Read, and skips the Step 7 artifact nothing consumes (removes the mechanism behind 3 of 4 historical timeouts) * test: deflake terminal-agent concurrent startup (write the placeholder record before spawning, like the product) and qa-evidence resumed pipe (barrier on a full high-water mark instead of a sleep) * fix(design): daemon log stream handles open errors instead of crashing the daemon; shutdown test awaits the stubbed exit * test(evals): skillify checks the product's resolved state root (no GSTACK_HOME bypass), negative cases check every root; tpa shims live outside the agent's cwd and answer consistently * test(evals): coverage-audit detector splits parallel columns at │ rails and [+] groups; coverage prompts name absolute skill paths; TODOs from the gate eval census * fix(plan-eng-review): scope gate always sends the menu (no headless 'Scope pending' exit); PTY harness ends idle turn-ends and API-error panels promptly with a precise diagnostic * test(evals): one position-bound coverage-read rule credits read-only && chains (labels, context ranges, git displays in either order) and still rejects forged output * fix(ship): documentation section has one saved source inserted by cat (never retyped); spawned-marker evidence is the child output; refreshed codex/factory ship goldens * test(docsync): the byte-exact insert positive is POSIX-only (the bash-command observer refuses backslash paths by design) * test(evals): plan-design-with-ui focus-title rule accepts the comma-less 'dimensions or focus' wording (replayed on the captured CI run, negative controls kept) * fix(qa-callers): exploratory preflight says the scope/method Reads come after exploratory.md; design-review scan check credits an executed scan proven by one engine run over the changed files --------- Co-authored-by: Andrey Esipov <61357035+andrey-esipov@users.noreply.github.com> Co-authored-by: Matthew Williams <5863886+ridermw@users.noreply.github.com> Co-authored-by: Rocky Wu <92764750+lolisaigao1234@users.noreply.github.com>
91 lines
3.6 KiB
TypeScript
91 lines
3.6 KiB
TypeScript
/**
|
|
* One Bun version across every CI surface.
|
|
*
|
|
* The drift class this pins: Dockerfile.ci's comment records that the old
|
|
* `| BUN_VERSION=x.y.z bash` form silently installed latest on every image
|
|
* rebuild (observed 1.3.13/1.3.14 drift vs the 1.3.10 devs ran locally),
|
|
* and before 2026-08-29 the lanes disagreed four ways (1.3.13 / latest /
|
|
* unpinned / 1.3.10). Different Bun versions change test-runner OUTPUT
|
|
* SHAPES the strict classifiers regex-match, spawn semantics, and shell
|
|
* parsing — a lane on a different Bun is testing a different product.
|
|
*
|
|
* Bumping Bun: change every surface in one commit; this test names each one.
|
|
*/
|
|
import { describe, expect, test } from 'bun:test';
|
|
import * as fs from 'node:fs';
|
|
import * as path from 'node:path';
|
|
|
|
const ROOT = path.resolve(__dirname, '..');
|
|
const WORKFLOWS_DIR = path.join(ROOT, '.github', 'workflows');
|
|
|
|
interface Pin {
|
|
surface: string;
|
|
version: string;
|
|
}
|
|
|
|
function collectPins(): Pin[] {
|
|
const pins: Pin[] = [];
|
|
|
|
for (const name of fs.readdirSync(WORKFLOWS_DIR).sort()) {
|
|
if (!/\.ya?ml$/.test(name)) continue;
|
|
const source = fs.readFileSync(path.join(WORKFLOWS_DIR, name), 'utf-8');
|
|
const lines = source.split('\n');
|
|
for (let i = 0; i < lines.length; i++) {
|
|
if (!/uses:\s*oven-sh\/setup-bun@/.test(lines[i])) continue;
|
|
// A pinned stanza is `with:` + `bun-version: <v>` within the next few
|
|
// lines; an unpinned setup-bun is itself drift (installs latest).
|
|
const window = lines.slice(i + 1, i + 4).join('\n');
|
|
const m = window.match(/bun-version:\s*["']?([\w.]+)["']?/);
|
|
pins.push({
|
|
surface: `${name}:${i + 1}`,
|
|
version: m ? m[1] : '<unpinned setup-bun — installs latest>',
|
|
});
|
|
}
|
|
}
|
|
|
|
const dockerfile = fs.readFileSync(
|
|
path.join(ROOT, '.github', 'docker', 'Dockerfile.ci'), 'utf-8');
|
|
const dockerPin = dockerfile.match(/^ARG BUN_VERSION=["']?([\w.]+)["']?$/m);
|
|
pins.push({
|
|
surface: 'Dockerfile.ci',
|
|
version: dockerPin ? dockerPin[1] : '<no ARG BUN_VERSION=X.Y.Z>',
|
|
});
|
|
|
|
const gitlab = fs.readFileSync(path.join(ROOT, '.gitlab-ci.yml'), 'utf-8');
|
|
const gitlabPin = gitlab.match(/BUN_VERSION:\s*["']?([\w.]+)["']?/);
|
|
pins.push({
|
|
surface: '.gitlab-ci.yml',
|
|
version: gitlabPin ? gitlabPin[1] : '<no BUN_VERSION>',
|
|
});
|
|
|
|
return pins;
|
|
}
|
|
|
|
describe('bun version pins', () => {
|
|
test('every CI surface pins the same bun version', () => {
|
|
const pins = collectPins();
|
|
// Sanity: the scan found the known surfaces (a regex rot that finds
|
|
// nothing must fail loudly, not vacuously pass).
|
|
expect(pins.length).toBeGreaterThanOrEqual(6);
|
|
|
|
const versions = [...new Set(pins.map((p) => p.version))];
|
|
const detail = pins.map((p) => `${p.surface} → ${p.version}`).join('\n');
|
|
expect(versions, `bun version drift across CI surfaces:\n${detail}`).toHaveLength(1);
|
|
expect(versions[0]).toMatch(/^\d+\.\d+\.\d+$/);
|
|
});
|
|
|
|
test('every CI surface requires Bun 1.4.0 or newer for safe extra-stdio ownership', () => {
|
|
// Matching pins alone would allow every lane to regress together. Older
|
|
// Linux Bun releases double-close extra stdio FDs during subprocess GC,
|
|
// which can close unrelated listeners after the OS reuses an FD number.
|
|
// https://github.com/oven-sh/bun/issues/34785#issuecomment-5020318035
|
|
for (const pin of collectPins()) {
|
|
expect(pin.version, `${pin.surface} must pin a stable numeric version`).toMatch(/^\d+\.\d+\.\d+$/);
|
|
expect(
|
|
Bun.semver.satisfies(pin.version, '>=1.4.0'),
|
|
`${pin.surface} pins Bun ${pin.version}; Bun >=1.4.0 is required for safe extra-stdio ownership`,
|
|
).toBe(true);
|
|
}
|
|
});
|
|
});
|