Garry Tan
c88825dba0
test(catalog): unit + regression coverage for catalog-trim helpers
...
Four exported functions in scripts/gen-skill-docs.ts handle every skill's
frontmatter rewrite at gen time but had zero unit tests. Both real bugs we
shipped (and fixed) on this branch lived in these functions:
v1.45.0.0 design-consultation: when the first sentence exceeded 200 chars,
routing-prose extraction lost the entire tail (anchored on truncated lead
with "..." that didn't substring-match the original).
v1.45.0.0 CI freshness: root-skill key leaked the checkout directory
name ("seville-v3" vs "gstack") and aggregate order was filesystem-
iteration order.
Both shapes are now regression-tested:
- splitCatalogDescription: 7 tests covering simple multi-line, >200-char
first sentence (design-consultation regression), voice-trigger
extraction, no-(gstack) handling, embedded periods (documents known
fallback), no-period fragments, and idempotency.
- buildTrimmedDescription: 3 tests.
- buildWhenToInvokeSection: 3 tests.
- applyCatalogTrim: 4 tests covering the standard rewrite, no-op for
already-short descriptions, the YAML-collision newline fix, and the
malformed-frontmatter null return.
- proactive-suggestions.json determinism: 3 tests asserting sorted keys,
root keyed as "gstack" (not the worktree directory), and no
timestamp/generated_at field that would flap CI freshness.
Test plan:
- bun test test/catalog-trim.test.ts: 20 pass, 0 fail
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com >
2026-05-26 08:39:47 -07:00
..
2026-05-25 21:18:15 -07:00
2026-05-25 20:37:36 -07:00
2026-04-24 00:04:53 -07:00
2026-03-18 23:57:59 -05:00
2026-05-17 08:26:36 -07:00
2026-04-19 17:50:31 +08:00
2026-05-21 21:21:07 -07:00
2026-04-19 17:50:31 +08:00
2026-05-25 10:57:15 -07:00
2026-05-06 19:37:53 -07:00
2026-05-21 21:21:07 -07:00
2026-05-20 07:35:01 -07:00
2026-04-08 22:21:28 -10:00
2026-05-26 08:39:47 -07:00
2026-04-23 07:25:20 -07:00
2026-03-23 23:05:22 -07:00
2026-05-14 11:11:52 -04:00
2026-05-09 08:06:47 -07:00
2026-05-16 12:32:33 -07:00
2026-04-19 08:38:19 +08:00
2026-05-25 20:37:08 -07:00
2026-05-25 10:57:15 -07:00
2026-05-21 21:21:07 -07:00
2026-04-26 13:55:13 -07:00
2026-05-24 01:43:51 -07:00
2026-05-20 07:35:01 -07:00
2026-04-24 01:38:21 -07:00
2026-05-14 17:20:48 -07:00
2026-05-17 08:26:36 -07:00
2026-05-14 17:20:48 -07:00
2026-05-21 18:55:55 -07:00
2026-05-21 21:21:07 -07:00
2026-04-24 01:38:21 -07:00
2026-05-17 08:26:36 -07:00
2026-04-24 01:38:21 -07:00
2026-05-17 08:26:36 -07:00
2026-05-04 09:29:48 -07:00
2026-05-21 21:21:07 -07:00
2026-05-14 17:20:48 -07:00
2026-05-21 18:55:55 -07:00
2026-04-16 10:41:38 -07:00
2026-05-21 21:21:07 -07:00
2026-05-20 06:56:41 -07:00
2026-05-14 11:11:52 -04:00
2026-05-21 21:21:07 -07:00
2026-05-20 07:35:01 -07:00
2026-05-25 10:57:15 -07:00
2026-05-21 21:21:07 -07:00
2026-05-06 19:37:53 -07:00
2026-04-28 01:17:54 -07:00
2026-05-20 07:35:01 -07:00
2026-05-21 21:21:07 -07:00
2026-05-21 21:21:07 -07:00
2026-05-17 08:26:36 -07:00
2026-05-25 10:57:15 -07:00
2026-05-20 07:35:01 -07:00
2026-04-18 15:05:42 +08:00
2026-04-18 15:05:42 +08:00
2026-04-28 01:17:54 -07:00
2026-05-14 17:20:48 -07:00
2026-05-25 10:57:15 -07:00
2026-04-26 13:55:13 -07:00
2026-05-10 06:57:24 -07:00
2026-04-17 00:45:13 -07:00
2026-05-25 10:57:15 -07:00
2026-04-18 15:05:42 +08:00
2026-05-21 21:21:07 -07:00
2026-05-21 21:21:07 -07:00
2026-05-14 11:11:52 -04:00
2026-05-01 19:51:51 -07:00
2026-05-07 20:14:59 -07:00
2026-05-20 07:35:01 -07:00
2026-04-19 08:38:19 +08:00
2026-05-06 19:37:53 -07:00
2026-04-25 11:52:48 -07:00
2026-05-14 21:19:58 -07:00
2026-04-17 00:45:13 -07:00
2026-05-25 20:37:36 -07:00
2026-04-18 15:05:42 +08:00
2026-05-06 19:37:53 -07:00
2026-05-01 07:06:37 -07:00
2026-04-23 18:25:34 -07:00
2026-04-18 15:05:42 +08:00
2026-05-21 21:21:07 -07:00
2026-05-21 21:21:07 -07:00
2026-05-21 21:21:07 -07:00
2026-05-20 06:56:41 -07:00
2026-05-20 06:56:41 -07:00
2026-05-21 21:21:07 -07:00
2026-04-23 18:25:34 -07:00
2026-05-25 20:30:36 -07:00
2026-05-20 07:35:01 -07:00
2026-03-26 23:21:27 -06:00
2026-04-24 01:38:21 -07:00
2026-05-24 01:43:51 -07:00
2026-05-14 21:19:58 -07:00
2026-05-06 19:37:53 -07:00
2026-05-14 21:19:58 -07:00
2026-05-09 08:06:47 -07:00
2026-04-18 23:58:59 +08:00
2026-05-25 20:36:43 -07:00
2026-04-19 08:38:19 +08:00
2026-05-25 20:38:35 -07:00
2026-05-25 20:38:35 -07:00
2026-05-25 20:38:35 -07:00
2026-05-01 19:51:51 -07:00
2026-05-11 12:16:26 -07:00
2026-05-01 08:45:36 -07:00
2026-04-26 13:55:13 -07:00
2026-04-19 08:38:19 +08:00
2026-05-11 12:16:26 -07:00
2026-05-06 19:37:53 -07:00
2026-04-23 17:54:54 -07:00
2026-04-19 08:38:19 +08:00
2026-03-23 06:57:22 -07:00
2026-03-26 11:08:31 -07:00
2026-05-11 12:16:26 -07:00
2026-05-21 16:09:26 -07:00
2026-05-21 16:09:26 -07:00
2026-05-21 16:09:26 -07:00
2026-03-31 23:08:22 -06:00
2026-05-04 09:29:48 -07:00
2026-05-01 08:45:36 -07:00
2026-05-01 19:51:51 -07:00
2026-04-19 05:44:39 +08:00
2026-04-22 01:06:22 -07:00
2026-04-23 18:42:58 -07:00
2026-04-30 02:50:09 -07:00
2026-05-06 20:27:20 -07:00
2026-04-30 02:50:09 -07:00
2026-05-09 17:01:13 -07:00
2026-04-30 02:50:09 -07:00
2026-05-06 20:27:20 -07:00
2026-05-09 17:01:13 -07:00
2026-05-11 12:16:26 -07:00
2026-04-30 02:50:09 -07:00
2026-05-06 20:27:20 -07:00
2026-05-03 20:26:59 -07:00
2026-04-30 02:50:09 -07:00
2026-05-06 20:27:20 -07:00
2026-05-09 17:01:13 -07:00
2026-05-09 17:01:13 -07:00
2026-05-01 19:51:51 -07:00
2026-04-26 13:55:13 -07:00
2026-04-23 18:25:34 -07:00
2026-04-18 15:05:42 +08:00
2026-05-21 16:09:26 -07:00
2026-05-11 12:16:26 -07:00
2026-03-23 10:17:33 -07:00
2026-03-30 22:07:50 -06:00
2026-05-11 12:16:26 -07:00
2026-04-19 08:38:19 +08:00
2026-05-06 19:37:53 -07:00
2026-05-14 17:20:48 -07:00
2026-05-06 19:37:53 -07:00
2026-04-26 13:55:13 -07:00
2026-04-04 15:32:20 -07:00
2026-05-11 12:16:26 -07:00
2026-05-11 12:16:26 -07:00
2026-03-31 23:08:22 -06:00
2026-03-26 17:31:53 -06:00
2026-03-13 21:08:12 -07:00
2026-04-16 10:41:38 -07:00
2026-05-25 21:18:15 -07:00
2026-05-25 21:09:59 -07:00
2026-05-25 10:57:15 -07:00
2026-04-19 17:50:31 +08:00
2026-04-22 01:06:22 -07:00
2026-03-29 21:43:36 -06:00
2026-05-01 07:21:28 -07:00
2026-05-25 10:57:15 -07:00
2026-05-09 17:01:13 -07:00
2026-03-27 00:44:37 -06:00
2026-05-24 01:43:51 -07:00
2026-04-18 15:05:42 +08:00
2026-04-06 14:41:06 -07:00
2026-05-25 21:09:59 -07:00