mirror of
https://github.com/garrytan/gstack.git
synced 2026-09-18 02:42:25 +02:00
* feat: add optional Memorable workflow memory (cherry picked from commit6bd5d477b2) * fix: refuse the second registration, and say what leaves the machine Two things the first cut got wrong. Memorable's own installer registers the same UserPromptSubmit hook, under its own name and outside gstack's table. `memorable start`, `memorable setup` and `memorable install-hooks` all do it, and that is the documented way to install the CLI, so on most machines it is already there before gstack is asked. Registering ours beside it ran the same command twice on every prompt: context injected twice, and the session captured twice against the user's own extraction allowance. `enable` now looks for it and refuses, naming the entry and the file it lives in; `status` says who registered it rather than reporting none. Matched on the command rather than on a tag, for the reason the hook table already gives: Claude Code rewrites settings and private tags do not survive it. The removal instruction says to delete the entry by hand because Memorable has no command that removes its own hook. `uninstall-hooks` is not a command in 0.5.18; it answers "unknown command". The README said "Memorable, not gstack, owns the captured data and any network access", which answers the question by pointing away from it. It now carries a per-command table of exactly what leaves the machine, in the shape the adopted gbrain section uses, and it is explicit that the hook makes no network call of its own, that every row is the third-party CLI acting under its own consent, and that `gstack-egress` will therefore not show any of it. Under it, the split between what gstack pin-tests (the gating and the wiring) and what is Memorable's claim (storage, sending, and what disable and forget erase). The CHANGELOG entry is removed. This file has never carried an [Unreleased] heading; every entry is a version and a date, written at release. The text is in the pull request for whoever cuts the next one. Three tests added: enable refuses and touches neither consent nor settings when Memorable already holds the hook, status names that registration, and a foreign UserPromptSubmit hook is not mistaken for Memorable's. (cherry picked from commite0899afa8c) * docs: a guide for the Memorable bridge, in the gbrain-sync shape README carries the section and the egress table; this is the page it links to for anyone who wants the whole thing. Same shape as docs/gbrain-sync.md, which is the closest thing in the repo: an optional integration whose interesting questions are all about what leaves the machine and how to turn it off. What it covers that the README cannot at that length: that the hook sees every Claude Code prompt rather than only the ones a skill produced; that capture is a separate consent from this bridge, so turning the bridge off does not turn capture off; what to do when Memorable has already registered the hook itself, which is the common case because its own installer does it; and why the hook has no loud failure path. The egress table is repeated here rather than linked, because the sentence it is answering ("what does this send") is the one somebody arrives on this page already asking. Co-authored-by: Advaiyt Sane <advaiyt.sane@gmail.com> Co-authored-by: Nikhil Krishnaswamy <krishnaswamynikhil@gmail.com> (cherry picked from commit5c108cc0f7) * feat(settings-hook): identity-aware remove-source + read-only list-items remove-source used to inspect only entries still carrying the _gstack_source tag. Claude Code strips that tag when it rewrites settings.json, so an off switch built on remove-source alone silently no-oped on exactly the entries it was written for. Removal is now driven by KNOWN_HOOKS identity for the requested source (tagged or not), keeps the tagged-single-item legacy-stray rule, never touches another source's items, and leaves entries with nothing of ours byte-identical. list-items is the read-only view of the same identity table: one JSON string literal per matching hook command, filters (--owned-by, --command-regex as a JavaScript RegExp) applied inside the JS, empty stdout for no match, and the mutating verbs' exit codes (1 usage, 3 unparseable settings, 4 unexpected shape) so callers can decide mutations from its output without parsing raw command strings. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> * feat(config): memorable_recall consent key (on|off, default off, reject-and-preserve) The gstack-side gate for the Memorable UserPromptSubmit bridge. `on` lets a Claude Code hook hand every prompt to a third-party binary, so the key follows the codex_reviews rule: an invalid value is rejected and the stored value kept, never coerced in either direction. Registered in all four places gstack-config keeps in sync (annotated header, DEFAULTS table, the set validator, and both enumeration loops). Memorable's own capture consent (`memorable enable`) is a separate thing gstack never sets. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> * feat(hooks): memorable-user-prompt-hook.ts — consent gate, deny veto, HIGH-tier pre-scan, fail-closed receipt, trust envelope; runExternal in spawn-bin The PR's hook exec'd the vendor binary with the full environment and passed its stdout to Claude verbatim. It is now the house pattern: a fail-open bash shim over a .ts twin that (1) gates on the memorable_recall consent key, (2) skips repos whose trust policy is deny or read-only, (3) scans the prompt (raw bytes and decoded string leaves) and refuses to hand over a HIGH-tier credential shape, (4) writes a fail-closed egress receipt naming the local executable it ran, (5) spawns the vendor in its own process group with an allowlisted environment and group-kills it on timeout, (6) accepts only a string additionalContext back, caps it at 8 KiB on a UTF-8 boundary and wraps it in the trust envelope, and (7) records an `output-written` outcome after the stdout write completes. One deadline clock (4.5 s) undercuts Claude Code's 5 s kill and bounds both ledger writes through the new lockBudgetMs option on writeReceipt/writeOutcome (default unchanged). spawn-bin gains runExternal for external executables (detached group, stderr drained, stdin EPIPE handled, stdout capped, win32 refused). The wiring test pins the sink fail-closed and sweeps hosts/. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> * fix(gstack-memorable): canonical hook path, no vendor consent, --timeout 5, identity-based status, verified disable, lifecycle lock enable used to bake the hook path from whatever tree the CLI ran in and to run the vendor's own `memorable enable` (its consent for storing AND uploading session traces) before registering anything. It now resolves the canonical install like setup does and refuses when that install does not carry this bridge (version and hook-twin check), registers through the canonical hook manager with --timeout 5, records gstack's own consent in memorable_recall, never executes the vendor, and restores the captured prior state if consent cannot be recorded. disable flips the gate first, removes the entry by identity (tag or no tag), verifies both states and reports partial failure instead of a blended success. status reads only: resolution path, gate, registration by identity (gstack / vendor-own / both / unknown), mismatch lines, receipt count, recent hook errors. enable and disable serialise under a lock with stale takeover. Windows is refused (TODOS.md D21). Exit codes mirror the hook manager (3/4/5). Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> * fix(setup): --no-team sweep keeps the opt-in gstack-memorable hook `./setup --no-team` finishes its teardown with `prune-stale --all`, which removes every KNOWN_HOOKS item. The Memorable bridge hook is a user-registered opt-in unrelated to team mode, exactly like verify-gate, so it joins the sweep exclusion list. The verify-gate pin now accepts the comma-extended list; a schema-aware case proves the exclusion keeps both opt-ins (tagged or tag-stripped) while the uninstall sweep still removes them. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> * fix(uninstall): named gstack-memorable arm, vendor-consent notice, honest kept config The identity sweep already removed the Memorable bridge hook as an unnamed stray. It now has a named arm like every other source, so the summary says what went, and says plainly that Memorable's own consent (if the user granted it) is theirs to revoke. Under --keep-state the kept config is set memorable_recall=off so it never claims a hook that is gone. The canonical-paths pins cover the sixth KNOWN_HOOKS row and the new uninstall source. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> * feat(egress): memorable-recall row in gstack-egress grants `gstack-egress grants` promises every standing consent in force with the command that revokes it. The Memorable bridge's memorable_recall key is one, so it gets a row: off by default, granted only when `gstack-memorable enable` set it, revoked by `gstack-memorable disable`. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> * docs(memorable): accurate bridge guide; README row, Docs table, privacy pointer; PROJECT_STRUCTURE The README section becomes one row in the Standalone binaries table (the shape every other binary uses) plus a Docs-table row and one Privacy bullet saying that optional third-party bridges are off by default and receipted. The guide now separates the two consents, says what gstack hands to the vendor binary and what the receipt can and cannot attest, attributes every statement about the vendor's network activity to the vendor, describes the hook manager accurately (identity via KNOWN_HOOKS, list-items vs list-sources, rollback is whole-file), states the Claude Code hot-reload behaviour, adds a troubleshooting runbook, and keeps the contributors' credit in the CHANGELOG idiom. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> * chore(todos): Memorable bridge follow-ups Filed from the CEO and eng reviews of the bridge fix-up: the generic third-party hook seam, Windows support (deferred whole), the envelope kind parameter, a vendor payload-minimization contract, a latency and timeout revisit, resolver and canonical-root consolidation, a non-interactive MEDIUM-tier redaction policy for hooks, and adopting list-items at setup's plan-tune check. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> * fix(settings-hook): list-items --owned-by with --command-regex intersects When both filters are given, an item must satisfy both: owned by the requested source AND matching the pattern. Before, the regex branch skipped every owned row, so the combination could never match. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> * fix(gstack-memorable): compat_check reads list-items output before grepping Under pipefail, piping the probe straight into grep -q let a non-zero probe exit mask the match, so a hook manager without list-items was sometimes reported as compatible. Capture the output, then grep. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> * test: coverage for the memorable bridge (remove-source regression for every KNOWN_HOOKS source) - settings-hook: identity removal pinned for each source in KNOWN_HOOKS; list-items unknown flag and combined --owned-by/--command-regex - gstack-memorable: enable/disable failure paths (lock give-up exit 5 with the test-only lock timeout override, consent-write failures guarded by canRevokeWrites, canonical-version mismatch, no-bun status) - hook: non-object JSON, missing cwd, non-ASCII bytes, held-open stdin, shim without bun, stripControl, resolveVendor, runExternal ENOENT - egress-receipt: lockBudgetMs 0 and writeOutcome on garbage input - uninstall: no memorable entry present reports nothing removed Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> * docs(memorable): gbrain backend note and the settings-rewrite race Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> * perf(redact-engine): line/col by binary search over a per-scan line index lineColAt walked the input from offset 0 for every finding, so a match-dense input (a pasted log full of emails and IPs) cost O(findings x bytes): 128 KiB took ~400 ms and 900 KiB tens of seconds. The line starts are now indexed once per scan, on the first finding, and each finding is a binary search. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> * feat(gbrain-repo-policy-client): repoPolicyTier accepts a spawn timeout The policy script spawn was fixed at 10 s, more than twice the memorable hook's whole budget. Callers on their own deadline pass what they can afford; a timeout reads as unreadable and polarity stays the caller's. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> * fix(spawn-bin): runExternal resolves on the child's exit, keeps stdin errors advisory - A vendor that exits 0 but leaves a background child holding its pipes was held to the deadline, group-killed and reported as a timeout with its answer dropped. 'exit' now starts a short stdout drain, then resolves with the real exit code and kills whatever still holds the group. - EPIPE on the child's stdin (it answered before reading a large input) is reported as stdinError, separate from error, so a delivered answer is not classified as a spawn failure. - Stdio streams are destroyed and the child unref'd on resolve so a straggler cannot pin the hook process; tail/grace/drain sizes are named constants. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> * fix(hooks): memorable hook closes the review army's gaps - Vendor failures are logged even with empty stderr (a silently hanging vendor taxed every prompt invisibly); the stderr tail is withheld when the redaction engine finds a credential or PII shape in it; hook-errors.log is created 0600. - Trust-policy veto fails closed when git cannot run or answer in time (it read as 'no remote' before); the policy script spawn is bounded by the hook's clock; a payload cwd that is not a directory falls back. - Each secret scan is admitted by the deadline clock (the engine's cost grows with match density); stdin is decoded once. - The pre-spawn gate re-check logs a config failure instead of swallowing it; an incomplete stdin read is named as such, not as 'not JSON'. - Carriage returns are stripped with the other controls. - The vendor env allowlist adds the standard proxy, TLS and XDG variables so a vendor behind a corporate proxy or private CA still reaches its service. - A stdin EPIPE on a delivered answer is recorded in the outcome, not treated as a spawn error. - Stage caps and the truncation marker are named constants; a test-only GSTACK_MEMORABLE_TEST_BUDGET_MS can shorten (never widen) the budget. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> * fix(gstack-memorable): lock staleness from the directory mtime; honest messages - A contender that looked between the holder's mkdir and its ts write read a missing ts as 0, called the lock stale and reclaimed it; staleness now comes from the lock directory's own mtime (the settings-hook idiom). - The ensure-event failure is no longer labelled 'warning'; the consent-write rollback message says what was actually kept; a removal that left no entry is reported on stdout, not as an error; receipts are counted from the filtered JSON array, not a formatting artefact; the resolution order and lock tuning are named once. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> * fix(uninstall): memorable_recall goes off whether or not state is kept gstack-config resolves its root through GSTACK_STATE_ROOT/GSTACK_HOME, which can differ from the STATE_DIR uninstall removes; a full uninstall could leave memorable_recall=on in a config that survived. Flipped only when currently on. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> * test: pin the review-army fixes for the memorable bridge Nonce-scoped orphan checks (the system-wide ps grep could see another shard's sleeper); exit-with-lingering-grandchild; advisory stdin EPIPE; withheld stderr; vendor timeout logged with empty stderr; CR stripping; budget seam; rate-limit expiry and 0600 log; unreadable policy store fails closed; file-as-cwd fallback; mtime-based lock staleness and the mkdir gap. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> * docs(memorable): vendor environment allowlist and stderr policy; two follow-ups Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> * fix(hooks): memorable hook second-pass review fixes - Trust-policy lookup fails closed on any git failure that is not 'no such remote' or 'not a git repository' (a corrupt or unreadable .git/config and dubious ownership exit 128 and used to read as 'no remote'). - pickAdditionalContext takes the first complete top-level JSON object, so a vendor whose background helper appends a line to stdout (or prints a banner first) does not lose its answer. - The hook-errors.log rate limiter keys on a stable string (a vendor's timestamped stderr no longer defeats it); the log is chmod 0600 on every append because sibling hooks create the same file without a mode. - Scan admission is sized by payload bytes (scan() is uninterruptible). - The receipt payload class is a stable token; the prose moved to the docs. - Header, constants and comments match the behaviour (silent skips vs logged refusals; HIGH/MEDIUM withholding; STAGE_CAP_MS scope; runExternal in the spawn-bin header; the ledger lock budget doc). Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> * fix(gstack-memorable): stale-lock takeover by atomic rename; comments match behaviour Two contenders that both saw a stale lock could both reclaim it with rm -rf; the settings-hook idiom (mv to a private name, exactly one winner) is used instead. The hook-manager fallback comment now says every verb falls back. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> * test: second-pass coverage for the memorable bridge Policy lookup outcomes (plain dir, repo without policy, corrupt .git/config fails closed); repoPolicyTier timeoutMs; line/col at line starts, after blank lines, CRLF and first char; tolerant first-JSON-object parsing; keyed rate limit; uninstall never creates a config just to say off and flips consent in a GSTACK_STATE_ROOT outside the removed state dir. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> * docs(memorable): silent skips vs logged refusals; payload class token; D21/D24 anchors Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> * fix(hooks): memorable hook survives host termination and brace-bearing banners - The bash shim runs bun as a job and forwards SIGTERM/SIGINT/SIGHUP (bash holds a signal until a foreground child exits); the .ts kills the in-flight vendor's process group on the way out (runExternal exposes the group kill through onSpawn), so a hook the host terminates cannot leave the vendor running with the prompt on its stdin. - The tolerant stdout parser tries every complete top-level object (bounded) and takes the first carrying a string additionalContext, so a banner with braces or quotes, or a progress object, no longer costs the answer. - git runs with LC_ALL=C and the not-a-repository check is anchored to the start of its message: a localized git or a repository path containing the phrase can no longer flip the lookup. - The rate limiter remembers up to 32 live keys, so alternating failures cost two lines, not one per prompt. - Unicode format characters (bidi overrides, zero-width spaces) are stripped from vendor text at egress; the zero-width joiner stays for emoji. - A killed child (timeout, ENOBUFS) resolves on exit without the stdout drain, and the post-kill grace is 100 ms, so the timeout outcome fits the reserve. - The ledger size warning, which the host discards from an exit-0 hook's stderr, is logged where status looks. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> * fix(gstack-memorable): failed stale-lock takeover reaches the give-up; disable runs without gstack-config; status shows ledger size Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> * test: host termination kills the vendor group; brace banners, decoys and format characters; non-reclaimable stale lock gives up; ledger line in status Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> * docs(memorable): the vendor dies with a terminated hook Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> * test: deterministic stdin EPIPE case for runExternal (child closes stdin, stays alive) Under parallel shard load a child that merely exits fast raced the write and the EPIPE was not always observed; closing the read end first makes it so. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> * fix(hooks): outside-model review fixes for the memorable hook and runExternal - Nothing in the vendor's process group outlives the call: the group is killed on every resolve, the clean 'close' path included (a helper the vendor forked with redirected stdio ran on unsupervised before). - A child that already exited when the deadline fires keeps its result; the deadline only ends the drain instead of rewriting a completed exit as a timeout. - The decoded-leaf scan reports when its node/depth bound cut the walk short and the hook refuses the hand-off as unscanned; object keys are scanned too. - git for the trust-policy lookup runs without inherited GIT_* selectors (GIT_DIR, GIT_WORK_TREE, GIT_CONFIG_*), so it inspects the session's repository and no other; a host cancellation kills that git as well. - An unmatched brace in a vendor banner no longer hides the answer after it. - The stderr tail is scanned whole before it is cropped for the log, so a credential's prefix cannot be cropped away from its secret half. - The vendor override reads an empty GSTACK_MEMORABLE_BIN as unset, exactly as bin/gstack-memorable does, so enable checks the binary the hook runs. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> * fix(gstack-memorable): stale-lock reclaim checks the inode it judged and the owner's liveness; status reports a failed receipt query as unknown Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> * fix(uninstall): revoke memorable_recall independently of the hook manager and name a failed revocation Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> * test: group kill on clean close, walk exhaustion refused, GIT_DIR cannot bypass the deny, unmatched-brace banner, whole-tail scan, empty-override parity, uninstall revocation without the hook manager Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> * docs(memorable): the process-group guarantee and its setsid boundary Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> * chore(release): v1.83.0.0 — Memorable recall bridge, identity-aware hook removal, faster redaction line/col CHANGELOG entry for the Memorable workflow-memory bridge (opt-in, off by default, Claude Code only), the identity-aware remove-source and read-only list-items in the hook manager, the memorable-recall egress sink, runExternal, lockBudgetMs, and the binary-search line/col index in the redaction engine. No migration. Contributed by @AdvaiytSane and @NIkhil-cmd-cmd (#2831). Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> * test: stdin EPIPE observation is scheduling-dependent under shard load; pin the invariant instead A delivered answer is never reclassified as a spawn error; when the EPIPE is observed it is reported as stdinError. Whether it is observed before the child's exit resolves the call is not something the test can force. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> * docs: list the memorable-recall sink among the fail-closed egress sinks CLAUDE.md and ARCHITECTURE.md enumerate the receipt sinks that refuse to send when the ledger cannot be written; the Memorable bridge's per-prompt hand-off is pinned fail-closed in test/egress-receipt-wiring.test.ts but was missing from both lists. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> * test: memorable bridge tests pass on a runner that enforces file modes; scanner-proof key fixture - The consent-write-failure tests make the state dir read-only, which also blocked the bridge lock directory (exit 5 before the path under test); the locks dir is pre-created so only the consent write fails. - The unreadable-store test leaves a 0600 directory behind (the policy script chmods the store path); cleanup restores the search bit and the suite's afterEach reopens directories before removing. - The AWS-key-shaped fixture is built by concatenation, as every sibling test does, so the CI credential gate does not read it as a live key. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> * fix(gstack-memorable): name an unwritable state directory when the lock cannot be created Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> --------- Co-authored-by: AdvaiytSane <advaiyt.sane@gmail.com> Co-authored-by: Nikhil Krishnaswamy <krishnaswamynikhil@gmail.com> Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
415 lines
18 KiB
TypeScript
415 lines
18 KiB
TypeScript
/**
|
|
* Static-grep tripwire for egress-receipt wiring. Free tier — no API.
|
|
*
|
|
* THREAT MODEL: the egress ledger is forensic observability — it records
|
|
* ATTEMPTED egress so accidents are auditable; it is not an exfiltration
|
|
* control. Receipts are written before send, outcomes are best-effort, and
|
|
* fail-open classes can send unrecorded with a warning.
|
|
*
|
|
* Every enumerated off-machine sink must route its send through the receipt
|
|
* ledger (lib/egress-receipt.ts), receipt BEFORE send. A future egress call
|
|
* site added without a receipt fails CI here instead of becoming a
|
|
* user-filed issue. The NEW-SINK SCANNER at the bottom sweeps the whole
|
|
* tree for outbound network ops and requires every hit to be either wired
|
|
* or in the REASONED exemption list — there is no KNOWN_UNWIRED bucket.
|
|
*
|
|
* Out of scope, documented here on purpose: the preamble-generated brain
|
|
* sync block (scripts/resolvers/preamble/generate-brain-sync-block.ts)
|
|
* renders a `git fetch` into skill PROSE that the agent executes — it is
|
|
* agent-executed instructions, not a gstack binary, so it is covered by the
|
|
* skill-prose exemption below rather than a receipt.
|
|
*
|
|
* Pattern mirrors test/hermetic-wiring.test.ts: read source files as text,
|
|
* assert invariants on their contents. Brittle by design — renaming a
|
|
* helper must force the author to look here.
|
|
*/
|
|
|
|
import { describe, test, expect } from 'bun:test';
|
|
import * as fs from 'fs';
|
|
import * as path from 'path';
|
|
|
|
const ROOT = path.resolve(import.meta.path, '..', '..');
|
|
|
|
function read(rel: string): string {
|
|
return fs.readFileSync(path.join(ROOT, rel), 'utf-8');
|
|
}
|
|
|
|
function exists(rel: string): boolean {
|
|
return fs.existsSync(path.join(ROOT, rel));
|
|
}
|
|
|
|
// ── POLARITY TABLE (amendments T3/C8) ──────────────────────────────────────
|
|
// Pinned as data: which sinks refuse the send when the receipt cannot be
|
|
// written (fail-closed) vs warn and proceed (fail-open). Changing a sink's
|
|
// polarity is a security decision — update this table deliberately.
|
|
const POLARITY: Record<string, 'fail-closed' | 'fail-open'> = {
|
|
// fail-closed: gstack state leaving the machine unrecorded is worse than
|
|
// the operation failing.
|
|
'brain-sync': 'fail-closed',
|
|
'memory-ingest': 'fail-closed',
|
|
'gbrain-sync': 'fail-closed',
|
|
'telemetry-sync': 'fail-closed',
|
|
'browse-tunnel (ngrok)': 'fail-closed',
|
|
'gbrain-mcp-verify': 'fail-closed',
|
|
'supabase-provision': 'fail-closed',
|
|
// memorable-recall: a Claude Code hook hands the user's prompt JSON to a
|
|
// third-party binary on every prompt. Skipping one recall costs nothing;
|
|
// an unrecorded hand-off of user content is the thing the ledger exists to
|
|
// prevent, so it fails closed ("no receipt, no send").
|
|
'memorable-recall': 'fail-closed',
|
|
// fail-open: user-facing operations that must not die over an audit-log
|
|
// hiccup; they warn on stderr and proceed.
|
|
'design-openai': 'fail-open',
|
|
'update-check': 'fail-open',
|
|
'security-dashboard': 'fail-open',
|
|
'community-dashboard': 'fail-open',
|
|
'git-class user ops (artifacts-init, brain-restore, session-update)': 'fail-open',
|
|
'context-bill --exact': 'fail-open',
|
|
};
|
|
|
|
/** TS sinks: must import the canonical helper and call writeReceipt(). */
|
|
const MODULE_SINKS = [
|
|
'bin/gstack-gbrain-sync.ts',
|
|
'bin/gstack-memory-ingest.ts',
|
|
'browse/src/server.ts',
|
|
// Code-intelligence adapters (fork port wave 2): the gbrain adapter shells
|
|
// repo content to the user's gbrain DB and the Sourcebot adapter POSTs
|
|
// queries to a self-hosted HTTP endpoint — both sensitive-class
|
|
// (repo-content) sinks, fail-closed. Registered so a refactor that drops
|
|
// their writeReceipt calls fails CI, not just the tree-sweep scanner.
|
|
'lib/code-intelligence/gbrain-adapter.ts',
|
|
'lib/code-intelligence/sourcebot-adapter.ts',
|
|
// Unconditional: context-bill ships in the same tree as this tripwire. A
|
|
// missing file must fail loudly (a rename/move that drops its receipt wiring
|
|
// is exactly what this pins), not silently soften the assertion.
|
|
'lib/context-bill.ts',
|
|
// supabase-provision engine (bin/gstack-gbrain-supabase-provision is a thin
|
|
// bun-shebang entry over this module; the receipt lives at the api-call layer).
|
|
'lib/gbrain-supabase-provision.ts',
|
|
// The Memorable bridge hook: gstack-owned code that hands each prompt to a
|
|
// vendor CLI. hosts/ has no curl/fetch for the scanner to see, so the
|
|
// receipt wiring is pinned here explicitly.
|
|
'hosts/claude/hooks/memorable-user-prompt-hook.ts',
|
|
];
|
|
|
|
/** Shell sinks: must source the shared lib; every network op receipted. */
|
|
const SHELL_SINKS = [
|
|
'bin/gstack-telemetry-sync',
|
|
'bin/gstack-update-check',
|
|
'bin/gstack-brain-sync',
|
|
'bin/gstack-gbrain-mcp-verify',
|
|
'bin/gstack-security-dashboard',
|
|
'bin/gstack-community-dashboard',
|
|
'bin/gstack-artifacts-init',
|
|
'bin/gstack-brain-restore',
|
|
'bin/gstack-session-update',
|
|
];
|
|
|
|
/** design files that talk to api.openai.com — all must use receiptedFetch. */
|
|
const DESIGN_SINKS = [
|
|
'design/src/generate.ts',
|
|
'design/src/variants.ts',
|
|
'design/src/iterate.ts',
|
|
'design/src/evolve.ts',
|
|
'design/src/check.ts',
|
|
'design/src/diff.ts',
|
|
'design/src/design-to-code.ts',
|
|
'design/src/memory.ts',
|
|
];
|
|
|
|
// ── NEW-SINK SCANNER exemptions ────────────────────────────────────────────
|
|
// Every entry carries its reason. An unexplained network op anywhere in the
|
|
// swept tree fails the scanner — add real sinks to the wired lists above,
|
|
// not here.
|
|
const SCANNER_EXEMPT: Record<string, string> = {
|
|
'bin/gstack-team-init':
|
|
'every git clone is inside an echoed instruction string (install docs); the script executes no network ops',
|
|
'bin/gstack-gbrain-install':
|
|
'user-invoked installer: bodyless HEAD reachability probe to github.com + clone of the public gbrain repo (user-directed install; no gstack state leaves the machine)',
|
|
'bin/gstack-next-version':
|
|
'fetches the user\'s own repo\'s base branch for version-claim freshness — a user-repo dev-workflow op, not gstack-state egress',
|
|
'bin/gstack-version-bump':
|
|
'git fetch appears only in an error-message string',
|
|
'bin/gstack-redact-prepush':
|
|
'git push mentions are hook documentation strings (bypass instructions)',
|
|
'browse/src/security-classifier.ts':
|
|
'HF model download: bodyless GET of a public classifier model (variable URL)',
|
|
'browse/src/write-commands.ts':
|
|
'user-directed page fetch — the browser command surface fetches what the user asked for',
|
|
'browse/src/cli.ts':
|
|
'health probe of the user\'s own pair-agent tunnel URL (reachability probe)',
|
|
'browse/src/commands.ts':
|
|
'git pull appears only in an upgrade-hint message string',
|
|
'browse/src/cookie-picker-ui.ts':
|
|
'served-page JS talking to its own loopback server (same-origin relative fetch)',
|
|
'design/src/compare.ts':
|
|
'served-page JS talking to its own loopback server (relative ./api fetch)',
|
|
// Skill prose templates: these render agent-executed instructions (the
|
|
// agent runs git in the USER\'S repo at the user\'s direction), they are
|
|
// not gstack binaries. Includes the preamble-generated brain-sync block —
|
|
// see the header.
|
|
'scripts/resolvers':
|
|
'skill prose templates — agent-executed instructions rendered into SKILL.md, not gstack binaries',
|
|
};
|
|
|
|
function isExempt(rel: string): string | undefined {
|
|
for (const [key, reason] of Object.entries(SCANNER_EXEMPT)) {
|
|
if (rel === key || rel.startsWith(`${key}/`)) return reason;
|
|
}
|
|
return undefined;
|
|
}
|
|
|
|
// Receipt markers that make a nearby network op "wired".
|
|
const RECEIPT_MARKER =
|
|
/_receipted_(curl|git|version_fetch)\b|gstack-egress-receipt["']?\s+write\b|writeReceipt\(|receiptedFetch\(/;
|
|
|
|
/** Was a receipt marker present on this line or the 30 preceding lines? */
|
|
function guarded(lines: string[], i: number): boolean {
|
|
for (let j = i; j >= Math.max(0, i - 30); j--) {
|
|
if (RECEIPT_MARKER.test(lines[j])) return true;
|
|
}
|
|
return false;
|
|
}
|
|
|
|
// git as a COMMAND followed by a remote op. Local ops (rev-parse, remote
|
|
// get-url, add, commit, merge) never match; neither does prose like
|
|
// "curated-memory-git-push" (hyphenated) or "'git fetch'" (quoted).
|
|
const GIT_REMOTE_OP = /(^|[;|&`($!]|\s)git(\s+-C\s+\S+)?\s+(push|pull|fetch|clone|ls-remote)\b/;
|
|
// git spawn-array form in TS: spawn("git", ["push", ...]).
|
|
const GIT_SPAWN_OP = /["'`]git["'`]\s*,\s*\[\s*["'`](push|pull|fetch|clone|ls-remote)/;
|
|
// curl as a command token.
|
|
const CURL_OP = /(^|[|&;(`]|\s|\$\()curl\s/;
|
|
// fetch() with an absolute http(s) URL (loopback filtered separately).
|
|
const FETCH_ABS = /(^|[^A-Za-z])fetch(Fn|Impl)?\(\s*[`'"]https?:\/\//;
|
|
|
|
function isTextFile(full: string): boolean {
|
|
try {
|
|
const buf = fs.readFileSync(full);
|
|
return !buf.subarray(0, 1024).includes(0);
|
|
} catch {
|
|
return false;
|
|
}
|
|
}
|
|
|
|
function* walk(dir: string): Generator<string> {
|
|
for (const entry of fs.readdirSync(dir, { withFileTypes: true })) {
|
|
if (entry.name === 'node_modules' || entry.name === 'dist' || entry.name.startsWith('.')) continue;
|
|
const full = path.join(dir, entry.name);
|
|
if (entry.isDirectory()) yield* walk(full);
|
|
else if (entry.isFile()) yield full;
|
|
}
|
|
}
|
|
|
|
/**
|
|
* Collect un-receipted outbound network ops in a file. Skips comments,
|
|
* loopback lines, `command -v` probes, message-emitting lines, and shell
|
|
* heredoc bodies (echoed instructions are not executed ops).
|
|
*/
|
|
function scanFile(rel: string): string[] {
|
|
const src = read(rel);
|
|
const isTs = /\.(ts|js|mjs|tsx)$/.test(rel);
|
|
const lines = src.split('\n');
|
|
const offenders: string[] = [];
|
|
let heredocEnd: string | null = null;
|
|
for (let i = 0; i < lines.length; i++) {
|
|
const line = lines[i];
|
|
if (heredocEnd !== null) {
|
|
if (line.trim() === heredocEnd) heredocEnd = null;
|
|
continue;
|
|
}
|
|
if (!isTs) {
|
|
const heredoc = line.match(/<<-?\s*['"]?([A-Za-z_][A-Za-z0-9_]*)['"]?/);
|
|
if (heredoc) heredocEnd = heredoc[1];
|
|
}
|
|
const trimmed = line.trimStart();
|
|
if (/^(#|\/\/|\*|\/\*)/.test(trimmed)) continue;
|
|
if (line.includes('127.0.0.1') || line.includes('localhost')) continue;
|
|
if (/command -v/.test(line)) continue;
|
|
if (/^(echo|printf|emit|die|fail|log)\b/.test(trimmed)) continue;
|
|
|
|
// TS: shell-style git ops only count on lines that actually execute
|
|
// something (spawn/exec markers) — template-literal prose does not.
|
|
const tsExecGit =
|
|
GIT_SPAWN_OP.test(line) ||
|
|
(GIT_REMOTE_OP.test(line) && /\b(spawn|spawnSync|exec|execSync|execFileSync|runCommand)\b/.test(line));
|
|
const isNetOp = isTs
|
|
? FETCH_ABS.test(line) || tsExecGit
|
|
: CURL_OP.test(line) || GIT_REMOTE_OP.test(line);
|
|
if (!isNetOp) continue;
|
|
if (guarded(lines, i)) continue;
|
|
offenders.push(`${rel}:${i + 1}: ${line.trim().slice(0, 100)}`);
|
|
}
|
|
return offenders;
|
|
}
|
|
|
|
describe('egress receipt wiring tripwire', () => {
|
|
test('every TS sink imports lib/egress-receipt and calls writeReceipt()', () => {
|
|
for (const rel of MODULE_SINKS) {
|
|
const src = read(rel);
|
|
expect(src.includes('egress-receipt'), `${rel}: must import lib/egress-receipt`).toBe(true);
|
|
expect(src.includes('writeReceipt('), `${rel}: must call writeReceipt() before its send`).toBe(true);
|
|
}
|
|
});
|
|
|
|
test('every shell sink sources gstack-egress-lib.sh', () => {
|
|
for (const rel of SHELL_SINKS) {
|
|
const src = read(rel);
|
|
expect(
|
|
src.includes('gstack-egress-lib.sh'),
|
|
`${rel}: must source bin/gstack-egress-lib.sh for _receipted_* helpers`,
|
|
).toBe(true);
|
|
}
|
|
});
|
|
|
|
test('every network op in a wired shell sink sits under a receipt', () => {
|
|
const offenders = SHELL_SINKS.flatMap((rel) => scanFile(rel));
|
|
expect(
|
|
offenders,
|
|
'un-receipted network call(s) — wrap in _receipted_curl/_receipted_git or write the receipt first:\n' +
|
|
offenders.join('\n'),
|
|
).toEqual([]);
|
|
});
|
|
|
|
test('browse tunnel: every ngrok.forward() has a writeReceipt in the 30 preceding lines', () => {
|
|
const lines = read('browse/src/server.ts').split('\n');
|
|
const offenders: string[] = [];
|
|
let sawForward = false;
|
|
for (let i = 0; i < lines.length; i++) {
|
|
if (!lines[i].includes('ngrok.forward(')) continue;
|
|
if (/^\s*(\/\/|\*)/.test(lines[i])) continue;
|
|
sawForward = true;
|
|
const context = lines.slice(Math.max(0, i - 30), i).join('\n');
|
|
if (!context.includes('writeReceipt(')) offenders.push(`browse/src/server.ts:${i + 1}`);
|
|
}
|
|
expect(sawForward, 'expected ngrok.forward call sites in server.ts').toBe(true);
|
|
expect(offenders, 'tunnel session opened without a receipt: ' + offenders.join(', ')).toEqual([]);
|
|
});
|
|
|
|
test('design: every api.openai.com call routes through receiptedFetch', () => {
|
|
for (const rel of DESIGN_SINKS) {
|
|
const src = read(rel);
|
|
expect(
|
|
src.includes('receipted-fetch'),
|
|
`${rel}: must import design/src/receipted-fetch`,
|
|
).toBe(true);
|
|
const lines = src.split('\n');
|
|
for (let i = 0; i < lines.length; i++) {
|
|
if (!lines[i].includes('api.openai.com')) continue;
|
|
if (/^\s*(\/\/|\*)/.test(lines[i])) continue;
|
|
if (/\bfetch(Fn|Impl)?\(/.test(lines[i])) {
|
|
throw new Error(
|
|
`${rel}:${i + 1}: raw fetch to api.openai.com — route it through receiptedFetch()`,
|
|
);
|
|
}
|
|
}
|
|
}
|
|
});
|
|
|
|
test('deprecated dead-endpoint brain consumer/reader scripts stay deleted', () => {
|
|
// lstat (not existsSync) so a dangling symlink also fails.
|
|
for (const rel of ['bin/gstack-brain-consumer', 'bin/gstack-brain-reader']) {
|
|
let present = true;
|
|
try {
|
|
fs.lstatSync(path.join(ROOT, rel));
|
|
} catch {
|
|
present = false;
|
|
}
|
|
expect(present, `${rel} was deleted (dead /ingest-repo egress sink) — do not resurrect`).toBe(false);
|
|
}
|
|
});
|
|
|
|
test('polarity table names every wired sink exactly once per polarity', () => {
|
|
const closed = Object.entries(POLARITY).filter(([, p]) => p === 'fail-closed').map(([s]) => s);
|
|
const open = Object.entries(POLARITY).filter(([, p]) => p === 'fail-open').map(([s]) => s);
|
|
expect(closed.sort()).toEqual([
|
|
'brain-sync',
|
|
'browse-tunnel (ngrok)',
|
|
'gbrain-mcp-verify',
|
|
'gbrain-sync',
|
|
'memorable-recall',
|
|
'memory-ingest',
|
|
'supabase-provision',
|
|
'telemetry-sync',
|
|
]);
|
|
expect(open.sort()).toEqual([
|
|
'community-dashboard',
|
|
'context-bill --exact',
|
|
'design-openai',
|
|
'git-class user ops (artifacts-init, brain-restore, session-update)',
|
|
'security-dashboard',
|
|
'update-check',
|
|
]);
|
|
});
|
|
|
|
test('polarity spot-checks: closed sinks refuse, open sinks warn', () => {
|
|
// telemetry-sync (closed): the wrapped POST uses the `closed` policy.
|
|
expect(read('bin/gstack-telemetry-sync')).toMatch(/_receipted_curl closed telemetry-sync/);
|
|
// brain-sync (closed): refusal exits before the commit consumes the queue.
|
|
expect(read('bin/gstack-brain-sync')).toMatch(/gstack-egress-receipt["']? write/);
|
|
// update-check (open).
|
|
expect(read('bin/gstack-update-check')).toMatch(/_receipted_curl open update-check/);
|
|
// dashboards (open).
|
|
expect(read('bin/gstack-security-dashboard')).toMatch(/_receipted_curl open security-dashboard/);
|
|
expect(read('bin/gstack-community-dashboard')).toMatch(/_receipted_curl open community-dashboard/);
|
|
// mcp-verify (closed).
|
|
expect(read('bin/gstack-gbrain-mcp-verify')).toMatch(/_receipted_curl closed gbrain-mcp-verify/);
|
|
// supabase-provision (closed): TS module — the receipt is written before
|
|
// the fetch, and a receipt failure refuses the send (fail-closed, exit 8).
|
|
const provision = read('lib/gbrain-supabase-provision.ts');
|
|
expect(provision).toMatch(/sink:\s*['"]supabase-provision['"]/);
|
|
expect(provision).toContain('fail-closed');
|
|
expect(provision.indexOf('writeReceipt(')).toBeGreaterThan(0);
|
|
expect(provision.indexOf('writeReceipt(')).toBeLessThan(provision.indexOf('ctx.fetchImpl('));
|
|
// memorable-recall (closed): the hook's receipt precedes the vendor spawn
|
|
// (marker-based: the policy lookup spawns git earlier, so plain
|
|
// `runExternal(` order would be the wrong thing to pin) and a receipt
|
|
// failure skips the vendor. The behavioural proof lives in
|
|
// test/memorable-user-prompt-hook.test.ts.
|
|
const memo = read('hosts/claude/hooks/memorable-user-prompt-hook.ts');
|
|
expect(memo).toContain('fail-closed');
|
|
expect(memo.indexOf('writeReceipt(')).toBeGreaterThan(0);
|
|
expect(memo.indexOf('writeReceipt(')).toBeLessThan(memo.indexOf('// VENDOR SPAWN'));
|
|
// design (open): the wrapper catches receipt errors and proceeds.
|
|
const rf = read('design/src/receipted-fetch.ts');
|
|
expect(rf).toContain('fail-open');
|
|
expect(rf.indexOf('writeReceipt(')).toBeLessThan(rf.indexOf('fetchImpl(url, init)'));
|
|
});
|
|
|
|
test('NEW-SINK SCANNER: every outbound network op in the tree is wired or reasoned-exempt', () => {
|
|
const SWEEP = ['bin', 'lib', 'scripts', 'design/src', 'browse/src', 'hosts'];
|
|
const offenders: string[] = [];
|
|
for (const dirRel of SWEEP) {
|
|
const dir = path.join(ROOT, dirRel);
|
|
if (!fs.existsSync(dir)) continue;
|
|
for (const full of walk(dir)) {
|
|
const rel = path.relative(ROOT, full).split(path.sep).join('/');
|
|
if (!/\.(ts|js|mjs|sh|tsx)$/.test(rel) && !isTextFile(full)) continue;
|
|
if (isExempt(rel)) continue;
|
|
offenders.push(...scanFile(rel));
|
|
}
|
|
}
|
|
expect(
|
|
offenders,
|
|
'unwired outbound network op(s). Wire each through the receipt helpers ' +
|
|
'(_receipted_curl/_receipted_git in shell, writeReceipt/receiptedFetch in TS) ' +
|
|
'or add a REASONED exemption with the honest why:\n' +
|
|
offenders.join('\n'),
|
|
).toEqual([]);
|
|
});
|
|
|
|
test('shebang tripwire: no bin/gstack-* file carries a node shebang (amendment 2A)', () => {
|
|
const offenders: string[] = [];
|
|
for (const entry of fs.readdirSync(path.join(ROOT, 'bin'))) {
|
|
if (!entry.startsWith('gstack-')) continue;
|
|
const full = path.join(ROOT, 'bin', entry);
|
|
if (!fs.lstatSync(full).isFile()) continue;
|
|
if (!isTextFile(full)) continue;
|
|
const firstLine = fs.readFileSync(full, 'utf-8').split('\n', 1)[0];
|
|
if (firstLine.startsWith('#!') && /\bnode\b/.test(firstLine)) {
|
|
offenders.push(`bin/${entry}: ${firstLine}`);
|
|
}
|
|
}
|
|
expect(offenders, 'node shebangs in bin/ (use #!/usr/bin/env bun): ' + offenders.join(', ')).toEqual([]);
|
|
});
|
|
});
|