mirror of
https://github.com/garrytan/gstack.git
synced 2026-08-21 21:47:32 +02:00
Garry TanandClaude Fable 5
f9e3fc8ab4
New free tripwire: eval:bg:gate / eval:bg:periodic --timeout must cover ceil(shards/jobs) x shard-timeout x 1.05, recomputed from the actual paid test census every run. Hand-derived numbers go stale every time a paid file lands — the review split just proved it: periodic's 28800s dropped BELOW its new 32130s worst case (raised to 32400s here). An undersized watchdog kills healthy runs and the tail reports never-started. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
69 lines
2.9 KiB
TypeScript
69 lines
2.9 KiB
TypeScript
/**
|
||
* Detach-timeout floor — free, gate-tier tripwire.
|
||
*
|
||
* The eval:bg:gate / eval:bg:periodic scripts wrap the sharded paid runner in
|
||
* bin/gstack-detach with a hard --timeout. If that number dips below the
|
||
* runner's worst-case wall clock — ceil(shards / jobs) × shard timeout — the
|
||
* watchdog kills a healthy run mid-flight and the tail shards report
|
||
* never-started: paid truncation by configuration. That nearly shipped once
|
||
* (a review pass proposed 10800s against a 19,800s gate worst case), so the
|
||
* bound is enforced here against the LIVE shard census instead of a comment
|
||
* snapshot that goes stale every time a paid test file is added.
|
||
*
|
||
* If this test fails you have two honest options: raise the --timeout in the
|
||
* package.json script it names, or reduce the tier's worst case (split fewer
|
||
* files per shard, raise DEFAULT_JOBS after verifying API rate headroom).
|
||
*/
|
||
|
||
import { describe, test, expect } from 'bun:test';
|
||
import * as fs from 'fs';
|
||
import * as path from 'path';
|
||
import {
|
||
collectPaidTestFiles,
|
||
selectPaidTestFiles,
|
||
DEFAULT_JOBS,
|
||
DEFAULT_SHARD_TIMEOUT_MS,
|
||
type PaidTier,
|
||
} from '../scripts/test-paid-shards';
|
||
|
||
const ROOT = path.resolve(import.meta.dir, '..');
|
||
// 5% margin over the theoretical bound: detach setup, lock wait, aggregation.
|
||
const MARGIN = 1.05;
|
||
|
||
function detachTimeoutSeconds(scriptName: string): number {
|
||
const pkg = JSON.parse(fs.readFileSync(path.join(ROOT, 'package.json'), 'utf-8'));
|
||
const script: string | undefined = pkg.scripts?.[scriptName];
|
||
expect(script, `package.json is missing the "${scriptName}" script`).toBeTruthy();
|
||
const m = script!.match(/--timeout\s+(\d+)/);
|
||
expect(m, `"${scriptName}" has no gstack-detach --timeout flag`).toBeTruthy();
|
||
return parseInt(m![1], 10);
|
||
}
|
||
|
||
function worstCaseSeconds(tier: PaidTier): number {
|
||
const shards = selectPaidTestFiles(collectPaidTestFiles(), tier).selected.length;
|
||
expect(shards).toBeGreaterThan(0);
|
||
return Math.ceil(shards / DEFAULT_JOBS) * (DEFAULT_SHARD_TIMEOUT_MS / 1000);
|
||
}
|
||
|
||
describe('eval:bg detach timeouts cover the sharded runner worst case', () => {
|
||
for (const [tier, script] of [
|
||
['gate', 'eval:bg:gate'],
|
||
['periodic', 'eval:bg:periodic'],
|
||
] as Array<[PaidTier, string]>) {
|
||
test(`${script} >= ceil(${tier} shards / jobs) x shard timeout x ${MARGIN}`, () => {
|
||
const floor = Math.ceil(worstCaseSeconds(tier) * MARGIN);
|
||
const configured = detachTimeoutSeconds(script);
|
||
if (configured < floor) {
|
||
throw new Error(
|
||
`${script} --timeout ${configured}s is below the ${tier} tier's worst-case ` +
|
||
`wall clock of ${floor}s (ceil(shards/${DEFAULT_JOBS} jobs) x ` +
|
||
`${DEFAULT_SHARD_TIMEOUT_MS / 1000}s shard timeout x ${MARGIN} margin). ` +
|
||
`An undersized detach watchdog kills healthy runs mid-flight and the tail ` +
|
||
`shards report never-started. Raise the --timeout in package.json or reduce ` +
|
||
`the tier's worst case.`,
|
||
);
|
||
}
|
||
});
|
||
}
|
||
});
|