mirror of
https://github.com/garrytan/gstack.git
synced 2026-11-02 15:04:37 +01:00
garrytanandcapy-ai[bot]
da65a356cf
The checklist bound severity to its passes (Pass 1 CRITICAL, Pass 2 INFORMATIONAL) and the core floor had no security clause, so GSTA-11's replay saw real bugs filed INFORMATIONAL. One floor sentence now reaches every reviewer prompt; the passes set check order only; shell injection covers shell sinks; a state-swap-before-failure check joins Pass 1 (GSTA-159); the Testing specialist reports a floor-level product defect as category correctness so classify keeps it blocking. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
27 lines
1.7 KiB
TypeScript
27 lines
1.7 KiB
TypeScript
/**
|
|
* Fix-check prompt (docs/review-policy.md#transitions): the one reviewer /ship dispatches after a
|
|
* step whose fixes do not earn a full pass. It reads the fixes, never the whole diff. The parent
|
|
* writes every input in literally: a reviewer never sees the parent's shell.
|
|
*/
|
|
import { BLOCKING_FLOOR } from './review-floor';
|
|
|
|
export interface FixCheckInput { fixList: string; touchedHunks: string; callers: string; testResults: string }
|
|
|
|
export const FIX_CHECK_INSTRUCTIONS = `You are the fix-check reviewer for a pre-landing review. An earlier review pass found
|
|
findings and the author fixed them. You check only those fixes: the fix list, the hunks the fixes
|
|
touched, the callers of every symbol the fixes changed, and the test results after the fixes.
|
|
|
|
Find any defect a fix introduced or left in place: a caller the change breaks, a guard that now
|
|
fails open (accepts what it refused) or fails closed (refuses what it accepted), a regression of
|
|
behaviour the code had before the fix, an error or unreadable state now read as success, a test
|
|
made weaker. Name the input or call site that reaches each defect.
|
|
|
|
Rate each finding against the blocking floor. ${BLOCKING_FLOOR} Output one JSON object per
|
|
line, {"severity":"CRITICAL|INFORMATIONAL","path":"<file>","line":<n>,"summary":"<what breaks, for which input>"},
|
|
or the two words NO FINDINGS when the fixes are sound.`;
|
|
|
|
export function renderFixCheckPrompt(i: FixCheckInput): string {
|
|
return [FIX_CHECK_INSTRUCTIONS, '', '## Fix list', i.fixList.trim(), '', '## Touched hunks', '```diff', i.touchedHunks.trim(), '```', '',
|
|
'## Callers of changed symbols', i.callers.trim() || '(none found)', '', '## Test results after the fixes', i.testResults.trim()].join('\n') + '\n';
|
|
}
|