mirror of
https://github.com/garrytan/gstack.git
synced 2026-10-03 01:46:55 +02:00
* refactor(resolvers): split review.ts into MECE resolver modules (pure move) Move every function from scripts/resolvers/review.ts, unchanged, into: - review-dashboard.ts: review dashboard, plan-file review report - plan-gates.ts: approval check, exit-plan-mode gate, plan-file discovery, plan-completion audit/gate (ship + review), plan verification exec - spec-review.ts: both spec review loops, benefits-from, anti-shortcut clause - outside-voice-steps.ts: Codex second opinion, adversarial step, Codex plan review, Codex doc review, disabled-outside record - review-scope.ts: scope drift, cross-review dedup, shared-code reuse review.ts is deleted; index.ts imports the new modules. gen-skill-docs output is byte-identical for every host (--host all). Test imports and source-path references are re-pointed; the two source-text report/gate tests in gen-skill-docs.test.ts become behavioral renders across every consuming skill and host. All 46 touchfile entries that named review.ts now name all five modules, guarded by a recorded selection golden. * test(browse): black-box auth matrix for every server route and both surfaces Drives buildFetchHandler fetchLocal/fetchTunnel with no token, wrong token, root token, scoped token and the SSE cookie for all 33 routes, plus unmatched paths and wrong methods. Denials assert today's exact status, body and content type; allowed credentials assert the handler was reached. Written against the unchanged if-chain server so the W3 route-table refactor must keep it green. * refactor(shard-engine): move scripts/test-strict-output.ts to scripts/lib/shard-engine.ts The shared shard engine grows from the existing strict-output module (runShardChild, killProcessGroup, signal forwarding, strict classifier). scripts/test-strict-output.ts stays as a re-export so existing importers, mock.module paths and the strict-output/run-shard-child tests are unchanged. The engine inherits the global touchfile entry; the free runner's CLI-routing fixture copies the new module. * refactor(resolvers): decompose the three >150-line review resolvers (output-neutral) Split generateAdversarialStep, generateCodexPlanReview and generatePlanCompletionAuditInner into per-section helpers whose template literals are copied verbatim, so every function in the new modules is at or under 150 lines. gen-skill-docs output is byte-identical for every host (--host all, compared against96764e80with a fixed --link-root). * refactor(resolvers): one outside-voice failure policy (deliberate prose unification) outsideVoiceFailurePolicy(ctx, opts) in outside-voice.ts now renders the auth / timeout / empty-response bullets for all four call sites that hand-typed them (Codex second opinion, adversarial step, Codex plan review, design outside voices). Options are explicit per site (timeoutMinutes, onTimeout, stderrOnEmpty, fallback, escape) with no defaults. Deliberate generated-prose changes (every host): - office-hours: 'Fall back to <native> subagent.' becomes 'Fall back to the <native> subagent below.' - plan-devex-review: the plain 'Auth failure (stderr contains ...)' bullets become the canonical bold bullets; auth also triggers on 'API key'; 'auth failed' becomes 'authentication failed'. - review/ship adversarial: 'exceeded 9 minutes and was terminated' becomes 'timed out after 9 minutes and was terminated'; the timeout is still MISSING COVERAGE. - design outside voices: unchanged. Adds ratchet (d) (test/outside-voice-failure-policy.test.ts) with a reasoned allowlist for /codex's own CLI errors, the MISSING COVERAGE retention test, refreshed codex/factory ship goldens, and outside-voice.ts in every touchfile entry of review.ts and design.ts (selection golden extended). * test(pty): fake PTY session driver with an injectable clock through the runner launch seam The three plan-skill runners take an optional PtyDriver (launch, now, monotonic, sleep); omitted, they use the real launcher and clocks exactly as before. test/helpers/pty/fake-session.ts feeds scripted frames through that seam, and claude-pty-runner.runners.unit.test.ts runs observation, counting and floor for success, deadline timeout, permission prompt and plan-ready outcomes with no CLI or real timers. These cases must stay green unchanged through the W4 split and the runPtySession extraction. Touchfiles: every entry that lists claude-pty-runner.ts or pty-screen.ts now also lists test/helpers/pty/**. * refactor(shard-engine): run both lanes on the shared engine; lane policy injected Engine (scripts/lib/shard-engine.ts) gains the W2 primitives: per-shard tmp/Chromium sandbox + async cleanup backstop, log-path allocation and full-stream log capture, one duration-seed reader/writer with a lane predicate, LanePolicy (seed predicate + zero-execution verdict), strictShardStatus, and the shared CLI flag loop. runShardChild takes an optional companion (signal/settle) and waits a bounded 250ms to reap a wall-killed child. Free lane stops spawning shards itself: runFreeShard uses runShardChild with trackShardBrowser as the companion (win32 path unchanged: no process group, no negative-pid kill). Its sync state-dir removal stays lane policy. Paid lane uses the sandbox, log, seed, verdict and flag primitives; the hollow-shard guard applies PAID_LANE_POLICY. Lane outcomes are unchanged (free keeps >= 0 seeds and file-count zero-exec rule; paid keeps > 0 seeds, warning under selection and passed-empty under EVALS_ALL). paid-free-boundary's closure assertion now names the engine module, where the strict classifier lives. * test(shard-engine): engine unit tests, fixture-corpus equivalence, per-lane CLI parity - test/shard-engine.test.ts: failing/unhandled/module-load output fails both lanes, per-lane zero-execution and seed rules, whole-group kill on a wall timeout (both lanes), mocked-win32 path with no negative-pid kill, companion settle order, log capture, sandbox isolation, flag loop. - test/shard-engine-equivalence.test.ts + test/fixtures/shard-equivalence: seven outcome fixtures plus one real shard, run through both lanes and compared with classifications recorded from the base runners (96764e80). - test/shard-cli-parity.test.ts + test/fixtures/shard-cli-parity: flag set, defaults, validation errors and the Unknown argument error per lane match the base runners. * refactor(shard-engine): decompose runFreeShard and runPaidShard to <= 150 lines Output-neutral extraction under the fixture-corpus equivalence and runner tests: captureFreeStream, explainFreeVerdict and logFreeRecovery (free); paidShardCommand, settleShardSpool, settleBootstrapRetention and printLogTail (paid). The bootstrap scope-creation block that bootstrap-retention.test.ts evaluates stays verbatim. * refactor(pty): split claude-pty-runner.ts into test/helpers/pty/* behind a barrel Pure move: every line of the former 5,047-line runner lands verbatim in one module (four private helpers gain `export` for cross-module use): binary, screen (absorbs test/helpers/pty-screen.ts, which now re-exports it), launch, session (PtyDriver), judge, classify, auq, plan-native, boundaries, runners/{observation,counting,floor}. claude-pty-runner.ts re-exports the original public surface by name; pty/ modules import siblings directly. Tests that read the runner's source text: - rewritten as behavioral: the unit test's model-pin tripwire (fake CLI argv: fallback chain, --model before extraArgs, hermetic --strict-mcp-config), pty-skill-seeding-wiring (runners through the fake driver; launcher through a fake CLI reporting CLAUDE_CONFIG_DIR). The "three wrappers forward model" grep is replaced by the runners' fake-driver launch assertions. - pty-screen-session / pty-screen-supervision: stop copying runner source; they mock.module the real pty/screen.ts (and the fixture cleanup) instead. - re-pointed to the owning module (they execute a sliced runner body with injected boundaries; no seam exists for those boundaries yet): eng-seeded-completion-ai, plan-floor-permission, plan-create-prepublication, plan-count-completion; hermetic-wiring's source guard now reads pty/launch.ts and scans every pty/ module for raw process.env spreads. - plan-count-timeout and pty-output-wake mock the viewport at pty/screen.ts. * test(ratchet-c): enforcing module/function size ratchet and moved-code touchfile coverage Ratchet (c) ships enforcing: test/helpers/module-size.ts counts file and top-level function lengths by brace matching over masked source (strings, comments, regex literals and template text masked; ${} expressions kept), covering function declarations, arrow functions assigned to consts and route-table handler properties, with no parser dependency. Its self-test uses template literals and code-fence braces copied from scripts/resolvers/review.ts and design.ts. test/fixtures/module-size-ratchet.json binds scripts/lib/shard-engine.ts (<= 800 lines, <= 150 per function) and records the residual runner sizes (free 2352, paid 1921) as non-growth caps; allowlist entries are keyed on file plus matched text and need a reason. Failure output lists file:line, the rule, Fix: and the allowlist path. touchfiles.test.ts gains the moved-code superset check over test/fixtures/touchfile-move-goldens/ (W2 golden recorded at96764e80: test-strict-output.ts and test-paid-shards.ts global, test-free-shards.ts none). * refactor(browse): declared route table replaces the buildFetchHandler if-chain The ~1,300-line if-chain in buildFetchHandler becomes a route table: each entry declares method, path, auth kind and surfaces, and one auth gate in browse/src/routes/table.ts returns the per-kind denial (root-bearer, scoped, root-or-sse-cookie: 401 Unauthorized; root-token: 403 Root token required; extension-origin: 403 Forbidden). Unmatched requests take the declared fallthrough (root-bearer check, then plain-text 404). Handlers move to browse/src/routes/{core,pairing,pty,tokens,tunnel,activity,commands,files, inspector}.ts and receive a RouteContext with auth checks as functions instead of closing over factory locals. Dispatch order is unchanged: tunnel filter, beforeRoute overlay, gate, handler. TUNNEL_PATHS stays a literal in server.ts. Behavior-preserving: the black-box auth matrix from the previous commit passes unchanged. /memory and /inspector/events are declared root-bearer because the blanket check always ran before their SSE-cookie branch. Source-text route tests are rewritten as behavioral tests through buildFetchHandler or a route's real handler with a stub RouteContext (browse/test/route-test-harness.ts). Checks with no runtime seam are re-pointed to the route modules: Surface type, /inspector/events SSE helper, sanitizeReplacer imports, /pty-inject-scan sidecar-client import, and the ngrok config lookup and startTunnel wiring that stay in server.ts. * test(browse): stubbed-handler auth matrix and route inventory for the route table Every ROUTES entry runs through the real dispatcher and gate with stub handlers on each declared surface and six credentials; denials assert the exact status and body each auth kind returned at96764e8, admitted credentials assert the handler ran (with the gate's TokenInfo for scoped routes). Also pins the reviewed route inventory (method, path, auth kind, surfaces), that every entry declares auth and surfaces, that the table's tunnel paths equal the TUNNEL_PATHS literal with GET /connect admitted, the unmatched fallthrough, and that the root token is rejected on every tunnel route through buildFetchHandler. * test(browse): ratchet (b) keeps route dispatch inside the route table Scans browse/src/server.ts and browse/src/routes/*.ts for pathname comparisons; only the table matcher and the tunnel-surface filter are allowed, listed with reasons in browse/test/fixtures/route-dispatch-allowlist.json (keyed on file plus line text). Also checks every entry declares auth and surfaces and that gstack registers no beforeRoute overlay itself. Self-tests plant a violation and assert the file:line, Fix: and allowlist path in the message, that a shifted line stays allowlisted, and that a reasonless entry is rejected. * test: touchfile superset check for modules moved out of browse/src/server.ts Records the paid evals selected by touching browse/src/server.ts at96764e80(17 E2E, 1 LLM judge) and asserts every browse/src/routes/*.ts module selects a superset. The test reads every golden in test/fixtures/moved-module-selection/ so other moved-code goldens can sit beside it. * test(shard-engine): give non-timeout corpus fixtures CI headroom; keep the POSIX golden off the Windows lane Only the wall-timeout fixture keeps a 3s wall; the rest get 60s so a loaded host cannot turn a pass into a timeout. Base and branch runners still agree on every classification under the new walls. The Windows exclusion entry moves the free runner's ratchet (c) residual cap to 2356 lines. * refactor(pty): one runPtySession loop drives observation, counting and floor test/helpers/pty/session.ts owns launch -> start -> (poll -> tick)* -> timeout and the failure contract the three runners each hand-rolled: the run's own error wins over capture and close errors, close always runs, owned fixture cleanup runs last (also when launch fails). Each runner now supplies a PtySessionPlan: its boot/command step, poll cadence (2s observation/floor sleep; counting's output wake + 250ms coalesce), tick policy (permission handling, native identity, terminal rules stay per runner because they differ) and capture hooks. The runner bodies are decomposed into top-level steps so no function exceeds 150 lines; behavior is unchanged and the fake-driver cases from the first W4 commit pass unmodified. The counting capture step and the native completion-summary predicate are now named functions (countingCapture, isNativeCompletionSummary), so plan-create-prepublication and plan-count-completion call them directly instead of executing sliced source. The two harnesses that still execute a sliced runner body with injected boundaries (eng-seeded-completion-ai, plan-floor-permission) pass the PtyDriver seam instead of overriding Date/Bun.sleep. * test(ratchet-c): register route modules, review resolver modules and server.ts residual cap * refactor(pty): decompose launchClaudePty and engNumberedFindingAUQ under 150 lines launchClaudePty (349 lines) becomes launch preparation (args, hermetic child env, owned state roots), recorder creation, spawn, the trust-dialog watcher, close, and the session handle over one PtyProcess state object. The failure order is unchanged: abort the viewport, dispose any recorders created so far, dispose the viewport, rethrow. The --model / --strict-mcp-config ordering and seedSkills wiring stay pinned by the behavioral fake-CLI tests. engNumberedFindingAUQ (345 lines) keeps its guards and dispatch; each self-contained issue family (declared cache, library retry hooks, cache owner, injected singleton, shared writers, injected export) moves verbatim into its own function. Every pty/ module is now <= 800 lines and every top-level function <= 150 lines. * test(pty): split claude-pty-runner.unit.test.ts along the pty/ module seams The 188 unit tests move verbatim into claude-pty-runner.{screen,classify, auq,launch,plan-native,boundaries}.unit.test.ts (test names unchanged; each file imports only what it uses from the barrel). The five files that no longer read a SKILL.md template join the test-of-test ratchet baseline with a reason. * test(touchfiles): moved PTY modules keep their paid-eval selection test/fixtures/touchfile-selection/w4-pty.json records, at96764e8, the paid evals selected by touching test/helpers/claude-pty-runner.ts (20) and test/helpers/pty-screen.ts (20). touchfiles.test.ts now asserts every .ts file under test/helpers/pty/ (and pty/screen.ts for both sources) selects a superset, reading every golden in that directory so later moves can add one; a planted-violation case pins the report and its Fix line. * fix(browse): unexchanged pair setup keys no longer authenticate bearer requests validateToken accepted a gsk_setup_ key as a bearer on /command, /batch and /file (found while building the W3 auth matrix). A setup key now only authenticates the /connect exchange. * W1: one state-root owner (lib/state-root.ts + bin/gstack-state-root.sh), gstack-paths --explain and fail-stop, parity tests * W1: guarded migration of every executable state-root site; uninstall deletes only ~/.gstack Bins, careful/freeze hooks, setup, upgrade migrations, browse/src, design, ios-qa daemon, lib and scripts resolve the state root through bin/gstack-state-root.sh (bash) or lib/state-root.ts (TS). Bins source the twin and stop with a reinstall message when it is missing; hooks source it and never spawn gstack-paths. browse/src/config.ts and lib/cso/state.ts delegate to resolveStateRoot. Analytics writers and readers move together so the usage log stays one file. gstack-uninstall deletes state only at ~/.gstack, refuses (exit 2) when it resolves to /, $HOME or an ancestor, the checkout or the git root, and leaves any other resolved root in place with the removal command. Fixtures that copy single bins now copy the twin. * W1: privacy keys and trust-policy deny tiers merge across state roots; gstack-config reporting; test hermeticity readConfigKey / gstack_read_config_key return the most restrictive telemetry, memorable_recall, codex_reviews and update_check across the resolved root and ~/.gstack; other keys read the resolved root only. gstack-config set reports an overriding root with the exact override command, list shows the winning root and a root-variable disagreement line. gstack-gbrain-repo-policy get merges deny/read-only tiers. gstack-egress reads through readConfigKey. test-setup.ts strips inherited GSTACK_STATE_ROOT/GSTACK_STATE_DIR and redirects the legacy root. * W1: shared hook logging helper (hosts/claude/hooks/hook-log.ts) One hook-errors.log writer: root from resolveStateRoot, 0600 on every append, opt-in rate limit used only by memorable-user-prompt. The five hooks route through it. * W1: docs/state-root.md and README troubleshooting pointer Precedence table, a real --explain example, the move-your-state recipe, merged privacy keys, the uninstall rule, the resolver-failure fix, and the plugin-mode note (evidence gate: no official plugin distribution). * W1b: template and resolver prose resolve state through guarded gstack-paths; ratchet (a) Every gstack-paths eval in templates and resolvers carries the fail-stop guard; executable ~/.gstack paths in bash blocks (context recovery preamble, eureka log, analytics, project artifacts, upgrade snooze, setup-gbrain lock, retro snapshots, ship consent marker) use $GSTACK_STATE_ROOT, and the writer prose that pairs with them points at the printed PROJECT_DIR / RETRO_FILE. ship drops export GSTACK_STATE_ROOT. SKILL.md regenerated (claude + codex), ship goldens re-pinned, parity and context-budget caps raised to the measured sizes with notes. test/state-root-ratchet.test.ts enforces the rule with a reasoned allowlist; W1 touchfile entries plus a superset golden. * refactor: apply W1 state-root edits in W2/W3/W5-owned files; one moved-code touchfile golden for all workstreams * test: fold the moved-code touchfile golden into touchfiles.test.ts; fix integration fixture closure and caps * v1.91.11.0: CHANGELOG, TODOS, docs and conventions for the refactor wave * test: re-measure plan-ceo/design-consultation caps and ship goldens after the guarded plan-discovery and spec-review blocks; add the state-root twin to the workflow-boundaries fixture * fix(windows): migrations resolve their directory with either path separator; state-root parity compares under the HOME Git Bash actually sees * fix(review,ship): state plan-check timing after smoke expiry and test_stub Skip semantics (review workflow judge clarity) * test(qa-eval): webhook fix eval asks for the fix loop's post-repair probes; eight-scenario coverage stays in the report-only case and the harness recheck * test(qa-eval): re-pin the webhook prompt contract to the fix-loop stage; R29 coverage omissions stay bound by the report-only case * fix(review,ship): plan checks publish a checkpoint before each probe; only the smoke expiry stop is skipped * fix(qa): carry #2999's checkpoint receipt link, report-template line and full-revision placeholder (identical hunks) * test(qa-callers): disable git auto maintenance in the caller fixture Git 2.47+ runs auto maintenance detached after commit; on the CI runner's git 2.55 it rewrote .git/objects fan-out directories while the write observer was running, which surfaced as unauthorized mutations. Same gc.auto=0 / maintenance.auto=false guard the shared-libs fixture already uses. * test(plan-mode-no-op): require prose evidence for the prose-fallback members so a spinner-frame judge verdict cannot end the run as asked * test(ship-docsync): carry #2999's seeded-attempt docsync harness (identical files) The doc-sync fault cases replayed attempt 1 before reaching their gate and ran out of their 285s budget. The fixture now seeds attempt 1 and the parent starts at the gate under test. Taken byte-identical from origin/capy/audit-fix-wave (fb526898,e6ac813d,6ce10ff7,d0c53577,77cce3be). Local: stale-before, recovery and late-result 6/6 PASS (97-164s); the whole file 12/12 PASS.
464 lines
19 KiB
Cheetah
464 lines
19 KiB
Cheetah
---
|
|
name: design-html
|
|
preamble-tier: 2
|
|
version: 1.0.0
|
|
description: |
|
|
Design finalization: generates production-quality Pretext-native HTML/CSS.
|
|
Works with approved mockups from /design-shotgun, CEO plans from /plan-ceo-review,
|
|
design review context from /plan-design-review, or from scratch with a user
|
|
description. Text actually reflows, heights are computed, layouts are dynamic.
|
|
30KB overhead, zero deps. Smart API routing: picks the right Pretext patterns
|
|
for each design type. Use when: "finalize this design", "turn this into HTML",
|
|
"build me a page", "implement this design", or after any planning skill.
|
|
Proactively suggest when user has approved a design or has a plan ready. (gstack)
|
|
voice-triggers:
|
|
- "build the design"
|
|
- "code the mockup"
|
|
- "make it real"
|
|
triggers:
|
|
- build the design
|
|
- code the mockup
|
|
- make design real
|
|
allowed-tools:
|
|
- Bash
|
|
- Read
|
|
- Write
|
|
- Edit
|
|
- Glob
|
|
- Grep
|
|
- Agent
|
|
- AskUserQuestion
|
|
---
|
|
|
|
{{PREAMBLE}}
|
|
|
|
# /design-html: Pretext-Native HTML Engine
|
|
|
|
You generate production-quality HTML where text actually works correctly. Not CSS
|
|
approximations. Computed layout via Pretext. Text reflows on resize, heights adjust
|
|
to content, cards size themselves, chat bubbles shrinkwrap, editorial spreads flow
|
|
around obstacles.
|
|
|
|
---
|
|
|
|
{{SECTION_INDEX:design-html}}
|
|
|
|
---
|
|
|
|
{{DESIGN_SETUP}}
|
|
|
|
{{DESIGN_DETECTOR}}
|
|
|
|
{{SECTION:doctrine}}
|
|
|
|
---
|
|
|
|
## Step 0: Input Detection
|
|
|
|
Detect context with the CEO-plan check and the design-artifact checks below:
|
|
|
|
```bash
|
|
eval "$(~/.claude/skills/gstack/bin/gstack-slug 2>/dev/null)"
|
|
eval "$(~/.claude/skills/gstack/bin/gstack-paths)"; : "${GSTACK_STATE_ROOT:?gstack-paths failed; reinstall with ./setup or /gstack-upgrade}"
|
|
setopt +o nomatch 2>/dev/null || true
|
|
_CEO=$(ls -t "$GSTACK_STATE_ROOT/projects/$SLUG/ceo-plans/"*.md 2>/dev/null | head -1)
|
|
[ -n "$_CEO" ] && echo "CEO_PLAN: $_CEO" || echo "NO_CEO_PLAN"
|
|
```
|
|
|
|
```bash
|
|
eval "$(~/.claude/skills/gstack/bin/gstack-slug 2>/dev/null)"
|
|
eval "$(~/.claude/skills/gstack/bin/gstack-paths)"; : "${GSTACK_STATE_ROOT:?gstack-paths failed; reinstall with ./setup or /gstack-upgrade}"
|
|
setopt +o nomatch 2>/dev/null || true
|
|
_APPROVED=$(ls -t "$GSTACK_STATE_ROOT/projects/$SLUG/designs/"*/approved.json 2>/dev/null | head -1)
|
|
[ -n "$_APPROVED" ] && echo "APPROVED: $_APPROVED" || echo "NO_APPROVED"
|
|
_VARIANTS=$(ls -t "$GSTACK_STATE_ROOT/projects/$SLUG/designs/"*/variant-*.png 2>/dev/null | head -1)
|
|
[ -n "$_VARIANTS" ] && echo "VARIANTS: $_VARIANTS" || echo "NO_VARIANTS"
|
|
_FINALIZED=$(ls -t "$GSTACK_STATE_ROOT/projects/$SLUG/designs/"*/finalized.html 2>/dev/null | head -1)
|
|
[ -n "$_FINALIZED" ] && echo "FINALIZED: $_FINALIZED" || echo "NO_FINALIZED"
|
|
[ -f DESIGN.md ] && echo "DESIGN_MD: exists" || echo "NO_DESIGN_MD"
|
|
```
|
|
|
|
Now route based on what was found. Check these cases in order:
|
|
|
|
### Case A: approved.json exists (design-shotgun ran)
|
|
|
|
If `APPROVED` was found, read it. Extract: approved variant PNG path, user feedback,
|
|
screen name. Also read the CEO plan if one exists (it adds strategic context).
|
|
|
|
Read `DESIGN.md` if it exists in the repo root. These tokens take priority for
|
|
system-level values (fonts, brand colors, spacing scale).
|
|
|
|
Then check for prior finalized.html. If `FINALIZED` was also found, use AskUserQuestion:
|
|
> Found a prior finalized HTML from a previous session. Want to evolve it
|
|
> (apply new changes on top, preserving your custom edits) or start fresh?
|
|
> A) Evolve — iterate on the existing HTML
|
|
> B) Start fresh — regenerate from the approved mockup
|
|
|
|
If evolve: read the existing HTML. Apply changes on top during Step 3.
|
|
If fresh or no finalized.html: proceed to Step 1 with the approved PNG as the
|
|
visual reference.
|
|
|
|
### Case B: CEO plan and/or design variants exist, but no approved.json
|
|
|
|
If `CEO_PLAN` or `VARIANTS` was found but no `APPROVED`:
|
|
|
|
Read whichever context exists:
|
|
- If CEO plan found: read it and summarize the product vision and design requirements.
|
|
- If variant PNGs found: show them inline using the Read tool.
|
|
- If DESIGN.md found: read it for design tokens and constraints.
|
|
|
|
Use AskUserQuestion:
|
|
> Found [CEO plan from /plan-ceo-review | design review variants from /plan-design-review | both]
|
|
> but no approved design mockup.
|
|
> A) Run /design-shotgun — explore design variants based on the existing plan context
|
|
> B) Skip mockups — I'll design the HTML directly from the plan context
|
|
> C) I have a PNG — let me provide the path
|
|
|
|
If A: tell the user to run /design-shotgun, then come back to /design-html.
|
|
If B: proceed to Step 1 in "plan-driven mode." There is no approved PNG, the plan is
|
|
the source of truth. Ask the user for a screen name to use for the output directory
|
|
(e.g., "landing-page", "dashboard", "pricing").
|
|
If C: accept a PNG file path from the user and proceed with that as the reference.
|
|
|
|
### Case C: Nothing found (clean slate)
|
|
|
|
If none of the above produced any context:
|
|
|
|
Use AskUserQuestion:
|
|
> No design context found for this project. How do you want to start?
|
|
> A) Run /plan-ceo-review first — think through the product strategy before designing
|
|
> B) Run /plan-design-review first — design review with visual mockups
|
|
> C) Run /design-shotgun — jump straight to visual design exploration
|
|
> D) Just describe it — tell me what you want and I'll design the HTML live
|
|
|
|
If A, B, or C: tell the user to run that skill, then come back to /design-html.
|
|
If D: proceed to Step 1 in "freeform mode." Ask the user for a screen name.
|
|
|
|
### Context summary
|
|
|
|
After routing, output a brief context summary:
|
|
- **Mode:** approved-mockup | plan-driven | freeform | evolve
|
|
- **Visual reference:** path to approved PNG, or "none (plan-driven)" or "none (freeform)"
|
|
- **CEO plan:** path or "none"
|
|
- **Design tokens:** "DESIGN.md" or "none"
|
|
- **Screen name:** from approved.json, user-provided, or inferred from CEO plan
|
|
|
|
---
|
|
|
|
## Step 1: Design Analysis
|
|
|
|
1. If `$D` is available (`DESIGN_READY`), extract a structured implementation spec:
|
|
```bash
|
|
$D prompt --image <approved-variant.png> --output json
|
|
```
|
|
This returns colors, typography, layout structure, and component inventory via GPT-4o vision.
|
|
|
|
2. If `$D` is not available, read the approved PNG inline using the Read tool.
|
|
Describe the visual layout, colors, typography, and component structure yourself.
|
|
|
|
3. If in plan-driven or freeform mode (no approved PNG), design from context:
|
|
- **Plan-driven:** read the CEO plan and/or design review notes. Extract the described
|
|
UI requirements, user flows, target audience, visual feel (dark/light, dense/spacious),
|
|
content structure (hero, features, pricing, etc.), and design constraints. Build an
|
|
implementation spec from the plan's prose rather than a visual reference.
|
|
- **Freeform:** use AskUserQuestion to gather what the user wants to build. Ask about:
|
|
purpose/audience, visual feel (dark/light, playful/serious, dense/spacious),
|
|
content structure (hero, features, pricing, etc.), and any reference sites they like.
|
|
In both cases, describe the intended visual layout, colors, typography, and
|
|
component structure as your implementation spec. Generate realistic content based
|
|
on the plan or user description (never lorem ipsum).
|
|
|
|
4. Read `DESIGN.md` tokens. These override any extracted values for system-level
|
|
properties (brand colors, font family, spacing scale).
|
|
|
|
5. Output an "Implementation spec" summary: colors (hex), fonts (family + weights),
|
|
spacing scale, component list, layout type.
|
|
|
|
---
|
|
|
|
## Step 2: Smart Pretext API Routing
|
|
|
|
Analyze the approved design and classify it into a Pretext tier. Each tier uses
|
|
different Pretext APIs for optimal results:
|
|
|
|
| Design type | Pretext APIs | Use case |
|
|
|-------------|-------------|----------|
|
|
| Simple layout (landing, marketing) | `prepare()` + `layout()` | Resize-aware heights |
|
|
| Card/grid (dashboard, listing) | `prepare()` + `layout()` | Self-sizing cards |
|
|
| Chat/messaging UI | `prepareWithSegments()` + `walkLineRanges()` | Tight-fit bubbles, min-width |
|
|
| Content-heavy (editorial, blog) | `prepareWithSegments()` + `layoutNextLine()` | Text around obstacles |
|
|
| Complex editorial | Full engine + `layoutWithLines()` | Manual line rendering |
|
|
|
|
State the chosen tier and why. Reference the specific Pretext APIs that will be used.
|
|
|
|
---
|
|
|
|
## Step 2.5: Framework Detection
|
|
|
|
Check if the user's project uses a frontend framework:
|
|
|
|
```bash
|
|
[ -f package.json ] && cat package.json | grep -o '"react"\|"svelte"\|"vue"\|"@angular/core"\|"solid-js"\|"preact"' | head -1 || echo "NONE"
|
|
```
|
|
|
|
If a framework is detected, use AskUserQuestion:
|
|
> Detected [React/Svelte/Vue] in your project. What format should the output be?
|
|
> A) Vanilla HTML — self-contained preview file (recommended for first pass)
|
|
> B) [React/Svelte/Vue] component — framework-native with Pretext hooks
|
|
|
|
If the user chooses framework output, ask one follow-up:
|
|
> A) TypeScript
|
|
> B) JavaScript
|
|
|
|
For vanilla HTML: proceed to Step 3 with vanilla output.
|
|
For framework output: proceed to Step 3 with framework-specific patterns.
|
|
If no framework detected: default to vanilla HTML, no question needed.
|
|
|
|
---
|
|
|
|
## Step 3: Generate Pretext-Native HTML
|
|
|
|
{{SECTION:pretext-patterns}}
|
|
|
|
### Pretext Source Embedding
|
|
|
|
For **vanilla HTML output**, check for the vendored Pretext bundle:
|
|
```bash
|
|
_PRETEXT_VENDOR=""
|
|
_ROOT=$(git rev-parse --show-toplevel 2>/dev/null)
|
|
[ -n "$_ROOT" ] && [ -f "$_ROOT/.claude/skills/gstack/design-html/vendor/pretext.js" ] && _PRETEXT_VENDOR="$_ROOT/.claude/skills/gstack/design-html/vendor/pretext.js"
|
|
[ -z "$_PRETEXT_VENDOR" ] && [ -f ~/.claude/skills/gstack/design-html/vendor/pretext.js ] && _PRETEXT_VENDOR=~/.claude/skills/gstack/design-html/vendor/pretext.js
|
|
[ -n "$_PRETEXT_VENDOR" ] && echo "VENDOR: $_PRETEXT_VENDOR" || echo "VENDOR_MISSING"
|
|
```
|
|
|
|
- If `VENDOR` found: read the file and inline it in a `<script>` tag. The HTML file
|
|
is fully self-contained with zero network dependencies.
|
|
- If `VENDOR_MISSING`: use CDN import as fallback:
|
|
`<script type="module">import { prepare, layout, prepareWithSegments, walkLineRanges, layoutNextLine, layoutWithLines } from 'https://esm.sh/@chenglou/pretext'</script>`
|
|
Add a comment: `<!-- FALLBACK: vendor/pretext.js missing, using CDN -->`
|
|
|
|
For **framework output**, add to the project's dependencies instead:
|
|
```bash
|
|
# Detect package manager
|
|
[ -f bun.lockb ] && echo "bun add @chenglou/pretext" || \
|
|
[ -f pnpm-lock.yaml ] && echo "pnpm add @chenglou/pretext" || \
|
|
[ -f yarn.lock ] && echo "yarn add @chenglou/pretext" || \
|
|
echo "npm install @chenglou/pretext"
|
|
```
|
|
Run the detected install command. Then use standard imports in the component.
|
|
|
|
### HTML Generation
|
|
|
|
Write a single file using the Write tool. Save to:
|
|
`$GSTACK_STATE_ROOT/projects/$SLUG/designs/<screen-name>-YYYYMMDD/finalized.html`
|
|
|
|
For framework output, save to:
|
|
`$GSTACK_STATE_ROOT/projects/$SLUG/designs/<screen-name>-YYYYMMDD/finalized.[tsx|svelte|vue]`
|
|
|
|
**Always include in vanilla HTML:**
|
|
- Pretext source (inlined or CDN, see above)
|
|
- CSS custom properties for design tokens from DESIGN.md / Step 1 extraction
|
|
- Fonts from the source DESIGN.md names (Google Fonts, Fontshare, or self-hosted) via `<link>` tags + `document.fonts.ready` gate before first `prepare()`
|
|
- Semantic HTML5 (`<header>`, `<nav>`, `<main>`, `<section>`, `<footer>`)
|
|
- Responsive behavior via Pretext relayout (not just media queries)
|
|
- Breakpoint-specific adjustments at 375px, 768px, 1024px, 1440px
|
|
- ARIA attributes, heading hierarchy, focus-visible states
|
|
- `contenteditable` on text elements + MutationObserver to re-prepare + re-layout on edit
|
|
- ResizeObserver on containers to re-layout on resize
|
|
- `prefers-color-scheme` media query for dark mode
|
|
- `prefers-reduced-motion` for animation respect
|
|
- Real content extracted from the mockup (never lorem ipsum)
|
|
|
|
**Never include by default (AI slop blacklist):** an approved mockup that carries one, a DESIGN.md blessing, or an explicit user ask overrides it; say the tradeoff once.
|
|
- Purple/blue gradients as default <!-- ai-color-palette -->
|
|
- Cream-and-serif default palette <!-- cream-palette -->
|
|
- Gradient text <!-- gradient-text -->
|
|
- Generic 3-column feature grids <!-- feature-grid-3col -->
|
|
- Identical card grids, nested cards <!-- identical-cards --> <!-- nested-cards -->
|
|
- Center-everything layouts with no visual hierarchy <!-- centered-everything -->
|
|
- Kickers or icon tiles above headings <!-- kicker-above-heading --> <!-- icon-tile-stack -->
|
|
- Hero metric rows ("10k+ users") <!-- hero-metrics -->
|
|
- Decorative blobs, waves, or geometric patterns not in the mockup <!-- decorative-blobs -->
|
|
- Glowing edges or pulsing status dots <!-- dark-glow --> <!-- pulsing-dot -->
|
|
- Stock photo placeholder divs <!-- stock-photo-hero -->
|
|
- "Get Started" / "Learn More" generic CTAs not from the mockup <!-- generic-cta-copy -->
|
|
- Rounded-corner cards with drop shadows as the default component <!-- card-default-component -->
|
|
- Emoji as visual elements <!-- emoji-decoration -->
|
|
- Generic testimonial sections <!-- generic-testimonials -->
|
|
- Cookie-cutter hero sections with left-text right-image <!-- split-hero-template -->
|
|
|
|
Each `<!-- id -->` is the pattern's id in `lib/design-catalog.ts`; the design detector reports the same ids.
|
|
|
|
---
|
|
|
|
## Step 3.5: Live Reload Server
|
|
|
|
After writing the HTML file, start a simple HTTP server for live preview:
|
|
|
|
```bash
|
|
# Start a simple HTTP server in the output directory
|
|
_OUTPUT_DIR=$(dirname <path-to-finalized.html>)
|
|
cd "$_OUTPUT_DIR"
|
|
python3 -m http.server 0 --bind 127.0.0.1 &
|
|
_SERVER_PID=$!
|
|
_PORT=$(lsof -i -P -n | grep "$_SERVER_PID" | grep LISTEN | awk '{print $(9)}' | cut -d: -f2 | head -1)
|
|
echo "SERVER: http://localhost:$_PORT/finalized.html"
|
|
echo "PID: $_SERVER_PID"
|
|
```
|
|
|
|
If python3 is not available, fall back to:
|
|
```bash
|
|
open <path-to-finalized.html>
|
|
```
|
|
|
|
Tell the user: "Live preview running at http://localhost:$_PORT/finalized.html.
|
|
After each edit, just refresh the browser (Cmd+R) to see changes."
|
|
|
|
When the refinement loop ends (Step 4 exits), kill the server:
|
|
```bash
|
|
kill $_SERVER_PID 2>/dev/null || true
|
|
```
|
|
|
|
---
|
|
|
|
## Step 4: Preview + Refinement Loop
|
|
|
|
{{DESIGN_DETECTOR:gate}}
|
|
|
|
### Verification Screenshots
|
|
|
|
Take verification screenshots at 3 viewports. One `gstack-render` call serves
|
|
the HTML's directory on 127.0.0.1 (so relative assets resolve), opens the page
|
|
in the Aside browser when it is running — otherwise in gstack's own headless
|
|
browser (the first output line, `ENGINE=aside` or `ENGINE=browse`, says which)
|
|
— and captures each width:
|
|
|
|
```bash
|
|
bun run ~/.claude/skills/gstack/bin/gstack-render.ts <path-to-finalized.html> \
|
|
--screenshot /tmp/gstack-verify-mobile.jpg --width 375 --jpeg \
|
|
--screenshot /tmp/gstack-verify-tablet.jpg --width 768 --jpeg \
|
|
--screenshot /tmp/gstack-verify-desktop.jpg --width 1440 --jpeg
|
|
```
|
|
|
|
Show all three screenshots inline using the Read tool. Check for:
|
|
- Text overflow (text cut off or extending beyond containers)
|
|
- Layout collapse (elements overlapping or missing)
|
|
- Responsive breakage (content not adapting to viewport)
|
|
|
|
If issues are found, note them and fix before presenting to the user.
|
|
|
|
Only if `gstack-render` prints `NEEDS_ASIDE` or `ASIDE_NOT_RUNNING` followed by
|
|
`ERROR: no browser available` (Aside is not open AND gstack's own browser is not
|
|
built), skip verification and note: "No browser available (open the Aside app,
|
|
or run ./setup in the gstack repo to build gstack's browser). Skipping automated
|
|
viewport verification." Never install either for the user.
|
|
|
|
### Refinement Loop
|
|
|
|
```
|
|
LOOP:
|
|
1. If server is running, tell user to open http://localhost:PORT/finalized.html
|
|
Otherwise: open <path>/finalized.html
|
|
|
|
2. If an approved mockup PNG exists, show it inline (Read tool) for visual comparison.
|
|
If in plan-driven or freeform mode, skip this step.
|
|
|
|
3. AskUserQuestion (adjust wording based on mode):
|
|
With mockup: "The HTML is live in your browser. Here's the approved mockup for comparison.
|
|
Try: resize the window (text should reflow dynamically),
|
|
click any text (it's editable, layout recomputes instantly).
|
|
What needs to change? Say 'done' when satisfied."
|
|
Without mockup: "The HTML is live in your browser. Try: resize the window
|
|
(text should reflow dynamically), click any text (it's editable, layout
|
|
recomputes instantly). What needs to change? Say 'done' when satisfied."
|
|
|
|
4. If "done" / "ship it" / "looks good" / "perfect" → exit loop, go to Step 5
|
|
|
|
5. Apply feedback using targeted Edit tool changes on the HTML file
|
|
(do NOT regenerate the entire file — surgical edits only)
|
|
|
|
6. Brief summary of what changed (2-3 lines max)
|
|
|
|
7. If verification screenshots are available, re-take them to confirm the fix
|
|
|
|
8. Go to LOOP
|
|
```
|
|
|
|
Maximum 10 iterations. If the user hasn't said "done" after 10, use AskUserQuestion:
|
|
"We've done 10 rounds of refinement. Want to continue iterating or call it done?"
|
|
|
|
---
|
|
|
|
## Step 5: Save & Next Steps
|
|
|
|
### Design Token Extraction
|
|
|
|
If no `DESIGN.md` exists in the repo root, offer to create one from the generated HTML:
|
|
|
|
Extract from the HTML:
|
|
- CSS custom properties (colors, spacing, font sizes)
|
|
- Font families and weights used
|
|
- Color palette (primary, secondary, accent, neutral)
|
|
- Spacing scale
|
|
- Border radius values
|
|
- Shadow values
|
|
|
|
Use AskUserQuestion:
|
|
> No DESIGN.md found. I can extract the design tokens from the HTML we just built
|
|
> and create a DESIGN.md for your project. This means future /design-shotgun and
|
|
> /design-html runs will be style-consistent automatically.
|
|
> A) Create DESIGN.md from these tokens
|
|
> B) Skip — I'll handle the design system later
|
|
|
|
If A: write `DESIGN.md` in the open DESIGN.md format (/design-consultation Phase 6 template): extracted values in the front matter's five token groups, line 2 `# gstack: design-md-format=spec`, rationale in the canonical sections. An existing file keeps its persisted format choice; never offer a conversion here.
|
|
|
|
### Save Metadata
|
|
|
|
Write `finalized.json` alongside the HTML:
|
|
```json
|
|
{
|
|
"source_mockup": "<approved variant PNG path or null>",
|
|
"source_plan": "<CEO plan path or null>",
|
|
"mode": "<approved-mockup|plan-driven|freeform|evolve>",
|
|
"html_file": "<path to finalized.html or component file>",
|
|
"pretext_tier": "<selected tier>",
|
|
"framework": "<vanilla|react|svelte|vue>",
|
|
"iterations": <number of refinement iterations>,
|
|
"date": "<ISO 8601>",
|
|
"screen": "<screen name>",
|
|
"branch": "<current branch>"
|
|
}
|
|
```
|
|
|
|
### Next Steps
|
|
|
|
Use AskUserQuestion:
|
|
> Design finalized with Pretext-native layout. What's next?
|
|
> A) Copy to project — copy the HTML/component into your codebase
|
|
> B) Iterate more — keep refining
|
|
> C) Done — I'll use this as a reference
|
|
|
|
---
|
|
|
|
## Important Rules
|
|
|
|
- **Source of truth fidelity over code elegance.** When an approved mockup exists,
|
|
pixel-match it. If that requires `width: 312px` instead of a CSS grid class, that's
|
|
correct. When in plan-driven or freeform mode, the user's feedback during the
|
|
refinement loop is the source of truth. Code cleanup happens later during
|
|
component extraction.
|
|
|
|
- **Always use Pretext for text layout.** Even if the design looks simple, Pretext
|
|
ensures correct height computation on resize. The overhead is 30KB. Every page benefits.
|
|
|
|
- **Surgical edits in the refinement loop.** Use the Edit tool to make targeted changes,
|
|
not the Write tool to regenerate the entire file. The user may have made manual edits
|
|
via contenteditable that should be preserved.
|
|
|
|
- **Real content only.** When a mockup exists, extract text from it. In plan-driven mode,
|
|
use content from the plan. In freeform mode, generate realistic content based on the
|
|
user's description. Never use "Lorem ipsum", "Your text here", or placeholder content.
|
|
|
|
- **One page per invocation.** For multi-page designs, run /design-html once per page.
|
|
Each run produces one HTML file.
|