mirror of
https://github.com/garrytan/gstack.git
synced 2026-10-03 01:46:55 +02:00
* refactor(resolvers): split review.ts into MECE resolver modules (pure move) Move every function from scripts/resolvers/review.ts, unchanged, into: - review-dashboard.ts: review dashboard, plan-file review report - plan-gates.ts: approval check, exit-plan-mode gate, plan-file discovery, plan-completion audit/gate (ship + review), plan verification exec - spec-review.ts: both spec review loops, benefits-from, anti-shortcut clause - outside-voice-steps.ts: Codex second opinion, adversarial step, Codex plan review, Codex doc review, disabled-outside record - review-scope.ts: scope drift, cross-review dedup, shared-code reuse review.ts is deleted; index.ts imports the new modules. gen-skill-docs output is byte-identical for every host (--host all). Test imports and source-path references are re-pointed; the two source-text report/gate tests in gen-skill-docs.test.ts become behavioral renders across every consuming skill and host. All 46 touchfile entries that named review.ts now name all five modules, guarded by a recorded selection golden. * test(browse): black-box auth matrix for every server route and both surfaces Drives buildFetchHandler fetchLocal/fetchTunnel with no token, wrong token, root token, scoped token and the SSE cookie for all 33 routes, plus unmatched paths and wrong methods. Denials assert today's exact status, body and content type; allowed credentials assert the handler was reached. Written against the unchanged if-chain server so the W3 route-table refactor must keep it green. * refactor(shard-engine): move scripts/test-strict-output.ts to scripts/lib/shard-engine.ts The shared shard engine grows from the existing strict-output module (runShardChild, killProcessGroup, signal forwarding, strict classifier). scripts/test-strict-output.ts stays as a re-export so existing importers, mock.module paths and the strict-output/run-shard-child tests are unchanged. The engine inherits the global touchfile entry; the free runner's CLI-routing fixture copies the new module. * refactor(resolvers): decompose the three >150-line review resolvers (output-neutral) Split generateAdversarialStep, generateCodexPlanReview and generatePlanCompletionAuditInner into per-section helpers whose template literals are copied verbatim, so every function in the new modules is at or under 150 lines. gen-skill-docs output is byte-identical for every host (--host all, compared against96764e80with a fixed --link-root). * refactor(resolvers): one outside-voice failure policy (deliberate prose unification) outsideVoiceFailurePolicy(ctx, opts) in outside-voice.ts now renders the auth / timeout / empty-response bullets for all four call sites that hand-typed them (Codex second opinion, adversarial step, Codex plan review, design outside voices). Options are explicit per site (timeoutMinutes, onTimeout, stderrOnEmpty, fallback, escape) with no defaults. Deliberate generated-prose changes (every host): - office-hours: 'Fall back to <native> subagent.' becomes 'Fall back to the <native> subagent below.' - plan-devex-review: the plain 'Auth failure (stderr contains ...)' bullets become the canonical bold bullets; auth also triggers on 'API key'; 'auth failed' becomes 'authentication failed'. - review/ship adversarial: 'exceeded 9 minutes and was terminated' becomes 'timed out after 9 minutes and was terminated'; the timeout is still MISSING COVERAGE. - design outside voices: unchanged. Adds ratchet (d) (test/outside-voice-failure-policy.test.ts) with a reasoned allowlist for /codex's own CLI errors, the MISSING COVERAGE retention test, refreshed codex/factory ship goldens, and outside-voice.ts in every touchfile entry of review.ts and design.ts (selection golden extended). * test(pty): fake PTY session driver with an injectable clock through the runner launch seam The three plan-skill runners take an optional PtyDriver (launch, now, monotonic, sleep); omitted, they use the real launcher and clocks exactly as before. test/helpers/pty/fake-session.ts feeds scripted frames through that seam, and claude-pty-runner.runners.unit.test.ts runs observation, counting and floor for success, deadline timeout, permission prompt and plan-ready outcomes with no CLI or real timers. These cases must stay green unchanged through the W4 split and the runPtySession extraction. Touchfiles: every entry that lists claude-pty-runner.ts or pty-screen.ts now also lists test/helpers/pty/**. * refactor(shard-engine): run both lanes on the shared engine; lane policy injected Engine (scripts/lib/shard-engine.ts) gains the W2 primitives: per-shard tmp/Chromium sandbox + async cleanup backstop, log-path allocation and full-stream log capture, one duration-seed reader/writer with a lane predicate, LanePolicy (seed predicate + zero-execution verdict), strictShardStatus, and the shared CLI flag loop. runShardChild takes an optional companion (signal/settle) and waits a bounded 250ms to reap a wall-killed child. Free lane stops spawning shards itself: runFreeShard uses runShardChild with trackShardBrowser as the companion (win32 path unchanged: no process group, no negative-pid kill). Its sync state-dir removal stays lane policy. Paid lane uses the sandbox, log, seed, verdict and flag primitives; the hollow-shard guard applies PAID_LANE_POLICY. Lane outcomes are unchanged (free keeps >= 0 seeds and file-count zero-exec rule; paid keeps > 0 seeds, warning under selection and passed-empty under EVALS_ALL). paid-free-boundary's closure assertion now names the engine module, where the strict classifier lives. * test(shard-engine): engine unit tests, fixture-corpus equivalence, per-lane CLI parity - test/shard-engine.test.ts: failing/unhandled/module-load output fails both lanes, per-lane zero-execution and seed rules, whole-group kill on a wall timeout (both lanes), mocked-win32 path with no negative-pid kill, companion settle order, log capture, sandbox isolation, flag loop. - test/shard-engine-equivalence.test.ts + test/fixtures/shard-equivalence: seven outcome fixtures plus one real shard, run through both lanes and compared with classifications recorded from the base runners (96764e80). - test/shard-cli-parity.test.ts + test/fixtures/shard-cli-parity: flag set, defaults, validation errors and the Unknown argument error per lane match the base runners. * refactor(shard-engine): decompose runFreeShard and runPaidShard to <= 150 lines Output-neutral extraction under the fixture-corpus equivalence and runner tests: captureFreeStream, explainFreeVerdict and logFreeRecovery (free); paidShardCommand, settleShardSpool, settleBootstrapRetention and printLogTail (paid). The bootstrap scope-creation block that bootstrap-retention.test.ts evaluates stays verbatim. * refactor(pty): split claude-pty-runner.ts into test/helpers/pty/* behind a barrel Pure move: every line of the former 5,047-line runner lands verbatim in one module (four private helpers gain `export` for cross-module use): binary, screen (absorbs test/helpers/pty-screen.ts, which now re-exports it), launch, session (PtyDriver), judge, classify, auq, plan-native, boundaries, runners/{observation,counting,floor}. claude-pty-runner.ts re-exports the original public surface by name; pty/ modules import siblings directly. Tests that read the runner's source text: - rewritten as behavioral: the unit test's model-pin tripwire (fake CLI argv: fallback chain, --model before extraArgs, hermetic --strict-mcp-config), pty-skill-seeding-wiring (runners through the fake driver; launcher through a fake CLI reporting CLAUDE_CONFIG_DIR). The "three wrappers forward model" grep is replaced by the runners' fake-driver launch assertions. - pty-screen-session / pty-screen-supervision: stop copying runner source; they mock.module the real pty/screen.ts (and the fixture cleanup) instead. - re-pointed to the owning module (they execute a sliced runner body with injected boundaries; no seam exists for those boundaries yet): eng-seeded-completion-ai, plan-floor-permission, plan-create-prepublication, plan-count-completion; hermetic-wiring's source guard now reads pty/launch.ts and scans every pty/ module for raw process.env spreads. - plan-count-timeout and pty-output-wake mock the viewport at pty/screen.ts. * test(ratchet-c): enforcing module/function size ratchet and moved-code touchfile coverage Ratchet (c) ships enforcing: test/helpers/module-size.ts counts file and top-level function lengths by brace matching over masked source (strings, comments, regex literals and template text masked; ${} expressions kept), covering function declarations, arrow functions assigned to consts and route-table handler properties, with no parser dependency. Its self-test uses template literals and code-fence braces copied from scripts/resolvers/review.ts and design.ts. test/fixtures/module-size-ratchet.json binds scripts/lib/shard-engine.ts (<= 800 lines, <= 150 per function) and records the residual runner sizes (free 2352, paid 1921) as non-growth caps; allowlist entries are keyed on file plus matched text and need a reason. Failure output lists file:line, the rule, Fix: and the allowlist path. touchfiles.test.ts gains the moved-code superset check over test/fixtures/touchfile-move-goldens/ (W2 golden recorded at96764e80: test-strict-output.ts and test-paid-shards.ts global, test-free-shards.ts none). * refactor(browse): declared route table replaces the buildFetchHandler if-chain The ~1,300-line if-chain in buildFetchHandler becomes a route table: each entry declares method, path, auth kind and surfaces, and one auth gate in browse/src/routes/table.ts returns the per-kind denial (root-bearer, scoped, root-or-sse-cookie: 401 Unauthorized; root-token: 403 Root token required; extension-origin: 403 Forbidden). Unmatched requests take the declared fallthrough (root-bearer check, then plain-text 404). Handlers move to browse/src/routes/{core,pairing,pty,tokens,tunnel,activity,commands,files, inspector}.ts and receive a RouteContext with auth checks as functions instead of closing over factory locals. Dispatch order is unchanged: tunnel filter, beforeRoute overlay, gate, handler. TUNNEL_PATHS stays a literal in server.ts. Behavior-preserving: the black-box auth matrix from the previous commit passes unchanged. /memory and /inspector/events are declared root-bearer because the blanket check always ran before their SSE-cookie branch. Source-text route tests are rewritten as behavioral tests through buildFetchHandler or a route's real handler with a stub RouteContext (browse/test/route-test-harness.ts). Checks with no runtime seam are re-pointed to the route modules: Surface type, /inspector/events SSE helper, sanitizeReplacer imports, /pty-inject-scan sidecar-client import, and the ngrok config lookup and startTunnel wiring that stay in server.ts. * test(browse): stubbed-handler auth matrix and route inventory for the route table Every ROUTES entry runs through the real dispatcher and gate with stub handlers on each declared surface and six credentials; denials assert the exact status and body each auth kind returned at96764e8, admitted credentials assert the handler ran (with the gate's TokenInfo for scoped routes). Also pins the reviewed route inventory (method, path, auth kind, surfaces), that every entry declares auth and surfaces, that the table's tunnel paths equal the TUNNEL_PATHS literal with GET /connect admitted, the unmatched fallthrough, and that the root token is rejected on every tunnel route through buildFetchHandler. * test(browse): ratchet (b) keeps route dispatch inside the route table Scans browse/src/server.ts and browse/src/routes/*.ts for pathname comparisons; only the table matcher and the tunnel-surface filter are allowed, listed with reasons in browse/test/fixtures/route-dispatch-allowlist.json (keyed on file plus line text). Also checks every entry declares auth and surfaces and that gstack registers no beforeRoute overlay itself. Self-tests plant a violation and assert the file:line, Fix: and allowlist path in the message, that a shifted line stays allowlisted, and that a reasonless entry is rejected. * test: touchfile superset check for modules moved out of browse/src/server.ts Records the paid evals selected by touching browse/src/server.ts at96764e80(17 E2E, 1 LLM judge) and asserts every browse/src/routes/*.ts module selects a superset. The test reads every golden in test/fixtures/moved-module-selection/ so other moved-code goldens can sit beside it. * test(shard-engine): give non-timeout corpus fixtures CI headroom; keep the POSIX golden off the Windows lane Only the wall-timeout fixture keeps a 3s wall; the rest get 60s so a loaded host cannot turn a pass into a timeout. Base and branch runners still agree on every classification under the new walls. The Windows exclusion entry moves the free runner's ratchet (c) residual cap to 2356 lines. * refactor(pty): one runPtySession loop drives observation, counting and floor test/helpers/pty/session.ts owns launch -> start -> (poll -> tick)* -> timeout and the failure contract the three runners each hand-rolled: the run's own error wins over capture and close errors, close always runs, owned fixture cleanup runs last (also when launch fails). Each runner now supplies a PtySessionPlan: its boot/command step, poll cadence (2s observation/floor sleep; counting's output wake + 250ms coalesce), tick policy (permission handling, native identity, terminal rules stay per runner because they differ) and capture hooks. The runner bodies are decomposed into top-level steps so no function exceeds 150 lines; behavior is unchanged and the fake-driver cases from the first W4 commit pass unmodified. The counting capture step and the native completion-summary predicate are now named functions (countingCapture, isNativeCompletionSummary), so plan-create-prepublication and plan-count-completion call them directly instead of executing sliced source. The two harnesses that still execute a sliced runner body with injected boundaries (eng-seeded-completion-ai, plan-floor-permission) pass the PtyDriver seam instead of overriding Date/Bun.sleep. * test(ratchet-c): register route modules, review resolver modules and server.ts residual cap * refactor(pty): decompose launchClaudePty and engNumberedFindingAUQ under 150 lines launchClaudePty (349 lines) becomes launch preparation (args, hermetic child env, owned state roots), recorder creation, spawn, the trust-dialog watcher, close, and the session handle over one PtyProcess state object. The failure order is unchanged: abort the viewport, dispose any recorders created so far, dispose the viewport, rethrow. The --model / --strict-mcp-config ordering and seedSkills wiring stay pinned by the behavioral fake-CLI tests. engNumberedFindingAUQ (345 lines) keeps its guards and dispatch; each self-contained issue family (declared cache, library retry hooks, cache owner, injected singleton, shared writers, injected export) moves verbatim into its own function. Every pty/ module is now <= 800 lines and every top-level function <= 150 lines. * test(pty): split claude-pty-runner.unit.test.ts along the pty/ module seams The 188 unit tests move verbatim into claude-pty-runner.{screen,classify, auq,launch,plan-native,boundaries}.unit.test.ts (test names unchanged; each file imports only what it uses from the barrel). The five files that no longer read a SKILL.md template join the test-of-test ratchet baseline with a reason. * test(touchfiles): moved PTY modules keep their paid-eval selection test/fixtures/touchfile-selection/w4-pty.json records, at96764e8, the paid evals selected by touching test/helpers/claude-pty-runner.ts (20) and test/helpers/pty-screen.ts (20). touchfiles.test.ts now asserts every .ts file under test/helpers/pty/ (and pty/screen.ts for both sources) selects a superset, reading every golden in that directory so later moves can add one; a planted-violation case pins the report and its Fix line. * fix(browse): unexchanged pair setup keys no longer authenticate bearer requests validateToken accepted a gsk_setup_ key as a bearer on /command, /batch and /file (found while building the W3 auth matrix). A setup key now only authenticates the /connect exchange. * W1: one state-root owner (lib/state-root.ts + bin/gstack-state-root.sh), gstack-paths --explain and fail-stop, parity tests * W1: guarded migration of every executable state-root site; uninstall deletes only ~/.gstack Bins, careful/freeze hooks, setup, upgrade migrations, browse/src, design, ios-qa daemon, lib and scripts resolve the state root through bin/gstack-state-root.sh (bash) or lib/state-root.ts (TS). Bins source the twin and stop with a reinstall message when it is missing; hooks source it and never spawn gstack-paths. browse/src/config.ts and lib/cso/state.ts delegate to resolveStateRoot. Analytics writers and readers move together so the usage log stays one file. gstack-uninstall deletes state only at ~/.gstack, refuses (exit 2) when it resolves to /, $HOME or an ancestor, the checkout or the git root, and leaves any other resolved root in place with the removal command. Fixtures that copy single bins now copy the twin. * W1: privacy keys and trust-policy deny tiers merge across state roots; gstack-config reporting; test hermeticity readConfigKey / gstack_read_config_key return the most restrictive telemetry, memorable_recall, codex_reviews and update_check across the resolved root and ~/.gstack; other keys read the resolved root only. gstack-config set reports an overriding root with the exact override command, list shows the winning root and a root-variable disagreement line. gstack-gbrain-repo-policy get merges deny/read-only tiers. gstack-egress reads through readConfigKey. test-setup.ts strips inherited GSTACK_STATE_ROOT/GSTACK_STATE_DIR and redirects the legacy root. * W1: shared hook logging helper (hosts/claude/hooks/hook-log.ts) One hook-errors.log writer: root from resolveStateRoot, 0600 on every append, opt-in rate limit used only by memorable-user-prompt. The five hooks route through it. * W1: docs/state-root.md and README troubleshooting pointer Precedence table, a real --explain example, the move-your-state recipe, merged privacy keys, the uninstall rule, the resolver-failure fix, and the plugin-mode note (evidence gate: no official plugin distribution). * W1b: template and resolver prose resolve state through guarded gstack-paths; ratchet (a) Every gstack-paths eval in templates and resolvers carries the fail-stop guard; executable ~/.gstack paths in bash blocks (context recovery preamble, eureka log, analytics, project artifacts, upgrade snooze, setup-gbrain lock, retro snapshots, ship consent marker) use $GSTACK_STATE_ROOT, and the writer prose that pairs with them points at the printed PROJECT_DIR / RETRO_FILE. ship drops export GSTACK_STATE_ROOT. SKILL.md regenerated (claude + codex), ship goldens re-pinned, parity and context-budget caps raised to the measured sizes with notes. test/state-root-ratchet.test.ts enforces the rule with a reasoned allowlist; W1 touchfile entries plus a superset golden. * refactor: apply W1 state-root edits in W2/W3/W5-owned files; one moved-code touchfile golden for all workstreams * test: fold the moved-code touchfile golden into touchfiles.test.ts; fix integration fixture closure and caps * v1.91.11.0: CHANGELOG, TODOS, docs and conventions for the refactor wave * test: re-measure plan-ceo/design-consultation caps and ship goldens after the guarded plan-discovery and spec-review blocks; add the state-root twin to the workflow-boundaries fixture * fix(windows): migrations resolve their directory with either path separator; state-root parity compares under the HOME Git Bash actually sees * fix(review,ship): state plan-check timing after smoke expiry and test_stub Skip semantics (review workflow judge clarity) * test(qa-eval): webhook fix eval asks for the fix loop's post-repair probes; eight-scenario coverage stays in the report-only case and the harness recheck * test(qa-eval): re-pin the webhook prompt contract to the fix-loop stage; R29 coverage omissions stay bound by the report-only case * fix(review,ship): plan checks publish a checkpoint before each probe; only the smoke expiry stop is skipped * fix(qa): carry #2999's checkpoint receipt link, report-template line and full-revision placeholder (identical hunks) * test(qa-callers): disable git auto maintenance in the caller fixture Git 2.47+ runs auto maintenance detached after commit; on the CI runner's git 2.55 it rewrote .git/objects fan-out directories while the write observer was running, which surfaced as unauthorized mutations. Same gc.auto=0 / maintenance.auto=false guard the shared-libs fixture already uses. * test(plan-mode-no-op): require prose evidence for the prose-fallback members so a spinner-frame judge verdict cannot end the run as asked * test(ship-docsync): carry #2999's seeded-attempt docsync harness (identical files) The doc-sync fault cases replayed attempt 1 before reaching their gate and ran out of their 285s budget. The fixture now seeds attempt 1 and the parent starts at the gate under test. Taken byte-identical from origin/capy/audit-fix-wave (fb526898,e6ac813d,6ce10ff7,d0c53577,77cce3be). Local: stale-before, recovery and late-result 6/6 PASS (97-164s); the whole file 12/12 PASS.
563 lines
23 KiB
TypeScript
563 lines
23 KiB
TypeScript
/**
|
|
* gbrain-local-status — classify the local gbrain engine into 6 states.
|
|
*
|
|
* Shared between bin/gstack-gbrain-detect (preamble probe on every skill start)
|
|
* and bin/gstack-gbrain-sync.ts (orchestrator SKIP-when-not-ok semantics).
|
|
* Single source of truth: same probe, same classification, same cache.
|
|
*
|
|
* Per the split-engine plan (D2 + D8):
|
|
* - Probe: `gbrain sources list --json`. Cheap (~80ms), actually hits the DB.
|
|
* Uses the same stderr patterns as lib/gbrain-sources.ts:66-67.
|
|
* - Cache: 60s TTL at ~/.gstack/.gbrain-local-status-cache.json, keyed on
|
|
* {home, gbrain_home, path_hash, gbrain_bin_path, gbrain_version,
|
|
* config_mtime, probe_timeout_ms}.
|
|
* - --no-cache bypass: /setup-gbrain and /sync-gbrain pass it after any
|
|
* state-mutating operation so the next read sees fresh status.
|
|
*
|
|
* No-cli → gbrain not on PATH.
|
|
* Missing → CLI present, config.json absent (honors GBRAIN_HOME).
|
|
* Broken-config → config exists but `gbrain sources list` fails with config parse error
|
|
* (or any non-recognized error — defensive default per codex #8).
|
|
* Broken-db → config exists, DB unreachable per stderr classification.
|
|
* Engine-locked → PGLite probe hit gbrain's own connect timeout, usually
|
|
* because another `gbrain serve` process owns the embedded DB.
|
|
* Timeout → probe exceeded GSTACK_GBRAIN_PROBE_TIMEOUT_MS (default 15s) with no
|
|
* recognized error — engine is likely healthy but slow (e.g. a cold
|
|
* pooler connection, #1964). Consumers treat this as usable.
|
|
* Thin-client → config carries gbrain's remote_mcp marker (#2051), OR the
|
|
* agent host's MCP registration is remote-HTTP-only (#2520 — bearer
|
|
* installs via `gbrain connect --token` never get the marker): NO
|
|
* local engine by design; queries go to a remote-HTTP MCP brain.
|
|
* Usable for brain-aware prose gates; sync stages that need a LOCAL
|
|
* engine (code/memory/dream) skip. Remote reachability is verified
|
|
* at USE time (gbrain calls degrade gracefully), never by a
|
|
* classifier network probe — that's the #1964 pathology.
|
|
* Ok → DB reachable, sources list returned valid JSON.
|
|
*/
|
|
|
|
import { execFileSync } from "child_process";
|
|
import {
|
|
createHash,
|
|
} from "crypto";
|
|
import {
|
|
existsSync,
|
|
mkdirSync,
|
|
readFileSync,
|
|
statSync,
|
|
} from "fs";
|
|
import { atomicWriteSync } from "./fs-atomic";
|
|
import { homedir } from "os";
|
|
import { dirname, join } from "path";
|
|
import { buildGbrainEnv, gbrainConfigDir, isExecTimeout, NEEDS_SHELL_ON_WINDOWS } from "./gbrain-exec";
|
|
import { resolveStateRoot } from "./state-root";
|
|
|
|
export type LocalEngineStatus =
|
|
| "ok"
|
|
| "no-cli"
|
|
| "missing-config"
|
|
| "broken-config"
|
|
| "broken-db"
|
|
| "engine-locked"
|
|
| "timeout"
|
|
| "thin-client";
|
|
|
|
export interface ClassifyOptions {
|
|
/** Bypass the 60s cache. Used after any state-mutating operation. */
|
|
noCache?: boolean;
|
|
/** Env override for the spawned `gbrain` (used by tests to point at a fake binary). */
|
|
env?: NodeJS.ProcessEnv;
|
|
}
|
|
|
|
interface CacheEntry {
|
|
// Local-cache schema version, controlled by gstack. Not to be confused
|
|
// with `gbrain doctor --json` output schema_version (gbrain v0.25+ emits
|
|
// schema_version: 2). Doctor-output parsing lives in
|
|
// lib/gstack-memory-helpers.ts:freshDetectEngineTier and accepts both
|
|
// doctor-output versions. This cache stays strictly at version 1 — a
|
|
// future shape change here requires an explicit migration.
|
|
schema_version: 1;
|
|
status: LocalEngineStatus;
|
|
cached_at: number;
|
|
/** Cache invariants — entry is invalidated if any of these change between writes. */
|
|
key: {
|
|
home: string;
|
|
gbrain_home: string; // honors GBRAIN_HOME (#1964 / codex D11)
|
|
path_hash: string;
|
|
gbrain_bin_path: string;
|
|
gbrain_version: string;
|
|
config_mtime: number; // 0 when config absent
|
|
config_size: number; // 0 when config absent
|
|
probe_timeout_ms: number; // raising the timeout invalidates a cached "timeout"
|
|
};
|
|
}
|
|
|
|
export const CACHE_TTL_MS = 60_000;
|
|
export const DEFAULT_PROBE_TIMEOUT_MS = 15_000;
|
|
|
|
/**
|
|
* Effective probe timeout. `GSTACK_GBRAIN_PROBE_TIMEOUT_MS` overrides the
|
|
* 15s default (tests set it low; users with slow poolers raise it).
|
|
* Non-numeric or non-positive values fall back to the default.
|
|
*/
|
|
export function probeTimeoutMs(env?: NodeJS.ProcessEnv): number {
|
|
const raw = (env ?? process.env).GSTACK_GBRAIN_PROBE_TIMEOUT_MS;
|
|
if (!raw) return DEFAULT_PROBE_TIMEOUT_MS;
|
|
const parsed = Number(raw);
|
|
if (!Number.isFinite(parsed) || parsed <= 0) return DEFAULT_PROBE_TIMEOUT_MS;
|
|
// Floor of 1ms: Math.floor(0.5) would yield 0, and execFileSync treats
|
|
// timeout: 0 as NO timeout — the probe that exists to bound hangs would
|
|
// itself hang forever (adversarial review finding 2).
|
|
return Math.max(1, Math.floor(parsed));
|
|
}
|
|
|
|
/** Effective user home — respects HOME env override (used by tests). */
|
|
function userHome(env?: NodeJS.ProcessEnv): string {
|
|
return (env ?? process.env).HOME || homedir();
|
|
}
|
|
|
|
/** Cache path computed fresh on each call so tests can mutate GSTACK_HOME per case. */
|
|
export function cacheFilePath(): string {
|
|
return join(resolveStateRoot(), ".gbrain-local-status-cache.json");
|
|
}
|
|
|
|
/**
|
|
* Honors GBRAIN_HOME (codex D11) with gbrain's own configDir() semantics
|
|
* (#2521): GBRAIN_HOME is a parent dir, `.gbrain` is appended. Same
|
|
* resolution as buildGbrainEnv — both route through gbrainConfigDir.
|
|
*/
|
|
function gbrainConfigPath(env?: NodeJS.ProcessEnv): string {
|
|
const e = env ?? process.env;
|
|
return join(gbrainConfigDir(e), "config.json");
|
|
}
|
|
|
|
/**
|
|
* Bearer-token thin-client evidence (#2520). `gbrain connect <url> --token`
|
|
* registers a remote-HTTP MCP server with the agent host but never writes
|
|
* gbrain's remote_mcp marker into config.json — that marker is OAuth-only,
|
|
* written by `gbrain init --mcp-only`. So the config-file marker check misses
|
|
* bearer installs entirely: they fall through to the local probe, which fails
|
|
* against the dead-or-absent local engine and lands on missing-config /
|
|
* broken-db / broken-config / engine-locked, silently suppressing brain
|
|
* blocks for a fully-working remote brain.
|
|
*
|
|
* Evidence read: ~/.claude.json MCP registrations — user scope plus the
|
|
* cwd's NEAREST-ANCESTOR project scope only (#2499 made project scope
|
|
* visible; the per-project scoping fixes the machine-wide bleed where ONE
|
|
* project's remote registration reclassified broken local engines as
|
|
* thin-client for EVERY cwd). Ancestor matching mirrors the inline jq
|
|
* resolution in bin/gstack-skill-start (the single bash copy of the #2499
|
|
* resolution, moved there in token-reduction Phase 1): cwd == key or
|
|
* cwd startswith key + separator, longest matching key that actually
|
|
* carries a gbrain entry wins (a nested project WITHOUT gbrain doesn't
|
|
* shadow its parent's registration).
|
|
*
|
|
* Same-name conflicts resolve project-local over user scope — Claude
|
|
* Code's own precedence, verified empirically against claude 2.1.233 with
|
|
* a hermetic fake $HOME: `claude mcp get gbrain` reports "Scope: Local
|
|
* config" and the project-local URL when both scopes define the name.
|
|
*
|
|
* File-read only: no subprocess, no network (a classifier network probe is
|
|
* the #1964 pathology). Returns true only when a visible gbrain
|
|
* registration is remote-HTTP AND no visible gbrain registration is
|
|
* local-stdio — a local-stdio entry means the user runs a local engine
|
|
* (possibly alongside a remote one, e.g. federation), and local-engine
|
|
* statuses like engine-locked must keep their precise meaning there.
|
|
*/
|
|
export function hasRemoteOnlyGbrainMcp(
|
|
env?: NodeJS.ProcessEnv,
|
|
cwd: string = process.cwd(),
|
|
): boolean {
|
|
interface McpEntry {
|
|
type?: string;
|
|
transport?: string;
|
|
command?: string;
|
|
url?: string;
|
|
}
|
|
let cj: unknown;
|
|
try {
|
|
cj = JSON.parse(readFileSync(join(userHome(env), ".claude.json"), "utf-8"));
|
|
} catch {
|
|
return false;
|
|
}
|
|
// Same classification rules as gstack-gbrain-detect's detectMcpMode tier 3,
|
|
// including the #2051 name generalization (gbrain, gbrain-remote, gbrain_work).
|
|
const classify = (entry: McpEntry): "remote" | "local" | null => {
|
|
const mtype = entry.type || entry.transport || "";
|
|
if (mtype === "url" || mtype === "http" || mtype === "sse") return "remote";
|
|
if (mtype === "stdio") return "local";
|
|
if (entry.url) return "remote";
|
|
if (entry.command) return "local";
|
|
return null;
|
|
};
|
|
/** Extract the gbrain-relevant entries from an mcpServers object. */
|
|
const gbrainEntries = (servers: unknown): Record<string, McpEntry> => {
|
|
const out: Record<string, McpEntry> = {};
|
|
if (!servers || typeof servers !== "object") return out;
|
|
for (const [name, entry] of Object.entries(servers as Record<string, McpEntry>)) {
|
|
if (!entry || typeof entry !== "object") continue;
|
|
const isGbrainName = /^gbrain([-_][\w-]*)?$/.test(name);
|
|
const cmdMentionsGbrain =
|
|
typeof entry.command === "string" && /\bgbrain\b/.test(entry.command);
|
|
if (!isGbrainName && !cmdMentionsGbrain) continue;
|
|
out[name] = entry;
|
|
}
|
|
return out;
|
|
};
|
|
const root = cj as {
|
|
mcpServers?: unknown;
|
|
projects?: Record<string, { mcpServers?: unknown }>;
|
|
} | null;
|
|
const userGbrain = gbrainEntries(root?.mcpServers);
|
|
// Nearest-ancestor project entry for cwd that carries a gbrain server.
|
|
// Path-boundary-aware (/a/repo never matches /a/repo2); both separators
|
|
// accepted so Windows project keys resolve.
|
|
let projectGbrain: Record<string, McpEntry> = {};
|
|
if (root?.projects && typeof root.projects === "object") {
|
|
let bestKey: string | null = null;
|
|
for (const [key, proj] of Object.entries(root.projects)) {
|
|
if (!proj || typeof proj !== "object") continue;
|
|
const entries = gbrainEntries((proj as { mcpServers?: unknown }).mcpServers);
|
|
if (Object.keys(entries).length === 0) continue;
|
|
const isAncestor =
|
|
cwd === key || cwd.startsWith(`${key}/`) || cwd.startsWith(`${key}\\`);
|
|
if (!isAncestor) continue;
|
|
if (bestKey === null || key.length > bestKey.length) {
|
|
bestKey = key;
|
|
projectGbrain = entries;
|
|
}
|
|
}
|
|
}
|
|
// Effective view for this cwd: project-local shadows user scope per name.
|
|
const effective: Record<string, McpEntry> = { ...userGbrain, ...projectGbrain };
|
|
let sawRemote = false;
|
|
let sawLocal = false;
|
|
for (const entry of Object.values(effective)) {
|
|
const c = classify(entry);
|
|
if (c === "remote") sawRemote = true;
|
|
if (c === "local") sawLocal = true;
|
|
}
|
|
return sawRemote && !sawLocal;
|
|
}
|
|
|
|
function configuredEngine(env?: NodeJS.ProcessEnv): "pglite" | "postgres" | null {
|
|
try {
|
|
const parsed = JSON.parse(readFileSync(gbrainConfigPath(env), "utf-8")) as { engine?: string };
|
|
return parsed.engine === "pglite" || parsed.engine === "postgres" ? parsed.engine : null;
|
|
} catch {
|
|
return null;
|
|
}
|
|
}
|
|
|
|
function hashPath(p: string): string {
|
|
return createHash("sha256").update(p).digest("hex").slice(0, 16);
|
|
}
|
|
|
|
/**
|
|
* Resolve the absolute path of `gbrain` on PATH. Returns null when missing.
|
|
* Memoized per-process keyed on PATH so detect's call and the classifier's
|
|
* call share one fork-exec (~200ms saved per skill preamble).
|
|
*/
|
|
// #2716: the probe must tell "gbrain isn't installed" apart from "gbrain is
|
|
// installed but the --version round trip blew the budget" (bun-shim installs
|
|
// on a loaded POSIX box take >2s). Both used to collapse into `null` → the
|
|
// classifier said `no-cli`, which the `--is-ok` whitelist does NOT forgive —
|
|
// so a slow box silently lost every brain-aware block. The cache stores the
|
|
// discriminated result (per-process, same lifetime the old null had).
|
|
export interface GbrainBinProbe {
|
|
bin: string | null;
|
|
timedOut: boolean;
|
|
}
|
|
// Caching a TIMEOUT for process lifetime is deliberate: the memo exists to
|
|
// dedupe the ~3 probes a single skill preamble fires, and preamble processes
|
|
// are short-lived — a retry next invocation gets a fresh probe anyway.
|
|
const _gbrainBinCache = new Map<string, GbrainBinProbe>();
|
|
// On Windows the shim is `gbrain.cmd` → `bun run cli.ts`; a cold spawn can
|
|
// exceed 2s, and a false negative here poisons the 60s status cache with
|
|
// "no-cli". Give the shim headroom; POSIX keeps the tight timeout.
|
|
// `GSTACK_GBRAIN_VERSION_PROBE_TIMEOUT_MS` overrides for tests (same
|
|
// precedent as GSTACK_GBRAIN_PROBE_TIMEOUT_MS on the sources probe).
|
|
const VERSION_PROBE_TIMEOUT_MS = NEEDS_SHELL_ON_WINDOWS ? 10_000 : 2_000;
|
|
function versionProbeTimeoutMs(env?: NodeJS.ProcessEnv): number {
|
|
const raw = (env ?? process.env).GSTACK_GBRAIN_VERSION_PROBE_TIMEOUT_MS;
|
|
const n = raw ? Number(raw) : NaN;
|
|
return Number.isFinite(n) && n > 0 ? n : VERSION_PROBE_TIMEOUT_MS;
|
|
}
|
|
export function probeGbrainBin(env?: NodeJS.ProcessEnv): GbrainBinProbe {
|
|
const e = env ?? process.env;
|
|
const key = e.PATH || "";
|
|
if (_gbrainBinCache.has(key)) return _gbrainBinCache.get(key)!;
|
|
let result: GbrainBinProbe = { bin: null, timedOut: false };
|
|
try {
|
|
execFileSync("gbrain", ["--version"], {
|
|
encoding: "utf-8",
|
|
timeout: versionProbeTimeoutMs(e),
|
|
stdio: ["ignore", "ignore", "ignore"],
|
|
env: e,
|
|
shell: NEEDS_SHELL_ON_WINDOWS, // #1731: gbrain is a .cmd shim on Windows
|
|
});
|
|
result = { bin: "gbrain", timedOut: false };
|
|
} catch (err) {
|
|
// Same discrimination the `sources list` probe below already uses: a
|
|
// killed/expired spawn is a TIMEOUT (binary present but slow), anything
|
|
// else (ENOENT, non-zero exit) is genuinely no CLI.
|
|
result = { bin: null, timedOut: isExecTimeout(err) };
|
|
}
|
|
_gbrainBinCache.set(key, result);
|
|
return result;
|
|
}
|
|
export function resolveGbrainBin(env?: NodeJS.ProcessEnv): string | null {
|
|
return probeGbrainBin(env).bin;
|
|
}
|
|
|
|
/** Memoized per-process. */
|
|
const _gbrainVersionCache = new Map<string, string>();
|
|
export function readGbrainVersion(env?: NodeJS.ProcessEnv): string {
|
|
const e = env ?? process.env;
|
|
const key = `${e.PATH || ""}|${resolveGbrainBin(e) || ""}`;
|
|
if (_gbrainVersionCache.has(key)) return _gbrainVersionCache.get(key)!;
|
|
let result = "";
|
|
try {
|
|
const out = execFileSync("gbrain", ["--version"], {
|
|
encoding: "utf-8",
|
|
timeout: versionProbeTimeoutMs(e),
|
|
stdio: ["ignore", "pipe", "ignore"],
|
|
env: e,
|
|
shell: NEEDS_SHELL_ON_WINDOWS, // #1731: gbrain is a .cmd shim on Windows
|
|
});
|
|
result = out.trim().split("\n")[0] || "";
|
|
} catch {
|
|
result = "";
|
|
}
|
|
_gbrainVersionCache.set(key, result);
|
|
return result;
|
|
}
|
|
|
|
function configFingerprint(env?: NodeJS.ProcessEnv): { mtime: number; size: number } {
|
|
try {
|
|
const st = statSync(gbrainConfigPath(env));
|
|
return { mtime: Math.floor(st.mtimeMs), size: st.size };
|
|
} catch {
|
|
return { mtime: 0, size: 0 };
|
|
}
|
|
}
|
|
|
|
function buildCacheKey(
|
|
gbrainBin: string | null,
|
|
gbrainVersion: string,
|
|
env?: NodeJS.ProcessEnv,
|
|
): CacheEntry["key"] {
|
|
const e = env ?? process.env;
|
|
const config = configFingerprint(e);
|
|
return {
|
|
home: e.HOME || "",
|
|
gbrain_home: e.GBRAIN_HOME || "",
|
|
path_hash: hashPath(e.PATH || ""),
|
|
gbrain_bin_path: gbrainBin || "",
|
|
gbrain_version: gbrainVersion,
|
|
config_mtime: config.mtime,
|
|
config_size: config.size,
|
|
probe_timeout_ms: probeTimeoutMs(e),
|
|
};
|
|
}
|
|
|
|
function keysEqual(a: CacheEntry["key"], b: CacheEntry["key"]): boolean {
|
|
return (
|
|
a.home === b.home &&
|
|
a.gbrain_home === b.gbrain_home &&
|
|
a.path_hash === b.path_hash &&
|
|
a.gbrain_bin_path === b.gbrain_bin_path &&
|
|
a.gbrain_version === b.gbrain_version &&
|
|
a.config_mtime === b.config_mtime &&
|
|
a.config_size === b.config_size &&
|
|
a.probe_timeout_ms === b.probe_timeout_ms
|
|
);
|
|
}
|
|
|
|
function readCache(key: CacheEntry["key"]): LocalEngineStatus | null {
|
|
if (!existsSync(cacheFilePath())) return null;
|
|
try {
|
|
const raw = JSON.parse(readFileSync(cacheFilePath(), "utf-8")) as CacheEntry;
|
|
if (raw.schema_version !== 1) return null;
|
|
if (Date.now() - raw.cached_at > CACHE_TTL_MS) return null;
|
|
if (!keysEqual(raw.key, key)) return null;
|
|
return raw.status;
|
|
} catch {
|
|
return null;
|
|
}
|
|
}
|
|
|
|
function writeCache(status: LocalEngineStatus, key: CacheEntry["key"]): void {
|
|
const entry: CacheEntry = {
|
|
schema_version: 1,
|
|
status,
|
|
cached_at: Date.now(),
|
|
key,
|
|
};
|
|
try {
|
|
mkdirSync(dirname(cacheFilePath()), { recursive: true });
|
|
atomicWriteSync(cacheFilePath(), JSON.stringify(entry, null, 2));
|
|
} catch {
|
|
// Cache write failure is non-fatal — we re-probe next call.
|
|
}
|
|
}
|
|
|
|
/**
|
|
* Probe via `gbrain sources list --json`. Classify the outcome.
|
|
*
|
|
* Pattern strings ("Cannot connect to database", "config.json") are deliberately
|
|
* the same strings used in lib/gbrain-sources.ts:66-67. If gbrain reworks its
|
|
* error messages, classifier returns broken-config defensively (codex #8).
|
|
*/
|
|
function freshClassify(env?: NodeJS.ProcessEnv): LocalEngineStatus {
|
|
// 1. CLI on PATH? A probe that TIMED OUT means the binary exists but the
|
|
// box is slow (#2716: bun-shim installs) — that's "timeout", which the
|
|
// `--is-ok` whitelist forgives, never "no-cli", which it doesn't.
|
|
const probe = probeGbrainBin(env);
|
|
if (!probe.bin) return probe.timedOut ? "timeout" : "no-cli";
|
|
const gbrainBin = probe.bin;
|
|
|
|
// 2. Config file present? A bearer thin client (#2520) may never have run
|
|
// a local init, so config.json can be absent while the remote-HTTP MCP
|
|
// registration IS the user's brain.
|
|
if (!existsSync(gbrainConfigPath(env))) {
|
|
return hasRemoteOnlyGbrainMcp(env) ? "thin-client" : "missing-config";
|
|
}
|
|
|
|
// 2.5 Thin client? gbrain's own marker (mirrors gbrain isThinClient():
|
|
// truthy remote_mcp in config). A thin client has NO local engine — gbrain
|
|
// REFUSES `sources` commands on it (THIN_CLIENT_REFUSED_COMMANDS, exit 1
|
|
// with no recognized error string), so the probe below would fall to the
|
|
// defensive broken-config default and silently suppress brain-aware blocks
|
|
// (#2051). Detected PRE-probe from the config file: zero network cost,
|
|
// immune to gbrain error-string drift. Remote reachability is deliberately
|
|
// NOT probed here — a classifier network probe is the #1964 pathology.
|
|
try {
|
|
const cfg = JSON.parse(readFileSync(gbrainConfigPath(env), "utf-8")) as {
|
|
remote_mcp?: unknown;
|
|
};
|
|
if (cfg && typeof cfg === "object" && cfg.remote_mcp) {
|
|
return "thin-client";
|
|
}
|
|
} catch {
|
|
// Unparseable config: fall through to the probe, whose stderr
|
|
// classification surfaces broken-config with the raw error upstream.
|
|
}
|
|
|
|
// 3. Probe gbrain sources list.
|
|
//
|
|
// Seed DATABASE_URL from ~/.gbrain/config.json (via buildGbrainEnv, the
|
|
// same helper the sync orchestrator uses in lib/gbrain-exec.ts). Without
|
|
// this, Bun autoloads a project's .env when the probe runs inside a repo
|
|
// that defines its own DATABASE_URL (e.g. an app DB on a different port),
|
|
// gbrain connects to the wrong DB, and the classifier falsely reports
|
|
// broken-db. This also makes the result cwd-independent, so the 60s cache
|
|
// can no longer propagate a poisoned negative to clean directories.
|
|
try {
|
|
execFileSync("gbrain", ["sources", "list", "--json"], {
|
|
encoding: "utf-8",
|
|
timeout: probeTimeoutMs(env),
|
|
stdio: ["ignore", "pipe", "pipe"],
|
|
env: buildGbrainEnv({ baseEnv: env ?? process.env }),
|
|
shell: NEEDS_SHELL_ON_WINDOWS, // #1731: gbrain is a .cmd shim on Windows
|
|
});
|
|
return "ok";
|
|
} catch (err) {
|
|
const e = err as NodeJS.ErrnoException & {
|
|
stdout?: Buffer | string;
|
|
stderr?: Buffer | string;
|
|
killed?: boolean;
|
|
signal?: NodeJS.Signals | null;
|
|
status?: number | null;
|
|
};
|
|
const stderr = (e.stderr ? e.stderr.toString() : "") || "";
|
|
|
|
// ENOENT can happen if gbrain disappeared between resolveGbrainBin and now.
|
|
if (e.code === "ENOENT") return "no-cli";
|
|
|
|
// Pattern match against gbrain's known error strings. Order matters:
|
|
// thin-client refusal first (backstop for a config the pre-probe check
|
|
// couldn't read — gbrain's dispatch guard says e.g. "`gbrain sources` is
|
|
// not routable ... (thin-client of <url>)"), then the more specific
|
|
// DB-unreachable signal.
|
|
const raw = ((): LocalEngineStatus => {
|
|
if (/thin[- ]client/i.test(stderr)) return "thin-client";
|
|
if (stderr.includes("Cannot connect to database")) return "broken-db";
|
|
if (stderr.includes("config.json")) return "broken-config";
|
|
|
|
let structuredBusy = false;
|
|
try {
|
|
structuredBusy = JSON.parse(e.stdout?.toString() || "")?.error === "pglite_busy";
|
|
} catch {}
|
|
if (structuredBusy) {
|
|
return configuredEngine(env) === "pglite" ? "engine-locked" : "broken-db";
|
|
}
|
|
|
|
// PGLite is single-process. A long-lived `gbrain serve` can own the
|
|
// embedded database, causing the CLI to finish with its own exit 124 and
|
|
// "connect timed out" message. This is neither our watchdog timeout nor
|
|
// evidence that the valid config is malformed (#2194).
|
|
if (stderr.includes("connect timed out") || e.status === 124) {
|
|
return configuredEngine(env) === "pglite" ? "engine-locked" : "broken-db";
|
|
}
|
|
|
|
// gbrain >= 0.43 refuses the same held-lock case with exit 1 and its
|
|
// own message: "GBrain's local database is already open through `gbrain
|
|
// serve` (MCP, PID N). This brain uses PGLite, ...". That string matches
|
|
// none of the branches above, so without this check it falls through to
|
|
// the defensive broken-config default — whose remediation tells the user
|
|
// to move a perfectly healthy config.json aside and re-init the engine
|
|
// (#2194 follow-up).
|
|
if (stderr.includes("already open through")) {
|
|
return configuredEngine(env) === "pglite" ? "engine-locked" : "broken-db";
|
|
}
|
|
|
|
// Probe killed by the timeout with no recognized error: the engine is
|
|
// most likely healthy but slow (cold pooler connections measured at
|
|
// 6.9-10.7s in #1964). Don't tell the user their config is malformed.
|
|
if (isExecTimeout(e)) {
|
|
return "timeout";
|
|
}
|
|
|
|
// Defensive default per codex #8: unrecognized failures classify as
|
|
// broken-config so the user sees the raw stderr surfaced upstream.
|
|
return "broken-config";
|
|
})();
|
|
|
|
// #2520 bearer-token fallback: the local probe failed, but the user's
|
|
// only gbrain MCP registration is remote-HTTP — the dead-or-locked local
|
|
// engine is not their brain (typical shape: a leftover local config plus
|
|
// `gbrain connect --token`). Reclassify as thin-client so brain blocks
|
|
// stay rendered and sync's local stages skip with the accurate "nothing
|
|
// to do locally" message. "timeout" is deliberately excluded: it already
|
|
// counts as usable and may be a genuinely healthy slow LOCAL engine.
|
|
if (
|
|
(raw === "broken-db" || raw === "broken-config" || raw === "engine-locked") &&
|
|
hasRemoteOnlyGbrainMcp(env)
|
|
) {
|
|
return "thin-client";
|
|
}
|
|
return raw;
|
|
}
|
|
}
|
|
|
|
/**
|
|
* Classify the local gbrain engine status. Cached for 60s; bypassable.
|
|
*
|
|
* Returns one of 5 states. Never throws — failure modes are surfaced as states.
|
|
*/
|
|
export function localEngineStatus(opts: ClassifyOptions = {}): LocalEngineStatus {
|
|
const env = opts.env ?? process.env;
|
|
const gbrainBin = resolveGbrainBin(env);
|
|
const gbrainVersion = gbrainBin ? readGbrainVersion(env) : "";
|
|
const key = buildCacheKey(gbrainBin, gbrainVersion, env);
|
|
|
|
if (!opts.noCache) {
|
|
const cached = readCache(key);
|
|
if (cached) return cached;
|
|
}
|
|
|
|
const fresh = freshClassify(env);
|
|
writeCache(fresh, key);
|
|
return fresh;
|
|
}
|