mirror of
https://github.com/garrytan/gstack.git
synced 2026-10-04 10:26:52 +02:00
* refactor(resolvers): split review.ts into MECE resolver modules (pure move) Move every function from scripts/resolvers/review.ts, unchanged, into: - review-dashboard.ts: review dashboard, plan-file review report - plan-gates.ts: approval check, exit-plan-mode gate, plan-file discovery, plan-completion audit/gate (ship + review), plan verification exec - spec-review.ts: both spec review loops, benefits-from, anti-shortcut clause - outside-voice-steps.ts: Codex second opinion, adversarial step, Codex plan review, Codex doc review, disabled-outside record - review-scope.ts: scope drift, cross-review dedup, shared-code reuse review.ts is deleted; index.ts imports the new modules. gen-skill-docs output is byte-identical for every host (--host all). Test imports and source-path references are re-pointed; the two source-text report/gate tests in gen-skill-docs.test.ts become behavioral renders across every consuming skill and host. All 46 touchfile entries that named review.ts now name all five modules, guarded by a recorded selection golden. * test(browse): black-box auth matrix for every server route and both surfaces Drives buildFetchHandler fetchLocal/fetchTunnel with no token, wrong token, root token, scoped token and the SSE cookie for all 33 routes, plus unmatched paths and wrong methods. Denials assert today's exact status, body and content type; allowed credentials assert the handler was reached. Written against the unchanged if-chain server so the W3 route-table refactor must keep it green. * refactor(shard-engine): move scripts/test-strict-output.ts to scripts/lib/shard-engine.ts The shared shard engine grows from the existing strict-output module (runShardChild, killProcessGroup, signal forwarding, strict classifier). scripts/test-strict-output.ts stays as a re-export so existing importers, mock.module paths and the strict-output/run-shard-child tests are unchanged. The engine inherits the global touchfile entry; the free runner's CLI-routing fixture copies the new module. * refactor(resolvers): decompose the three >150-line review resolvers (output-neutral) Split generateAdversarialStep, generateCodexPlanReview and generatePlanCompletionAuditInner into per-section helpers whose template literals are copied verbatim, so every function in the new modules is at or under 150 lines. gen-skill-docs output is byte-identical for every host (--host all, compared against96764e80with a fixed --link-root). * refactor(resolvers): one outside-voice failure policy (deliberate prose unification) outsideVoiceFailurePolicy(ctx, opts) in outside-voice.ts now renders the auth / timeout / empty-response bullets for all four call sites that hand-typed them (Codex second opinion, adversarial step, Codex plan review, design outside voices). Options are explicit per site (timeoutMinutes, onTimeout, stderrOnEmpty, fallback, escape) with no defaults. Deliberate generated-prose changes (every host): - office-hours: 'Fall back to <native> subagent.' becomes 'Fall back to the <native> subagent below.' - plan-devex-review: the plain 'Auth failure (stderr contains ...)' bullets become the canonical bold bullets; auth also triggers on 'API key'; 'auth failed' becomes 'authentication failed'. - review/ship adversarial: 'exceeded 9 minutes and was terminated' becomes 'timed out after 9 minutes and was terminated'; the timeout is still MISSING COVERAGE. - design outside voices: unchanged. Adds ratchet (d) (test/outside-voice-failure-policy.test.ts) with a reasoned allowlist for /codex's own CLI errors, the MISSING COVERAGE retention test, refreshed codex/factory ship goldens, and outside-voice.ts in every touchfile entry of review.ts and design.ts (selection golden extended). * test(pty): fake PTY session driver with an injectable clock through the runner launch seam The three plan-skill runners take an optional PtyDriver (launch, now, monotonic, sleep); omitted, they use the real launcher and clocks exactly as before. test/helpers/pty/fake-session.ts feeds scripted frames through that seam, and claude-pty-runner.runners.unit.test.ts runs observation, counting and floor for success, deadline timeout, permission prompt and plan-ready outcomes with no CLI or real timers. These cases must stay green unchanged through the W4 split and the runPtySession extraction. Touchfiles: every entry that lists claude-pty-runner.ts or pty-screen.ts now also lists test/helpers/pty/**. * refactor(shard-engine): run both lanes on the shared engine; lane policy injected Engine (scripts/lib/shard-engine.ts) gains the W2 primitives: per-shard tmp/Chromium sandbox + async cleanup backstop, log-path allocation and full-stream log capture, one duration-seed reader/writer with a lane predicate, LanePolicy (seed predicate + zero-execution verdict), strictShardStatus, and the shared CLI flag loop. runShardChild takes an optional companion (signal/settle) and waits a bounded 250ms to reap a wall-killed child. Free lane stops spawning shards itself: runFreeShard uses runShardChild with trackShardBrowser as the companion (win32 path unchanged: no process group, no negative-pid kill). Its sync state-dir removal stays lane policy. Paid lane uses the sandbox, log, seed, verdict and flag primitives; the hollow-shard guard applies PAID_LANE_POLICY. Lane outcomes are unchanged (free keeps >= 0 seeds and file-count zero-exec rule; paid keeps > 0 seeds, warning under selection and passed-empty under EVALS_ALL). paid-free-boundary's closure assertion now names the engine module, where the strict classifier lives. * test(shard-engine): engine unit tests, fixture-corpus equivalence, per-lane CLI parity - test/shard-engine.test.ts: failing/unhandled/module-load output fails both lanes, per-lane zero-execution and seed rules, whole-group kill on a wall timeout (both lanes), mocked-win32 path with no negative-pid kill, companion settle order, log capture, sandbox isolation, flag loop. - test/shard-engine-equivalence.test.ts + test/fixtures/shard-equivalence: seven outcome fixtures plus one real shard, run through both lanes and compared with classifications recorded from the base runners (96764e80). - test/shard-cli-parity.test.ts + test/fixtures/shard-cli-parity: flag set, defaults, validation errors and the Unknown argument error per lane match the base runners. * refactor(shard-engine): decompose runFreeShard and runPaidShard to <= 150 lines Output-neutral extraction under the fixture-corpus equivalence and runner tests: captureFreeStream, explainFreeVerdict and logFreeRecovery (free); paidShardCommand, settleShardSpool, settleBootstrapRetention and printLogTail (paid). The bootstrap scope-creation block that bootstrap-retention.test.ts evaluates stays verbatim. * refactor(pty): split claude-pty-runner.ts into test/helpers/pty/* behind a barrel Pure move: every line of the former 5,047-line runner lands verbatim in one module (four private helpers gain `export` for cross-module use): binary, screen (absorbs test/helpers/pty-screen.ts, which now re-exports it), launch, session (PtyDriver), judge, classify, auq, plan-native, boundaries, runners/{observation,counting,floor}. claude-pty-runner.ts re-exports the original public surface by name; pty/ modules import siblings directly. Tests that read the runner's source text: - rewritten as behavioral: the unit test's model-pin tripwire (fake CLI argv: fallback chain, --model before extraArgs, hermetic --strict-mcp-config), pty-skill-seeding-wiring (runners through the fake driver; launcher through a fake CLI reporting CLAUDE_CONFIG_DIR). The "three wrappers forward model" grep is replaced by the runners' fake-driver launch assertions. - pty-screen-session / pty-screen-supervision: stop copying runner source; they mock.module the real pty/screen.ts (and the fixture cleanup) instead. - re-pointed to the owning module (they execute a sliced runner body with injected boundaries; no seam exists for those boundaries yet): eng-seeded-completion-ai, plan-floor-permission, plan-create-prepublication, plan-count-completion; hermetic-wiring's source guard now reads pty/launch.ts and scans every pty/ module for raw process.env spreads. - plan-count-timeout and pty-output-wake mock the viewport at pty/screen.ts. * test(ratchet-c): enforcing module/function size ratchet and moved-code touchfile coverage Ratchet (c) ships enforcing: test/helpers/module-size.ts counts file and top-level function lengths by brace matching over masked source (strings, comments, regex literals and template text masked; ${} expressions kept), covering function declarations, arrow functions assigned to consts and route-table handler properties, with no parser dependency. Its self-test uses template literals and code-fence braces copied from scripts/resolvers/review.ts and design.ts. test/fixtures/module-size-ratchet.json binds scripts/lib/shard-engine.ts (<= 800 lines, <= 150 per function) and records the residual runner sizes (free 2352, paid 1921) as non-growth caps; allowlist entries are keyed on file plus matched text and need a reason. Failure output lists file:line, the rule, Fix: and the allowlist path. touchfiles.test.ts gains the moved-code superset check over test/fixtures/touchfile-move-goldens/ (W2 golden recorded at96764e80: test-strict-output.ts and test-paid-shards.ts global, test-free-shards.ts none). * refactor(browse): declared route table replaces the buildFetchHandler if-chain The ~1,300-line if-chain in buildFetchHandler becomes a route table: each entry declares method, path, auth kind and surfaces, and one auth gate in browse/src/routes/table.ts returns the per-kind denial (root-bearer, scoped, root-or-sse-cookie: 401 Unauthorized; root-token: 403 Root token required; extension-origin: 403 Forbidden). Unmatched requests take the declared fallthrough (root-bearer check, then plain-text 404). Handlers move to browse/src/routes/{core,pairing,pty,tokens,tunnel,activity,commands,files, inspector}.ts and receive a RouteContext with auth checks as functions instead of closing over factory locals. Dispatch order is unchanged: tunnel filter, beforeRoute overlay, gate, handler. TUNNEL_PATHS stays a literal in server.ts. Behavior-preserving: the black-box auth matrix from the previous commit passes unchanged. /memory and /inspector/events are declared root-bearer because the blanket check always ran before their SSE-cookie branch. Source-text route tests are rewritten as behavioral tests through buildFetchHandler or a route's real handler with a stub RouteContext (browse/test/route-test-harness.ts). Checks with no runtime seam are re-pointed to the route modules: Surface type, /inspector/events SSE helper, sanitizeReplacer imports, /pty-inject-scan sidecar-client import, and the ngrok config lookup and startTunnel wiring that stay in server.ts. * test(browse): stubbed-handler auth matrix and route inventory for the route table Every ROUTES entry runs through the real dispatcher and gate with stub handlers on each declared surface and six credentials; denials assert the exact status and body each auth kind returned at96764e8, admitted credentials assert the handler ran (with the gate's TokenInfo for scoped routes). Also pins the reviewed route inventory (method, path, auth kind, surfaces), that every entry declares auth and surfaces, that the table's tunnel paths equal the TUNNEL_PATHS literal with GET /connect admitted, the unmatched fallthrough, and that the root token is rejected on every tunnel route through buildFetchHandler. * test(browse): ratchet (b) keeps route dispatch inside the route table Scans browse/src/server.ts and browse/src/routes/*.ts for pathname comparisons; only the table matcher and the tunnel-surface filter are allowed, listed with reasons in browse/test/fixtures/route-dispatch-allowlist.json (keyed on file plus line text). Also checks every entry declares auth and surfaces and that gstack registers no beforeRoute overlay itself. Self-tests plant a violation and assert the file:line, Fix: and allowlist path in the message, that a shifted line stays allowlisted, and that a reasonless entry is rejected. * test: touchfile superset check for modules moved out of browse/src/server.ts Records the paid evals selected by touching browse/src/server.ts at96764e80(17 E2E, 1 LLM judge) and asserts every browse/src/routes/*.ts module selects a superset. The test reads every golden in test/fixtures/moved-module-selection/ so other moved-code goldens can sit beside it. * test(shard-engine): give non-timeout corpus fixtures CI headroom; keep the POSIX golden off the Windows lane Only the wall-timeout fixture keeps a 3s wall; the rest get 60s so a loaded host cannot turn a pass into a timeout. Base and branch runners still agree on every classification under the new walls. The Windows exclusion entry moves the free runner's ratchet (c) residual cap to 2356 lines. * refactor(pty): one runPtySession loop drives observation, counting and floor test/helpers/pty/session.ts owns launch -> start -> (poll -> tick)* -> timeout and the failure contract the three runners each hand-rolled: the run's own error wins over capture and close errors, close always runs, owned fixture cleanup runs last (also when launch fails). Each runner now supplies a PtySessionPlan: its boot/command step, poll cadence (2s observation/floor sleep; counting's output wake + 250ms coalesce), tick policy (permission handling, native identity, terminal rules stay per runner because they differ) and capture hooks. The runner bodies are decomposed into top-level steps so no function exceeds 150 lines; behavior is unchanged and the fake-driver cases from the first W4 commit pass unmodified. The counting capture step and the native completion-summary predicate are now named functions (countingCapture, isNativeCompletionSummary), so plan-create-prepublication and plan-count-completion call them directly instead of executing sliced source. The two harnesses that still execute a sliced runner body with injected boundaries (eng-seeded-completion-ai, plan-floor-permission) pass the PtyDriver seam instead of overriding Date/Bun.sleep. * test(ratchet-c): register route modules, review resolver modules and server.ts residual cap * refactor(pty): decompose launchClaudePty and engNumberedFindingAUQ under 150 lines launchClaudePty (349 lines) becomes launch preparation (args, hermetic child env, owned state roots), recorder creation, spawn, the trust-dialog watcher, close, and the session handle over one PtyProcess state object. The failure order is unchanged: abort the viewport, dispose any recorders created so far, dispose the viewport, rethrow. The --model / --strict-mcp-config ordering and seedSkills wiring stay pinned by the behavioral fake-CLI tests. engNumberedFindingAUQ (345 lines) keeps its guards and dispatch; each self-contained issue family (declared cache, library retry hooks, cache owner, injected singleton, shared writers, injected export) moves verbatim into its own function. Every pty/ module is now <= 800 lines and every top-level function <= 150 lines. * test(pty): split claude-pty-runner.unit.test.ts along the pty/ module seams The 188 unit tests move verbatim into claude-pty-runner.{screen,classify, auq,launch,plan-native,boundaries}.unit.test.ts (test names unchanged; each file imports only what it uses from the barrel). The five files that no longer read a SKILL.md template join the test-of-test ratchet baseline with a reason. * test(touchfiles): moved PTY modules keep their paid-eval selection test/fixtures/touchfile-selection/w4-pty.json records, at96764e8, the paid evals selected by touching test/helpers/claude-pty-runner.ts (20) and test/helpers/pty-screen.ts (20). touchfiles.test.ts now asserts every .ts file under test/helpers/pty/ (and pty/screen.ts for both sources) selects a superset, reading every golden in that directory so later moves can add one; a planted-violation case pins the report and its Fix line. * fix(browse): unexchanged pair setup keys no longer authenticate bearer requests validateToken accepted a gsk_setup_ key as a bearer on /command, /batch and /file (found while building the W3 auth matrix). A setup key now only authenticates the /connect exchange. * W1: one state-root owner (lib/state-root.ts + bin/gstack-state-root.sh), gstack-paths --explain and fail-stop, parity tests * W1: guarded migration of every executable state-root site; uninstall deletes only ~/.gstack Bins, careful/freeze hooks, setup, upgrade migrations, browse/src, design, ios-qa daemon, lib and scripts resolve the state root through bin/gstack-state-root.sh (bash) or lib/state-root.ts (TS). Bins source the twin and stop with a reinstall message when it is missing; hooks source it and never spawn gstack-paths. browse/src/config.ts and lib/cso/state.ts delegate to resolveStateRoot. Analytics writers and readers move together so the usage log stays one file. gstack-uninstall deletes state only at ~/.gstack, refuses (exit 2) when it resolves to /, $HOME or an ancestor, the checkout or the git root, and leaves any other resolved root in place with the removal command. Fixtures that copy single bins now copy the twin. * W1: privacy keys and trust-policy deny tiers merge across state roots; gstack-config reporting; test hermeticity readConfigKey / gstack_read_config_key return the most restrictive telemetry, memorable_recall, codex_reviews and update_check across the resolved root and ~/.gstack; other keys read the resolved root only. gstack-config set reports an overriding root with the exact override command, list shows the winning root and a root-variable disagreement line. gstack-gbrain-repo-policy get merges deny/read-only tiers. gstack-egress reads through readConfigKey. test-setup.ts strips inherited GSTACK_STATE_ROOT/GSTACK_STATE_DIR and redirects the legacy root. * W1: shared hook logging helper (hosts/claude/hooks/hook-log.ts) One hook-errors.log writer: root from resolveStateRoot, 0600 on every append, opt-in rate limit used only by memorable-user-prompt. The five hooks route through it. * W1: docs/state-root.md and README troubleshooting pointer Precedence table, a real --explain example, the move-your-state recipe, merged privacy keys, the uninstall rule, the resolver-failure fix, and the plugin-mode note (evidence gate: no official plugin distribution). * W1b: template and resolver prose resolve state through guarded gstack-paths; ratchet (a) Every gstack-paths eval in templates and resolvers carries the fail-stop guard; executable ~/.gstack paths in bash blocks (context recovery preamble, eureka log, analytics, project artifacts, upgrade snooze, setup-gbrain lock, retro snapshots, ship consent marker) use $GSTACK_STATE_ROOT, and the writer prose that pairs with them points at the printed PROJECT_DIR / RETRO_FILE. ship drops export GSTACK_STATE_ROOT. SKILL.md regenerated (claude + codex), ship goldens re-pinned, parity and context-budget caps raised to the measured sizes with notes. test/state-root-ratchet.test.ts enforces the rule with a reasoned allowlist; W1 touchfile entries plus a superset golden. * refactor: apply W1 state-root edits in W2/W3/W5-owned files; one moved-code touchfile golden for all workstreams * test: fold the moved-code touchfile golden into touchfiles.test.ts; fix integration fixture closure and caps * v1.91.11.0: CHANGELOG, TODOS, docs and conventions for the refactor wave * test: re-measure plan-ceo/design-consultation caps and ship goldens after the guarded plan-discovery and spec-review blocks; add the state-root twin to the workflow-boundaries fixture * fix(windows): migrations resolve their directory with either path separator; state-root parity compares under the HOME Git Bash actually sees * fix(review,ship): state plan-check timing after smoke expiry and test_stub Skip semantics (review workflow judge clarity) * test(qa-eval): webhook fix eval asks for the fix loop's post-repair probes; eight-scenario coverage stays in the report-only case and the harness recheck * test(qa-eval): re-pin the webhook prompt contract to the fix-loop stage; R29 coverage omissions stay bound by the report-only case * fix(review,ship): plan checks publish a checkpoint before each probe; only the smoke expiry stop is skipped * fix(qa): carry #2999's checkpoint receipt link, report-template line and full-revision placeholder (identical hunks) * test(qa-callers): disable git auto maintenance in the caller fixture Git 2.47+ runs auto maintenance detached after commit; on the CI runner's git 2.55 it rewrote .git/objects fan-out directories while the write observer was running, which surfaced as unauthorized mutations. Same gc.auto=0 / maintenance.auto=false guard the shared-libs fixture already uses. * test(plan-mode-no-op): require prose evidence for the prose-fallback members so a spinner-frame judge verdict cannot end the run as asked * test(ship-docsync): carry #2999's seeded-attempt docsync harness (identical files) The doc-sync fault cases replayed attempt 1 before reaching their gate and ran out of their 285s budget. The fixture now seeds attempt 1 and the parent starts at the gate under test. Taken byte-identical from origin/capy/audit-fix-wave (fb526898,e6ac813d,6ce10ff7,d0c53577,77cce3be). Local: stale-before, recovery and late-result 6/6 PASS (97-164s); the whole file 12/12 PASS.
528 lines
30 KiB
TypeScript
528 lines
30 KiB
TypeScript
/**
|
||
* runPlanSkillFloorCheck. Moved from claude-pty-runner.ts.
|
||
* Import through test/helpers/claude-pty-runner.ts from tests; pty/ modules import siblings directly.
|
||
*/
|
||
import * as fs from 'node:fs';
|
||
import * as path from 'node:path';
|
||
import { resolveEvalModel } from '../../../../lib/eval-model';
|
||
import { createPlanCountFixture } from '../../plan-count-fixture';
|
||
import { createPlanCountSnapshotWriter } from '../../plan-count-artifacts';
|
||
import { readPlanFloorTarget, type PlanFloorTargetDelivery } from '../../plan-floor-target';
|
||
import { judgePlanFloorReview, pickPlanFloorMode, pickPlanFloorProductType, type PlanFloorReview, type PlanFloorAssessment } from '../../plan-floor-review';
|
||
import { readPlanCountTranscript, type NativePlanQuestionCall, type PlanCountTranscript, type NativePublicToolEvent } from '../../plan-count-transcript';
|
||
import { readPendingQuestion, pendingQuestionRecorderStatus } from '../../plan-count-pending-question';
|
||
import { currentFilePermissionBinding, readPendingWriteInput, isCroppedEditPermissionVisible } from '../../plan-count-file-permission';
|
||
import { isDeepStrictEqual } from 'node:util';
|
||
import { randomUUID } from 'node:crypto';
|
||
import { capturePlanCountQuestion, createPlanCountPermissionGuard, matchesNativePlanQuestion, planCountPrerequisitePick, planCountQuestionInput } from '../auq';
|
||
import { resolveClaudeBinary } from '../binary';
|
||
import { designReviewSetupAUQ } from '../boundaries';
|
||
import { SANCTIONED_WRITE_SUBSTRINGS, isProseAUQVisible, planCountSubmissionInput } from '../classify';
|
||
import type { ClaudePtySession } from '../launch';
|
||
import { isNumberedOptionListVisible, isPermissionDialogVisible, isPlanReadyVisible, isRejectedSlashCommand, stripPtyResidue } from '../screen';
|
||
import { realPtyDriver, runPtySession, type PtyDriver, type PtyStep } from '../session';
|
||
|
||
// ────────────────────────────────────────────────────────────────────────────
|
||
// runPlanSkillFloorCheck — stop at the first substantive seeded question.
|
||
// Current owned input → complete question → evidence-backed assessment → outcome.
|
||
// Setup answers advance only the predeclared review interface. Findings are
|
||
// observed without answering them; permissions and generic waiting never count.
|
||
// The existing model-work deadline also bounds the replacement waiting judge.
|
||
// ────────────────────────────────────────────────────────────────────────────
|
||
|
||
export interface PlanSkillFloorObservation {
|
||
/** True iff a review-phase AUQ render was observed. */
|
||
auqObserved: boolean;
|
||
/** Owned native acknowledgment of the exact seeded target command. */
|
||
targetDelivery?: PlanFloorTargetDelivery;
|
||
outcome:
|
||
| 'auq_observed'
|
||
| 'plan_ready'
|
||
| 'silent_write'
|
||
| 'exited'
|
||
| 'timeout'
|
||
| 'assessment_error';
|
||
summary: string;
|
||
/** Public current viewport for an accepted finding; terminal tail otherwise. */
|
||
evidence: string;
|
||
/** Wall time (ms) until the outcome was decided. */
|
||
elapsedMs: number;
|
||
}
|
||
|
||
/**
|
||
* Drive a plan-* skill and qualify its first current seeded finding question.
|
||
* The actor answers only its declared optional-prerequisite, mode and product-type choices.
|
||
*/
|
||
/** DX's long empathy prompt needs its whole native pane, not an interior crop.
|
||
* Retain the actual header and complete pinned renderer prefix; the shared
|
||
* matcher still authenticates the pending question and native menu. */
|
||
export function planFloorDXPane(visible: string, call: NativePlanQuestionCall): string | null {
|
||
if (call.answered || call.failed || call.questions.length !== 1) return null;
|
||
const text = stripPtyResidue(visible).replace(/\r+\n?/g, '\n')
|
||
.replace(/((?:^|\n)Enter\s+to\s+select\s*·\s*↑\/↓\s+to\s+navigate\s*·\s*)ctrl\+g\s+to\s+edit\s+in[ \t]+[^\s·\x00-\x1f\x7f][^·\x00-\x1f\x7f]*?\s*·\s*(Esc\s+to\s+cancel\s*)$/, '$1$2');
|
||
const headers = [...text.matchAll(/(?:^|\n)[\t ]*[☐□][^\n]*\n/g)];
|
||
const header = headers.at(-1);
|
||
if (!header) return null;
|
||
const preceding = text.slice(0, header.index).trimEnd();
|
||
if (preceding && !/(?:^|\n)[ \t]*[─━]{10,}[ \t]*$/.test(preceding)) return null;
|
||
let fence: string | undefined;
|
||
for (const line of preceding.split('\n')) {
|
||
const marker = /^ {0,3}(`{3,}|~{3,})(.*)$/.exec(line);
|
||
if (!marker) continue;
|
||
if (!fence) fence = marker[1];
|
||
else if (marker[1]![0] === fence[0] && marker[1]!.length >= fence.length && !marker[2]!.trim()) fence = undefined;
|
||
}
|
||
if (fence) return null;
|
||
const pane = text.slice(header.index).trimStart();
|
||
const cursor = /(?:^|\n)❯\s*1\./.exec(pane);
|
||
if (!cursor) return null;
|
||
const body = pane.slice(pane.indexOf('\n') + 1, cursor.index)
|
||
.replace(/^[ \t]*[│┃] ?|[│┃][ \t]*$/gm, '').trim();
|
||
const compact = (value: string) => value.replace(/\s+/g, '');
|
||
const q = call.questions[0]!;
|
||
const displayed = q.question.length > 2000 ? q.question.slice(0, 2000) + '…' : q.question;
|
||
if (compact(body) !== compact(displayed) || !matchesNativePlanQuestion(pane, call)) return null;
|
||
return pane;
|
||
}
|
||
|
||
export interface PlanFloorDXReply {
|
||
call: NativePlanQuestionCall;
|
||
pane: string;
|
||
reply: string;
|
||
stage: 'focus' | 'paste' | 'submit' | 'done';
|
||
}
|
||
|
||
/** The native custom field focuses first, then accepts literal bracketed paste.
|
||
* Each step binds the same unanswered call and unchanged complete pane. */
|
||
export function planFloorDXReplyInput(visible: string, call: NativePlanQuestionCall,
|
||
state: PlanFloorDXReply): { input: string; stage: PlanFloorDXReply['stage'] } | null {
|
||
if (state.stage === 'done' || call.answered || call.failed || call.questions.length !== 1 ||
|
||
call.questions[0]!.multiSelect || call.sessionId !== state.call.sessionId || call.toolUseId !== state.call.toolUseId ||
|
||
!isDeepStrictEqual(call.questions, state.call.questions) || !state.reply.trim() || state.reply.length > 1400 ||
|
||
/[\x00-\x1f\x7f]/.test(state.reply)) return null;
|
||
const compact = (value: string) => value.replace(/\s+/g, '');
|
||
const index = call.questions[0]!.options.length + 1;
|
||
if (state.stage === 'focus') {
|
||
const pane = planFloorDXPane(visible, call);
|
||
if (!pane || compact(pane) !== compact(state.pane) ||
|
||
!new RegExp(`(?:^|\\n) ${index}\\. Type something\\.[ \\t]*(?:\\n|$)`).test(pane)) return null;
|
||
return { input: String(index), stage: 'paste' };
|
||
}
|
||
const lines = stripPtyResidue(visible).replace(/\r+\n?/g, '\n').split('\n');
|
||
const start = lines.findIndex(line => new RegExp(`^❯ ${index}\\. `).test(line));
|
||
if (start < 0 || lines.filter(line => /^❯ [1-9]\. /.test(line)).length !== 1) return null;
|
||
let end = start + 1;
|
||
while (end < lines.length && /^ {5}\S|^ {5,}\S/.test(lines[end]!)) end++;
|
||
const field = [lines[start]!.replace(new RegExp(`^❯ ${index}\\. `), ''),
|
||
...lines.slice(start + 1, end).map(line => line.trim())].join(' ').trim();
|
||
if (field !== (state.stage === 'paste' ? 'Type something.' : state.reply)) return null;
|
||
lines.splice(start, end - start, ` ${index}. Type something.`);
|
||
const first = lines.findIndex(line => /^ 1\. /.test(line));
|
||
if (first < 0) return null;
|
||
lines[first] = lines[first]!.replace(/^ 1\./, '❯ 1.');
|
||
const pane = planFloorDXPane(lines.map(line => line.replace(
|
||
/^(Enter to select · ↑\/↓ to navigate · (?:n to add notes · )?)ctrl\+g to edit in [^\x00-\x1f\x7f·]+ · (Esc to cancel)$/,
|
||
'$1$2')).join('\n'), call);
|
||
if (!pane || compact(pane) !== compact(state.pane)) return null;
|
||
return state.stage === 'paste'
|
||
? { input: '\x1b[200~' + state.reply + '\x1b[201~', stage: 'submit' }
|
||
: { input: '\r', stage: 'done' };
|
||
}
|
||
|
||
/** Options for runPlanSkillFloorCheck. */
|
||
export interface PlanSkillFloorOptions {
|
||
/** Skill name, e.g. 'plan-eng-review'. Used for diagnostic strings only. */
|
||
skillName: string;
|
||
/** Slash command; the owned PLAN.md target is supplied in the same submission. */
|
||
slashCommand: string;
|
||
/** Complete request seeded in an isolated project before the command starts. */
|
||
followUpPrompt: string;
|
||
/** Explicit working-plan request relocated into the owned fixture before launch. */
|
||
requestedPlanPath?: string;
|
||
/** Predeclared DX fixture classification; never inferred from a recommendation. */
|
||
productType?: 'sdk-documentation';
|
||
/** Literal persona/journey correction declared before DX setup; approves no offered remedy. */
|
||
devexSetupContext?: string;
|
||
/** Installation cwd retained for caller compatibility; review uses an owned seeded project. */
|
||
cwd?: string;
|
||
/** Total budget. Default 600000 (10 min). Tests exit early on AUQ. */
|
||
timeoutMs?: number;
|
||
/** Extra env merged into the spawned `claude` process. */
|
||
env?: Record<string, string>;
|
||
/** Override the spawned model. Defaults via launchClaudePty's chain. */
|
||
model?: string;
|
||
/** Launch seam and clock; tests pass the fake driver. Default: real launcher and clocks. */
|
||
driver?: PtyDriver;
|
||
}
|
||
|
||
export async function runPlanSkillFloorCheck(opts: PlanSkillFloorOptions): Promise<PlanSkillFloorObservation> {
|
||
const driver = opts.driver ?? realPtyDriver;
|
||
const startedAt = driver.now();
|
||
const timeoutMs = opts.timeoutMs ?? 600_000;
|
||
const dxContext = opts.devexSetupContext;
|
||
if (dxContext !== undefined && (opts.skillName !== 'plan-devex-review' || opts.productType !== 'sdk-documentation' ||
|
||
!dxContext.trim() || dxContext.length > 1400 || /[\x00-\x1f\x7f]/.test(dxContext)))
|
||
throw Error('DX setup context requires the declared SDK-documentation actor and a bounded literal single line');
|
||
|
||
const request = [
|
||
'Proceed directly to the requested review; skip the optional /office-hours prerequisite.',
|
||
'This actor has already declined routing setup, cross-project recall and outside reviewers.',
|
||
'Preserve the supplied product scope. For review-mode questions choose HOLD SCOPE (CEO), DX POLISH (DX), or the full BIG CHANGE review (Eng). Design: review all seven dimensions.',
|
||
...(opts.productType === 'sdk-documentation' ? [
|
||
'Product type is confirmed: SDK quickstart documentation, with the complete journey to the first SDK call as context. If asked to classify, choose SDK + Docs when offered, otherwise Documentation. This confirms the review lens; it does not expand the plan.',
|
||
'Target persona is confirmed: a hands-on developer integrating this SDK for the first time, trying to make one successful call. Product type and persona setup are already answered; proceed to reviewing the supplied plan.',
|
||
] : []),
|
||
...(dxContext ? ['For setup confirmations, this actor can supply only the following persona/journey correction through the native custom answer. It does not approve a proposed narrative, remedy, or scope change: ' + dxContext] : []),
|
||
opts.followUpPrompt,
|
||
].join('\n\n');
|
||
const fixture = createPlanCountFixture(request, { requestedPlanPath: opts.requestedPlanPath,
|
||
nativeReviewOnly: true, preconfiguredReviewActor: true });
|
||
const sessionId = randomUUID();
|
||
const run = { opts, driver, startedAt, timeoutMs, dxContext, fixture, sessionId,
|
||
ownedFilePermissions: [], planningDirectory: undefined, transcript: { status: 'missing', calls: [], assistantMessages: [] },
|
||
viewport: '', publicTools: [], pendingQuestion: undefined, floorReview: undefined, floorAssessment: undefined,
|
||
setupChoices: new Map(), submittedSetup: new Set(), assessed: new Map(), dxReplies: new Map(),
|
||
since: 0, commandStartedAt: 0, targetDelivery: undefined, saveSnapshot: undefined, nativeCandidates: [],
|
||
validatedPendingQuestion: undefined, sampledAt: undefined, lastCheckpointAt: 0, lastCheckpointState: '',
|
||
artifactError: undefined, finished: false, started: false, start: 0, deadlineAt: 0, screenDeadlineAt: 0,
|
||
} as unknown as FloorRun;
|
||
return runPtySession<PlanSkillFloorObservation>({
|
||
driver,
|
||
cleanup: () => fixture.cleanup(),
|
||
launch: {
|
||
permissionMode: 'plan',
|
||
cwd: fixture.cwd,
|
||
timeoutMs: timeoutMs + 60_000,
|
||
env: { ...opts.env, ...fixture.env },
|
||
model: opts.model,
|
||
seedSkills: true,
|
||
observeScreen: true,
|
||
observeSetupQuestions: true,
|
||
...(dxContext ? { rows: 80 } : {}),
|
||
observeFilePermissions: fixture.workingPlanPath ? [fixture.workingPlanPath] : undefined,
|
||
extraArgs: ['--session-id', sessionId],
|
||
},
|
||
start: session => floorStart(run, session),
|
||
poll: async () => {
|
||
if (!(driver.now() - run.start < timeoutMs)) return false;
|
||
await driver.sleep(2000);
|
||
return true;
|
||
},
|
||
tick: session => floorTick(run, session),
|
||
timeout: session => floorFinish(run, session, {
|
||
auqObserved: false,
|
||
outcome: 'timeout',
|
||
summary: run.targetDelivery.status === 'ready'
|
||
? `no qualifying finding question within ${timeoutMs}ms`
|
||
: `seeded target delivery unavailable within ${timeoutMs}ms: ${run.targetDelivery.reason ?? run.targetDelivery.status}`,
|
||
evidence: session.visibleSince(run.since).slice(-3000),
|
||
elapsedMs: driver.now() - startedAt,
|
||
}),
|
||
beforeClose: (session, failure) => floorBeforeClose(run, session, failure),
|
||
});
|
||
}
|
||
|
||
/** Mutable state of one floor attempt, shared by its session-loop steps. */
|
||
interface FloorRun {
|
||
opts: PlanSkillFloorOptions;
|
||
driver: PtyDriver;
|
||
startedAt: number;
|
||
timeoutMs: number;
|
||
dxContext: string | undefined;
|
||
fixture: ReturnType<typeof createPlanCountFixture>;
|
||
sessionId: string;
|
||
ownedFilePermissions: Array<{ expected: string; file: string; guard: ReturnType<typeof createPlanCountPermissionGuard> }>;
|
||
planningDirectory: string | undefined;
|
||
transcript: PlanCountTranscript;
|
||
viewport: string;
|
||
publicTools: NativePublicToolEvent[];
|
||
pendingQuestion: NativePlanQuestionCall | undefined;
|
||
floorReview: PlanFloorReview | undefined;
|
||
floorAssessment: PlanFloorAssessment | undefined;
|
||
setupChoices: Map<string, Set<number>>;
|
||
submittedSetup: Set<string>;
|
||
assessed: Map<string, PlanFloorAssessment>;
|
||
dxReplies: Map<string, PlanFloorDXReply>;
|
||
since: number;
|
||
commandStartedAt: number;
|
||
deliveryOptions: { seed: string; sessionId: string; slashCommand: string; startedAt: number };
|
||
targetDelivery: PlanFloorTargetDelivery;
|
||
saveSnapshot: ReturnType<typeof createPlanCountSnapshotWriter>;
|
||
nativeCandidates: NativePlanQuestionCall[];
|
||
validatedPendingQuestion: ReturnType<typeof readPendingQuestion>;
|
||
sampledAt: number | undefined;
|
||
lastCheckpointAt: number;
|
||
lastCheckpointState: string;
|
||
artifactError: string | undefined;
|
||
finished: boolean;
|
||
/** Command sent and capture state ready; before-close capture applies from here. */
|
||
started: boolean;
|
||
/** Loop start after the command; the finding clock and assessment deadline. */
|
||
start: number;
|
||
deadlineAt: number;
|
||
screenDeadlineAt: number;
|
||
}
|
||
|
||
async function floorStart(run: FloorRun, session: ClaudePtySession): Promise<undefined> {
|
||
const { opts, driver, fixture } = run;
|
||
run.ownedFilePermissions = (session.pendingFilePermissionFiles ?? []).map(binding =>
|
||
({ ...binding, guard: createPlanCountPermissionGuard() }));
|
||
run.planningDirectory = session.hermeticConfigDir ? path.join(session.hermeticConfigDir, 'plans') : undefined;
|
||
await driver.sleep(8000); // boot grace + auto-trust handler window
|
||
run.since = session.mark();
|
||
run.commandStartedAt = driver.now();
|
||
session.send(`${opts.slashCommand} PLAN.md\r`);
|
||
run.deliveryOptions = { seed: fixture.seed, sessionId: run.sessionId,
|
||
slashCommand: opts.slashCommand, startedAt: run.commandStartedAt };
|
||
run.targetDelivery = readPlanFloorTarget(session.hermeticConfigDir, fixture.cwd,
|
||
{ ...run.deliveryOptions, now: driver.now() });
|
||
run.saveSnapshot = createPlanCountSnapshotWriter();
|
||
run.started = true;
|
||
run.start = driver.now();
|
||
run.deadlineAt = run.start + run.timeoutMs;
|
||
run.screenDeadlineAt = driver.monotonic() + run.timeoutMs;
|
||
return undefined;
|
||
}
|
||
|
||
function floorCapture(run: FloorRun, session: ClaudePtySession, observation: object) {
|
||
const { fixture } = run;
|
||
const recorderStatus = pendingQuestionRecorderStatus(session.pendingQuestionFile, fixture.cwd, session.hermeticConfigDir);
|
||
const artifacts = run.saveSnapshot({ skillName: run.opts.skillName, cwd: fixture.cwd,
|
||
claudeConfigDir: session.hermeticConfigDir, raw: session.rawOutput(),
|
||
visible: session.visibleSince(run.since), viewport: run.viewport,
|
||
observation: { ...observation, transcript: run.transcript, publicTools: run.publicTools, pendingQuestion: run.pendingQuestion,
|
||
floorReview: run.floorReview, floorAssessment: run.floorAssessment, targetDelivery: run.targetDelivery, commandStartedAt: run.commandStartedAt,
|
||
pendingWriteInputs: run.ownedFilePermissions.flatMap(binding => {
|
||
const input = readPendingWriteInput(binding.file, binding.expected, fixture.cwd, session.hermeticConfigDir, run.startedAt);
|
||
return input ? [input] : [];
|
||
}),
|
||
questionDiagnostics: { sampledAt: run.sampledAt, parentSessionId: run.sessionId, recorderStatus, recorderStatusAt: run.driver.now(),
|
||
nativeCandidates: run.nativeCandidates, validatedPendingQuestion: run.validatedPendingQuestion },
|
||
...(run.dxContext ? { setupContextReplies: [...run.dxReplies.values()] } : {}), artifactError: run.artifactError } });
|
||
if (artifacts.artifactError) {
|
||
run.artifactError ??= artifacts.artifactError;
|
||
console.error(`PTY artifact write failed: ${artifacts.artifactError}`);
|
||
}
|
||
return { ...artifacts, ...(run.artifactError ? { artifactError: run.artifactError } : {}) };
|
||
}
|
||
|
||
function floorCheckpoint(run: FloorRun, session: ClaudePtySession): void {
|
||
const state = JSON.stringify([pendingQuestionRecorderStatus(session.pendingQuestionFile, run.fixture.cwd, session.hermeticConfigDir),
|
||
run.targetDelivery.status, run.nativeCandidates, run.validatedPendingQuestion, run.pendingQuestion, [...run.dxReplies.values()]]);
|
||
if (state === run.lastCheckpointState && run.driver.now() - run.lastCheckpointAt < 15_000) return;
|
||
run.lastCheckpointState = state; run.lastCheckpointAt = run.driver.now();
|
||
floorCapture(run, session, { state: 'in_progress', elapsedMs: run.driver.now() - run.startedAt });
|
||
}
|
||
|
||
function floorBeforeClose(run: FloorRun, session: ClaudePtySession, failure: { error: unknown } | undefined): void {
|
||
if (!run.started) return;
|
||
if (failure && session.hermeticConfigDir) {
|
||
const publicTools: NativePublicToolEvent[] = [];
|
||
run.publicTools = publicTools;
|
||
run.transcript = readPlanCountTranscript(session.hermeticConfigDir, run.fixture.cwd, event => publicTools.push(event));
|
||
}
|
||
if (!run.finished) floorCapture(run, session, { state: failure ? 'threw' : 'in_progress', error: failure ? String(failure.error) : undefined,
|
||
captureReason: 'before_cleanup', elapsedMs: run.driver.now() - run.startedAt });
|
||
}
|
||
|
||
function floorFinish(run: FloorRun, session: ClaudePtySession, observation: PlanSkillFloorObservation): PlanSkillFloorObservation {
|
||
const artifacts = floorCapture(run, session, observation);
|
||
run.finished = true;
|
||
return { ...observation, targetDelivery: run.targetDelivery, ...artifacts };
|
||
}
|
||
|
||
async function floorTick(run: FloorRun, session: ClaudePtySession): Promise<PtyStep<PlanSkillFloorObservation>> {
|
||
const { opts, driver, fixture, sessionId } = run;
|
||
const visible = session.visibleSince(run.since);
|
||
const finish = (observation: PlanSkillFloorObservation) => ({ done: floorFinish(run, session, observation) });
|
||
if (session.exited()) return finish({ auqObserved: false, outcome: 'exited',
|
||
summary: `claude exited (code=${session.exitCode()}) before a qualifying finding`,
|
||
evidence: visible.slice(-3000), elapsedMs: driver.now() - run.startedAt });
|
||
if (isRejectedSlashCommand(visible, opts.slashCommand)) return finish({ auqObserved: false, outcome: 'exited',
|
||
summary: `claude rejected ${opts.slashCommand} as unknown command`,
|
||
evidence: visible.slice(-3000), elapsedMs: driver.now() - run.startedAt });
|
||
|
||
if (run.targetDelivery.status !== 'ready') {
|
||
run.targetDelivery = readPlanFloorTarget(session.hermeticConfigDir, fixture.cwd,
|
||
{ ...run.deliveryOptions, now: driver.now() });
|
||
if (run.targetDelivery.status !== 'ready') {
|
||
run.viewport = await session.currentScreen(run.screenDeadlineAt);
|
||
floorCheckpoint(run, session);
|
||
return 'continue';
|
||
}
|
||
}
|
||
|
||
// Current native identity precedes permission handling and finding assessment.
|
||
run.floorReview = undefined; run.floorAssessment = undefined;
|
||
run.viewport = await session.currentScreen(run.screenDeadlineAt);
|
||
const publicTools: NativePublicToolEvent[] = [];
|
||
run.publicTools = publicTools;
|
||
run.transcript = session.hermeticConfigDir
|
||
? readPlanCountTranscript(session.hermeticConfigDir, fixture.cwd, event => publicTools.push(event))
|
||
: { status: 'missing', calls: [], assistantMessages: [] };
|
||
const hook = readPendingQuestion(session.pendingQuestionFile, fixture.cwd,
|
||
session.hermeticConfigDir, run.commandStartedAt, run.transcript);
|
||
const currentCalls = run.transcript.status === 'ready' ? run.transcript.calls.filter(call =>
|
||
call.sessionId === sessionId && !call.answered && !call.failed && publicTools.filter(event =>
|
||
event.sessionId === sessionId && event.kind === 'use' && event.name === 'AskUserQuestion' &&
|
||
event.toolUseId === call.toolUseId && Date.parse(event.timestamp) >= run.commandStartedAt &&
|
||
Date.parse(event.timestamp) <= driver.now() && isDeepStrictEqual(event.input?.questions, call.questions)).length === 1) : [];
|
||
run.nativeCandidates = currentCalls.slice();
|
||
run.validatedPendingQuestion = hook;
|
||
run.sampledAt = driver.now();
|
||
if (hook?.sessionId === sessionId && !run.transcript.calls.some(call => call.toolUseId === hook.toolUseId)) currentCalls.push(hook);
|
||
const activeReply = currentCalls.length === 1 && run.dxReplies.get(`${currentCalls[0]!.sessionId}:${currentCalls[0]!.toolUseId}`);
|
||
if (activeReply) {
|
||
run.pendingQuestion = undefined;
|
||
const next = planFloorDXReplyInput(run.viewport, currentCalls[0]!, activeReply);
|
||
if (next) { session.send(next.input); activeReply.stage = next.stage; }
|
||
floorCheckpoint(run, session);
|
||
return 'continue';
|
||
}
|
||
const matching = currentCalls.filter(call => run.dxContext
|
||
? planFloorDXPane(run.viewport, call) !== null : matchesNativePlanQuestion(run.viewport, call, run.planningDirectory));
|
||
run.pendingQuestion = matching.length === 1 ? matching[0] : undefined;
|
||
floorCheckpoint(run, session);
|
||
if (floorPermission(run, session)) return 'continue';
|
||
const question = floorQuestion(run, session, currentCalls);
|
||
if (question) return question;
|
||
return floorAssess(run, session, visible);
|
||
}
|
||
|
||
/** An authorized owned file write enables the review, but never supplies its
|
||
* finding question. True when an active permission render owns this tick. */
|
||
function floorPermission(run: FloorRun, session: ClaudePtySession): boolean {
|
||
const { fixture, viewport } = run;
|
||
const permissionIsActiveRender = !run.pendingQuestion &&
|
||
(isPermissionDialogVisible(viewport) || isCroppedEditPermissionVisible(viewport));
|
||
if (!permissionIsActiveRender) return false;
|
||
// Exclude the permission's old render after approval.
|
||
const owned = currentFilePermissionBinding(run.ownedFilePermissions, fixture.cwd,
|
||
session.hermeticConfigDir, run.startedAt, run.transcript, viewport);
|
||
let ordinaryOwnedTarget = false;
|
||
if (fixture.workingPlanPath) try {
|
||
const parent = fs.realpathSync(path.dirname(fixture.workingPlanPath));
|
||
let target: fs.Stats | undefined;
|
||
try { target = fs.lstatSync(fixture.workingPlanPath); }
|
||
catch (error) { if ((error as NodeJS.ErrnoException).code !== 'ENOENT') throw error; }
|
||
ordinaryOwnedTarget = parent === fs.realpathSync(fixture.cwd) && (!target || target.isFile());
|
||
} catch { /* No authority for a linked, foreign, or unreadable target. */ }
|
||
if (owned && ordinaryOwnedTarget && owned.binding.guard(viewport, session.visibleText(), owned.epoch) === 'grant')
|
||
session.send('1\r');
|
||
return true;
|
||
}
|
||
|
||
/** Answer declared setup choices; otherwise stage the current question (native
|
||
* or complete prose) as the floor review candidate. A step ends this tick. */
|
||
function floorQuestion(run: FloorRun, session: ClaudePtySession, currentCalls: NativePlanQuestionCall[]): PtyStep<PlanSkillFloorObservation> | undefined {
|
||
const { opts, fixture, viewport, pendingQuestion } = run;
|
||
const questionViewport = run.dxContext && pendingQuestion ? planFloorDXPane(viewport, pendingQuestion)! : viewport;
|
||
const fp = pendingQuestion && capturePlanCountQuestion(questionViewport, new Set(), run.driver.now() - run.start, true, pendingQuestion, run.planningDirectory);
|
||
if (fp && pendingQuestion) {
|
||
const index = fp.nativeQuestionIndex ?? 0;
|
||
const question = pendingQuestion.questions[index]!;
|
||
const key = `${pendingQuestion.sessionId}:${pendingQuestion.toolUseId}`;
|
||
const chosen = run.setupChoices.get(key) ?? new Set<number>();
|
||
const allDesign = opts.skillName === 'plan-design-review' && designReviewSetupAUQ(fp)
|
||
? question.options.flatMap((option, i) => /^(?:Review )?All 7 (?:design )?(?:dimensions|passes)(?:\s*\(recommended\))?$/i.test(option.label.trim()) ? [i + 1] : []) : [];
|
||
const pick = pickPlanFloorMode(opts.skillName, question) ?? planCountPrerequisitePick(fp, fp)
|
||
?? (opts.skillName === 'plan-devex-review' ? pickPlanFloorProductType(question, opts.productType) : null)
|
||
?? (allDesign.length === 1 ? allDesign[0]! : null);
|
||
if (pick !== null) {
|
||
if (!chosen.has(index)) {
|
||
session.send(planCountQuestionInput(viewport, fp, pick));
|
||
chosen.add(index); run.setupChoices.set(key, chosen);
|
||
}
|
||
return 'continue';
|
||
}
|
||
run.floorReview = { seed: fixture.seed, candidate: { transport: 'native', identity: `${key}:question:${index}`,
|
||
question: structuredClone(question) } };
|
||
return undefined;
|
||
}
|
||
// Public fallback must be a complete current question, not scrollback,
|
||
// a generic idle prompt, permission, tool result or quoted example.
|
||
run.floorReview = undefined;
|
||
const message = run.transcript.assistantMessages.filter(m => m.sessionId === run.sessionId &&
|
||
Date.parse(m.timestamp) >= run.commandStartedAt && Date.parse(m.timestamp) <= run.driver.now()).at(-1);
|
||
const compact = (text: string) => text.replace(/\s+/g, '');
|
||
if (!currentCalls.length && message && isProseAUQVisible(viewport) && isProseAUQVisible(message.text) &&
|
||
!/^\s*(?:>|`{3,}|~{3,})/m.test(message.text) && compact(viewport).includes(compact(message.text)))
|
||
run.floorReview = { seed: fixture.seed, candidate: { transport: 'prose',
|
||
identity: `${message.sessionId}:${message.timestamp}`, text: message.text } };
|
||
const submit = planCountSubmissionInput(viewport);
|
||
const packet = currentCalls.find(call => run.setupChoices.get(`${call.sessionId}:${call.toolUseId}`)?.size === call.questions.length);
|
||
if (submit && packet) {
|
||
const key = `${packet.sessionId}:${packet.toolUseId}`;
|
||
if (!run.submittedSetup.has(key)) { session.send(submit); run.submittedSetup.add(key); }
|
||
return 'continue';
|
||
}
|
||
return undefined;
|
||
}
|
||
|
||
/** Assess a staged candidate once; then the silent-write and plan-ready terminals. */
|
||
function floorAssess(run: FloorRun, session: ClaudePtySession, visible: string): PtyStep<PlanSkillFloorObservation> {
|
||
const { driver, floorReview, pendingQuestion } = run;
|
||
const finish = (observation: PlanSkillFloorObservation) => ({ done: floorFinish(run, session, observation) });
|
||
if (floorReview) {
|
||
const key = JSON.stringify(floorReview);
|
||
run.floorAssessment = run.assessed.get(key);
|
||
if (!run.floorAssessment) {
|
||
try {
|
||
run.floorAssessment = judgePlanFloorReview(floorReview, {
|
||
binary: resolveClaudeBinary() ?? 'claude', model: resolveEvalModel('warmup'), deadlineAt: run.deadlineAt });
|
||
} catch (error) {
|
||
return finish({ auqObserved: false, outcome: 'assessment_error',
|
||
summary: `Finding assessment failed: ${error instanceof Error ? error.message : String(error)}`,
|
||
evidence: run.viewport, elapsedMs: driver.now() - run.startedAt });
|
||
}
|
||
run.assessed.set(key, run.floorAssessment);
|
||
}
|
||
if (run.dxContext && run.floorAssessment.kind === 'setup' && pendingQuestion?.questions.length === 1 &&
|
||
!pendingQuestion.questions[0]!.multiSelect && floorReview.candidate.transport === 'native') {
|
||
const replyKey = `${pendingQuestion.sessionId}:${pendingQuestion.toolUseId}`;
|
||
const questionViewport = planFloorDXPane(run.viewport, pendingQuestion)!;
|
||
run.dxReplies.set(replyKey, { call: structuredClone(pendingQuestion), pane: questionViewport, reply: run.dxContext, stage: 'focus' });
|
||
}
|
||
if (run.floorAssessment.kind === 'finding') return finish({
|
||
auqObserved: true, outcome: 'auq_observed',
|
||
summary: `Current ${floorReview.candidate.transport} question addresses the owned seeded finding: ${run.floorAssessment.reason}`,
|
||
evidence: run.viewport, elapsedMs: driver.now() - run.startedAt,
|
||
});
|
||
}
|
||
|
||
// Silent write outside sanctioned dirs is the transcript-bug shape.
|
||
const writeRe = /⏺\s*(?:Write|Edit)\(([^)]+)\)/g;
|
||
let m: RegExpExecArray | null;
|
||
while ((m = writeRe.exec(visible)) !== null) {
|
||
const target = m[1] ?? '';
|
||
const sanctioned = SANCTIONED_WRITE_SUBSTRINGS.some((s) => target.includes(s));
|
||
if (!sanctioned && !isNumberedOptionListVisible(visible)) {
|
||
return finish({
|
||
auqObserved: false,
|
||
outcome: 'silent_write',
|
||
summary: `Write/Edit to ${target} fired before any AskUserQuestion`,
|
||
evidence: visible.slice(-3000),
|
||
elapsedMs: driver.now() - run.startedAt,
|
||
});
|
||
}
|
||
}
|
||
|
||
// Reached terminal without AUQ → transcript-bug regression.
|
||
// Note: COMPLETION_SUMMARY_RE is intentionally NOT checked here — it
|
||
// matches "GSTACK REVIEW REPORT" anywhere in the buffer, including
|
||
// when the agent does recon by reading existing plan files (which
|
||
// contain that string as a generated section). The plan_ready check
|
||
// (claude's actual "Ready to execute" confirmation) is the reliable
|
||
// terminal signal for "agent finished without asking."
|
||
if (isPlanReadyVisible(visible)) {
|
||
return finish({
|
||
auqObserved: false,
|
||
outcome: 'plan_ready',
|
||
summary: 'agent reached plan_ready without a qualifying finding question',
|
||
evidence: visible.slice(-3000),
|
||
elapsedMs: driver.now() - run.startedAt,
|
||
});
|
||
}
|
||
return 'continue';
|
||
}
|