Files
gstack/browse/test/find-browse.test.ts
T
Garry Tan 07b4e15b34 feat: v0.3.2 — project-local state, diff-aware QA, Greptile integration (#36)
* fix: cookie import picker returns JSON instead of HTML

jsonResponse() was defined at module scope but referenced `url` which
only existed as a parameter of handleCookiePickerRoute(). Every API call
crashed, the catch block also crashed, and Bun returned a default HTML
page that the frontend couldn't parse as JSON.

Thread port via corsOrigin() helper and options objects. Add route-level
tests to prevent this class of bug from shipping again.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* feat: add help command to browse server

Agents that don't have SKILL.md loaded (or misread flags) had no way to
self-discover the CLI. The help command returns a formatted reference of
all commands and snapshot flags.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* feat: version-aware find-browse with META signal protocol

Agents in other workspaces found stale browse binaries that were missing
newer flags. find-browse now compares the local binary's git SHA against
origin/main via git ls-remote (4hr cache), and emits META:UPDATE_AVAILABLE
when behind. SKILL.md setup checks parse META signals and prompt the user
to update.

- New compiled binary: browse/dist/find-browse (TypeScript, testable)
- Bash shim at browse/bin/find-browse delegates to compiled binary
- .version file written at build time with git commit SHA
- Build script compiles both browse and find-browse binaries
- Graceful degradation: offline, missing .version, corrupt cache all skip check

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* chore: clean up .bun-build temp files after compile

bun build --compile leaves ~58MB temp files in the working directory.
Add rm -f .*.bun-build to the build script to clean up after each build.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* fix: make help command reachable by removing it from META_COMMANDS

help was in META_COMMANDS, so it dispatched to handleMetaCommand() which
threw "Unknown meta command: help". Removing it from the set lets the
dedicated else-if handler in handleCommand() execute correctly.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* chore: bump version and changelog (v0.3.2)

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* feat: add shared Greptile comment triage reference doc

Shared reference for fetching, filtering, and classifying Greptile
review comments on GitHub PRs. Used by both /review and /ship skills.
Includes parallel API fetching, suppressions check, classification
logic, reply APIs, and history file writes.

* feat: make /review and /ship Greptile-aware

/review: Step 2.5 fetches and classifies Greptile comments, Step 5
resolves them with AskUserQuestion for valid issues and false positives.

/ship: Step 3.75 triages Greptile comments between pre-landing review
and version bump. Adds Greptile Review section to PR body in Step 8.
Re-runs tests if any Greptile fixes are applied.

* feat: add Greptile batting average to /retro

Reads ~/.gstack/greptile-history.md, computes signal ratio
(valid catches vs false positives), includes in metrics table,
JSON snapshot, and Code Quality Signals narrative.

* docs: add Greptile integration section to README

Personal endorsement, two-layer review narrative, full UX walkthrough
transcript, skills table updates. Add Greptile training feedback loop
to TODO.md future ideas.

* feat: add local dev mode for testing skills from within the repo

bin/dev-setup creates .claude/skills/gstack symlink to the working tree
so Claude Code discovers skills locally. bin/dev-teardown cleans up.
DEVELOPING_GSTACK.md documents the workflow.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* fix: narrow gitignore to .claude/skills/ instead of all .claude/

Avoids ignoring legitimate Claude Code config like settings.json or CLAUDE.md.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* docs: rename DEVELOPING_GSTACK.md to CONTRIBUTING.md

Rewritten as a contributor-friendly guide instead of a dry plan doc.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* docs: explain why dev-setup is needed in CONTRIBUTING.md quick start

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* feat: add browser interaction guidance to CLAUDE.md

Prevents Claude from using mcp__claude-in-chrome__* tools instead of /browse.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* feat: add shared config module for project-local browse state

Centralizes path resolution (git root detection, state dir, log paths) into
config.ts. Both cli.ts and server.ts import from it, eliminating duplicated
PORT_OFFSET/BROWSE_PORT/STATE_FILE logic.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* feat: rewrite port selection to use random ports

Replace CONDUCTOR_PORT magic offset and 9400-9409 scan with random port
10000-60000. Atomic state file writes, log paths from config module,
binaryVersion field for auto-restart on update.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* feat: move browse state from /tmp to project-local .gstack/

CLI now uses config module for state paths, passes BROWSE_STATE_FILE to
spawned server. Adds version mismatch auto-restart, legacy /tmp cleanup
with PID verification, and removes stale global install fallback.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* fix: update crash log path reference to .gstack/

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* test: add config tests and update CLI lifecycle test

14 new tests for config resolution, ensureStateDir, readVersionHash,
resolveServerScript, and version mismatch detection. Remove obsolete
CONDUCTOR_PORT/BROWSE_PORT filtering from commands.test.ts.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* docs: update BROWSER.md and TODO.md for project-local state

Replace /tmp paths with .gstack/, remove CONDUCTOR_PORT docs, document
random port selection and per-project isolation. Add server bundling TODO.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* docs: update README, CHANGELOG, and CONTRIBUTING for v0.3.2

- README: replace Conductor-aware language with project-local isolation,
  add Greptile setup note
- CHANGELOG: comprehensive v0.3.2 entry with all state management changes
- CONTRIBUTING: add instructions for testing branches in other repos

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* feat: add diff-aware mode to /qa — auto-tests affected pages from branch diff

When on a feature branch, /qa now reads git diff main, identifies affected
pages/routes from changed files, and tests them automatically. No URL required.
The most natural flow: write code, /ship, /qa.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* chore: update CHANGELOG for complete v0.3.2 coverage

Add missing entries: diff-aware QA mode, Greptile integration,
local dev mode, crash log path fix, README/SKILL.md updates.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-13 18:10:56 -07:00

145 lines
5.4 KiB
TypeScript

/**
* Tests for find-browse version check logic
*
* Tests the checkVersion() and locateBinary() functions directly.
* Uses temp directories with mock .version files and cache files.
*/
import { describe, test, expect, beforeEach, afterEach } from 'bun:test';
import { checkVersion, locateBinary } from '../src/find-browse';
import { mkdtempSync, writeFileSync, rmSync, existsSync, mkdirSync } from 'fs';
import { join } from 'path';
import { tmpdir } from 'os';
let tempDir: string;
beforeEach(() => {
tempDir = mkdtempSync(join(tmpdir(), 'find-browse-test-'));
});
afterEach(() => {
rmSync(tempDir, { recursive: true, force: true });
// Clean up test cache
try { rmSync('/tmp/gstack-latest-version'); } catch {}
});
describe('checkVersion', () => {
test('returns null when .version file is missing', () => {
const result = checkVersion(tempDir);
expect(result).toBeNull();
});
test('returns null when .version file is empty', () => {
writeFileSync(join(tempDir, '.version'), '');
const result = checkVersion(tempDir);
expect(result).toBeNull();
});
test('returns null when .version has only whitespace', () => {
writeFileSync(join(tempDir, '.version'), ' \n');
const result = checkVersion(tempDir);
expect(result).toBeNull();
});
test('returns null when local SHA matches remote (cache hit)', () => {
const sha = 'a'.repeat(40);
writeFileSync(join(tempDir, '.version'), sha);
// Write cache with same SHA, recent timestamp
const now = Math.floor(Date.now() / 1000);
writeFileSync('/tmp/gstack-latest-version', `${sha} ${now}\n`);
const result = checkVersion(tempDir);
expect(result).toBeNull();
});
test('returns META:UPDATE_AVAILABLE when SHAs differ (cache hit)', () => {
const localSha = 'a'.repeat(40);
const remoteSha = 'b'.repeat(40);
writeFileSync(join(tempDir, '.version'), localSha);
// Create a fake browse binary path so resolveSkillDir works
const browsePath = join(tempDir, 'browse');
writeFileSync(browsePath, '');
// Write cache with different SHA, recent timestamp
const now = Math.floor(Date.now() / 1000);
writeFileSync('/tmp/gstack-latest-version', `${remoteSha} ${now}\n`);
const result = checkVersion(tempDir);
// Result may be null if resolveSkillDir can't determine skill dir from temp path
// That's expected — the META signal requires a known skill dir path
if (result !== null) {
expect(result).toStartWith('META:UPDATE_AVAILABLE');
const jsonStr = result.replace('META:UPDATE_AVAILABLE ', '');
const payload = JSON.parse(jsonStr);
expect(payload.current).toBe('a'.repeat(8));
expect(payload.latest).toBe('b'.repeat(8));
expect(payload.command).toContain('git stash');
expect(payload.command).toContain('git reset --hard origin/main');
expect(payload.command).toContain('./setup');
}
});
test('uses cached SHA when cache is fresh (< 4hr)', () => {
const localSha = 'a'.repeat(40);
const remoteSha = 'a'.repeat(40);
writeFileSync(join(tempDir, '.version'), localSha);
// Cache is 1 hour old — should still be valid
const oneHourAgo = Math.floor(Date.now() / 1000) - 3600;
writeFileSync('/tmp/gstack-latest-version', `${remoteSha} ${oneHourAgo}\n`);
const result = checkVersion(tempDir);
expect(result).toBeNull(); // SHAs match
});
test('treats expired cache as stale', () => {
const localSha = 'a'.repeat(40);
writeFileSync(join(tempDir, '.version'), localSha);
// Cache is 5 hours old — should be stale
const fiveHoursAgo = Math.floor(Date.now() / 1000) - 18000;
writeFileSync('/tmp/gstack-latest-version', `${'b'.repeat(40)} ${fiveHoursAgo}\n`);
// This will try git ls-remote which may fail in test env — that's OK
// The important thing is it doesn't use the stale cache value
const result = checkVersion(tempDir);
// Result depends on whether git ls-remote succeeds in test environment
// If offline, returns null (graceful degradation)
expect(result === null || typeof result === 'string').toBe(true);
});
test('handles corrupt cache file gracefully', () => {
const localSha = 'a'.repeat(40);
writeFileSync(join(tempDir, '.version'), localSha);
writeFileSync('/tmp/gstack-latest-version', 'garbage data here');
// Should not throw, should treat as stale
const result = checkVersion(tempDir);
expect(result === null || typeof result === 'string').toBe(true);
});
test('handles cache with invalid SHA gracefully', () => {
const localSha = 'a'.repeat(40);
writeFileSync(join(tempDir, '.version'), localSha);
writeFileSync('/tmp/gstack-latest-version', `not-a-sha ${Math.floor(Date.now() / 1000)}\n`);
// Invalid SHA should be treated as no cache
const result = checkVersion(tempDir);
expect(result === null || typeof result === 'string').toBe(true);
});
});
describe('locateBinary', () => {
test('returns null when no binary exists at known paths', () => {
// This test depends on the test environment — if a real binary exists at
// ~/.claude/skills/gstack/browse/dist/browse, it will find it.
// We mainly test that the function doesn't throw.
const result = locateBinary();
expect(result === null || typeof result === 'string').toBe(true);
});
test('returns string path when binary exists', () => {
const result = locateBinary();
if (result !== null) {
expect(existsSync(result)).toBe(true);
}
});
});