mirror of
https://github.com/garrytan/gstack.git
synced 2026-10-31 14:06:50 +01:00
+44









Garry Tan
Lewis
Yugz
Florian
cdecook23
mb1810
Koda
Merit Blake
Nguyen Thanh Dat
pneumorea-ai
maxpetrusenkoagent
Matt Van Horn
Infiniteyieldai
Gabriel Rondon
Davon Johnson
Kevin Grasso
Xuan-Ce Wang
loulanyue
Thomas Reuser
Bit0ps
oli548
Slava
ryanlaiwy
李翊楠
Mammad M.
Lockyer
Spooks444
punksterlabs
Jonathan Zhang
Marek Cermak
y$un_
neallee
hardy
afshaker
cube
jacob-wang
miao
Jonah Berg
Jayesh Betala
Ryan Alberts
AlinValentin7
Evgenii Lopatin
Jino
snig-17
Sholto McNeilage
Phil Hie
Sinabina
Jimmy Zeisweiss
liutiming
Brandon Pugsley
benjamin beres
Som Samantray
Vaughan
Bharadwaj Mittapelli
2db0b3adc8
* docs: approved severe fix wave plan (Oct 2026) * D0: keep a project's .env and bunfig.toml out of compiled binaries and daemon children Compiled binaries are built with --no-compile-autoload-dotenv and --no-compile-autoload-bunfig; the browse server and terminal agent are spawned with --no-env-file and an empty config, so a repo's .env cannot set GSTACK_CHROMIUM_NO_SANDBOX and a bunfig preload cannot run code in them. Verified on Bun 1.4.0. * A9: --no-write is a dry run and leaves ingest state untouched --no-write stamped every prepared page ingested_at and saved state, so a later real run skipped those pages forever. It now prepares and reports pages without importing or changing the state file. Tests that used GSTACK_MEMORY_INGEST_NO_WRITE / --no-write to seed state move to an explicit seam (a fake gbrain that accepts every staged page), because the --no-write contract deliberately changes. * H #2885 #2827: vector geometry is not phone or card PII pii.phone.e164 accepts "." as a group separator, so a single float (viewBox="0 0 581.66796875 ...") and a run of path coordinates ("37.6188 101.694") read as phone numbers. pii.cc's \b stops at a decimal point, so the long fraction of an .excalidraw float is a Luhn candidate. Excalidraw's seed/versionNonce/updated integers read as bare phone numbers. A rendered /diagram triplet raised 18 (svg) and 97 (excalidraw) MEDIUM findings on main; it now raises none. - looksLikeDecimalCoordinates (ported from #2885, extended to a single decimal and refusing a leading "+", the E.164 marker) - insideDecimalNumber: a cc span glued to "<digit>." or ".<digit>" - isNumericMetadataValue: an unquoted JSON value under a seed, nonce or timestamp key; the same digits under "phone" still report Controls: E.164 in prose, dotted and spaced phones, "+"-prefixed runs, "phone"/"contact" JSON numbers, Luhn-valid cards in prose and at sentence end. Co-authored-by: Lewis <lewispeel@hotmail.com> * D1: pin the terminal-agent /ws Origin to the gstack extension (#1324) GSTACK_EXTENSION_ID moves to browse/src/extension-id.ts, shared by /extension-token and the terminal agent's /ws gate. /ws now returns 403 for every origin except the pinned extension. Forks override the ID with gstack-config set browse_extension_id <id>, honored by both routes; the BROWSE_EXTENSION_ID env var is no longer read. Test sites that used fake extension IDs now use the pinned origin. * H #2899: env.kv skips a function call assigned to a credential name `session = _FlakySession(...)`, `token = make_token(user, ...)` and `password = getpass.getpass()` raised env.kv MEDIUM, which blocks the fail-closed decision log. The exemption needs the line's evidence, not the span's shape: the value is unquoted, is an identifier or dotted path followed by "(", and the call closes on the line or opens a multi-line argument list. Quoted values, unclosed "(" inside an unquoted secret (API_SECRET=Abc123xyz(9Qm) and calls carrying a high-entropy literal argument still report. The literal check is shared with the #2912 env-read exemption. Co-authored-by: Yugz <yannduzelier@gmail.com> * H #2962: per-machine config filenames are not internal hostnames `CLAUDE.local.md` and `settings.local.json` reported internal.hostname MEDIUM (the pattern's \b stops at the dot before the extension), which fails closed in the decision log. A span immediately followed by a known config extension (.md .json .jsonc .yaml .yml .toml .ini .conf .txt) and a word boundary is a filename. Controls: `ssh build.local`, `printer.local.` at a sentence end, `printer.local/md`, `printer.local.mdx`, a host with a port, `api.corp`, `build-7.internal`. The `.env.local` vectors (#2740) pass on main already via isDotenvFilename and are pinned here as regressions. Co-authored-by: Florian <florian.cleyetmerle@gmail.com> * H #2784: four-part versions need a version declaration, not a shape `"version": "1.128.1.0"`, `<Version>`, `AssemblyVersion("1.0.0.0")` and Keep a Changelog headings raised pii.ip_public MEDIUM on every release, because a four-part version is byte-for-byte a dotted quad. Exempt only when the same line declares it a version immediately before the value (a version key or word, an XML tag, an attribute call, or a `## [x]` heading). The same digits after host:/server =/"upstream", bare on a line, or after prose that merely mentions a version still report. Unlike #2784, this does not exempt a value because the same string is declared a version elsewhere in the text: that let a real address sharing a diff with a matching version slip. The pre-push hook's VERSION-file rule (#2856) is unchanged. Co-authored-by: cdecook23 <decook23@gmail.com> * H #2913: postgres:postgres is exempt only on a loopback host The postgres image's default pair in compose files and CI DATABASE_URLs blocked pushes as db.url_with_password HIGH. It is now exempt only for postgres/postgresql URLs with exactly postgres:postgres on localhost or 127.0.0.1 (optional port). A bare single-label host (`db`, `postgres`), any other host, a host that merely starts with localhost (`localhost.evil...`, `localhost@prod-db`), any other user or password, and other schemes still block. #2913 exempted the pair on any host; this keeps the plan's narrower rule. Co-authored-by: mb1810 <michael.berger1810@gmail.com> * G1: ship without a version when no version source is configured Resolve the version source to four outcomes (valid, absent, ambiguous, broken) in lib/version-source.ts and read that one signal in gstack-version-bump (new NO_VERSION state; write refuses to invent a VERSION), gstack-next-version (no_version, no slot), /ship's bump, CHANGELOG and title steps, /land-and-deploy's drift check and /document-release. A configured version file that is missing, empty, unreadable or malformed stops with its path; 0.0.0.0 is never substituted. docs/skills.md documents .gstack/version-path. Migrates two tests that pinned the old fabricated-0.0.0.0 behavior. Co-authored-by: Koda <koda@edgeviewfinance.com.au> Co-authored-by: Merit Blake <merit@newsprint.com> * H #2949: eval credential screen checks every name segment The hermetic eval env admits GITHUB_* and EVALS_* metadata but rejects credential-shaped names, judged only by the last underscore segment. A trailing qualifier carried a credential through: GITHUB_APP_PRIVATE_KEY_BASE64, GITHUB_TOKEN_1, EVALS_API_KEY_FALLBACK reached eval children. The screen now rejects a name when any segment is a credential word; segments, not substrings, so GITHUB_PATH / GITHUB_TOKENIZER / GITHUB_KEYRING stay metadata, and explicit runner admissions still win. Co-authored-by: Nguyen Thanh Dat <ntdat812@gmail.com> * H #2915: cover chunked scanning of large multi-file push diffs Test-only coverage for behavior already on main: a clean two-file pushed diff over the engine's 1 MiB cap passes without engine.input_too_large, and a credential at the end of the second file (a later scan chunk) still blocks the push. Co-authored-by: pneumorea-ai <pneumorea@gmail.com> * A3: keep a project's DATABASE_URL away from a PGLite brain With a PGLite config, buildGbrainEnv returned the caller env unchanged, so a project's .env DATABASE_URL (autoloaded by Bun) reached gbrain: a false broken-db at best, gbrain talking to the app's own Postgres at worst. Inherited DATABASE_URL and GBRAIN_DATABASE_URL are now blanked for PGLite configs (GSTACK_RESPECT_ENV_DATABASE_URL=1 still keeps them), and every gbrain child runs from gbrain's config dir instead of the user's project, so it cannot reload the project's .env / .env.local. The old test that pinned pass-through for an engine:pglite config is migrated: pass-through now applies only to configs that name neither a database_url nor PGLite. Co-authored-by: maxpetrusenkoagent <max.petrusenko.agent@gmail.com> * C9: guard destructive gstack-upgrade and spec fences against unset or wrong paths Fresh-shell hosts (and Claude Code, which keeps cwd but not shell variables) ran cd "$INSTALL_DIR" with an empty variable, so git checkout/stash/reset targeted the user's project. Step 2 now prints an absolute path; every destructive fence starts with cd -- "${VAR:?...}" || exit 1 and checks it is gstack's own checkout before any git command. /spec's worktree and spawn fences get the same guard. * F4: keep every paid design variant across regenerate rounds $D variants now reserves a collision-safe round-<N>/ directory per run (atomic mkdir) and writes a manifest.json of what each round saved. The paid image request and the local write retry separately: a write failure retries the write (temp + rename) and, if the path stays unwritable, keeps the bytes in the temp dir instead of buying the image again. Responsive variants land in their round directory too. Readers updated: design-shotgun reserves a round dir and a private temp dir for its parallel agents and records approved_path/round in approved.json; design-html resolves approved_path (legacy letters still work) and finds round-dir variants; design-consultation checks the printed paths; the gallery shows round-dir variants. Variants that were already overwritten before this change cannot be recovered. Migrates the consultation contract test that pinned the flat path. Co-authored-by: Matt Van Horn <mvanhorn@gmail.com> * A2: stage dot-leading slugs gbrain can collect; network errors are db-unreachable A page slug segment starting with a dot (a .claude project) staged a file gbrain's import walker prunes, so the batch was refused on every run. Leading dots become "dot-" per segment, and slugs recorded in state under the old name map through the same function so no page is duplicated. A DNS or connection failure (ENOTFOUND, EAI_AGAIN, ECONNREFUSED, ...) no longer classifies as broken-db, which routed users to move a working config aside. The new db-unreachable status carries the reason "database host unreachable (<code> <host>); your gbrain config is unchanged. Fix: check network or VPN, then re-run /sync-gbrain.", skips local sync stages with that reason, and counts as usable for gstack-gbrain-detect --is-ok like timeout. Co-authored-by: Infiniteyieldai <infiniteyield.ai@gmail.com> * D2: one address classifier for navigation literals, DNS answers, redirects and page-driven navigations (#2811) classifyAddress() in url-validation.ts blocks 169.254.0.0/16 (metadata and container credential endpoints), 100.100.100.200, fe80::/10 and fc00::/7, including IPv4-mapped, IPv4-compatible and NAT64 spellings and decimal, octal and hex IPv4. validateNavigationUrl, the A/AAAA answer check and session-persist's cookie-domain guard all use it. BrowserManager now checks every navigation request (redirect hops, link clicks, scripted navigations): a blocked target resets the tab to about:blank and the write command fails with the reason. Connection-time DNS rebinding remains out of scope. Co-authored-by: Gabriel Rondon <grondon@gmail.com> * C4: external hosts point at carved sections relative to the installed skill Publishes the pointer form setup matches: on every non-Claude host a carved section is `sections/<file>` relative to the installed gstack-<skill> SKILL.md directory (QA's existing form), never $GSTACK_ROOT/<skill>/sections/, which does not exist in external runtime roots. No render changes yet: only QA is carved on external hosts today. * INV-1: gate outcome contract for outside reviews classifyOutsideReview() returns separate execution, findings and verdict fields from text, stderr and exit status; reason codes, anchors and fix actions live in lib/gate-outcomes.ts. validateOutsideReview() stays as the text-only wrapper and the two-argument CLI keeps exit 0/1/2 for importers and installed skills that predate a re-render. The --verdict form (implied by --stderr/--exit) prints VERDICT/FINDINGS/REASON and exits 0/3/4/1; the generated outside-voice caller moves to it and branches on each status (unverified prints OUTSIDE_STATUS: unverified, never completed). Adds docs/troubleshooting.md with one anchored section per reason code, the anchor test, and the gate-tail lint (query scripts may not swallow failures, gate calls may not end in || true, other best-effort tails say why). * G1: quote the base placeholder in document-release title sync The title-sync block is checked with bash -n; an unquoted <base> parses as a redirection. Migrates the test that pinned the old root VERSION read to the shared classifier call. * G3: give every logging-bin mktemp a ${TMPDIR:-/tmp} template Bare mktemp, mktemp -t and literal /tmp templates in the learnings, question and preference logs (plus jsonl-merge, distill, the two dashboards, /ship's PR body and /document-release's run dir) now use "${TMPDIR:-/tmp}/<name>.XXXXXX", the form the INV-3 lint accepts. When the temp file cannot be created, the learnings, question and preference logs now say the entry was not recorded and how to fix TMPDIR instead of exiting with only mktemp's own error. Three tests that pinned the bare PR_BODY_FILE=$(mktemp) and one that pinned the /tmp run dir migrate. GNU and BSD mktemp already honor TMPDIR without a template, so the macOS-sandbox drop in #2952 is unverified here; the template makes the temp location explicit on every mktemp. Co-authored-by: Davon Johnson <d.johnson@dayofshow.net> * B1b: structured outside-review gate fails on P0 as well as P1 validateOutsideReview() derived its structured pass/fail from a [P1] match, so a review reporting only [P0] findings passed. The wrapper now reads the classifier's findings verdict (P0 or P1), and the /review and /ship structured-gate prose requests [P0]-[P3] tags and fails on P0/P1; untagged output (OUTSIDE_STATUS: unverified) is missing coverage. The ship clarity pin moves from 'structured P1' to 'structured P0/P1' with the behavior. * E1: freeze normalizes boundary and target the same way on Windows; hooks spawn through cmd.exe (#2876, #2354) gstack_hook_normalize_path (careful/bin/hook-extract.sh) maps C:\..., c:/..., UNC \\server\share (leading // kept) and /cygdrive/c to one form; check-freeze runs both the saved boundary and file_path through it before the absolute test, after symlink resolution, and compares case-insensitively on Windows bash. freeze, guard and careful register hooks as bash -c "exec bash \"$HOME/...\"" so cmd.exe, which never expands $HOME, no longer turns the hook into a silent exit 127. Co-authored-by: Kevin Grasso <kevin@biblingo.com> Co-authored-by: Xuan-Ce Wang <261591073+xwang4-svg@users.noreply.github.com> * G4: keep CLI-to-daemon loopback calls off HTTP_PROXY (#494) The CLI appends 127.0.0.1, localhost and ::1 to the user's NO_PROXY (and no_proxy), keeping existing entries, before its first fetch. Verified on Bun 1.4.0: fetch honors NO_PROXY when it is set before the first request and ignores later changes, so it is set at the top of main(). * F1: bind the plan audit to this branch's plan, never the newest file Plan File Discovery now prefers an explicit binding (the plan-mode file or /autoplan ACTIVE_PLAN from the conversation, then a "Plan: <path>" line in the PR body), then lists candidates: repo-committed docs/designs/ files this branch changed or that name it, and personal plan files that name the branch. Candidates are offered, never picked silently. The repo-name match and the newest-file-of-the-day fallback, which audited PRs against unrelated plans, are gone. With nothing bound or chosen it prints the exact line 'Plan completion audit: not run (...). Fix: add "Plan: <path>" to the PR body, or run /autoplan.' /ship's parent now binds the plan before dispatching the audit subagent ({{PLAN_COMPLETION_GATE_SHIP:discovery}}), so the child never searches. Migrates three tests that pinned the old markers and notice. Co-authored-by: loulanyue <260355617@qq.com> * G5: browse type --selector <sel> <text> (#2936) --selector focuses the element (sel or @ref) and types into it. The bare form still types its text literally into the focused element; text that starts with -- goes after a -- separator. When the first word looks like a CSS selector, the result adds a hint to use --selector without echoing the typed text, and never refuses based on page contents. Help and command usage updated. Co-authored-by: Thomas Reuser <thomasreuser@gmail.com> * F2: design-doc discovery reads docs/designs, never a root DESIGN.md A root DESIGN.md is the design system /design-consultation writes, so preferring it unconditionally reviewed plans against a token file while printing "Design doc found" and never looked at docs/designs/ feature docs. Discovery now considers only docs/designs/*.md as the repo-local design doc (still freshness-compared with the private ~/.gstack copy). The CEO finding fixture seeds its supplied design as a docs/designs doc and its test follows. Co-authored-by: Bit0ps <alex.dreamscaper@gmail.com> * C4: rename the external carve test (typecheck:test union-order artifact) tsc prints a union's members in type-creation order; a test file sorting before ceo-mode-option.test.ts reordered one baseline diagnostic's text. * C1: every env-var host fence resolves its own gstack root Codex and the other env-var hosts run each block in a fresh shell, so GSTACK_ROOT/BIN, B and D set by the preamble were empty in later blocks (/bin/gstack-slug, B=/browse). scripts/resolvers/runtime-root.ts now owns root resolution: a valid exported GSTACK_ROOT (bin/ and lib/), else the per-install literal root (no git call), else repo-local, else the global root (CODEX_HOME on Codex); no root prints the setup fix line and exits. One post-render pass inserts it (<=400 bytes) into every fence that uses these variables without assigning them; B/D come from the same helper as BROWSE and DESIGN SETUP. Claude output is byte-identical. Migrated pins of the old preamble lines (gen-skill-docs.test.ts) and a fixture whose exported GSTACK_ROOT lacked lib/ (skill-positional-literals). * E8: headless browse honors GSTACK_CHROMIUM_PATH; extensions load in new headless mode (#2771, #1968, #2281) The headless launch passes GSTACK_CHROMIUM_PATH as executablePath, scopes the XProtect self-heal out for that bundle, and names the path in a launch failure with the fix. BROWSE_EXTENSIONS_DIR now launches a persistent context under the project state dir with --headless=new, so the extension runs and no window appears (the off-screen window was visible on macOS and the extension never ran in an isolated newContext). The GPU source guard test moves from the removed useHeadless flag to launch() vs launchHeaded(). Co-authored-by: oli548 <312288720+oli548@users.noreply.github.com> Co-authored-by: Slava <slava.istomin@tuta.io> Co-authored-by: ryanlaiwy <129729476+ryanlaiwy@users.noreply.github.com> Co-authored-by: 李翊楠 <yinanli1917@gmail.com> * C2: link design/dist and make-pdf/dist into every host runtime root and the agents sidecar Codex design and make-pdf skills fall back to $GSTACK_DESIGN and $GSTACK_MAKE_PDF under the runtime root, but setup linked only browse/dist, so both preflights reported NOT_AVAILABLE on a fresh install. One helper links dist/ only (make-pdf/ ships a Claude SKILL.md) into the Codex, Factory, OpenCode, Cursor, Copilot and Kiro roots, the .agents sidecar and the Cursor sidecar. Co-authored-by: Mammad M. <mammad@digit.az> * C3: install router and nested SKILL.md files as real copies; back up hand edits; --status checks Codex skips a symlinked SKILL.md file, so the gstack router linked into ~/.codex/skills/gstack was invisible. Every host runtime root (Codex, Factory, OpenCode, Cursor, Copilot, Kiro) and Kiro's per-skill installs now get real copies, rewritten on every run (the auto-update path runs setup --refresh-registered, so it refreshes them too). setup records each copy's hash in <state root>/skill-copies.tsv; a copy that no longer matches is saved to a uniquely named backup under <state root>/backups/skill-copies/ before _activate_runtime_root replaces the tree, and a failed backup keeps the old tree. setup prints what it refreshed or removed. ./setup --status now prints, per registered install, whether the router is a real file and whether every section pointer resolves, with the fix command. Test migration: setup-codex-model pinned the Kiro router/upgrade links as _link_or_copy; C3 deliberately changes them to copies. * INV-3: install-level host conformance checks (no symlinked SKILL.md, dist present, section pointers resolve) For codex, kiro, factory, opencode, cursor and copilot, the real-setup conformance kit now fails when an installed SKILL.md is a symlink, when design/dist or make-pdf/dist is missing from the runtime root, or when a 'Read `.../sections/<f>.md`' pointer in an installed SKILL.md does not resolve (bare pointers in carved skills, relative-to-installed-skill pointers, and $GSTACK_ROOT/~/absolute/../ pointers everywhere), and ./setup --status must report 'all resolve'. No new setup runs. Expected red until the generator lane lands: design-html's install-offer pointer and plan-eng-review's review-sections pointer name $GSTACK_ROOT/<skill>/sections/... on every external host. * B11: auto-update tracks pull, setup and migrations; announces only on success; retries with backoff gstack-session-update wrote the 'just upgraded' marker after SETUP_FAILED or SETUP_SKIPPED bun_missing, and re-ran setup only when HEAD moved, so a failed install was announced as an upgrade and never retried. Stages are now persisted in <state root>/session-update-pending; the marker is written only when every stage succeeded; a pending setup or migrations stage is retried even with HEAD unchanged after the update-check interval, then 6h, then 24h; and each session start prints one line naming the stage, the reason and the repair command while it is pending. Best-effort tails carry a same-line reason. * D1: gstack-config key browse_extension_id for forks and self-built extensions The browse daemon trusts one Chrome extension ID on /extension-token and the terminal-agent /ws. The override now lives only in gstack-config (never an env var a project .env could set): empty by default (gstack's published extension), a 32-letter a-p Chrome ID when set, "" clears it, and anything else is rejected with the stored value kept. The browse lane reads it. gstack-config-defaults: browse/src counts as a reader directory; the key is listed prose-only until the browse lane's reader lands (the stale-entry check then asks for the entry's removal). * G2: key the sticky slug cache on the git common dir A linked worktree used to resolve its slug fresh from the remote while the main checkout kept its sticky pre-remote identity, so learnings, checkpoints and timelines split into two buckets. gstack-slug and its TS twin in lib/bin-context.ts now key the cache on the git common dir (read from .git files, no git spawn, so cache hits stay git-free) and read entries in one deterministic order: the repository entry, then the main checkout's pre-upgrade entry, then this directory's own. Both the repository and per-path entries are written. When a worktree's own old entry named a different bucket that still holds data, that slug is recorded in projects/<slug>/.former-slugs and reported by --get FORMER_SLUGS. New --adopt-legacy --from <slug> merges it: JSONL logs append missing lines with de-duplication, missing files copy, differing files are listed as conflicts and never overwritten, the source bucket is kept, and it prints migrated/pending/conflicting counts; reruns are idempotent. --adopt-legacy --dismiss <slug> drops the reminder. Co-authored-by: loulanyue <260355617@qq.com> * C5: OpenCode /gstack-* commands load the skill by its frontmatter name OpenCode's skill tool knows gstack-review as `review` (its frontmatter name), and OpenCode's builtin /review shadows that name as a command. The managed /gstack-review command told the agent to load `gstack-review`, a name the skill tool does not list. Every managed command now names the frontmatter name. OpenCode's AskUserQuestion/ExitPlanMode mapping (#2759) already shipped in v1.91.16.0. Test migration: the #2629 commands test pinned the directory name. Co-authored-by: Lockyer <135391289+Lockyer228@users.noreply.github.com> * E4: Windows node-server bundle keeps sharp and socks external; CLI resolves its server script lazily (#2260, #2439) build-node-server.sh passes --external sharp and --external socks (Bun on Windows refuses to inline them; on Linux they were silently inlined). The CLI no longer resolves server.ts or server-node.mjs at module load: resolveServerLaunch() runs when a server starts, so a Windows minimal runtime with only server-node.mjs works and a missing script is reported only when one is needed. Co-authored-by: Spooks444 <193448029+Spooks444@users.noreply.github.com> Co-authored-by: punksterlabs <77217235+punksterlabs@users.noreply.github.com> * B1: Codex reviews whose sandbox could not start are unavailable, not a pass In containers without unprivileged user namespaces every Codex command fails, yet the review exits 0 and concludes 'no findings' (captured in test/fixtures/codex-sandbox/). The validator now takes execution evidence: 'codex exec --json' command events and the 'codex review' stderr transcript (a command that succeeded proves execution); sandbox failure lines on stderr or in failed command output return unavailable(sandbox_unavailable); exact 'could not run commands / read the diff' phrases are the last fallback. Review text that merely discusses bwrap or namespaces still passes. A free 'codex sandbox ... true' preflight (Linux, 10 s) runs before the paid model probe and every automatic outside review; CODEX_MODE gains sandbox_unavailable, and an inconclusive model probe reports unverified instead of ready (exit code kept for stale callers). Every Codex site (outside-voice resolver, /codex review, challenge, consult) takes its sandbox from _GSTACK_CODEX_SANDBOX and pipes its result through the validator; a static test parses rendered command positions for both. GSTACK_CODEX_NO_SANDBOX=1 (exactly 1, shell env only) switches to danger-full-access with a warning on every use. Sandbox pins in existing tests move from the literal read-only to the selected-sandbox variable; captured autoplan probes are judged against the probe block they executed. * C6: gstack-relink discovers skills structurally, so /browse survives a skill_prefix toggle relink skipped a hardcoded list of support-directory names that included browse, a real skill, so toggling skill_prefix removed /browse. A top-level directory is now a skill exactly when it carries a SKILL.md. Co-authored-by: Jonathan Zhang <topcoder1@Mac-Studio.local> * C4: carve ship and plan-ceo-review on every host; enforce the 160 KB byte gate The generated ship skill was 202-241 KB on all 10 non-Claude hosts (and Factory plan-ceo-review 160,039 bytes), over the 160,000-byte ceiling, because section carving ran only for Claude. Both skills now carve on every host, pointing at sections relative to the installed skill directory (literal $GSTACK_ROOT/<skill>/sections refs are rewritten the same way). The ceiling is measured in UTF-8 bytes and fails generation in repo mode; under --install-root it warns so setup never leaves a user without skills. qa-lazy-sections.test.ts pinned ship as inline-on-external-hosts; migrated to the carved policy and kept the inline check on review (Claude-only carve). * B5: learnings and timeline reads fail loudly when bun is missing gstack-learnings-search and gstack-timeline-read ended in '2>/dev/null || exit 0', so a missing bun or a crashed embedded script printed nothing and exited 0, identical to 'nothing recorded'. Both now exit 127 with '<script>: bun not found on PATH, so ... could not be read. Fix: install Bun (https://bun.sh), then re-run ./setup.' and let an embedded-script failure exit non-zero with its stderr. A successful run with no matches still exits 0 with empty output. The generated callers that print 'LEARNINGS: unavailable (...)' belong to the generator lane. Co-authored-by: loulanyue <260355617@qq.com> * B2: a retired-model 404 reports MODEL_UNUSABLE, not CODEX_MODE: ready The model probe matched only 400 / 'is not supported', so a retired model's 404 ('does not exist or you do not have access to it') and a custom provider's bare 404 fell through to the inconclusive branch and reported ready. Both now classify as MODEL_UNUSABLE with a hint naming the two causes (retired model, or a wrong base_url) and log codex_model_retired; a 'requires a newer version of Codex' 400 points at upgrading the CLI and logs codex_cli_outdated. Ported from #2843 onto the current probe. Co-authored-by: Marek Cermak <marek.cermak@strv.com> * B6: rank learnings by matched query tokens and disclose truncation A more specific query used to drop the exact match: the token-OR filter recalled every entry sharing one token, the sort used confidence alone, and the default --limit cut silently. Entries now rank by how many distinct query tokens they match, then confidence, then recency, and a query that matched more than fit says '-- N more matched, raise --limit to see them'. The hit count lives in a local map so a field stored on disk can never become a sort key, and the type grouping uses a null-prototype map so a row typed 'constructor' or '__proto__' cannot crash the run. Ranking code ported from #2796; regression vectors adapted from #2799 (its stemmer is not needed). Co-authored-by: loulanyue <260355617@qq.com> Co-authored-by: y$un_ <forrest.sun527@gmail.com> * C7: required team mode also blocks Copilot CLI's lowercase skill tool Copilot CLI applies Claude-format matchers by tool name; its skill tool is `skill`, which no Claude tool name maps to, so the 'Skill' matcher never fired and Copilot ran protected skills without gstack. The hook entry now matches 'Skill|skill', an entry an older team-init wrote is upgraded in place, and the deny is emitted in both decision formats (Copilot reads the top-level permissionDecision, Claude Code reads hookSpecificOutput) with exit 0 so both parse it. Test migration: the settings test pinned matcher 'Skill'. Co-authored-by: neallee <neallee@gmail.com> * B3: Codex auth probe accepts custom providers' env_key credentials The auth probe only knew CODEX_API_KEY, OPENAI_API_KEY and auth.json, so a working self-hosted or OpenAI-compatible provider configured with [model_providers.<id>] env_key = "X" reported AUTH_FAILED and /codex stopped. The probe now reads env_key from model_providers tables only (comments ignored, the name must be a shell identifier before it is dereferenced) and accepts a set variable; when none is set it names the missing key on stderr. Ported from #2192 with the table scoping added. Co-authored-by: hardy <932821449@qq.com> * E8: keep the extensions profile under the state dir at a path lock cleanup accepts cleanSingletonLocks only cleans directories named chromium-profile, so the BROWSE_EXTENSIONS_DIR profile moves to <state>/extensions/chromium-profile. * B10: plan-tune never reports CALIBRATED with zero signal events Stats printed CALIBRATED: true from logged-answer counts alone, while every answer could miss SIGNAL_MAP and leave each dimension at its 0.5 seed (#2623). --derive now records inferred.signal_events, the answers that actually moved a dimension; calibration requires at least one, and the summary prints 'not calibrated: no recorded signals' verbatim when there are none (or says the count is unknown for a profile derived before this change). The psychographic redesign stays out of scope. * A1: verify gbrain landing before stamping transcripts, plus --reconcile gbrain import exits 0 while skipping pages (returned per-file failures, malformed filenames, managed-import Pending receipts), and its failure ledger exists only for git import dirs, so a skipped page was stamped ingested and never retried (field reports: 37 and 69 lost entries). Write, verify, then stamp (lib/memory-ingest-landing.ts, a new ratcheted module): - State schema 2 with a transition table (staged -> imported_unverified -> ingested, plus refused, quarantined, unrecoverable). Schema 1 files migrate in place: entries become ingested in the legacy "default" source and a reconcile pass is marked pending. - Named failures come from --json `failures`, stderr "Skipped <rel>:" lines and the ledger; a failure gbrain does not attribute refuses the whole batch. After 3 refused batches the batch is bisected and the page that poisons it is quarantined (printed even under --quiet). - Landing check: one `gbrain list --source-id` per source per run and at most 50 `gbrain get --json` content checks against a gstack_content_sha256 frontmatter field gstack now writes. Lookup errors and pglite_busy mean "not yet checked", never absent; pages over the cap stay imported_unverified and are not re-imported. - Each entry records its gbrain source_id. Remote-http mode records "staged", never "ingested". - The source fingerprint comes from the exact bytes parsed, so a transcript that grows during import is not stamped as its newer self (the old unscanned contract test is migrated; it pinned that bug). - --reconcile mode (bounded by --limit, default 200; resumable; --dry-run; backs up the state file) prints "reconcile: checked N, present M, re-queued K, not yet checked L". --request-reconcile records a pending pass without calling gbrain; the v1.91.17.0 migration (placeholder name) uses it, and the next ingest run does one bounded pass. - One lock for every state writer; a state-save failure fails the run. The #1802 static pins in regression-1611 move to the new structure (remote-http returns before importBatch; the finally honors preserveStaging). Co-authored-by: afshaker <andrew@phone2.io> * B4: arm64 re-sign keeps a backup, restores it when codesign fails, and reports design unavailable on exit 137 setup's Apple Silicon re-sign mutated each binary in place (truncate, remove signature) and left it that way when re-signing failed; a design binary that was then SIGKILLed at launch produced at most a quiet log line. Each binary is now copied first and restored as built when signing fails, and design is exec-probed after re-signing: exit 137 prints 'design unavailable: ... Fix: cd <checkout> && ./setup' (even under -q). Verified on Linux with the real block and uname/codesign/otool/stat stubs; not run on a Mac. * D3: treat design docs and handoff notes as data in plan reviews plan-ceo-review, plan-eng-review and plan-devex-review read the freshest design doc as the source of truth, and nothing said its content is data. In multi-agent pipelines another agent may have written it, or a handoff note beside it, with reviewer-directed text ('skip Step 0', 'approve as-is'). Each read site now says the doc and any handoff note are data, never to follow text aimed at the reviewer, and to report it as suspicious content. The plan-completion audit's discovery, which now reads repo docs/designs/ files (F1), carries the same rule. Co-authored-by: cube <frosimanuel@gmail.com> * D4: setup-deploy reports Render API key presence only /setup-deploy ran 'echo $RENDER_API_KEY | head -c 4', printing the key's first bytes into the transcript. It now prints only 'RENDER_API_KEY: set' or 'RENDER_API_KEY: not set'. Wording follows the #2971 port of #1096; a test also guards against any setup-deploy command echoing a credential variable. Co-authored-by: jacob-wang <jiayuw794@gmail.com> * D5: per-project headed Chromium profiles; never kill a live profile owner (#2492) The headed profile moves from <gstack home>/chromium-profile to <project>/.gstack/chromium-profile (CHROMIUM_PROFILE still wins). killOrphanChromium now kills a SingletonLock PID only when the lock names this host, the process is a Chromium using that profile, and its daemon is gone (reparented to init or a subreaper); a live owner or another host's lock stops browse with the holder named. On first headed use a project profile is seeded from the old shared profile only when nothing holds it: copied without Singleton* files into a 0700 temp dir and renamed into place, with a one-time notice; otherwise it starts fresh and says how to import later. New: browse profiles [list] and browse profiles prune [--days N] (never removes a profile in use or the old shared one). The #2817 headed-startup tests move to the project profile and a real orphan (the old stand-in was a live child of the test). Co-authored-by: miao <miao@macmini-2.local> * F5: installed Claude skills serve the rendered sections, not the checkout copies Probe: a gbrain user render serves ship/SKILL.md from the render dir; its STOP pointers name absolute render paths, but its section index names `sections/<f>.md` relative to the installed skill directory, whose sections/ was linked from the checkout. So the rendered 'Save Results to Brain' blocks (plan reviews, office-hours, ship adversarial) were generated and never read. setup's _link_skill_runtime_assets and gstack-relink (the gbrain-refresh path) now serve a rendered counterpart per file, keep checkout-only assets (manifest.json), return an asset to the checkout once its render is gone, and never touch an entry that is not gstack's links. Co-authored-by: Jonah Berg <jonah.berg.g@gmail.com> * F1: ratchet /ship's parity union-size cap for this lane's content G1's NO_VERSION arms, F1's parent-side plan binding and D3's data line add 2,126 bytes to /ship's skeleton-plus-sections union, taking it from 1.4022x to 1.4135x of the v1.64.1.0 baseline (cap was 1.405). The cap moves to 1.414 with the measurement recorded, as earlier growth did; no other invariant changes. * E5: feed every Codex prompt on stdin instead of argv Prompts went to Codex as one argv string ('codex exec "$(cat file)"'), which fails over 32 KB on Windows (and over 128 KB on Linux, E2BIG) and mangles quotes. Every codex exec site (outside-voice resolver, /codex review custom instructions, challenge, consult new and resume) now runs 'codex exec -' with the prepared prompt file on stdin; challenge and consult write the prompt with a quoted heredoc so it is never shell-parsed. The bash-native timeout watchdog (stock macOS) started the command in the background, which gives it /dev/null as stdin; it now passes the caller's stdin through. The 'byte for byte' dispatch test drops its old argv trailing-LF exception, the consultation and autoplan fixtures follow the stdin form, and the static site test requires stdin at every rendered codex exec. * G6: prettyscreenshot --hide keeps a trailing image path as the output path (#1419) --hide collected every following non-flag argument as a selector, so the output path was hidden instead of written to. A trailing argument that looks like a path or ends in .png/.jpg/.jpeg/.webp is now the output path. Co-authored-by: Jayesh Betala <jayesh.betala7@gmail.com> * INV-3: render-level host conformance and generated-bash lint on every host One render per host checks every fence of every SKILL.md and section file: bash -n with angle-bracket placeholders normalized; the env-var host prelude and its B/D consumers run under env -i and set -u with stub binaries (no empty value, no /bin/, /browse, /design or /gstack- path); and a quote-aware lint (test/helpers/generated-bash-lint.ts) fails on a ~/ word inside double quotes, mktemp without a TMPDIR-respecting template, and cd/rm -r/mv/git -C on a variable the fence never assigned unless written ${VAR:?...} (cd must also handle failure). Negative controls plant each failure. Templated the bare mktemp calls in generator-owned resolvers and the upgrade fence; migrated the two tests that pinned the bare form. * G6: analytics averages quoted duration_s values (#1728) gstack-skill-end writes duration_s as a quoted string, and the per-skill average stripped everything from the leading quote, so every average read 0s. The awk now drops a leading quote before extracting digits. Co-authored-by: Ryan Alberts <ryan.a.alberts@gmail.com> * G6: gstack-ios-qa-daemon --help prints usage instead of starting the daemon (#1932) Co-authored-by: maxpetrusenkoagent <max.petrusenko.agent@gmail.com> * G1: tighten /ship's NO_VERSION wording to fit the union-size cap Same behavior in fewer bytes: the NO_VERSION arm, the broken-source exit, the unprefixed-title rule, the Step 20 null and the CHANGELOG skip. The cap ratchet commit measured this wording. * G6: rejected taste preferences gain confidence (#1777) bumpPref computed every entry's confidence from approved_count, so a rejected entry, which never gains approvals, stayed at 0: show ranked rejections by insertion order and the taste-drift warning could not fire from real use. Confidence now uses the entry's own bucket count. Also salvaged by Garry's #2971. Co-authored-by: Jayesh Betala <jayesh.betala7@gmail.com> * E2: Windows /cso build disables only C5105, and a failed MSVC compile is not reported as a missing toolchain The Windows SDK's winbase.h raises C5105, which /W4 /WX promotes to error C2220, so every MSVC build of the native /cso helper failed, and setup mapped every probe failure to 'install Visual Studio 2022 Build Tools'. Both compile lines add /wd5105 (only that diagnostic), and setup keeps the probe's output: a probe that found MSVC but failed to compile reports windows-msvc-compile with the compiler's first error. Not run on Windows: the mapping test stubs powershell.exe; the ps1 assertion runs everywhere. Co-authored-by: AlinValentin7 <AlinValentin7@users.noreply.github.com> * E6: gbrain-refresh hands the detection file to Python on stdin Under Git Bash, a native Windows Python first on PATH cannot open an MSYS /c/... path, so gbrain-refresh always summarized the detection as 'local-status: unknown' and brain-aware blocks were suppressed. bash now opens the file and Python reads stdin; the grep fallback without Python is unchanged. Verified on Linux with a stub Python that refuses path opens; not run on Windows. Co-authored-by: maxpetrusenkoagent <max.petrusenko.agent@gmail.com> * G6: context-save computes session duration on Linux (#2704) The duration step parsed 'ps -o lstart=' with BSD-only 'date -jf', so on Linux session_duration_s was always unknown. It now falls back to GNU 'date -d', and never parses an empty start (GNU reads that as midnight). Ported onto the current block instead of #2704's ~/.gstack/sessions mtime, which bypassed the state root. Co-authored-by: Evgenii Lopatin <e75533@gmail.com> * Q2: one-time notice naming the Codex provider and account for outside reviews Outside reviews are on by default and use whatever Codex login exists (#965). The first automatic Codex review on a machine now prints one non-blocking notice: the provider (config.toml model_provider, else openai), where the credential comes from (CODEX_API_KEY, OPENAI_API_KEY, the ChatGPT login or the key saved by codex login; never the value), that reviews stay on, and how to turn them off (gstack-config set codex_reviews disabled). A marker in the gstack state root keeps it to once per machine. Tests that run the generated command now use private state roots. Also shortens the no-sandbox provenance line. * Q1: validate browser output paths the way the kernel resolves them (#2971 salvage) validateOutputPath walks the destination one component at a time, resolving each existing component before the next, so link/../x, a dangling symlink and a dangling symlinked parent can no longer route a write outside the safe directories, while a new multi-level directory inside them is allowed. scrape validates its manifest and every downloaded file, not only --dir. Ported from PR #2971 onto current code. * G6: retro test census counts non-JS suites, skips generated output The census recognized only JS/TS-style names, so pytest and minitest (test_*.py|rb), XCTest (Tests/ dirs, FooTests.swift), Terraform (*.tftest.hcl) and Bats (*.bats) suites counted as zero, and a committed build directory counted as authored code (and its Test/ subdirs as test LOC). is_test now knows those conventions and never treats prose as a test, generated output is skipped in the numstat pass, TEST_FILES_CHANGED uses is_test, and TEST_FILES_TOTAL uses the same filename conventions minus generated paths. Merges #2812, #2809 and #2037's patterns (#2037's retro template edits target a block the metrics bin replaced). Co-authored-by: Jino <dgfrty00@gmail.com> Co-authored-by: snig-17 <santosh.m.tiwari@gmail.com> Co-authored-by: Sholto McNeilage <sholto@nodenarrative.com.au> * Q3: setup stops auto-installing the AskUserQuestion preference hook in Conductor and removes one it added The PreToolUse question-preference hook breaks Conductor's native AskUserQuestion round-trip even when it only defers (#2207), and setup auto-installed it on every Conductor workspace setup. Now a Conductor setup without an explicit opt-in never installs it and removes an existing one (the question-log and AUQ-error hooks stay), printing how to keep it (gstack-config set plan_tune_hooks yes). An explicit opt-in still installs it. gstack-settings-hook remove-source gains --event to scope the removal. Test migration: setup-plan-tune-hooks-noninteractive pinned the retired Conductor auto-opt-in. Co-authored-by: Phil Hie <philhie@outlook.com> * E5: watchdog stdin test feeds the wrapper through a redirect Callers run '_gstack_codex_timeout_wrapper ... codex exec - < file'. Bash keeps stdin for a backgrounded command inside a pipeline but not behind a redirect, so the pipe form passed on the old watchdog; the redirect form reproduces the lost prompt. * F4: type the variant-round fetch stub like the existing stubs The test-typecheck ratchet flagged the zero-argument stub cast to typeof fetch; it now takes the fetch arguments like variants-retry-after's stub. Test behavior unchanged. * A4: import transcripts into per-repository, non-federated gbrain sources `gbrain import` ran without --source-id, so transcripts from every project landed in the shared (often federated) default source. - Each transcript partition imports with --source-id into its originating repository's own source (gstack-transcripts-<repo>, built with constrainSourceId, now exported from lib/gbrain-sources.ts). The source is registered machine-local and --no-federated before its first import, and the registration is cached in state. Partitions import one after another (PGLite is a single writer); a failing source no longer blocks the others, except a timeout, whose checkpoint must survive. - If gbrain cannot register the source, that partition stays local and unstamped, and the run says why (even under --quiet). - --include-unattributed sends repo-less transcripts only to the machine-local gstack-transcripts-unattributed source, keeps them on the machine when the brain is remote (Postgres, Supabase or remote-HTTP), and never writes them to the publishable ~/.gstack/transcripts staging. - A page's recorded source is sticky: pages stamped before this release ("default") keep importing there, so no source gains a duplicate. - The staging dir name carries -src-<id> so a resumed import keeps its source. Test fakes that recorded only the last import now record every import of one run, and answer `gbrain sources`; remote-http scan tests use an attributed transcript, since unattributed ones no longer stage there. Co-authored-by: Sinabina <sinabina@Sinabinas-MacBook-Pro-4.local> * F3: load the taste profile, and report a failed slug lookup The taste-profile probe double-quoted ~/.claude/.../gstack-slug, so the tilde never expanded and /design-consultation and /design-shotgun always printed NO_TASTE_PROFILE. Use quoteSafePath(); stop hiding gstack-slug's stderr and print TASTE_PROFILE_UNAVAILABLE with the fix when the slug cannot be resolved. * B4: DESIGN_READY only when the design binary actually starts DESIGN SETUP (and office-hours' visual exploration) printed DESIGN_READY for any executable binary, so one SIGKILLed at launch by an invalid macOS code signature still passed. Launch it under the portable 10-second deadline (gtimeout, timeout, or perl alarm); otherwise print DESIGN_NOT_AVAILABLE with the exit code, 'timed out after 10s', or on 137 the code-signature hint and 'Fix: cd <checkout> && ./setup'. A success is cached by inode and mtime under the state root so Gatekeeper's first-launch scan is paid once. The probe launches the binary with no arguments (usage, exit 0): the design CLI has no --version command today. * C2: name the runtime root every way a generated preflight may read it in the dist test The generator lane's C1 resolves D from $GSTACK_ROOT instead of $GSTACK_DESIGN, so the test now exports GSTACK_ROOT as well; it still fails on main (no dist in the roots) and passes with and without the C1 change. * A5: brain-sync stage fails loud when the artifacts source indexed zero pages The stage reported "curated artifacts pushed" whenever gstack-brain-sync exited 0, but a git push is not gbrain indexing. After a successful push the stage now reads the maintained artifacts source's page count (GSTACK_BRAIN_SOURCE_ID, else the source whose path is the artifacts worktree or state root): zero pages is ERR with the fix command; a missing source or an unavailable count says so instead of claiming indexing. Co-authored-by: Jimmy Zeisweiss <4261258+jzeisweiss@users.noreply.github.com> * B1: state the effective read-only sandbox in /codex review prose The codex parity invariant requires the skill to state sandbox_mode="read-only"; the command now takes it from _GSTACK_CODEX_SANDBOX, so the prose names the effective default explicitly. * A6: report deleted-worktree gbrain sources; prune only with proof, on request A deleted Conductor worktree leaves its gstack-code-<hash> source behind and gbrain's autopilot fails on it forever. Local absence is not proof a source is dead (machines sharing a federated brain register their own paths, and its pages may be the only copy of uncommitted work), so gstack never removes one automatically. - Each sync counts consecutive misses for gstack code sources whose path is missing, prints "path unavailable" once per source with the review command, and records which repository each synced source belongs to. - New gstack-gbrain-sync --prune-gone-worktrees (with --dry-run, whose plan it always prints first) removes a source only when its path was missing on two consecutive syncs, its parent is readable, recomputing deriveCodeSourceId() for that path on this host yields its id, and the repository's git common dir still exists and no longer lists the worktree. It re-checks the path right before removing (through the #1734-guarded safeSourcesRemove) and logs each removal. * D0: pass the Bun child flags after 'run' so wrappers that rewrite 'bun run' argv keep working bun run --no-env-file --config=/dev/null <script> has the same effect (verified on Bun 1.4.0) and keeps argv[1] === 'run', which the publication-lock fixture's preload injection relies on. The sidebar-tabs source guard now expects the flags in the terminal-agent spawn. * E8: count the BROWSE_EXTENSIONS_DIR persistent launch in the signal-flags guard The new launch site carries handleSIGINT/SIGTERM/SIGHUP false like the other three, so the guard's expected count moves from 3 to 4. * D2: give the memory-leak reproducer's fake request isNavigationRequest() wirePageEvents now runs the navigation guard on every request event; the fake request adapter supplies the method real Playwright requests have. * A7: run only the resolve_symbol_edges dream phase, detected first /sync-gbrain --dream and the --full auto-build ran gbrain's full dream cycle (~35 minutes, LLM phases) when the call graph needs only the resolve_symbol_edges phase. The stage now runs gbrain dream [--source <id>] --phase resolve_symbol_edges when the installed gbrain accepts that phase (detected by behavior: gbrain validates --phase before printing --help). Otherwise it skips the forced dream and says the full cycle costs about 35 minutes and how to run it, instead of starting it. Co-authored-by: liutiming <timingliu@outlook.com> * D0: keep the dotenv isolation test runnable on the Windows lane The compiled probe gets its .exe name on Windows, and the terminal-agent case (owner identity comes from ps) is skipped there. * B9: read cycle_freshness from a doctor run that includes it /sync-gbrain Step 3.5 and the --full auto-dream decision read CYCLE from gbrain doctor --json --fast, which skips the DB checks that carry cycle_freshness, so the answer was always "unknown". Both now read gbrain doctor --json --scope=brain (DB checks, no skill-file walk), parse its JSON even when doctor exits 1 for a failing check, and match the issue that names this source: "never completed" is never, "last cycled Nh ago" is completed. When the installed gbrain does not report the check, they say "unknown: installed gbrain does not expose cycle_freshness" (lib readCycleStatus carries the reason to the --full SKIP row). The source-probe fixture that pinned the --fast call and a made-up message format now answers --scope=brain with gbrain's real message. * B4: compact the launch probe (cache keyed on inode, valid while newer than the binary) Keeps design-consultation inside its parity size budget. * C4: migrate the ship docs-dispatch test to the carved external ship On Codex and Factory the documentation dispatch now lives in sections/documentation.md behind a pointer relative to the installed skill, like Claude; the test pinned the old inlined layout. * B5: learnings callers report a failed search instead of reading as empty Every generated gstack-learnings-search caller ended in 2>/dev/null || true, so a missing bun or a failed search looked like 'nothing recorded'. Callers now keep stdout, capture stderr and the exit status, and print 'LEARNINGS: unavailable (<first stderr line>)' on failure (resolver callers in learnings.ts and review-army.ts, plus investigate, qa and ship's adversarial section). * F1: ship and review count unverified/unavailable outside reviews as missing coverage INV-1 consumers in this lane's templates: /ship's readiness note, its PR body Pre-Landing Review section and /review's completion rule now say an outside review reporting unverified or unavailable is missing coverage, never a pass. The PR body's Plan Completion section prints F1's not-run line instead of the old 'No plan file detected.' The /ship union-size cap moves to 1.415 for these lines (measured 1.4148). * A8: rename the artifacts repo with OWNER/REPO, rewrite the remote only after it The v1.27.0.0 migration passed a bare repo name to gh repo rename / gh repo edit, which always fails (gh wants [HOST/]OWNER/REPO), then step 2 rewrote ~/.gstack-artifacts-remote.txt to the never-renamed repository. - Qualify both names with the owner from the recorded remote URL (else the signed-in gh user) and surface gh's error. - Step 2 moves the remote file but rewrites the URL only once the rename is confirmed; a later successful retry rewrites it then. - A pending journal now counts as state to migrate, so the #1383 retry actually re-runs step 1 (it used to see no legacy file and declare the migration done). - The v1.91.17.0 migration (placeholder name) repairs installs already hit: when the remote names gstack-artifacts-<user> that does not exist but gstack-brain-<user> does, it restores the old URL in the remote file and ~/.gstack's origin and says so. It only calls gh for such a remote and never fails the upgrade. Co-authored-by: Brandon Pugsley <aibpaem@gmail.com> * B8: read gbrain JSON with bun instead of jq in install and wireup gstack-gbrain-install read package.json with jq but never checked for it, so on a machine without jq a successful install failed with "cannot read version". gstack-gbrain-source-wireup hard-failed without jq ("brew install jq" is not actionable on git-bash), so the wireup was skipped on every run. Both now read the JSON with bun, which they already require. Co-authored-by: benjamin beres <benjamin.beres@bienpreter.com> * B4: shorter probe messages (design-consultation parity budget) * B5: shorter capture variable names (parity budget) * E7: find the Aside CLI in ~/.local/bin when it is not on PATH (#2902) The installer puts aside in ~/.local/bin, which is not on the default macOS login PATH, so the probe said NEEDS_ASIDE ('download Aside') for a healthy install. The probe now falls back to ~/.local/bin/aside, drives the resolved binary, and prints READY: <path> when it is off PATH so later blocks run that path. Ported from PR #2965 onto the current _gs_d probe. Co-authored-by: Som Samantray <som.samantray@gmail.com> * A2: key the dot-slug catalog entry on the message users actually saw * E1: cmd.exe-safe investigate freeze hook On Windows Claude Code runs hook commands through cmd.exe, which cannot parse the single-quoted bash -c argument, so /investigate's scope-lock hook never ran. Use one double-quoted bash -c script that names the hook path directly (no S= variable: POSIX sh would expand $S to empty and skip the hook). * F4: design resolver reads per-round variant paths $D variants now writes $_DESIGN_DIR/round-<N>/variant-*.png and prints JSON with roundDir, manifest and paths. The mockup flow and comparison-board loops build the board from those printed paths instead of hardcoded variant-{A,B,C}.png, and approved.json records approved_path and round so a round-1 choice made after round 2 still resolves. * E4: generators tolerate Bun's spurious EEXIST on Windows (#2329) Bun on Windows throws EEXIST from a recursive mkdir of an existing directory, so gen:skill-docs and the llms.txt writer crashed once a second file landed in a directory. Both now use lib/fs-utils' mkdirpSync (ported from PR #2329 onto the existing helper instead of a new scripts/fs-utils.ts). Co-authored-by: Vaughan <vaughan@cairnsitguy.com.au> * C7: keep the required-mode hook's exit-2 deny Copilot CLI treats a preToolUse exit 2 as deny (its hooks reference), and #2413 established exit 2 plus hookSpecificOutput as the shape Claude Code enforces, so the deny output stays as on main; only the matcher and the in-place upgrade of older 'Skill' entries change. * C3: guard Kiro's router copies on a present source; give the QA pointer adapter the copy and dist helpers A copy fails where a symlink dangled, so the Kiro router and upgrade copies are written only when their render exists (as every other runtime root already does). test/qa-lazy-sections' extracted Kiro installer now supplies _link_runtime_dists (C2) and the SKILL.md copy helpers (C3). * Q3: office-hours asks open-ended questions in a Q<N> prose form (#2719) In Conductor, and whenever AskUserQuestion fails, prose is the only channel, and the prose fallback defined only the D<N> decision brief. Phase 2A/2B diagnostic questions have no option set, so the model dropped the phase. Office-hours' preamble now defines the Q<N> open-question form (question, why I'm asking, what a strong answer sounds like) and routes free-text replies to it; the diagnostic sections name it. Scoped to office-hours so every other skill's preamble is unchanged. Ported from PR #2729. Co-authored-by: Bharadwaj Mittapelli <bharadwajmittapelli@gmail.com> * A2: render db-unreachable like timeout gbrain's new db-unreachable status is a transient network failure; a setup run while offline must not strip brain-aware blocks from every skill. * A2: treat db-unreachable like timeout in gbrain-refresh The memory lane's new db-unreachable status (network or DNS failure, config intact) is transient, so gbrain-refresh keeps rendering brain-aware blocks for it exactly as it does for timeout instead of suppressing them. * C8: a render given disabled skills drops them from the router (#3018) The root router named every skill and ends 'When in doubt, invoke the skill', so it routed to skills the user disabled. gen-skill-docs takes --disabled-skills (runGeneration disabledSkills): the router drops their routing rules, keeps the other side of an 'A or B' rule, and names them as disabled. The router and gstack-upgrade cannot be disabled. With no disabled skills the render is byte-identical. * G2/G3/INV-1: skill-start former-bucket notice and visible learnings failure; TMPDIR mktemp in gbrain bins; best-effort reasons * C9: Step 2 falls back to the install registry's source checkout (DX-7) Codex users who installed from the README's ~/gstack clone got 'ERROR: gstack not found' from /gstack-upgrade: Step 2 only looked under host skill directories. It now falls back to the source checkout the install registry recorded for the current host. * B4: design --version prints the version, and the probe uses it The design CLI treated --version as an unknown command (exit 1), so the probe launched the binary with no arguments instead. Add --version (prints the gstack version, exit 0, before auth or network) and probe with it, so messages read '<path> --version exited <code>' as planned. * C4: no external render points at a section file that is not installed design-html's detector install offer and plan-eng-review's self-check pointed at $GSTACK_ROOT/<skill>/sections/<file> on every external host, where neither skill is carved and no section tree exists. design-html now inlines the offer off Claude, and a skill's pointer to its own {{SECTION}}-inlined section names the inlined text. * C1: skillify finds the browse SDK under its own host's install root The template hardcoded ~/.claude/skills/gstack for the canonical browse-client.ts, so external hosts read another host's install or nothing. A new INSTALLED_ROOT resolver (sibling of INSTALLED_BIN_DIR) names the host's global root, or the per-install root when setup renders for one. * C4: rewrite section refs on hosts whose root stays a literal ~/<globalRoot> Kiro, OpenCode, Cursor and Copilot render ~/.claude/skills/gstack as their own literal root, not $GSTACK_ROOT, so plan-eng-review's self-check pointer escaped the rewrite (found by the setup lane's installed-pointer check). * Integrator: outside-voice fences use the shared runtime prelude; TMPDIR mktemp and per-round variant paths in design templates * Integrator: C8 router omits disabled skills on every render (relink renders the served Claude router in place); Windows-safe E4/E6 entries; investigate hooks under the cmd.exe check; browse_extension_id reader; order-insensitive test typecheck identities tsc printed one unchanged ceo-mode-option diagnostic's object members in a different order (content?/isError?) once lib/fs-utils joined the generator's import graph; identities now sort object-type members, and old baselines normalize on read. * Q1 (#2971 salvage): bound iOS proxy responses One wall-clock deadline covers headers and body (stalled and dribbling bodies time out), the whole body is capped at 64 MiB (upstream_response_too_large), every terminal path clears its timer, removes listeners and destroys the request, and the daemon threads the deadline through both listeners. Ambiguous mutations are still never replayed after a timeout or abort. Ported from #2971's proxy-transport work plus the size bound. * I1: grade the AUQ matrix's (recommended) marker on option labels, the field the auto-decide hook reads The decision-brief format puts a Pros / cons block with 'A) ... (recommended)' in the question text and the same marker on the option label. The matrix counted both and failed all six skills in periodic run 37151477069 with 'expected exactly one (recommended) option, found 2'. The question-preference hook reads labels only, so the gate now checks the native question: a Recommendation line in the question text and exactly one label ending in (recommended). Fixtures move to the native question shape and add the real spec capture plus a marker-only-in-text negative control. * Q1: type the proxy-transport test doubles (typecheck:test ratchet) * INV-1: gate outcome rows and troubleshooting sections for every lane's new messages * Release v1.91.19.0 (next free patch in the queue: #3022 holds 1.91.17.0, #3023 holds 1.91.18.0); migration renamed; engines.bun >=1.4.0 to match the CI pin (#2815) * v1.91.19.0 docs and metadata: CHANGELOG, TODOS, README troubleshooting/upgrade/type --selector, BROWSER.md type and profiles, AGENTS.md conventions, CONTRIBUTING #2949, touchfiles for the wave's new lib/bin files * I1: give hermetic Codex runs a temp dir beside CODEX_HOME so Codex can create its PATH aliases Codex 0.160 refuses to create its helper aliases (codex-linux-sandbox among them) when CODEX_HOME sits under its temp dir, and the runner put the hermetic home under the shard TMPDIR. Periodic run 37151477069 shows the warning and 'Unable to spawn codex-linux-sandbox ... No viable candidates found in PATH' for every exec_command in codex-sol-scope-termination. * I1: Codex evals fail a review whose commands never ran and stop reading tool errors as skill-load problems validateCodexReview accepted codex-review-findings in periodic run 37151477069 although its only command failed in bwrap ('I couldn't run the review'); it now requires execution evidence from classifyOutsideReview (B1's INV-1 classifier). codex-sol-scope-termination failed on 'apply_patch verification failed: invalid hunk' because the skill-load check matched any 'invalid'; it now matches Codex 0.160's skill-loader diagnostics only. * I1: run paid eval containers with seccomp unconfined so Codex's sandbox can start Docker's default seccomp profile blocks the user namespaces bubblewrap needs, so every Codex command in a paid eval failed with 'bwrap: No permissions to create a new namespace' (codex-review-findings, run 37151477069). Reproduced in the CI image locally: default profile fails, seccomp=unconfined runs the command. The runner stays non-root. * I1: shared-libs plan actor reads one exclusion grammar for scope lists Periodic run 37151477069 refused 'Existing-caller migration and helper hardening stay out of scope' as a hardening proposal: the actor had two partial exclusion rules (unanchored is/are/remains outside, and an anchored list that only stays unchanged), the third refusal at this boundary after 36633323521 and 36776104571. One anchored predicate now covers a bare list of scope nouns (hyphenated compounds included) with is/are/stays/remains and unchanged/untouched/excluded/out of scope/outside/not part; any other verb in the clause is still read as a proposal. Adds the real capture and two adversarial controls. * Parity caps: measured v1.91.19.0 union/skeleton sizes for ship, review, design-consultation, office-hours and design-shotgun, with the reason beside each * Regenerate generated output for v1.91.19.0 (gen:skill-docs --host all, goldens, llms.txt, context-budget fixture) * I1: plan-eng-review writes the Test Plan Artifact even while test choices are pending Periodic run 37151477069 (plan-eng-review-artifact): a non-interactive review recorded every Test review choice as pending and never wrote the QA test plan, because Step 5 said to write the artifact 'when these test and eval choices are resolved' while the artifact section says to list unresolved choices as pending. Both now say to write it after the decision gate, with unanswered choices under Pending Decisions. The pinned sentence becomes a meaning-level check. * I3: plan-eng-review states when findings first enter the report and that the scope menu's recommendation needs no repo probe Judge rationales for 'plan-eng-review/SKILL.md sections' (actionability 3.67 in periodic run 37151477069, clarity 3 in 36385945043 and 35567915613) cite two concrete tensions: 'do not add findings before Scope Challenge C' versus the ledger saves C itself performs, and 'Recommendation: A when a branch diff exists' versus 'do not probe for session state'. The write policy now says findings first enter through Scope Challenge C's ledger saves; the selector says its Recommendation line advises the user and needs no repository inspection. The pinned sentence becomes the new meaning-level regex. * I3: plan-ceo-review defines the closing sequence's cleanup step Two of three judge samples for 'plan-ceo-review/SKILL.md modes' in periodic run 37151477069 (actionability at the 4.0 gate) flag 'perform permitted cleanup' as never defined. The only cleanup the skill has is archiving old CEO plans, which needs approval; step 5 now says so. * I3: /qa-only's value-card rule names only its own card location qa-only rendered the /qa line 'Put it in the 8e.5 record (/qa) or under each proposed test (/qa-only)'; judge samples for 'qa-only/SKILL.md workflow' (actionability at the 4.0 gate in run 37151477069, 3.67 in 36907895813) flag the /qa-only-irrelevant 8e.5 record. The qa-mode bar now renders the invoking skill's location; both skills get shorter. * test-of-test ratchet: a repo script or setup read by path counts as product code codex-invocation-sites (runs scripts/gen-skill-docs.ts), gstack-config-gbrain-refresh (copies bin/<name> through a variable) and setup-cso-windows-probe (reads setup and scripts/build-cso-windows.ps1) exercise product code the detector could not see. * I1: DX floor actor strips the editor hint from the footer line only (from #2971) The custom-field reply normalization removed 'ctrl+g to edit in <editor>' from every line, so question text that resembled the menu footer could be rewritten and still authenticate. Only the last non-empty line is the footer. Ported from Garry's #2971 with its negative control. * I4: attribute every census testcase; deselections never count as SKIPPED The paid report counted every skipped JUnit testcase as SKIPPED and every testcase whose name was not a registry id as unattributed. On the 2026-10-03 census (run 37151477069) that was SKIPPED 82 / unattributed 72 (periodic) and SKIPPED 282 / unattributed 24 (gate), and every case-shard sibling also wrote a skipped history record that reset its pass-rate series. - attributeJUnitCase: a name is its registry id or CASE_TEST_NAMES label, else the only id its file registers, else the keyless file itself. Skipped other-tier cases, case-shard siblings, isolated or unselected cases and Bun's '(unnamed)' hook placeholders are zero-credit deselections with a reason and write no history record. Anything else is listed by name as unattributed. - One result and one history record per case per shard; a genuinely skipped selected case counts as SKIPPED and is listed with its reason, also in report-summary.md and collector-outcomes.json. SKIPPED panels show their reason and skipped trials are no longer called assertions. - CASE_TEST_NAMES labels for the three /cso cases. - tierSkipReason: a computed registration whose lane-tier ids are all registered to other test files is excluded at plan time, so the four gate and two periodic files that ran with every test skipped no longer take a runner. Census rerun: periodic SKIPPED 0 / unattributed 0, gate SKIPPED 0 / unattributed 0; verdicts unchanged. * I5: split the deploy file per case; guard PR-lane shard walls at 600 s test/skill-e2e-deploy.test.ts ran 668 s as one gate shard in the 2026-10-03 census (six sequential cases, 51-201 s each). It is now case-sharded, so each case is its own shard with its own (smaller) supervision budget; no timeout or budget was raised. - CASE_SHARDED_FILES gains the deploy file (names already equal ids). - Gate duration seeds for the six case keys from the census JUnit walls, so packing stays at 12 gate-census slices (CI cap 230m -> 200m). - shardDurationViolations + PR_LANE_SHARD_LIMIT_MS: a free test fails when a planned gate shard's recorded wall (committed seed, and the last gate census in test/fixtures/paid-report-census/gate-census-durations.json) exceeds 600 s. - Tests that pinned deploy as one shard follow the split (cookie planner keys, reuse fixture key, release/PR floors). * TODOS: /review fingerprint under Codex's read-only .git sandbox (found by the live Codex check) * Free-suite repairs from the first integrated Ubicloud run Product: - Outside-voice fences carry runtimeRootPrelude(ctx) explicitly again, so the resolver output runs on its own (the post-render pass skips fences that already assign GSTACK_ROOT); outsideVoiceRuntime stays deleted. - D5: an explicit CHROMIUM_PROFILE (gbrowser's per-workspace gbd) is never seeded from the shared profile or registered for `browse profiles prune`; this was also the free suite's write to the real ~/.gstack/browse-profiles.json. - gstack-ios-qa-daemon: BASH_COMPAT=50 for its >512-byte --help heredoc. Tests migrated to the wave's deliberate contract changes: - B1 heading admits `unverified`; sandbox flag is ${_GSTACK_CODEX_SANDBOX:?}; verdict-form output (VERDICT/FINDINGS/REASON); fake codex follows the preflight + stdin + -o form; Q2 notice marked shown in a private state root. - C1: an exported root needs bin/ and lib/; a lone GSTACK_BIN is not honored. - C4: plan-ceo-review is carved on every host (carrier, discovery and methodology fixtures read sections/ when the render has it). - E7: READY prints the resolved Aside path. - INV-3: the cookie-approval reconstruction reverses the bun-install mktemp template. - F1's `Plan:` binding read gets a reasoned tracker-guard exemption. - Browse stubs stop their server instead of scheduling process.exit; the headless launch check only counts browsers its own launch started. * Regenerate generated output after the outside-voice prelude repair * I1: revert the seccomp-only eval container option; it does not let Codex's sandbox start Run 37158847998 on this branch and a stock Ubicloud VM both show that seccomp=unconfined only moves bubblewrap's failure from 'No permissions to create a new namespace' to 'Failed to make / slave: Permission denied'. Codex's sandbox started only with the host sysctl kernel.apparmor_restrict_unprivileged_userns=0 plus seccomp and AppArmor unconfined on the container, which a container job cannot set from its steps. The relaxation bought nothing, so it goes; the fix is filed as a TODO for the integrator. This reverts commitec97187. * I1: a Codex review eval needs a completed command, not just review-shaped text Run 37158847998 recorded codex-review-findings as passed again: the agent wrote 'I couldn't run the review because the execution sandbox failed (bwrap: Failed to make / slave)', the failure never reached stderr or a command event, and no phrase rule matched. validateCodexReview now also requires at least one command_execution event that completed with exit 0. Fixtures gain that event; the CI output is a new negative control. * Evals lane follow-ups: close the skillify gate TODO (I2 green), file its open reds, CHANGELOG lines; refresh measured parity annotations * Regenerate generated output after merging wave/evals * D2: bound the navigation guard's tab reset (commit, 5 s) Ubicloud run 3: a click to a link-local link reported the block, but the reset's page.goto('about:blank') waited the full 30 s default navigation timeout, so the command hung past the test deadline and the stale block leaked into the next command. The reset now waits for commit only, with a 5 s bound. * I1: run Codex paid slices on a host-run job where bubblewrap can start Docker's default seccomp/AppArmor profiles and the Ubuntu 24.04 host's kernel.apparmor_restrict_unprivileged_userns=1 keep Codex's bubblewrap sandbox from starting in a job container, so every Codex command failed. The planner now packs Codex shards into their own slices (plan.codexSlices, validated against the entries); evals-periodic runs those slices on a new host-run job that lifts the host restriction and runs the same CI image with seccomp and AppArmor unconfined. Artifact names match eval-slices, so the report reconciles one manifest. Gate plans have no Codex slices. * I1: the /codex review eval passes only when Codex executed Run 37158847998 recorded codex-review as passed while the sandbox preflight said unavailable and no review ran: the case only checked the session exit and an optional output file. It now requires the shared validator's executed verdict (findings, clean or unverified) in the codex command's own output and a written, non-fail-closed GATE. * TODOS: characterize the free-suite timing reds from Ubicloud run 4 * I1: QA evidence names the probes to rerun after an input change, before the one-shot materialize ship-exploratory-late-input returned inconclusive in gate census 37158847998: the fixture locale changed after captures 001 and 002, the agent reran only input 9, and materialize (which publishes once) recorded capture 001 as open. Its next line then said to rerun what is open, which the published verdict no longer allowed. Every capture now lists the commands that observed an older input snapshot and have no rerun on current inputs (revalidate, plus the next line), and materialize's next line says the verdict is final. * I1: the eng batching counter reads records under "Section N — <review> review" headings plan-eng-multi-finding-batching failed in 6 of 12 runs with reviewCount 0-1 (or a timeout with every ask counted as Step 0). In run 37158847998 the agent asked 11 separate questions, each with a saved ledger record, but filed records R2-R10 under '## Section 1 — Architecture review'. The counter strips 'Section 1' but not the dash separator, so it rejected every record outside the Decision ledger and the floor never filled. Quoted, historical and unrelated headings still do not count. * I1: plan-eng-review-artifact names its report file without making it the only output Runs 37151477069 and 37158847998 wrote the whole review, including the GSTACK REVIEW REPORT, into review-output.md and never ran the Test Plan Artifact block. #3017 made the artifact a hard assertion and dropped the prompt's explicit artifact instruction, leaving 'Write your review to review-output.md' as the one named destination. The prompt now names that file as the selected report file and says every other output keeps the destination the skill gives it, without naming the artifact. * browse: close returns when Chromium exits; Xvfb cleanup does not wait on its own zombie BrowserManager.close() detached every 'disconnected' listener before browser.close(). That also removed Playwright's internal listener that resolves close(), so every launched-mode close waited the full 5 s race timeout (measured 5,000 ms on origin/main and on this branch; raw Playwright closes in ~50 ms), and Playwright 1.62 has no Browser.process() for the SIGKILL fallback. The daemon's SIGINT shutdown therefore took over 5 s, which reddened the CLI lifecycle test under load (1 of 8 on main) and left browsers alive at shard cleanup. gstack now detaches only its own listeners: close takes ~50 ms. cleanupXvfb treated a terminated Xvfb child as alive until our own blocked event loop reaped it, so every close waited a full second then sent SIGKILL to a zombie. A zombie now counts as exited; the display test counts only running Xvfb processes. * I1: office-hours-brain-writeback reads the long skill with Read and skips the preamble 4 of 18 trials ended error_max_turns at the unchanged 12-turn budget with a gbrain search but no gbrain put. The failing trial in 37151477069 read the 1260-line rendered SKILL.md with cat, got truncated output, spent four more turns re-reading it with sed, then ran the preamble's skill-start block. The passing trials skipped the preamble. The prompt now says to read the skill with the Read tool and skip the preamble, onboarding, telemetry and contributor sections, as the plan-eng fixtures already do. Budget unchanged. * CI: no credential-shaped URLs in added lines (quality scan); release floor measured on the merged tree The quality job's credential scan of the PR diff flagged 7 db.url_with_password lines: three docs lines now describe the login instead of spelling a URL, and three tests build the URL from parts. paid-retry-supervision's periodic release floor is the merged tree's measured 35,711 (main's value; the evals lane's 33,821 predates main's new paid files). * qa-evidence: hold the stdout-pipe cases on a FIFO, not on a paused child stream Ubicloud run 4 finished the blocked-forever case in 71 ms (it should take the 5 s write deadline): the 2 MB write was not held, because saturation depended on how the runtime buffers a paused child pipe. On POSIX the child's stdout is now a FIFO the test reads only when it chooses to, so the kernel holds the write; Windows keeps the paused pipe. * TODOS/CHANGELOG: the three run-4 timing reds are fixed at their causes (daemon close latency, FIFO-held pipe tests) * I1: a QA helper call bun could not load is checked at the installed path, not failed outright review-exploratory-small-cli failed gate census 37162480720 with 'command outside declared caller observation interface': the actor dropped one character from the shard directory in a gstack-qa-evidence capture path, bun refused to load it ('Module not found', exit 1), and the next call ran the same capture correctly. A failed call whose only output is bun's refusal for a gstack-qa-evidence/deadline path is now held to the interface as the same command at the installed helper path, so a compound or undeclared command still fails. * I1: plan-eng-review's final self-check names its three outputs The fixture-prompt repair did not hold: in 37162480720 plan-eng-review-artifact again wrote one review-output.md, ran the skeleton's read-back gate on it and stopped without the QA Test Plan artifact (no gstack-paths/gstack-slug block). The transcript shows the agent's last check before finishing is the skeleton's Section self-check, which said only 'and outputs'. It now names the saved report, the QA Test Plan artifact and the Review Log, each at its own destination or presented as not persisted (the existing write policy). * I1: revert the plan-eng-review self-check wording; it did not change the artifact outcome A local run of plan-eng-review-artifact in the CI image (Claude Code 2.1.284) ate2f65ab22still wrote one review-output.md in 8 turns and ran no Bash, so the QA Test Plan artifact block never ran. Keep the skill text unchanged; the case is deferred with its evidence. * I1: seed the Codex files' periodic durations from their first executing run Every Codex file recorded ~1 s because its commands could not start in the container (codex-e2e*, outside-voice, workflow). Run 37162480720 executed them on the host-run job; its slice 24 walls replace the placeholders so the planner packs the Codex slice by real work (7 files, ~4.9 min estimated). * Refresh scripts/free-test-durations.json (bun run test:ubicloud --record-durations; covers the wave's new test files) * evals2 follow-ups: outside-voice-evidence helper in five case touchfiles; close the evals lane's Codex-CI, late-input, batching and brain-writeback TODOs (run 37162480720); CHANGELOG lines * fix(browse): take the next free X display when a concurrent allocator wins the race Pick-then-spawn let two allocators (parallel daemons or test shards) choose the same free display; the losing Xvfb exited and the handoff failed (run 6, handoff 'failure before launch'). spawnFreeXvfb now treats a display taken during startup as a collision and moves on. Regression test forces the race with a delayed Xvfb wrapper (pre-fix: fails; two-process repro 13/15 -> 0/15). * test(ci): read the host-run Codex eval job's docker env, mounts and uploads eval-codex-slices runs on the host and passes its executor env through docker -e flags and HOME through a $RUNNER_TEMP/eval-home mount. The evidence and coordination tests now map those back to the container view instead of assuming job.container, and the job's native-capture upload carries the qa-callers paths like the other executors. * I1: plan-eng-review-artifact runs the real interactive review in a PTY, replacing the composing fixture The claude -p case told the model to skip the preamble and questions and go straight to the review. In 37151477069, 37158847998, 37162480720 and a local CI-image run it wrote the whole review into one file without executing the workflow, so it measured composing, not /plan-eng-review. The interactive batching PTY run in 37158847998 did write the artifact during Test review, so there is no product defect. New test/skill-e2e-plan-eng-artifact.test.ts keeps the case id, tier (periodic), kind (rule) and budget (CAPTURE_LONG_MS): it drives the real /plan-eng-review over the same dashboard plan and sources, answers each question with its first option, stops once the QA test plan exists or the report completes, and asserts the same requirement (exactly one new eng-review test plan in the run's own state root, about the dashboard change). The composing case is retired from skill-e2e-plan.test.ts in this commit. runPlanSkillCounting reports engTestPlans (read before fixture cleanup) and passes them to isCollectionComplete. One paid run in the CI image (Claude Code 2.1.284): pass, collection_complete at 498 s with one test plan. The new file takes its own periodic runner (seeded at 498 s), so the periodic census plans 26 slices: the planner's --max-parallel and both executors' caps move from 25 to 26 so every slice still starts at once; the paid-file census pin moves from 106 to 107. * evals2 final: plan-eng-review-artifact touchfiles point at its PTY file and helpers; plan file wall drops the moved case Applies the lane's touchfiles-data patch (its outside-voice-evidence hunks were already in9a96fb3). skill-e2e-plan.test.ts lost one 600 s case to skill-e2e-plan-eng-artifact.test.ts, so its periodic wall is two 900 s + two 600 s (3,000,000 + reserve) and its timeout pin lists the remaining cases. * TODOS/CHANGELOG: close plan-eng-review-artifact (real PTY review, 498 s pass) * test: plan-eng-review-artifact is a PTY runner consumer (selected by claude-pty-runner and pty-screen changes) * test(windows): spawn cmd.exe hooks verbatim, use a .invalid UNC host, and match CRLF fixtures and native separators windows-free-tests reds on364f0f3, each verified on windows-latest (46 pass, 1 POSIX-only skip, 0 fail): - investigate-freeze-path cmd.exe cases: Bun MSVC-quoted the command line cmd.exe parses, so cmd saw \"bash and failed; Node's shell spawn (what Claude Code uses) passes it verbatim. - investigate-freeze-path UNC cases: a single-label host made each filesystem probe wait on network name resolution (cd 11 s, -L 2.8 s); a reserved .invalid host fails at once (55-80 ms). - paid-report-census: the junit fixture is CRLF in a Windows checkout. - codex-invocation-sites: rendered paths use backslashes on Windows. * eval(plan-design-with-ui): the Step 0D focus title may spell the seven dimensions as a word Run 37166586458 slice 5 (dfaf154) asked 'D2 - Review all seven design dimensions, or focus on specific areas?' and reached its review finding, but the focus predicate only accepted the numeral, so the case failed with no acknowledged Design focus. Both recognizers accept 7 or seven; the byte-exact capture is a free regression, and engineering/other-count/ no-'design' titles stay rejected. * eval(ship-docsync): git check-ignore is a declared read in the docs observation interface Run 37166586458 slice 2 (dfaf154): ship-docsync-completion's parent ran 'git check-ignore -v .qa-state' to verify the prompt's claim that the observer probe is Git-excluded. The read was outside the closed Git list, so the run's DOC_PATH replacement was unprovable and failed. check-ignore cannot write; it joins the list and the interface prose. Free regression replays the captured command against the fixture and keeps composition and redirects rejected. * fix(browse): read Xvfb's own startup error to classify a lost display race Run 10 (1ffd38e) failed handoff's concurrent promotion once: 'Xvfb on :100 exited during startup (code 1)' with the display free again by the exit check, so a holder that won the lock and closed within the 100 ms poll looked like a broken install. Startup stderr now goes to a private file; 'Server is already active for display' is a collision and moves on, and any other startup exit carries Xvfb's fatal line. Regression: a stub that reports the collision for one display and exits leaves spawnFreeXvfb on the next display (pre-fix: the misleading install error). * test: merged-main fixtures (E6 copies the Claude render library gstack-config now sources; the census fixture's plan-mode-no-op budget follows its v1.91.18.0 policy) * qa: materialize runs once per PROBE_DIR, and qa-only says §1 reuses the REPORT_DIR it resolved Run 37170610789 slice 3 (feaa28d): the qa-only workflow judge scored clarity 3.33 and named two ambiguities: §4 said materialize runs once per report root while mixed runs materialize each surface's PROBE_DIR, and SKILL.md deferred exploratory §1 without saying §1 reuses the REPORT_DIR resolved under Prepare Report Artifacts. A local run of the same judge on the repaired text: clarity 3.67, completeness 4.33, actionability 4 (pass); all three samples call the workflow internally consistent. * Regenerate generated output for the qa materialize/REPORT_DIR wording * eval: three detector defects from run 37170610789 (feaa28d) - safety-codex-consult-embed: the fake codex recorded argv only, but every codex exec takes its prompt on stdin since E5; it records stdin for the '-' form and the check reads both. - ship-docsync-missing-asset: 'ls ... 2>&1' on a read-only command is the same harmless stderr wrapper as '2>/dev/null'; stdout redirects, pipes and script calls stay rejected. - qa-functional-webhook-fix: a pre-repair capture whose command reran on the repaired inputs may be classified superseded (exploratory §4); the evidence check accepts that and still rejects superseded on a post-repair capture or one never rerun. Each free regression fails without its repair. * fix(test:free): a browser record removed mid-read by a shutting-down daemon is absent Run 13 (feaa28d) needed the flaky-retry for 'owned detached browser settlement > cancel': 2 unattributed failures instead of 1. A 16-vCPU stress run reproduced it once in 64 with the cause: 'browser ownership unavailable'. On SIGINT the cancelled daemon removes its state file; record() saw it exist, then lstat/read hit ENOENT, which failure() reports as an ownership error. ENOENT there now means absent. New mode cancel-vanishing-record forces the removal between the check and the read (pre-fix: 2 unattributed, deterministic; now 1). * test(windows): the 2>&1 wrapper regression uses relative reads (no native paths in literal commands) * test(plan-seed): wait for the fixture CLI's slash event instead of a fixed 50 ms Run 14 (b2f729b) needed the flaky-retry for 'startup-placeholder': the events log had paste/enter/end_turn but not yet the slash 50 ms after it was sent. The check now polls (bounded 5 s); the deadline assertion measures when submission settled, which is what it bounds. One test typecheck diagnostic goes away with the typed reader. * eval(plan-design-with-ui): recognize the Step 0D focus question by meaning, not one title spelling Theb2f729bgate run titled it "I've rated this plan 5/10 on design completeness. Review all 7 dimensions, or focus on specific areas?", the third native wording to miss a spelling-pinned regex. The native form is now a class: a title that offers all seven (numeral or word) dimensions or passes versus a focus and names design. Captured titles from 37166586458 and this run pass; other counts, engineering passes, titles without design or without a focus stay rejected. * eval(shared-libs-read-only): curl answers the provider rate-limit probe with the same 404 as gh Gate census 37174266054 slice 9: the model probed API availability with curl -o /dev/null https://api.github.com/rate_limit (GET, discarded). The gh transport already answers rate_limit as an unknown endpoint (404); the curl transport refused it, and the refusal counted as a read-only violation. curl now gets the same 404. POST, file output, other repos and raw hosts stay refused. Paid rerun (gate, 1 trial): PASS in 177 s. * eval(shared-libs-plan-callers): an exclusion may combine states (unchanged/out of scope) Periodic census 37174266054: every option ended 'Scheduler semantics, existing callers and helper hardening stay unchanged/out of scope', which the actor read as proposing hardening. Exclusion states may now be joined by '/', 'or' or 'and'; the captured question is answered, and clauses that pair a state with a real change ('stay unchanged/harden the helper') are still refused. Paid rerun (periodic, 1 trial): PASS in 296 s. * paid: --case plan-eng-review-artifact selects its PTY test by its registered name A local --case run matched 0 tests (no spend): the PTY test's Bun name is not its case id, and CASE_TEST_NAMES had no label for it. * eval(plan-eng-review-artifact): periodic checkpoint resumes at Test review; the fresh full run moves to marathon A fresh interactive /plan-eng-review cannot reach Test review inside the 600 s periodic budget: startup plus one-at-a-time Scope Challenge questions took 595 s with six questions and no Test review in census 37174266054 and in a local run (one earlier fresh run passed at 498 s). Per the eval-speed policy, the long run moves to the non-blocking marathon lane and the blocking case becomes a focused checkpoint. - plan-eng-review-artifact (periodic, 600 s unchanged): resumes the real interactive skill from a saved review record: the plan, the Scope Challenge result, Sections 1-2 complete, and a Decision ledger rebuilt from that census run's six actual native questions and answers (test/fixtures/plan-eng-artifact-resume-37174266054.json). The live skill runs Section 3, Test review. Assertion unchanged: exactly one new eng-review test plan in the run's own state root, about the dashboard change. Paid trial (local, Claude Code 2.1.284): PASS, 364 s. - plan-eng-review-artifact-full (marathon, PTY_LONG_MS): the fresh start-to-finish run with the same assertion; budget measured beside it. - test/plan-eng-resume.test.ts proves the rebuilt record is a valid resume point and rejects missing, unanswered, edited or duplicated records. - Registry: touchfiles, tiers, kinds, test-name labels, durations, paid file count 115, PTY consumer list; CHANGELOG and TODOS. * setup-deploy: say which deploy fields count as confirmed, how to resolve the default branch, and group the detection tests Periodic census 37176837432: the setup-deploy workflow judge's actionability mean was 3.67 (4, 4, 3). The low sample named the Fly/Heroku/Railway/GitHub Actions deploy trigger left undefined until Step 4's 'not already confirmed' catch-all and an unstated way to find <default branch>, and misread 'A || B && C' detection lines. Step 4 now defines a confirmed field and names the paths that leave the trigger unset, <default branch> resolves with gh repo view, and the two OR'd detection tests are grouped explicitly (same behavior). One judge run on the repaired text: 4/4/4, pass. * Regenerate generated output for the setup-deploy wording * TODOS: census data for the skipped CEO mode handoff (mode-routing, auto-decide-preserved); floor runner Edit-permission parse under collapsed TTY spaces * fix(browse): a blocked navigation that fails at once leaves the tab blank and the next command clean PR CI on8d2d269(free-suite 3): the redirect to [::ffff:169.254.170.2] failed immediately on the runner, so its chrome-error page committed around the guard's about:blank reset, and leaving the error page committed a second about:blank after the reset resolved, interrupting the next three tests' gotos. The guard now lets the blocked request settle (bounded at 1 s; a hanging target is still cut off by the reset), resets, and waits for the main frame to stay quiet before returning. Regression: a redirect to a blocked address on Chromium's unsafe port 1 fails at once (pre-fix: blank check and the next goto fail, deterministically). * qa: the checkpoint note is created for browser runs and composed for functional ones Periodic census 37178143007: the qa-only workflow judge scored actionability 3.67 again; one sample read step 2's 'Create exploration-NNN.json' as applying to functional runs before reaching 'Functional: do not write this file'. The sentence now names both surfaces up front; byte-neutral (the browser line drops its restated clause), qa union 1.1098 under its 1.110 cap. One judge run on the repaired text: 3.67/4/4, pass. * Regenerate generated output for the qa checkpoint wording * eval(section-loading): byte-range prints of a section count as a complete read Periodic census 37178143007: plan-ceo-section-loading printed review-sections.md in five byte ranges (head -c 16000, then tail -c +N | head -c 17000, one-byte overlaps) and the detector, which matched whole printed lines, saw the lines split at each range edge as missing. Outputs of the commands that name the section are also joined on their overlap. Regression: the captured ranges count; dropping a middle range or the last range does not (pre-fix: the complete ranges were refused). * test(plan-design-review): count design terms the review wrote into the plan * fix(aside): probe names the platform (GSTACK_PLATFORM override) so the macOS pitch never re-probes the OS * fix(plan-ceo-review): Step 0E mode handoff runs gstack-ceo-mode-handoff so the selected mode is printed, not only composed * chore: refresh context-budget fixture * test(auto-decide): accept Step 0E's documented AUTO_DECIDE line with its decisions suffix; replay the captured trial * docs: CHANGELOG and TODOS for the CEO mode handoff and platform line * test(plan-design-review): plan-term credit needs a rated summary; adapter regression for census 37179171083 * test(auto-decide): the printed handoff may precede Step 0E's provenance log; replay census 37182865432; TODOS for two rotating census reds * test(plan-ceo-section-loading): read the skill's ledger and currentDecision records for the stale-fill decision; replay three census reports * test: $B counts as a browser call only in command position; qa functional prompt defines its classification values * test(shared-libs-plan-callers): a verbless unchanged-scope list is an exclusion; replay census 37186854666; TODOS for two census reds * fix(settings-hook): retry a lock released between mkdir and the existence check instead of dropping the mutation * test(ship-docsync): the child's reply to a parent SendMessage counts as its spawned-marker report; replay PR run 37188668421 * test(browse): Xvfb stub-failure tests allocate from ranges no other allocator uses * perf(ship): documentation gate snapshots and compares its candidate with gstack-docs-candidate * fix(review): unverified Codex mode runs the passes in the mode summary too; stale-fill decision check accepts any ledger row ID * test(shared-libs-plan-callers): judge scope by forbidden verb+object actions, not an exclusion grammar; replay six refusals and four passing censuses * test(shared-libs-plan-callers): type the brief-line parameter * test(ship-docsync): an inline-code status quote is not a false current claim; replay PR run 37196811165 * fix(review,ship): Codex challenge and structured-review bodies run in unverified mode, matching their headers * docs(TODOS): overlay-harness control-arm error and format-approach provider refusals, with run links * docs(TODOS): qa-only workflow judge data point --------- Co-authored-by: Lewis <lewispeel@hotmail.com> Co-authored-by: Yugz <yannduzelier@gmail.com> Co-authored-by: Florian <florian.cleyetmerle@gmail.com> Co-authored-by: cdecook23 <decook23@gmail.com> Co-authored-by: mb1810 <michael.berger1810@gmail.com> Co-authored-by: Koda <koda@edgeviewfinance.com.au> Co-authored-by: Merit Blake <merit@newsprint.com> Co-authored-by: Nguyen Thanh Dat <ntdat812@gmail.com> Co-authored-by: pneumorea-ai <pneumorea@gmail.com> Co-authored-by: maxpetrusenkoagent <max.petrusenko.agent@gmail.com> Co-authored-by: Matt Van Horn <mvanhorn@gmail.com> Co-authored-by: Infiniteyieldai <infiniteyield.ai@gmail.com> Co-authored-by: Gabriel Rondon <grondon@gmail.com> Co-authored-by: Davon Johnson <d.johnson@dayofshow.net> Co-authored-by: Kevin Grasso <kevin@biblingo.com> Co-authored-by: Xuan-Ce Wang <261591073+xwang4-svg@users.noreply.github.com> Co-authored-by: loulanyue <260355617@qq.com> Co-authored-by: Thomas Reuser <thomasreuser@gmail.com> Co-authored-by: Bit0ps <alex.dreamscaper@gmail.com> Co-authored-by: oli548 <312288720+oli548@users.noreply.github.com> Co-authored-by: Slava <slava.istomin@tuta.io> Co-authored-by: ryanlaiwy <129729476+ryanlaiwy@users.noreply.github.com> Co-authored-by: 李翊楠 <yinanli1917@gmail.com> Co-authored-by: Mammad M. <mammad@digit.az> Co-authored-by: Lockyer <135391289+Lockyer228@users.noreply.github.com> Co-authored-by: Spooks444 <193448029+Spooks444@users.noreply.github.com> Co-authored-by: punksterlabs <77217235+punksterlabs@users.noreply.github.com> Co-authored-by: Jonathan Zhang <topcoder1@Mac-Studio.local> Co-authored-by: Marek Cermak <marek.cermak@strv.com> Co-authored-by: y$un_ <forrest.sun527@gmail.com> Co-authored-by: neallee <neallee@gmail.com> Co-authored-by: hardy <932821449@qq.com> Co-authored-by: afshaker <andrew@phone2.io> Co-authored-by: cube <frosimanuel@gmail.com> Co-authored-by: jacob-wang <jiayuw794@gmail.com> Co-authored-by: miao <miao@macmini-2.local> Co-authored-by: Jonah Berg <jonah.berg.g@gmail.com> Co-authored-by: Jayesh Betala <jayesh.betala7@gmail.com> Co-authored-by: Ryan Alberts <ryan.a.alberts@gmail.com> Co-authored-by: AlinValentin7 <AlinValentin7@users.noreply.github.com> Co-authored-by: Evgenii Lopatin <e75533@gmail.com> Co-authored-by: Jino <dgfrty00@gmail.com> Co-authored-by: snig-17 <santosh.m.tiwari@gmail.com> Co-authored-by: Sholto McNeilage <sholto@nodenarrative.com.au> Co-authored-by: Phil Hie <philhie@outlook.com> Co-authored-by: Sinabina <sinabina@Sinabinas-MacBook-Pro-4.local> Co-authored-by: Jimmy Zeisweiss <4261258+jzeisweiss@users.noreply.github.com> Co-authored-by: liutiming <timingliu@outlook.com> Co-authored-by: Brandon Pugsley <aibpaem@gmail.com> Co-authored-by: benjamin beres <benjamin.beres@bienpreter.com> Co-authored-by: Som Samantray <som.samantray@gmail.com> Co-authored-by: Vaughan <vaughan@cairnsitguy.com.au> Co-authored-by: Bharadwaj Mittapelli <bharadwajmittapelli@gmail.com>
2275 lines
97 KiB
TypeScript
2275 lines
97 KiB
TypeScript
#!/usr/bin/env bun
|
|
/**
|
|
* gstack-gbrain-sync — V1 unified sync verb.
|
|
*
|
|
* Orchestrates three storage tiers per plan §"Storage tiering":
|
|
*
|
|
* 1. Code (current repo) → `gbrain sources add` (idempotent via
|
|
* lib/gbrain-sources.ts) + `gbrain sync
|
|
* --strategy code` (incremental) or
|
|
* `gbrain reindex-code --yes` (--full).
|
|
* NEVER `gbrain import` (markdown only).
|
|
* 2. Transcripts + curated memory → gstack-memory-ingest (typed put_page)
|
|
* 3. Curated artifacts to git → gstack-brain-sync (existing pipeline)
|
|
*
|
|
* Modes:
|
|
* --incremental (default) — mtime fast-path; runs all 3 stages with cache hits
|
|
* --full — first-run; full walk + reindex; honest budget per ED2
|
|
* --dry-run — preview what would sync; no writes anywhere (incl. state file)
|
|
*
|
|
* Concurrency safety per /plan-eng-review D1:
|
|
* - Lock file at ~/.gstack/.sync-gbrain.lock (PID + start ts).
|
|
* - Stale-lock takeover after 5 min (process death).
|
|
* - State file written via tmp+rename for atomicity.
|
|
* - Lock released in finally; SIGINT/SIGTERM trapped for cleanup.
|
|
*
|
|
* --watch (V1.5 P0 TODO): file-watcher daemon. NOTE: gbrain v0.25.1 already
|
|
* ships `gbrain sync --watch [--interval N]` and `gbrain sync --install-cron`;
|
|
* when revisited, /sync-gbrain --watch wires through to the gbrain CLI rather
|
|
* than building a gstack-side daemon.
|
|
*/
|
|
|
|
import { existsSync, statSync, mkdirSync, writeFileSync, readFileSync, unlinkSync, renameSync, realpathSync, readdirSync, appendFileSync } from "fs";
|
|
import { join, dirname } from "path";
|
|
import { execSync, spawnSync } from "child_process";
|
|
import { homedir, hostname } from "os";
|
|
import { createHash } from "crypto";
|
|
|
|
import "../lib/conductor-env-shim";
|
|
import { detectEngineTier, withErrorContext, canonicalizeRemote } from "../lib/gstack-memory-helpers";
|
|
import {
|
|
constrainSourceId,
|
|
ensureSourceRegistered,
|
|
sourcePageCount,
|
|
parseSourcesList,
|
|
readCycleStatus,
|
|
decidePrune,
|
|
trackUnavailableSources,
|
|
type CodeSourceRecord,
|
|
type CycleStatus,
|
|
type UnavailableSource,
|
|
} from "../lib/gbrain-sources";
|
|
import { detectAutopilot, decideSourceRemove, decideCodeSync } from "../lib/gbrain-guards";
|
|
import { writeReceipt } from "../lib/egress-receipt";
|
|
import { dbUnreachableReason, localEngineStatus, localEngineStatusDetail, type LocalEngineStatus } from "../lib/gbrain-local-status";
|
|
import { buildGbrainEnv, spawnGbrain, spawnGbrainAsync, execGbrainJson, NEEDS_SHELL_ON_WINDOWS, bashScriptInvocation } from "../lib/gbrain-exec";
|
|
import { repoPolicyTier as sharedRepoPolicyTier } from "../lib/gbrain-repo-policy-client";
|
|
import { checkOwnedStagingDir } from "../lib/staging-guard";
|
|
import { resolveStateRoot } from "../lib/state-root";
|
|
import type { TranscriptConsent } from "./gstack-memory-ingest";
|
|
import {
|
|
describeTranscriptPolicy,
|
|
isScoped,
|
|
readTranscriptConsent,
|
|
reposHash,
|
|
type TranscriptPolicy,
|
|
} from "../lib/transcript-consent";
|
|
|
|
// ── Types ──────────────────────────────────────────────────────────────────
|
|
|
|
type Mode = "incremental" | "full" | "dry-run";
|
|
|
|
export interface CliArgs {
|
|
mode: Mode;
|
|
quiet: boolean;
|
|
noCode: boolean;
|
|
noMemory: boolean;
|
|
noBrainSync: boolean;
|
|
codeOnly: boolean;
|
|
/** Force the source-scoped dream cycle (builds this source's call graph). Always runs. */
|
|
dream: boolean;
|
|
/** Opt out of the dream cycle that `--full` would otherwise auto-run. */
|
|
noDream: boolean;
|
|
/** #1734: opt-in to sync a URL-managed source whose code walk may auto-reclone. */
|
|
allowReclone: boolean;
|
|
/** #2922: `--sources <list|all>` for the memory stage; wins over GSTACK_MEMORY_INGEST_SOURCES. */
|
|
memorySources?: string;
|
|
/** A6: remove gstack code sources whose worktree is provably gone (with --dry-run: report only). */
|
|
pruneGone?: boolean;
|
|
}
|
|
|
|
interface CodeStageDetail {
|
|
source_id?: string;
|
|
source_path?: string;
|
|
page_count?: number | null;
|
|
last_imported?: string;
|
|
status?:
|
|
| "ok"
|
|
| "skipped"
|
|
| "failed"
|
|
| "refused-autopilot"
|
|
| "refused-reclone"
|
|
| "refused-egress-receipt"
|
|
| "skipped-policy-read-only"
|
|
| "refused-policy-deny"
|
|
| "refused-policy-unreadable";
|
|
}
|
|
|
|
interface StageResult {
|
|
name: string;
|
|
ran: boolean;
|
|
ok: boolean;
|
|
duration_ms: number;
|
|
summary: string;
|
|
/**
|
|
* Stage ran and did not error, but the outcome is a degraded no-op the user
|
|
* should know about (e.g. dream completed but the schema pack can't extract
|
|
* code symbols, so the call graph stays empty). Rendered as WARN, counts as
|
|
* ok for the exit code — it's not a failure, just not the happy path.
|
|
*/
|
|
warn?: boolean;
|
|
/** Stage-specific structured detail. Code stage carries source_id + page_count. */
|
|
detail?: CodeStageDetail;
|
|
/** Memory stage: the type selection its ingest staged (resume must match it). */
|
|
memory_sources?: string[];
|
|
/** Memory stage: transcript consent read at sync start (resume must match it). */
|
|
transcript_consent?: TranscriptConsentRecord;
|
|
}
|
|
|
|
interface TranscriptConsentRecord {
|
|
/** Normalized transcript_ingest_mode: recent | all | new | off | not-set | legacy | unrecognized | repos-unreadable. */
|
|
mode: string;
|
|
window: "recent" | "all" | "new" | null;
|
|
/** Why transcripts were not ingested; absent when they were. */
|
|
skip_reason?: string;
|
|
/** The new@ cutoff in force; a changed cutoff restages. */
|
|
cutoff?: string;
|
|
/** Hash of the transcript_repos allowlist in force; a scope change restages. */
|
|
repos_hash?: string;
|
|
}
|
|
|
|
// ── Constants ──────────────────────────────────────────────────────────────
|
|
|
|
const HOME = homedir();
|
|
const GSTACK_HOME = resolveStateRoot();
|
|
const STATE_PATH = join(GSTACK_HOME, ".gbrain-sync-state.json");
|
|
const LOCK_PATH = join(GSTACK_HOME, ".sync-gbrain.lock");
|
|
const STALE_LOCK_MS = 5 * 60 * 1000;
|
|
|
|
// Dream (call-graph build) is brain-global and runs LOCK-FREE after the sync
|
|
// lock releases, so it can't use the sync lock to dedupe across worktrees. A
|
|
// dedicated short-TTL marker prevents two worktrees from launching duplicate
|
|
// ~35-min global jobs. TTL matches the dream timeout default so a crashed run
|
|
// can't wedge the marker longer than one cycle.
|
|
const DEFAULT_DREAM_TIMEOUT_MS = 45 * 60 * 1000; // 45min — dream is the slow stage
|
|
const DREAM_MARKER_STALE_MS = DEFAULT_DREAM_TIMEOUT_MS;
|
|
|
|
/**
|
|
* Marker path computed fresh per call (not a module const) so tests can mutate
|
|
* GSTACK_HOME at runtime — same pattern as cacheFilePath() in
|
|
* lib/gbrain-local-status.ts. Avoids the ESM static-import hoist trap where a
|
|
* module-load-time const captures the real ~/.gstack before a test can redirect.
|
|
*/
|
|
export function dreamMarkerPath(): string {
|
|
return join(resolveStateRoot(), ".dream-in-progress");
|
|
}
|
|
|
|
// Default 35-minute timeout for code-walk + memory-ingest stages. Override via
|
|
// GSTACK_SYNC_CODE_TIMEOUT_MS / GSTACK_SYNC_MEMORY_TIMEOUT_MS. Bounds-checked
|
|
// in resolveStageTimeoutMs below so wildly-low values don't make resume
|
|
// useless and wildly-high values don't mask config typos. See #1611.
|
|
const DEFAULT_STAGE_TIMEOUT_MS = 35 * 60 * 1000; // 2_100_000ms = 35min
|
|
const MIN_STAGE_TIMEOUT_MS = 60_000; // 1 minute floor
|
|
const MAX_STAGE_TIMEOUT_MS = 86_400_000; // 24 hour ceiling
|
|
|
|
/**
|
|
* Memory types that bin/gstack-memory-ingest.ts accepts via --sources.
|
|
* Keep in sync with ALL_TYPES there (#2922).
|
|
*/
|
|
export const MEMORY_INGEST_TYPES = [
|
|
"transcript",
|
|
"eureka",
|
|
"learning",
|
|
"timeline",
|
|
"ceo-plan",
|
|
"design-doc",
|
|
"retro",
|
|
"builder-profile-entry",
|
|
] as const;
|
|
|
|
/**
|
|
* Memory types whose files a registered federated gstack source already
|
|
* imports: the markdown paths gstack-artifacts-init allowlists
|
|
* (projects/*\/ceo-plans/*.md, projects/*\/*-design-*.md) under gbrain's
|
|
* markdown strategy, which skips .jsonl. Ingesting them again duplicates
|
|
* every curated page (#2922).
|
|
*/
|
|
export const FEDERATED_CURATED_TYPES = ["ceo-plan", "design-doc"] as const;
|
|
|
|
/**
|
|
* Parse a --sources / GSTACK_MEMORY_INGEST_SOURCES value into a validated
|
|
* type subset (#2922). Returns null when the value is unset or empty, or is
|
|
* `all` (walk every type). Unknown tokens are dropped with a stderr warning;
|
|
* when nothing valid remains, returns null with a warning rather than
|
|
* failing the whole memory stage.
|
|
*/
|
|
export function resolveMemoryIngestSources(
|
|
envValue: string | undefined,
|
|
envName: string,
|
|
): string[] | null {
|
|
if (envValue === undefined || envValue.trim() === "" || envValue.trim() === "all") return null;
|
|
const valid: string[] = [];
|
|
const dropped: string[] = [];
|
|
for (const token of envValue.split(",")) {
|
|
const t = token.trim();
|
|
if (t === "") continue;
|
|
if ((MEMORY_INGEST_TYPES as readonly string[]).includes(t)) {
|
|
if (!valid.includes(t)) valid.push(t);
|
|
} else {
|
|
dropped.push(t);
|
|
}
|
|
}
|
|
if (dropped.length > 0) {
|
|
console.warn(
|
|
`[sync] ${envName}: ignoring unknown memory type(s): ${dropped.join(", ")} (valid: ${MEMORY_INGEST_TYPES.join(", ")})`,
|
|
);
|
|
}
|
|
if (valid.length === 0) {
|
|
console.warn(
|
|
`[sync] ${envName}="${envValue}" names no valid memory types; running a full memory walk`,
|
|
);
|
|
return null;
|
|
}
|
|
return valid;
|
|
}
|
|
|
|
/**
|
|
* The federated source registered for the gstack artifacts worktree (or the
|
|
* state root itself), if any. Its pages already cover FEDERATED_CURATED_TYPES.
|
|
*/
|
|
export function federatedCuratedSourceId(env?: NodeJS.ProcessEnv): string | null {
|
|
const rows = parseSourcesList(execGbrainJson(["sources", "list", "--json"], { baseEnv: env, timeout: 10_000 }));
|
|
const row = rows.find((r) => (r as { federated?: boolean }).federated === true && isArtifactsSourceRow(r, env));
|
|
return row?.id ?? null;
|
|
}
|
|
|
|
/** A source this installation maintains for its curated artifacts (the worktree or the state root). */
|
|
function isArtifactsSourceRow(r: { local_path?: string }, env?: NodeJS.ProcessEnv): boolean {
|
|
const realOrSelf = (p: string): string => {
|
|
try {
|
|
return realpathSync(p);
|
|
} catch {
|
|
return p;
|
|
}
|
|
};
|
|
const home = (env ?? process.env).HOME || HOME;
|
|
const owned = new Set([
|
|
realOrSelf((env ?? process.env).GSTACK_BRAIN_WORKTREE || join(home, ".gstack-brain-worktree")),
|
|
realOrSelf(GSTACK_HOME),
|
|
]);
|
|
return !!r.local_path && owned.has(realOrSelf(r.local_path));
|
|
}
|
|
|
|
/**
|
|
* A5 (#2670): after a successful artifacts push, report what gbrain actually
|
|
* holds. A git push is not indexing; a maintained artifacts source with zero
|
|
* pages is the one provably broken state and fails the stage.
|
|
*/
|
|
export function brainSyncIndexVerdict(env: NodeJS.ProcessEnv = process.env): { ok: boolean; summary: string } {
|
|
const raw = execGbrainJson(["sources", "list", "--json"], { baseEnv: env, timeout: 10_000 });
|
|
if (raw === null) {
|
|
return { ok: true, summary: "curated artifacts pushed to git; gbrain page count unavailable (gbrain sources list failed)" };
|
|
}
|
|
const explicit = env.GSTACK_BRAIN_SOURCE_ID;
|
|
const row = parseSourcesList(raw).find((r) => (explicit ? r.id === explicit : isArtifactsSourceRow(r, env)));
|
|
if (!row?.id) {
|
|
return { ok: true, summary: "curated artifacts pushed to git (no gbrain artifacts source on this machine, so indexing is not checked here)" };
|
|
}
|
|
if (typeof row.page_count !== "number") {
|
|
return { ok: true, summary: `curated artifacts pushed to git; gbrain source ${row.id} did not report a page count` };
|
|
}
|
|
if (row.page_count === 0) {
|
|
return {
|
|
ok: false,
|
|
summary:
|
|
`curated artifacts pushed to git, but gbrain source ${row.id} has 0 indexed pages. ` +
|
|
`Fix: gbrain sync --source ${row.id}, then re-run /sync-gbrain`,
|
|
};
|
|
}
|
|
return { ok: true, summary: `curated artifacts pushed; gbrain source ${row.id} has ${row.page_count} pages` };
|
|
}
|
|
|
|
export interface MemorySourceSelection {
|
|
/** null = no --sources flag (walk every type). */
|
|
sources: string[] | null;
|
|
why: string;
|
|
}
|
|
|
|
/**
|
|
* Explicit --sources wins, then GSTACK_MEMORY_INGEST_SOURCES. With neither,
|
|
* skip the curated types a registered federated gstack source already owns,
|
|
* so a default sync stops duplicating them. `probe` false (dry-run) never
|
|
* spawns gbrain.
|
|
*/
|
|
export function selectMemorySources(
|
|
flag: string | undefined,
|
|
env: NodeJS.ProcessEnv,
|
|
probe: boolean,
|
|
): MemorySourceSelection {
|
|
if (flag !== undefined) return { sources: resolveMemoryIngestSources(flag, "--sources"), why: "--sources" };
|
|
const fromEnv = env.GSTACK_MEMORY_INGEST_SOURCES;
|
|
if (fromEnv !== undefined && fromEnv.trim() !== "") {
|
|
return { sources: resolveMemoryIngestSources(fromEnv, "GSTACK_MEMORY_INGEST_SOURCES"), why: "GSTACK_MEMORY_INGEST_SOURCES" };
|
|
}
|
|
if (!probe) {
|
|
return { sources: null, why: "default: curated types are skipped at run time when a federated gstack source is registered" };
|
|
}
|
|
const federated = federatedCuratedSourceId(env);
|
|
if (!federated) return { sources: null, why: "default: no federated gstack source registered" };
|
|
return {
|
|
sources: MEMORY_INGEST_TYPES.filter((t) => !(FEDERATED_CURATED_TYPES as readonly string[]).includes(t)),
|
|
why: `default: ${FEDERATED_CURATED_TYPES.join(",")} already indexed by federated source ${federated}`,
|
|
};
|
|
}
|
|
|
|
export interface ConsentedSelection {
|
|
/** Value for the ingest's --sources flag; null = let the ingest walk its default. */
|
|
sources: string[] | null;
|
|
/** Types this run stages (recorded for resume). */
|
|
selected: string[];
|
|
/** Transcripts are ingested only because an explicit list names them. */
|
|
override: boolean;
|
|
why: string;
|
|
}
|
|
|
|
/**
|
|
* Apply transcript consent to a memory source selection. Without consent
|
|
* (anything but `recent` or `all`), transcript is removed and the remaining
|
|
* types are passed as an explicit list, so a config change made while the
|
|
* sync runs cannot add transcripts to this run. Only an explicit --sources or
|
|
* GSTACK_MEMORY_INGEST_SOURCES list that names transcript overrides that;
|
|
* `all`, empty and invalid-only values resolve to null and do not.
|
|
*/
|
|
export function applyTranscriptConsent(selection: MemorySourceSelection, consent: TranscriptConsent): ConsentedSelection {
|
|
const explicit = selection.why === "--sources" || selection.why === "GSTACK_MEMORY_INGEST_SOURCES";
|
|
const override = !consent.affirmative && explicit && !!selection.sources?.includes("transcript");
|
|
if (consent.affirmative || override) {
|
|
return { sources: selection.sources, selected: selection.sources ?? [...MEMORY_INGEST_TYPES], override, why: selection.why };
|
|
}
|
|
const selected = (selection.sources ?? [...MEMORY_INGEST_TYPES]).filter((t) => t !== "transcript");
|
|
return { sources: selected, selected, override: false, why: `${selection.why}; no transcript consent (${consent.reason})` };
|
|
}
|
|
|
|
export const TRANSCRIPT_CHOICE_HINT =
|
|
"To choose: run /sync-gbrain, or gstack-config set transcript_ingest_mode recent|all|off. Details: setup-gbrain/memory.md#transcripts";
|
|
|
|
/**
|
|
* The stderr notice for a run that does not ingest transcripts by consent.
|
|
* Returns null when nothing should print: consent given, or a stored `off`
|
|
* under --quiet.
|
|
*/
|
|
export function transcriptConsentNotice(consent: TranscriptConsent, quiet: boolean, override: string | null = null): string | null {
|
|
if (consent.affirmative) return null;
|
|
const value = consent.value ?? "not set";
|
|
if (override) {
|
|
const scope = isScoped(consent) ? " The new@ cutoff and transcript_repos allowlist still apply." : "";
|
|
return `gbrain-sync: transcripts ingested because ${override} names transcript (transcript_ingest_mode=${value}).${scope} ${TRANSCRIPT_CHOICE_HINT}`;
|
|
}
|
|
if (consent.reason === "off") return quiet ? null : "gbrain-sync: transcripts off (your choice)";
|
|
if (consent.reason === "repos-unreadable") {
|
|
return `gbrain-sync: transcripts skipped (transcript_ingest_mode=${value}): its +repos marker needs a transcript_repos allowlist, which is missing or empty. Other memory still syncs. ${TRANSCRIPT_CHOICE_HINT}`;
|
|
}
|
|
return `gbrain-sync: transcripts skipped (transcript_ingest_mode=${value}). Other memory still syncs. ${TRANSCRIPT_CHOICE_HINT}`;
|
|
}
|
|
|
|
/** The consent in words for a consenting run (window or cutoff, repos, config roots). */
|
|
export function transcriptConsentSummary(consent: TranscriptPolicy, quiet: boolean): string | null {
|
|
if (!consent.affirmative || quiet) return null;
|
|
return `gbrain-sync: transcripts: ${describeTranscriptPolicy(consent)}`;
|
|
}
|
|
|
|
/** The consent record a memory stage stores; resume requires every field to match. */
|
|
export function transcriptConsentRecord(consent: TranscriptConsent, override: boolean): TranscriptConsentRecord {
|
|
const record: TranscriptConsentRecord = { mode: consent.reason, window: consent.window };
|
|
if (!consent.affirmative && !override) record.skip_reason = consent.reason;
|
|
if (consent.cutoff !== undefined) record.cutoff = consent.cutoff;
|
|
if (consent.repos !== undefined) record.repos_hash = reposHash(consent.repos);
|
|
return record;
|
|
}
|
|
|
|
/**
|
|
* Parse a stage-timeout env value with bounds validation. Returns the bounded
|
|
* value or the default with a stderr warning if the env was malformed or
|
|
* out-of-range. Exported for the regression test.
|
|
*/
|
|
export function resolveStageTimeoutMs(
|
|
envValue: string | undefined,
|
|
envName: string,
|
|
defaultMs: number = DEFAULT_STAGE_TIMEOUT_MS,
|
|
): number {
|
|
if (envValue === undefined || envValue === "") return defaultMs;
|
|
const n = Number.parseInt(envValue, 10);
|
|
if (!Number.isFinite(n) || Number.isNaN(n) || n <= 0) {
|
|
console.warn(
|
|
`[sync] ${envName}="${envValue}" is not a positive integer; falling back to ${defaultMs}ms`,
|
|
);
|
|
return defaultMs;
|
|
}
|
|
if (n < MIN_STAGE_TIMEOUT_MS) {
|
|
console.warn(
|
|
`[sync] ${envName}=${n} is below the ${MIN_STAGE_TIMEOUT_MS}ms (1min) floor; falling back to ${defaultMs}ms`,
|
|
);
|
|
return defaultMs;
|
|
}
|
|
if (n > MAX_STAGE_TIMEOUT_MS) {
|
|
console.warn(
|
|
`[sync] ${envName}=${n} is above the ${MAX_STAGE_TIMEOUT_MS}ms (24h) ceiling; falling back to ${defaultMs}ms`,
|
|
);
|
|
return defaultMs;
|
|
}
|
|
return n;
|
|
}
|
|
|
|
/**
|
|
* gbrain writes ~/.gbrain/import-checkpoint.json on every import run. If a
|
|
* previous /sync-gbrain hit the timeout (SIGTERM = exit 143), the checkpoint
|
|
* + its staging dir survive on disk. Detect both and let gbrain resume from
|
|
* processedIndex+1 on the next run. If the staging dir is missing/empty/
|
|
* unreadable, fall through to a fresh restage with a one-line warning so the
|
|
* user sees we noticed. See #1611 + plan D1/C1.
|
|
*/
|
|
interface GbrainCheckpoint {
|
|
dir?: string;
|
|
totalFiles?: number;
|
|
processedIndex?: number;
|
|
completedFiles?: number;
|
|
timestamp?: string;
|
|
}
|
|
|
|
export function readGbrainCheckpoint(): GbrainCheckpoint | null {
|
|
// Read HOME from env so tests can redirect via process.env.HOME = ...
|
|
// (Node/Bun's os.homedir() caches at process start and ignores later
|
|
// mutations.)
|
|
const home = process.env.HOME || homedir();
|
|
const cpPath = join(home, ".gbrain", "import-checkpoint.json");
|
|
if (!existsSync(cpPath)) return null;
|
|
try {
|
|
const raw = readFileSync(cpPath, "utf-8");
|
|
const parsed = JSON.parse(raw);
|
|
if (!parsed || typeof parsed !== "object") return null;
|
|
return parsed as GbrainCheckpoint;
|
|
} catch {
|
|
// Corrupt JSON — treat as no checkpoint and fall through to fresh restage.
|
|
return null;
|
|
}
|
|
}
|
|
|
|
export type ResumeVerdict =
|
|
| { kind: "no-checkpoint" }
|
|
| { kind: "resume"; stagingDir: string; processedIndex: number; totalFiles: number }
|
|
| { kind: "stale-staging-missing"; stagingDir: string; reason?: string };
|
|
|
|
/**
|
|
* Decide whether the next memory-ingest run should resume from gbrain's
|
|
* checkpoint or restage from scratch.
|
|
* - no checkpoint → run a fresh ingest pass
|
|
* - checkpoint + staging ok → resume (gbrain picks up at processedIndex+1)
|
|
* - checkpoint + staging gone → warn, fall through to fresh restage
|
|
*/
|
|
export function decideResume(gstackHome: string = GSTACK_HOME): ResumeVerdict {
|
|
const cp = readGbrainCheckpoint();
|
|
if (!cp || !cp.dir) return { kind: "no-checkpoint" };
|
|
const stagingDir = cp.dir;
|
|
// #1802: only resume into a path we can PROVE is a gstack-minted staging dir.
|
|
// A poisoned checkpoint (dir = repo root, written when an autopilot import was
|
|
// SIGTERM'd while CWD was the repo) would otherwise be adopted as the staging
|
|
// dir and later recursively deleted by cleanupStagingDir(). Fail-closed: any
|
|
// unprovable path restages from scratch (cost: one re-stage; never data loss).
|
|
// Pure decision: return the verdict (with reason) and let the caller log,
|
|
// so we don't double-log the same event from here and the call site.
|
|
const verdict = checkOwnedStagingDir(stagingDir, gstackHome);
|
|
if (!verdict.ok) {
|
|
return { kind: "stale-staging-missing", stagingDir, reason: verdict.reason };
|
|
}
|
|
return {
|
|
kind: "resume",
|
|
stagingDir,
|
|
processedIndex: cp.processedIndex ?? 0,
|
|
totalFiles: cp.totalFiles ?? 0,
|
|
};
|
|
}
|
|
|
|
// ── CLI ────────────────────────────────────────────────────────────────────
|
|
|
|
function printUsage(): void {
|
|
console.error(`Usage: gstack-gbrain-sync [--incremental|--full|--dry-run] [options]
|
|
|
|
Modes:
|
|
--incremental Default. mtime fast-path; ~50ms steady-state.
|
|
--full First-run; full walk + reindex. Honest ~25-35 min for big Macs (ED2).
|
|
--dry-run Preview what would sync; no writes anywhere.
|
|
|
|
Options:
|
|
--quiet Suppress per-stage output.
|
|
--no-code Skip the cwd code-import stage.
|
|
--no-memory Skip the gstack-memory-ingest stage (transcripts + artifacts).
|
|
--no-brain-sync Skip the gstack-brain-sync git pipeline stage.
|
|
--code-only Only run the code-import stage (alias for --no-memory --no-brain-sync).
|
|
--dream Force the source-scoped dream cycle that builds this
|
|
source's call graph (gbrain code-callers/code-callees).
|
|
Runs lock-free AFTER the sync stages. ~minutes. Default
|
|
timeout 45min, override GSTACK_SYNC_DREAM_TIMEOUT_MS.
|
|
--no-dream Opt out of the dream cycle that --full would auto-run.
|
|
--prune-gone-worktrees Remove gstack code sources whose worktree is provably
|
|
gone: missing on 2 consecutive syncs, created on this
|
|
host (its id recomputes from host + path), and no
|
|
longer listed by its repository. Prints the plan first;
|
|
add --dry-run to only print it. Never automatic.
|
|
--allow-reclone Permit the code walk for URL-managed sources (remote_url set)
|
|
even though gbrain may auto-reclone the working tree (#1734).
|
|
--sources <list> Memory types to ingest (comma-separated, or \`all\`):
|
|
${MEMORY_INGEST_TYPES.join(",")}.
|
|
Env: GSTACK_MEMORY_INGEST_SOURCES. Default: every type
|
|
except ${FEDERATED_CURATED_TYPES.join(",")} when a federated
|
|
gstack source already indexes them, and except
|
|
transcript unless transcript_ingest_mode is recent
|
|
(last 90 days), all (all history; --full passes
|
|
--all-history) or new@<UTC> (sessions started after
|
|
it). Without that consent each run prints a notice,
|
|
even with --quiet. A list naming transcript overrides
|
|
the mode for that run, but a new@ cutoff and the
|
|
transcript_repos allowlist still apply. See
|
|
setup-gbrain/memory.md#transcripts.
|
|
--help This text.
|
|
|
|
Stages run in order: code → memory ingest → curated git push, then (lock-free)
|
|
the optional dream call-graph build. --full auto-runs dream ONLY when the call
|
|
graph was never built; --dream always forces it. Each stage failure is
|
|
non-fatal; subsequent stages still run.
|
|
`);
|
|
}
|
|
|
|
function parseArgs(): CliArgs {
|
|
const args = process.argv.slice(2);
|
|
let mode: Mode = "incremental";
|
|
let quiet = false;
|
|
let noCode = false;
|
|
let noMemory = false;
|
|
let noBrainSync = false;
|
|
let codeOnly = false;
|
|
let dream = false;
|
|
let noDream = false;
|
|
let allowReclone = false;
|
|
let memorySources: string | undefined;
|
|
let pruneGone = false;
|
|
|
|
for (let i = 0; i < args.length; i++) {
|
|
const a = args[i];
|
|
switch (a) {
|
|
case "--incremental": mode = "incremental"; break;
|
|
case "--full": mode = "full"; break;
|
|
case "--dry-run": mode = "dry-run"; break;
|
|
case "--quiet": quiet = true; break;
|
|
case "--no-code": noCode = true; break;
|
|
case "--no-memory": noMemory = true; break;
|
|
case "--no-brain-sync": noBrainSync = true; break;
|
|
case "--allow-reclone": allowReclone = true; break;
|
|
case "--sources":
|
|
memorySources = args[++i];
|
|
if (memorySources === undefined || memorySources.trim() === "") {
|
|
console.error("--sources requires a comma-separated list of memory types, or `all`");
|
|
process.exit(1);
|
|
}
|
|
break;
|
|
case "--code-only":
|
|
codeOnly = true;
|
|
noMemory = true;
|
|
noBrainSync = true;
|
|
break;
|
|
// --dream forces the cycle; --full only chains it at the call site (so
|
|
// --no-dream can override) — do NOT set dream from --full here.
|
|
case "--dream": dream = true; break;
|
|
case "--no-dream": noDream = true; break;
|
|
case "--prune-gone-worktrees": pruneGone = true; break;
|
|
case "--help":
|
|
case "-h":
|
|
printUsage();
|
|
process.exit(0);
|
|
default:
|
|
console.error(`Unknown argument: ${a}`);
|
|
printUsage();
|
|
process.exit(1);
|
|
}
|
|
}
|
|
|
|
return { mode, quiet, noCode, noMemory, noBrainSync, codeOnly, dream, noDream, allowReclone, memorySources, pruneGone };
|
|
}
|
|
|
|
// ── Helpers ────────────────────────────────────────────────────────────────
|
|
|
|
function repoRoot(): string | null {
|
|
try {
|
|
const out = execSync("git rev-parse --show-toplevel", { encoding: "utf-8", timeout: 2000 });
|
|
return out.trim();
|
|
} catch {
|
|
return null;
|
|
}
|
|
}
|
|
|
|
function originUrl(): string | null {
|
|
try {
|
|
const out = execSync("git config --get remote.origin.url", { encoding: "utf-8", timeout: 2000 });
|
|
return out.trim();
|
|
} catch {
|
|
return null;
|
|
}
|
|
}
|
|
|
|
/**
|
|
* Derive a host- and worktree-aware source id for the cwd code corpus.
|
|
*
|
|
* Pattern: `gstack-code-<slug>-<hostpathhash8>` where slug comes from origin
|
|
* (org/repo) and hostpathhash8 is the first 8 hex chars of
|
|
* sha1(`${hostname}::${absolute repo path}`). Folding hostname into the hash
|
|
* keeps Conductor worktrees of the same repo as distinct sources on one host
|
|
* AND keeps two machines that share an absolute layout (e.g. chezmoi-managed
|
|
* home dirs against a federated brain) from colliding on each other.
|
|
*
|
|
* Falls back to the repo basename when there is no origin (local repo).
|
|
*
|
|
* `GSTACK_HOSTNAME` env override is honored for deterministic tests; in
|
|
* production paths it is unset and `os.hostname()` is used.
|
|
*
|
|
* gbrain enforces source ids to be 1-32 lowercase alnum chars with
|
|
* optional interior hyphens. `constrainSourceId` handles the 32-char cap
|
|
* with a hashed-tail fallback when the combined slug exceeds budget.
|
|
*/
|
|
export function deriveCodeSourceId(repoPath: string, remote: string = canonicalizeRemote(originUrl())): string {
|
|
const host = process.env.GSTACK_HOSTNAME || hostname();
|
|
const hostPathHash = createHash("sha1").update(`${host}::${repoPath}`).digest("hex").slice(0, 8);
|
|
if (remote) {
|
|
const segs = remote.split("/").filter(Boolean);
|
|
const slugSource = segs.slice(-2).join("-");
|
|
const fullId = constrainSourceId("gstack-code", `${slugSource}-${hostPathHash}`);
|
|
// If the org+repo+hostpathhash fits cleanly (suffix preserved), use it.
|
|
if (fullId.endsWith(`-${hostPathHash}`)) return fullId;
|
|
// Otherwise drop the org prefix and retry with just repo+hostpathhash so
|
|
// the repo name stays readable. If that still doesn't fit,
|
|
// constrainSourceId falls back to a deterministic hash-only form.
|
|
const repoOnly = segs[segs.length - 1] || "repo";
|
|
return constrainSourceId("gstack-code", `${repoOnly}-${hostPathHash}`);
|
|
}
|
|
const base = repoPath.split("/").pop() || "repo";
|
|
return constrainSourceId("gstack-code", `${base}-${hostPathHash}`);
|
|
}
|
|
|
|
/**
|
|
* Reuse an explicit repo pin when it names a registered source for this exact
|
|
* checkout. The path check prevents a stale or copied dotfile from redirecting
|
|
* a code sync into another repo's source.
|
|
*/
|
|
function readPinnedSourceId(repoPath: string): string | null {
|
|
const pinPath = join(repoPath, ".gbrain-source");
|
|
if (!existsSync(pinPath)) return null;
|
|
|
|
try {
|
|
const sourceId = readFileSync(pinPath, "utf-8").trim();
|
|
return /^[a-z0-9](?:[a-z0-9-]{0,30}[a-z0-9])?$/.test(sourceId) ? sourceId : null;
|
|
} catch {
|
|
// A pin is advisory. A permission race or a directory at this path must
|
|
// not turn a sync preview into an unexpected crash.
|
|
return null;
|
|
}
|
|
}
|
|
|
|
export function existingPinnedSourceId(repoPath: string, env?: NodeJS.ProcessEnv): string | null {
|
|
const sourceId = readPinnedSourceId(repoPath);
|
|
if (!sourceId) return null;
|
|
|
|
const registeredPath = sourceLocalPath(sourceId, env);
|
|
if (!registeredPath) return null;
|
|
try {
|
|
return realpathSync(registeredPath) === realpathSync(repoPath) ? sourceId : null;
|
|
} catch {
|
|
return null;
|
|
}
|
|
}
|
|
|
|
function resolveCodeSourceId(repoPath: string, env?: NodeJS.ProcessEnv): string {
|
|
return existingPinnedSourceId(repoPath, env) ?? deriveCodeSourceId(repoPath);
|
|
}
|
|
|
|
/**
|
|
* Pre-pathhash source id, kept for orphan detection only.
|
|
*
|
|
* Earlier /sync-gbrain versions registered `gstack-code-<slug>` (no pathhash
|
|
* suffix). On a multi-worktree repo, those collapsed onto a single source id
|
|
* with last-sync-wins semantics. The new path-keyed id leaves the legacy
|
|
* source orphaned in the brain — federated cross-source search would return
|
|
* stale duplicate hits. We remove the legacy id once, on the first new-format
|
|
* sync from any worktree of this repo, so users don't accumulate orphans.
|
|
*/
|
|
function deriveLegacyCodeSourceId(repoPath: string): string {
|
|
const remote = canonicalizeRemote(originUrl());
|
|
if (remote) {
|
|
const segs = remote.split("/").filter(Boolean);
|
|
const slugSource = segs.slice(-2).join("-");
|
|
return constrainSourceId("gstack-code", slugSource);
|
|
}
|
|
const base = repoPath.split("/").pop() || "repo";
|
|
return constrainSourceId("gstack-code", base);
|
|
}
|
|
|
|
/**
|
|
* Pre-#1468 path-only-hash source id, kept for hostname-fold migration only.
|
|
*
|
|
* Before the hostname fold, `deriveCodeSourceId` hashed only the absolute
|
|
* repo path: `gstack-code-<slug>-<sha1(path).slice(0,8)>`. After #1468 the
|
|
* hash key is `${hostname}::${path}`, so every existing user's brain has a
|
|
* legacy id that no longer matches what `deriveCodeSourceId` produces. We
|
|
* detect this form once, attempt rename-in-place if the gbrain CLI supports
|
|
* `sources rename`, and otherwise clean up after the new source successfully
|
|
* syncs. Distinct from `deriveLegacyCodeSourceId` (pre-pathhash v1.x form);
|
|
* both probes run.
|
|
*/
|
|
export function derivePathOnlyHashLegacyId(repoPath: string): string {
|
|
const pathHash = createHash("sha1").update(repoPath).digest("hex").slice(0, 8);
|
|
const remote = canonicalizeRemote(originUrl());
|
|
if (remote) {
|
|
const segs = remote.split("/").filter(Boolean);
|
|
const slugSource = segs.slice(-2).join("-");
|
|
return constrainSourceId("gstack-code", `${slugSource}-${pathHash}`);
|
|
}
|
|
const base = repoPath.split("/").pop() || "repo";
|
|
return constrainSourceId("gstack-code", `${base}-${pathHash}`);
|
|
}
|
|
|
|
/**
|
|
* Feature-check whether the installed gbrain CLI ships `sources rename <old> <new>`.
|
|
*
|
|
* Per the v1.40.0.0 design review: probing `gbrain sources rename --help` and
|
|
* matching for the exact argument shape catches the case where gbrain's
|
|
* `sources` parent help mentions a `rename` subcommand but the CLI doesn't
|
|
* accept the `<old> <new>` form (or vice versa). Cached for the lifetime
|
|
* of the process. As of gbrain 0.35.0.0 this command does not exist, so the
|
|
* function returns false and the migration path falls back to register-new
|
|
* + sync-OK + remove-old.
|
|
*/
|
|
let _gbrainSupportsRenameCache: boolean | null = null;
|
|
export function _resetGbrainSupportsRenameCache(): void {
|
|
_gbrainSupportsRenameCache = null;
|
|
}
|
|
function gbrainSupportsSourcesRename(env?: NodeJS.ProcessEnv): boolean {
|
|
if (_gbrainSupportsRenameCache !== null) return _gbrainSupportsRenameCache;
|
|
try {
|
|
const r = spawnGbrain(["sources", "rename", "--help"], {
|
|
timeout: 5_000,
|
|
baseEnv: env,
|
|
});
|
|
const out = `${r.stdout || ""}\n${r.stderr || ""}`;
|
|
// Match the exact argument shape: `rename <old> <new>` (with literal
|
|
// angle brackets in usage strings) or `rename OLD NEW`.
|
|
const exact = /sources\s+rename\s+<old>\s+<new>/i.test(out)
|
|
|| /sources\s+rename\s+OLD\s+NEW/.test(out)
|
|
|| /sources\s+rename\s+<oldId>\s+<newId>/i.test(out);
|
|
_gbrainSupportsRenameCache = exact && r.status === 0;
|
|
} catch {
|
|
_gbrainSupportsRenameCache = false;
|
|
}
|
|
return _gbrainSupportsRenameCache;
|
|
}
|
|
|
|
/**
|
|
* Look up a source's `local_path` from `gbrain sources list --json`.
|
|
* Returns null when the source is absent or the listing fails.
|
|
*
|
|
* `env` is the environment passed to the spawned `gbrain` process; defaults
|
|
* to `process.env`. Tests inject a PATH that points at a gbrain shim so the
|
|
* helper can be exercised without a real gbrain CLI.
|
|
*
|
|
* Shape note: `gbrain sources list --json` returns `{sources: [...]}` (v0.20+);
|
|
* older versions returned a flat array. Accept both for forward/backward compat
|
|
* (mirrors `probeSource`/`sourcePageCount` in lib/gbrain-sources.ts).
|
|
*/
|
|
export function sourceLocalPath(sourceId: string, env?: NodeJS.ProcessEnv): string | null {
|
|
const raw = execGbrainJson<unknown>(
|
|
["sources", "list", "--json"],
|
|
{ baseEnv: env },
|
|
);
|
|
if (!raw) return null;
|
|
const found = parseSourcesList(raw).find((s) => s.id === sourceId);
|
|
return found?.local_path ?? null;
|
|
}
|
|
|
|
/** Result of `planHostnameFoldMigration` — informs `runCodeImport` of next steps. */
|
|
export type HostnameFoldMigration =
|
|
| { kind: "none"; reason: "ids-match" | "no-legacy-source" }
|
|
| { kind: "skipped-path-drift"; oldId: string; oldPath: string; currentPath: string }
|
|
| { kind: "renamed"; oldId: string; newId: string }
|
|
| { kind: "pending-cleanup"; oldId: string };
|
|
|
|
/**
|
|
* Decide how to migrate from the pre-#1468 path-only-hash source id to the
|
|
* new hostname-fold id.
|
|
*
|
|
* Order:
|
|
* 1. If old == new → no-op.
|
|
* 2. Look up old source's local_path. Absent → no legacy source to migrate.
|
|
* 3. local_path != currentRoot → user moved the repo or two machines share a
|
|
* hash slot. Skip migration; let the user clean up manually. We will NOT
|
|
* rename or remove anything; the new source is registered alongside.
|
|
* 4. Otherwise: feature-check `gbrain sources rename`. If supported and the
|
|
* rename call exits 0 → renamed, pages preserved.
|
|
* 5. Else: pending-cleanup. Caller registers + syncs new source first; only
|
|
* after sync succeeds with a non-zero page count does it remove the old.
|
|
* This avoids a data-loss window where the old source is gone before the
|
|
* new one is verifiably populated.
|
|
*/
|
|
export function planHostnameFoldMigration(
|
|
currentRoot: string,
|
|
newSourceId: string,
|
|
legacyPathHashId: string,
|
|
env?: NodeJS.ProcessEnv,
|
|
): HostnameFoldMigration {
|
|
if (legacyPathHashId === newSourceId) {
|
|
return { kind: "none", reason: "ids-match" };
|
|
}
|
|
const oldPath = sourceLocalPath(legacyPathHashId, env);
|
|
if (oldPath === null) {
|
|
return { kind: "none", reason: "no-legacy-source" };
|
|
}
|
|
if (oldPath !== currentRoot) {
|
|
return {
|
|
kind: "skipped-path-drift",
|
|
oldId: legacyPathHashId,
|
|
oldPath,
|
|
currentPath: currentRoot,
|
|
};
|
|
}
|
|
if (gbrainSupportsSourcesRename(env)) {
|
|
const r = spawnGbrain(["sources", "rename", legacyPathHashId, newSourceId], { baseEnv: env });
|
|
if (r.status === 0) {
|
|
return { kind: "renamed", oldId: legacyPathHashId, newId: newSourceId };
|
|
}
|
|
// Rename failed at runtime — fall through to cleanup path.
|
|
}
|
|
return { kind: "pending-cleanup", oldId: legacyPathHashId };
|
|
}
|
|
|
|
export interface GuardedRemoveResult {
|
|
removed: boolean;
|
|
/** True when a guard refused the remove (autopilot active or unsafe source). */
|
|
skipped: boolean;
|
|
reason: string;
|
|
}
|
|
|
|
/**
|
|
* #1734: run `gbrain sources remove <id> --confirm-destructive` only behind the
|
|
* data-loss guards. Checked immediately before the destructive op (E8: as late
|
|
* as possible) so the autopilot window is as small as we can make it without a
|
|
* gbrain-side lease. Refuses when autopilot is active or when the source is
|
|
* user-managed and gbrain can't keep its storage. Pure side-effect helper; the
|
|
* caller decides whether a skip is fatal (it never is today — removes are
|
|
* best-effort cleanup).
|
|
*/
|
|
export function safeSourcesRemove(sourceId: string, env?: NodeJS.ProcessEnv): GuardedRemoveResult {
|
|
const ap = detectAutopilot(env);
|
|
if (ap.active) {
|
|
return {
|
|
removed: false,
|
|
skipped: true,
|
|
reason: `autopilot active (${ap.signal}); refusing destructive remove of ${sourceId}. ` +
|
|
`Stop autopilot, then re-run /sync-gbrain.`,
|
|
};
|
|
}
|
|
const decision = decideSourceRemove(sourceId, env);
|
|
if (!decision.allow) {
|
|
return { removed: false, skipped: true, reason: decision.reason };
|
|
}
|
|
const r = spawnGbrain(
|
|
["sources", "remove", sourceId, "--confirm-destructive", ...decision.extraArgs],
|
|
{ baseEnv: env },
|
|
);
|
|
return { removed: r.status === 0, skipped: false, reason: decision.reason };
|
|
}
|
|
|
|
/**
|
|
* Remove an orphaned source. Called only after new-source sync verifies pages
|
|
* exist, so the old source is provably redundant before deletion. Routed through
|
|
* safeSourcesRemove for the #1734 guards.
|
|
*/
|
|
export function removeOrphanedSource(oldId: string, env?: NodeJS.ProcessEnv): boolean {
|
|
return safeSourcesRemove(oldId, env).removed;
|
|
}
|
|
|
|
// ── Lock file (D1) ─────────────────────────────────────────────────────────
|
|
|
|
interface LockInfo {
|
|
pid: number;
|
|
started_at: string;
|
|
}
|
|
|
|
function acquireLock(): boolean {
|
|
mkdirSync(GSTACK_HOME, { recursive: true });
|
|
if (existsSync(LOCK_PATH)) {
|
|
// Check if stale.
|
|
try {
|
|
const stat = statSync(LOCK_PATH);
|
|
const ageMs = Date.now() - stat.mtimeMs;
|
|
if (ageMs > STALE_LOCK_MS) {
|
|
// Stale; take over.
|
|
unlinkSync(LOCK_PATH);
|
|
} else {
|
|
return false;
|
|
}
|
|
} catch {
|
|
// Cannot stat; bail conservatively.
|
|
return false;
|
|
}
|
|
}
|
|
const info: LockInfo = { pid: process.pid, started_at: new Date().toISOString() };
|
|
try {
|
|
writeFileSync(LOCK_PATH, JSON.stringify(info), { encoding: "utf-8", flag: "wx" });
|
|
return true;
|
|
} catch {
|
|
return false;
|
|
}
|
|
}
|
|
|
|
function releaseLock(): void {
|
|
try {
|
|
if (!existsSync(LOCK_PATH)) return;
|
|
const raw = readFileSync(LOCK_PATH, "utf-8");
|
|
const info = JSON.parse(raw) as LockInfo;
|
|
if (info.pid === process.pid) {
|
|
unlinkSync(LOCK_PATH);
|
|
}
|
|
} catch {
|
|
// Best-effort cleanup.
|
|
}
|
|
}
|
|
|
|
/**
|
|
* Acquire the dream marker (`~/.gstack/.dream-in-progress`). Returns false when
|
|
* a FRESH marker already exists (another worktree is mid-dream) — the caller
|
|
* then SKIPs rather than launching a duplicate ~35-min global job. A stale
|
|
* marker (older than DREAM_MARKER_STALE_MS, i.e. a crashed run) is taken over.
|
|
* Mirrors acquireLock but with the dream TTL and its own path.
|
|
*/
|
|
export function acquireDreamMarker(): boolean {
|
|
const path = dreamMarkerPath();
|
|
mkdirSync(dirname(path), { recursive: true });
|
|
if (existsSync(path)) {
|
|
try {
|
|
const stat = statSync(path);
|
|
if (Date.now() - stat.mtimeMs > DREAM_MARKER_STALE_MS) {
|
|
unlinkSync(path);
|
|
} else {
|
|
return false;
|
|
}
|
|
} catch {
|
|
return false;
|
|
}
|
|
}
|
|
const info: LockInfo = { pid: process.pid, started_at: new Date().toISOString() };
|
|
try {
|
|
writeFileSync(path, JSON.stringify(info), { encoding: "utf-8", flag: "wx" });
|
|
return true;
|
|
} catch {
|
|
return false;
|
|
}
|
|
}
|
|
|
|
export function releaseDreamMarker(): void {
|
|
try {
|
|
const path = dreamMarkerPath();
|
|
if (!existsSync(path)) return;
|
|
const info = JSON.parse(readFileSync(path, "utf-8")) as LockInfo;
|
|
if (info.pid === process.pid) unlinkSync(path);
|
|
} catch {
|
|
// Best-effort cleanup.
|
|
}
|
|
}
|
|
|
|
/** Read the pid recorded in a fresh dream marker, for the "already running" message. */
|
|
function dreamMarkerPid(): number | null {
|
|
try {
|
|
const info = JSON.parse(readFileSync(dreamMarkerPath(), "utf-8")) as LockInfo;
|
|
return typeof info.pid === "number" ? info.pid : null;
|
|
} catch {
|
|
return null;
|
|
}
|
|
}
|
|
|
|
// ── Stage runners ──────────────────────────────────────────────────────────
|
|
|
|
/**
|
|
* Build a SKIP result for the code/memory stage when the local engine is
|
|
* not in 'ok' state (per plan D12). Surface the status verbatim so the
|
|
* verdict block tells the user exactly what's wrong without re-probing.
|
|
*
|
|
* Reasons mapped to user-actionable summaries:
|
|
* no-cli → "gbrain CLI not on PATH; install via /setup-gbrain"
|
|
* missing-config → "no local engine; run /setup-gbrain to add local PGLite"
|
|
* broken-config → "config file at ~/.gbrain/config.json is malformed; see /setup-gbrain Step 1.5"
|
|
* broken-db → "config points at unreachable DB; see /setup-gbrain Step 1.5"
|
|
* engine-locked → PGLite is busy; stop its holder or sync outside the live session
|
|
* timeout → kept for Record totality; stages PROCEED on timeout (#1964)
|
|
* via the gate's warnProbeTimeout path, never this skip.
|
|
* thin-client → remote-HTTP MCP brain, no local engine by design (#2051);
|
|
* local sync stages skip (gbrain refuses sources/sync there),
|
|
* but suppression gates treat the brain as USABLE.
|
|
*/
|
|
function skipStageForLocalStatus(
|
|
stage: "code" | "memory" | "dream",
|
|
status: LocalEngineStatus,
|
|
t0: number,
|
|
): StageResult {
|
|
const reasons: Record<Exclude<LocalEngineStatus, "ok">, string> = {
|
|
"no-cli": "gbrain CLI not on PATH; install via /setup-gbrain",
|
|
"missing-config":
|
|
"no local engine; run /setup-gbrain to add local PGLite for code search",
|
|
"broken-config":
|
|
"config at ~/.gbrain/config.json is malformed; see /setup-gbrain Step 1.5",
|
|
"broken-db":
|
|
"config points at unreachable DB; see /setup-gbrain Step 1.5",
|
|
"engine-locked":
|
|
"PGLite is busy (often held by gbrain serve); stop the holding process or run /sync-gbrain outside the live Claude session, then retry",
|
|
"timeout":
|
|
"engine probe timed out; raise GSTACK_GBRAIN_PROBE_TIMEOUT_MS if your pooler is slow",
|
|
"db-unreachable": localEngineStatusDetail() ?? dbUnreachableReason("network error", ""),
|
|
"thin-client":
|
|
"thin client (remote-HTTP MCP brain, no local engine by design, #2051); " +
|
|
"code indexing runs on the brain server, memory syncs via the remote " +
|
|
"brain's artifacts pull — nothing to do locally",
|
|
};
|
|
const reason = reasons[status as Exclude<LocalEngineStatus, "ok">];
|
|
return {
|
|
name: stage,
|
|
ran: false,
|
|
ok: true, // SKIP (per D12) — not a stage failure, just an unsatisfied prerequisite
|
|
duration_ms: Date.now() - t0,
|
|
summary: `skipped — local engine ${status} — ${reason}`,
|
|
};
|
|
}
|
|
|
|
/**
|
|
* "timeout" means the probe hit its deadline with no recognized error — the
|
|
* engine is most likely healthy but slow (#1964: cold pooler connections
|
|
* measured at 6.9-10.7s). Stages proceed; a genuinely-dead engine surfaces
|
|
* its REAL error at the first actual operation instead of a false
|
|
* "config malformed" skip.
|
|
*/
|
|
function warnProbeTimeout(stage: "code" | "memory" | "dream"): void {
|
|
process.stderr.write(
|
|
`[gstack-gbrain-sync] ${stage}: engine probe timed out — proceeding anyway; ` +
|
|
`raise GSTACK_GBRAIN_PROBE_TIMEOUT_MS if your pooler is slow\n`,
|
|
);
|
|
}
|
|
|
|
|
|
/**
|
|
* Per-repo trust tier from ~/.gstack/gbrain-repo-policy.json, read through
|
|
* the bin/gstack-gbrain-repo-policy CLI (which owns URL normalization and
|
|
* schema migration — do not reimplement either here).
|
|
*
|
|
* The tier was previously enforced only in /sync-gbrain skill prose, so a
|
|
* direct or cron invocation of this script ingested repo code regardless of
|
|
* a `deny`/`read-only` setting — and the egress receipt below cited this
|
|
* chokepoint as consent before it existed (#2140 sync path). This check
|
|
* closes both gaps.
|
|
*
|
|
* Fail-open ONLY when no policy store exists (nothing was ever set — same
|
|
* behavior as before for every non-policy user, and skips the subprocess).
|
|
* Fail-closed ("error") when a store exists but can't be read: a policy the
|
|
* user set must not be silently bypassed by a broken store or missing jq.
|
|
*
|
|
* Reads through the shared lib/gbrain-repo-policy-client.ts (same client as
|
|
* the code-intelligence consent veto — the two gates can never drift, and
|
|
* win32 gets the invoke-via-bash path). A spawn failure is still fail-closed
|
|
* but says so, instead of the misleading "store could not be read".
|
|
*/
|
|
export function repoPolicyTier(url: string | null): "read-write" | "read-only" | "deny" | "unset" | "error" {
|
|
const res = sharedRepoPolicyTier(url, process.env);
|
|
if (res.error === "spawn-failed") {
|
|
process.stderr.write(
|
|
"[gstack-gbrain-sync] the repo-policy helper could not be spawned (bash missing from PATH?) — " +
|
|
"refusing ingest rather than bypassing a possibly-set policy\n",
|
|
);
|
|
return "error";
|
|
}
|
|
if (res.error) return "error";
|
|
return res.tier === "none" ? "unset" : res.tier;
|
|
}
|
|
|
|
// Bounded tail of a gbrain child's stderr: enough for the failure summary's
|
|
// last line without buffering a long code walk's output (spawnSync's 1 MiB
|
|
// maxBuffer turned a chatty walk into ENOBUFS).
|
|
const GBRAIN_STDERR_TAIL_BYTES = 8 * 1024;
|
|
// gstack's minimum gbrain (bin/gstack-gbrain-install MIN_GBRAIN_VERSION);
|
|
// `sync --no-pull` exists in every release since 0.2.0.
|
|
const MIN_GBRAIN_FOR_NO_PULL = "0.20.0";
|
|
|
|
export interface GbrainStreamResult {
|
|
status: number | null;
|
|
timedOut: boolean;
|
|
stderrTail: string;
|
|
}
|
|
|
|
/** Run gbrain, live-forwarding stderr unless quiet, keeping a bounded tail. */
|
|
export function runGbrainStreaming(
|
|
gbrainArgs: string[],
|
|
opts: { quiet: boolean; timeoutMs: number; env?: NodeJS.ProcessEnv },
|
|
): Promise<GbrainStreamResult> {
|
|
return new Promise((resolve) => {
|
|
const child = spawnGbrainAsync(gbrainArgs, {
|
|
stdio: ["ignore", opts.quiet ? "ignore" : "inherit", "pipe"],
|
|
baseEnv: opts.env,
|
|
});
|
|
let tail = "";
|
|
let timedOut = false;
|
|
let settled = false;
|
|
const finish = (status: number | null) => {
|
|
if (settled) return;
|
|
settled = true;
|
|
clearTimeout(timer);
|
|
resolve({ status: timedOut ? null : status, timedOut, stderrTail: tail });
|
|
};
|
|
const timer = setTimeout(() => {
|
|
timedOut = true;
|
|
child.kill("SIGTERM");
|
|
}, opts.timeoutMs);
|
|
child.stderr?.on("data", (chunk: Buffer) => {
|
|
if (!opts.quiet) process.stderr.write(chunk);
|
|
tail = (tail + chunk.toString("utf-8")).slice(-GBRAIN_STDERR_TAIL_BYTES);
|
|
});
|
|
child.on("error", (err) => {
|
|
tail = `${tail}\n${err.message}`.slice(-GBRAIN_STDERR_TAIL_BYTES);
|
|
finish(null);
|
|
});
|
|
child.on("close", (status) => finish(status));
|
|
});
|
|
}
|
|
|
|
export function gbrainFailureSummary(gbrainArgs: string[], run: GbrainStreamResult): string {
|
|
if (gbrainArgs.includes("--no-pull") && /unknown (?:flag|option|argument)[^\n]*--no-pull/i.test(run.stderrTail)) {
|
|
return `gbrain rejected --no-pull; upgrade gbrain to >= ${MIN_GBRAIN_FOR_NO_PULL} (gstack never lets gbrain pull your checkout)`;
|
|
}
|
|
const lastLine = run.stderrTail.split("\n").map((l) => l.trim()).filter(Boolean).pop()?.slice(0, 300);
|
|
const outcome = run.timedOut ? "timed out" : `exited ${run.status}`;
|
|
return `gbrain ${gbrainArgs.join(" ")} ${outcome}${lastLine ? `: ${lastLine}` : ""}`;
|
|
}
|
|
|
|
async function runCodeImport(args: CliArgs): Promise<StageResult> {
|
|
const t0 = Date.now();
|
|
const root = repoRoot();
|
|
if (!root) {
|
|
return { name: "code", ran: false, ok: true, duration_ms: 0, summary: "skipped (not in git repo)" };
|
|
}
|
|
|
|
// A preview must not spawn gbrain. Trust a syntactically-valid local pin
|
|
// there; a real run confirms its registered path before using it.
|
|
const gbrainEnv = args.mode === "dry-run" ? undefined : buildGbrainEnv({ announce: !args.quiet });
|
|
const pinnedSourceId = args.mode === "dry-run"
|
|
? readPinnedSourceId(root)
|
|
: existingPinnedSourceId(root, gbrainEnv);
|
|
const sourceId = pinnedSourceId ?? deriveCodeSourceId(root);
|
|
|
|
// Per-repo trust tier — checked BEFORE the dry-run branch so previews report
|
|
// the refusal honestly instead of claiming they would sync.
|
|
const policyUrl = originUrl();
|
|
const tier = repoPolicyTier(policyUrl);
|
|
if (tier === "read-only") {
|
|
// Honoring an explicit user setting (search allowed, page writes never) is
|
|
// a clean skip, not a stage failure — code ingest writes pages.
|
|
return {
|
|
name: "code",
|
|
ran: false,
|
|
ok: true,
|
|
duration_ms: Date.now() - t0,
|
|
summary: `skipped — repo policy is read-only for ${policyUrl} (code ingest writes pages). Change with: gstack-gbrain-repo-policy set ${policyUrl} read-write`,
|
|
detail: { source_id: sourceId, source_path: root, status: "skipped-policy-read-only" },
|
|
};
|
|
}
|
|
if (tier === "deny" || tier === "error") {
|
|
const why = tier === "deny"
|
|
? `repo policy is deny for ${policyUrl} — no gbrain ingest for this repo. Change with: gstack-gbrain-repo-policy set ${policyUrl} read-write`
|
|
: "repo policy store exists but could not be read (gstack-gbrain-repo-policy get failed) — refusing ingest rather than bypassing a set policy";
|
|
return {
|
|
name: "code",
|
|
ran: true,
|
|
ok: false,
|
|
duration_ms: Date.now() - t0,
|
|
summary: `refused: ${why}`,
|
|
detail: { source_id: sourceId, source_path: root, status: tier === "deny" ? "refused-policy-deny" : "refused-policy-unreadable" },
|
|
};
|
|
}
|
|
|
|
// dry-run preview always shows the would-do steps, regardless of local
|
|
// engine state. Useful for "what would /sync-gbrain do" without probing
|
|
// the engine.
|
|
if (args.mode === "dry-run") {
|
|
return {
|
|
name: "code",
|
|
ran: false,
|
|
ok: true,
|
|
duration_ms: 0,
|
|
summary: pinnedSourceId
|
|
? `would: gbrain sync --strategy code --source ${sourceId} --no-pull; gbrain sources attach ${sourceId}`
|
|
: `would: gbrain sources add ${sourceId} --path ${root} --federated; gbrain sync --strategy code --source ${sourceId} --no-pull; gbrain sources attach ${sourceId}`,
|
|
detail: { source_id: sourceId, source_path: root, status: "skipped" },
|
|
};
|
|
}
|
|
|
|
// Split-engine pre-flight (per plan D12): when local engine is not ok, SKIP
|
|
// code stage cleanly. Brain-sync stage still runs because it doesn't depend
|
|
// on local engine. The /sync-gbrain Step 1.5 pre-flight surfaces the user
|
|
// remediation message; this skip just keeps the orchestrator from crashing
|
|
// when the local DB is dead. Skipped on --dry-run (above) since dry-run
|
|
// never actually probes anything.
|
|
const localStatus = localEngineStatus({ noCache: false });
|
|
if (localStatus === "timeout") {
|
|
warnProbeTimeout("code"); // #1964: slow-but-healthy — proceed
|
|
} else if (localStatus !== "ok") {
|
|
return skipStageForLocalStatus("code", localStatus, t0);
|
|
}
|
|
|
|
// Step 0a: Best-effort cleanup of pre-pathhash legacy source (v1.x form).
|
|
// Earlier /sync-gbrain versions registered `gstack-code-<slug>` (no path
|
|
// suffix). On a multi-worktree repo, those collapsed onto a single id
|
|
// with last-sync-wins. Federated search would return stale duplicate
|
|
// hits forever if we left the orphan in place. Remove the legacy id once
|
|
// here so users don't accumulate orphans.
|
|
// Failure is non-fatal — we still register the new id below.
|
|
// gbrainEnv seeds DATABASE_URL from gbrain's config so this stage works
|
|
// inside Next.js / Prisma / Rails projects with their own .env.local
|
|
// (codex review #7 — bug fix is wider than #1508 as filed).
|
|
const legacyId = deriveLegacyCodeSourceId(root);
|
|
let legacyRemoved = false;
|
|
if (!pinnedSourceId && legacyId !== sourceId) {
|
|
// #1734: route through the data-loss guards (autopilot + source-safety).
|
|
const rm = safeSourcesRemove(legacyId, gbrainEnv);
|
|
if (rm.skipped && !args.quiet) {
|
|
console.error(`[sync:code] legacy-source cleanup skipped: ${rm.reason}`);
|
|
}
|
|
if (rm.removed) legacyRemoved = true;
|
|
}
|
|
|
|
// Step 0b: Hostname-fold migration (#1414).
|
|
// Before #1468 the source id hashed only the absolute repo path. After the
|
|
// hostname fold, every existing user has a legacy id that no longer matches
|
|
// what deriveCodeSourceId produces. Try rename-in-place first (preserves
|
|
// pages); fall back to register-new → sync-OK → remove-old. Path-drift
|
|
// (user moved the repo, etc.) skips migration with a warning.
|
|
const pathOnlyHashLegacyId = derivePathOnlyHashLegacyId(root);
|
|
const migration = pinnedSourceId
|
|
? { kind: "none", reason: "no-legacy-source" } as const
|
|
: planHostnameFoldMigration(root, sourceId, pathOnlyHashLegacyId, gbrainEnv);
|
|
if (migration.kind === "skipped-path-drift" && !args.quiet) {
|
|
console.error(
|
|
`[sync:code] hostname-fold migration skipped: legacy source ${migration.oldId} `
|
|
+ `points at ${migration.oldPath}, current repo is ${migration.currentPath}. `
|
|
+ `Clean up manually with: gbrain sources remove ${migration.oldId} --confirm-destructive`,
|
|
);
|
|
} else if (migration.kind === "renamed" && !args.quiet) {
|
|
console.error(`[sync:code] hostname-fold migration: renamed ${migration.oldId} → ${migration.newId} (pages preserved)`);
|
|
}
|
|
|
|
// Step 1: Ensure generated sources are registered. A confirmed explicit pin
|
|
// belongs to the user: its realpath was checked above, so never remove/add it
|
|
// merely because the registered spelling differs (e.g. a symlinked checkout).
|
|
let registered = false;
|
|
if (!pinnedSourceId) {
|
|
try {
|
|
const result = await ensureSourceRegistered(sourceId, root, { federated: true, env: gbrainEnv });
|
|
registered = result.changed;
|
|
} catch (err) {
|
|
return {
|
|
name: "code",
|
|
ran: true,
|
|
ok: false,
|
|
duration_ms: Date.now() - t0,
|
|
summary: `source registration failed: ${(err as Error).message}`,
|
|
detail: { source_id: sourceId, source_path: root, status: "failed" },
|
|
};
|
|
}
|
|
}
|
|
|
|
// Step 2: Always run the page-creating file walk first, then (for --full)
|
|
// a full re-embed.
|
|
//
|
|
// `gbrain reindex-code` only RE-EMBEDS pages that already exist; it never
|
|
// walks the filesystem. On a freshly-registered source (0 pages) a --full
|
|
// run that called reindex-code alone found nothing ("No code pages to
|
|
// reindex"), finished in ~1s, and left the code index permanently empty
|
|
// while still reporting OK. The page-creating walk is `sync --strategy
|
|
// code`, so --full must run it FIRST, then reindex-code, to honor the
|
|
// documented "full walk + reindex" contract for both fresh and populated
|
|
// sources.
|
|
const codeTimeoutMs = resolveStageTimeoutMs(
|
|
process.env.GSTACK_SYNC_CODE_TIMEOUT_MS,
|
|
"GSTACK_SYNC_CODE_TIMEOUT_MS",
|
|
);
|
|
|
|
// #1734 guards, checked immediately before the destructive walk (E8):
|
|
// - autopilot active → refuse (the race that wiped a working tree).
|
|
// - URL-managed source → the walk can auto-reclone (rm-rf); require
|
|
// --allow-reclone. Both surface a visible reason and fail the stage so the
|
|
// verdict shows ERR rather than silently skipping protection.
|
|
const apBeforeWalk = detectAutopilot(gbrainEnv);
|
|
if (apBeforeWalk.active) {
|
|
return {
|
|
name: "code", ran: true, ok: false, duration_ms: Date.now() - t0,
|
|
summary: `refused: gbrain autopilot active (${apBeforeWalk.signal}). Stop autopilot, then re-run /sync-gbrain.`,
|
|
detail: { source_id: sourceId, source_path: root, status: "refused-autopilot" },
|
|
};
|
|
}
|
|
const reclone = decideCodeSync(sourceId, gbrainEnv, args.allowReclone);
|
|
if (!reclone.allow) {
|
|
return {
|
|
name: "code", ran: true, ok: false, duration_ms: Date.now() - t0,
|
|
summary: `refused: ${reclone.reason}`,
|
|
detail: { source_id: sourceId, source_path: root, status: "refused-reclone" },
|
|
};
|
|
}
|
|
|
|
// Egress receipt BEFORE the code walk (fail-closed): the walk ships repo
|
|
// content to the user's gbrain DB, which may be a remote Postgres. The
|
|
// gbrain subprocess owns the wire bytes, so the receipt is content-free
|
|
// (destination + payload class only; sha256 null).
|
|
try {
|
|
writeReceipt({
|
|
sink: "gbrain-sync",
|
|
host: "gbrain-db (user-configured DATABASE_URL)",
|
|
payloadClass: `repo-code-index source=${sourceId} (sent by gbrain subprocess)`,
|
|
bytes: 0,
|
|
sha256: null,
|
|
consent: "gbrain setup consent + per-repo policy chokepoint (repoPolicyTier)",
|
|
});
|
|
} catch (err) {
|
|
return {
|
|
name: "code", ran: true, ok: false, duration_ms: Date.now() - t0,
|
|
summary: `EGRESS_RECEIPT_FAILED: ${(err as Error).message} — code sync refused`,
|
|
detail: { source_id: sourceId, source_path: root, status: "refused-egress-receipt" },
|
|
};
|
|
}
|
|
|
|
// `--full` must do a FULL walk, not a delta one.
|
|
//
|
|
// A bare `sync --strategy code` is incremental: it only revisits files that
|
|
// changed since the source's checkpoint. So a file missed at the ORIGINAL
|
|
// import is never revisited and stays invisible indefinitely — and the
|
|
// reindex-code pass below cannot rescue it, because it re-chunks pages that
|
|
// already exist and never walks the filesystem (the same property the comment
|
|
// above already relies on).
|
|
//
|
|
// The failure is silent: no error, no warning, and the verdict block still
|
|
// reports OK while `gbrain search` and `gbrain code-def` answer out of a
|
|
// partial index. It presents as "gbrain is weak at code questions" rather
|
|
// than "the index is incomplete", which is what makes it hard to spot.
|
|
//
|
|
// --yes because this is spawned non-interactively; a full walk otherwise
|
|
// prompts to confirm the import cost.
|
|
//
|
|
// --no-pull always (#2985): gstack indexes the user's working checkout and
|
|
// never wants gbrain to pull or rebase it, and managed gbrain (>= 0.51)
|
|
// refuses `sync` without it. Every supported gbrain accepts the flag.
|
|
const walkArgs = ["sync", "--strategy", "code", "--source", sourceId, "--no-pull"];
|
|
if (args.mode === "full") walkArgs.push("--full", "--yes");
|
|
const walkResult = await runGbrainStreaming(walkArgs, { quiet: args.quiet, timeoutMs: codeTimeoutMs, env: gbrainEnv });
|
|
|
|
if (walkResult.status !== 0) {
|
|
return {
|
|
name: "code",
|
|
ran: true,
|
|
ok: false,
|
|
duration_ms: Date.now() - t0,
|
|
summary: gbrainFailureSummary(walkArgs, walkResult),
|
|
detail: { source_id: sourceId, source_path: root, status: "failed" },
|
|
};
|
|
}
|
|
|
|
if (args.mode === "full") {
|
|
const reindexArgs = ["reindex-code", "--source", sourceId, "--yes"];
|
|
const reindexResult = await runGbrainStreaming(reindexArgs, { quiet: args.quiet, timeoutMs: codeTimeoutMs, env: gbrainEnv });
|
|
|
|
if (reindexResult.status !== 0) {
|
|
return {
|
|
name: "code",
|
|
ran: true,
|
|
ok: false,
|
|
duration_ms: Date.now() - t0,
|
|
summary: gbrainFailureSummary(reindexArgs, reindexResult),
|
|
detail: { source_id: sourceId, source_path: root, status: "failed" },
|
|
};
|
|
}
|
|
}
|
|
|
|
// Step 3: Pin this worktree's CWD to the source via .gbrain-source. Subsequent
|
|
// gbrain code-def / code-refs / code-callers calls from anywhere under <root>
|
|
// route to this source by default — no --source flag needed.
|
|
//
|
|
// If attach fails the whole flow has a silent correctness problem: sync
|
|
// succeeded but unqualified `gbrain code-def` from this worktree will hit
|
|
// the wrong/default source. Treat it as a stage failure (ok=false) so the
|
|
// verdict block surfaces ERR and the user knows to retry rather than
|
|
// trusting stale results.
|
|
const attach = spawnGbrain(["sources", "attach", sourceId], {
|
|
timeout: 10_000,
|
|
cwd: root,
|
|
baseEnv: gbrainEnv,
|
|
});
|
|
const pageCount = sourcePageCount(sourceId, gbrainEnv);
|
|
|
|
// Step 4: Deferred hostname-fold cleanup.
|
|
// Only remove the pre-#1468 path-only-hash source NOW that the new source
|
|
// has registered + synced + has pages. Removing before sync would create a
|
|
// data-loss window if sync failed; removing without a page-count check would
|
|
// wipe pages when sync silently no-op'd. This is the codex-review-flagged
|
|
// safety: register → sync → verify → THEN delete.
|
|
let hostnameLegacyRemoved = false;
|
|
if (migration.kind === "pending-cleanup" && pageCount !== null && pageCount > 0) {
|
|
hostnameLegacyRemoved = removeOrphanedSource(migration.oldId, gbrainEnv);
|
|
if (hostnameLegacyRemoved && !args.quiet) {
|
|
console.error(`[sync:code] hostname-fold migration: removed legacy ${migration.oldId} after new source sync verified (page_count=${pageCount})`);
|
|
}
|
|
}
|
|
|
|
const legacyParts: string[] = [];
|
|
if (legacyRemoved) legacyParts.push(`removed legacy ${legacyId}`);
|
|
if (migration.kind === "renamed") legacyParts.push(`renamed ${migration.oldId}→${migration.newId}`);
|
|
if (hostnameLegacyRemoved) legacyParts.push(`removed pre-hostname-fold ${migration.kind === "pending-cleanup" ? migration.oldId : ""}`);
|
|
const legacyNote = legacyParts.length > 0 ? `, ${legacyParts.join(", ")}` : "";
|
|
const baseSummary = `${registered ? "registered + " : ""}synced ${sourceId} (page_count=${pageCount ?? "unknown"}${legacyNote})`;
|
|
|
|
if (attach.status !== 0) {
|
|
const reason = (attach.stderr || attach.stdout || "").trim().split("\n").pop() || `exit ${attach.status}`;
|
|
return {
|
|
name: "code",
|
|
ran: true,
|
|
ok: false,
|
|
duration_ms: Date.now() - t0,
|
|
summary: `${baseSummary}; attach FAILED (${reason}) — code-def queries from this worktree will hit the default source until /sync-gbrain succeeds`,
|
|
detail: {
|
|
source_id: sourceId,
|
|
source_path: root,
|
|
page_count: pageCount,
|
|
last_imported: new Date().toISOString(),
|
|
status: "failed",
|
|
},
|
|
};
|
|
}
|
|
|
|
// v1.29.0.0 changelog promised the per-worktree pin would be ignored in the
|
|
// consuming repo, but the change actually only added .gbrain-source to
|
|
// gstack's own .gitignore. Without the consumer-side entry, the pin gets
|
|
// committed and breaks the per-worktree promise: Conductor sibling worktrees
|
|
// step on each other's pin every time anyone commits (#1384).
|
|
ensureGbrainSourceGitignored(root);
|
|
|
|
return {
|
|
name: "code",
|
|
ran: true,
|
|
ok: true,
|
|
duration_ms: Date.now() - t0,
|
|
summary: baseSummary,
|
|
detail: {
|
|
source_id: sourceId,
|
|
source_path: root,
|
|
page_count: pageCount,
|
|
last_imported: new Date().toISOString(),
|
|
status: "ok",
|
|
},
|
|
};
|
|
}
|
|
|
|
/**
|
|
* Ensure `.gbrain-source` is listed in the consumer repo's `.gitignore`.
|
|
*
|
|
* Idempotent: only appends when the entry is not already present (matched on
|
|
* trimmed lines so a leading/trailing whitespace difference doesn't add a
|
|
* second copy). Wraps writes in try/catch so a read-only checkout or weird
|
|
* perms logs a warning and lets the rest of the sync continue.
|
|
*/
|
|
export function ensureGbrainSourceGitignored(root: string): void {
|
|
const gitignorePath = join(root, ".gitignore");
|
|
try {
|
|
let existing = "";
|
|
try {
|
|
existing = readFileSync(gitignorePath, "utf-8");
|
|
} catch {
|
|
// No .gitignore yet — we'll create it.
|
|
}
|
|
const alreadyIgnored = existing
|
|
.split("\n")
|
|
.some((line) => line.trim() === ".gbrain-source");
|
|
if (alreadyIgnored) {
|
|
return;
|
|
}
|
|
const sep = existing.length > 0 && !existing.endsWith("\n") ? "\n" : "";
|
|
writeFileSync(gitignorePath, existing + sep + ".gbrain-source\n");
|
|
} catch (err) {
|
|
const msg = err instanceof Error ? err.message : String(err);
|
|
console.warn(
|
|
`[sync:code] could not add .gbrain-source to ${gitignorePath}: ${msg}`,
|
|
);
|
|
}
|
|
}
|
|
|
|
function printTranscriptNotice(args: CliArgs, consent: TranscriptPolicy, selection: ConsentedSelection, why: string): void {
|
|
const notice = transcriptConsentNotice(consent, args.quiet, selection.override ? why : null) ?? transcriptConsentSummary(consent, args.quiet);
|
|
if (notice) console.error(notice);
|
|
}
|
|
|
|
function runMemoryIngest(args: CliArgs, previous: SyncState, consent: TranscriptPolicy): StageResult {
|
|
const t0 = Date.now();
|
|
|
|
if (args.mode === "dry-run") {
|
|
const raw = selectMemorySources(args.memorySources, process.env, false);
|
|
const preview = applyTranscriptConsent(raw, consent);
|
|
printTranscriptNotice(args, consent, preview, raw.why);
|
|
const flag = preview.sources ? ` --sources ${preview.sources.join(",")}` : "";
|
|
return { name: "memory", ran: false, ok: true, duration_ms: 0, summary: `would: gstack-memory-ingest --probe${flag} (${preview.why})` };
|
|
}
|
|
|
|
// Split-engine pre-flight (per plan D12). gstack-memory-ingest shells out
|
|
// to `gbrain import` which targets the LOCAL engine. When that engine is
|
|
// not ok, SKIP cleanly so brain-sync (the only stage that doesn't depend
|
|
// on local engine) still runs.
|
|
const localStatus = localEngineStatus({ noCache: false });
|
|
if (localStatus === "timeout") {
|
|
warnProbeTimeout("memory"); // #1964: slow-but-healthy — proceed
|
|
} else if (localStatus !== "ok") {
|
|
return skipStageForLocalStatus("memory", localStatus, t0);
|
|
}
|
|
|
|
// Resume detection (#1611 / plan D1 + C1). If a previous run hit the
|
|
// timeout and gbrain left ~/.gbrain/import-checkpoint.json plus its staging
|
|
// dir on disk, signal the grandchild via env so it skips the prepare phase
|
|
// and lets `gbrain import` resume from processedIndex+1 against the same
|
|
// staging dir. If the staging dir is gone (disk pressure cleanup, OS
|
|
// reboot, user manual cleanup), warn and fall through to a fresh restage.
|
|
const childEnv = buildGbrainEnv({ announce: false });
|
|
const raw = selectMemorySources(args.memorySources, childEnv, true);
|
|
const selection = applyTranscriptConsent(raw, consent);
|
|
const selected = selection.selected;
|
|
const consentRecord = transcriptConsentRecord(consent, selection.override);
|
|
printTranscriptNotice(args, consent, selection, raw.why);
|
|
let resume = decideResume();
|
|
if (resume.kind === "resume") {
|
|
// The staging dir holds whatever the checkpointed run selected under its
|
|
// transcript consent; resuming it under a different selection or consent
|
|
// would import pages the user excluded. Runs recorded before #2922 walked
|
|
// every type; runs recorded before the consent record walked the 90-day
|
|
// transcript window.
|
|
const prevStage = previous.last_stages?.find((st) => st.name === "memory");
|
|
const staged = prevStage?.memory_sources ?? [...MEMORY_INGEST_TYPES];
|
|
const prevConsent: TranscriptConsentRecord = prevStage?.transcript_consent ?? { mode: "recent", window: "recent" };
|
|
if ([...staged].sort().join(",") !== [...selected].sort().join(",")) {
|
|
console.error(
|
|
`[sync:memory] memory source selection changed since the checkpointed run (${staged.join(",")} → ${selected.join(",")}); restaging from scratch.`,
|
|
);
|
|
resume = { kind: "no-checkpoint" };
|
|
}
|
|
if (
|
|
prevConsent.mode !== consentRecord.mode ||
|
|
prevConsent.window !== consentRecord.window ||
|
|
prevConsent.cutoff !== consentRecord.cutoff ||
|
|
prevConsent.repos_hash !== consentRecord.repos_hash
|
|
) {
|
|
console.error(
|
|
`gbrain-sync: transcript consent changed since the interrupted import (${prevConsent.mode} → ${consentRecord.mode}); restaging memory from scratch once.`,
|
|
);
|
|
resume = { kind: "no-checkpoint" };
|
|
}
|
|
}
|
|
if (resume.kind === "resume") {
|
|
console.error(
|
|
`[sync:memory] resuming from gbrain checkpoint (${resume.processedIndex}/${resume.totalFiles} files staged at ${resume.stagingDir})`,
|
|
);
|
|
childEnv.GSTACK_INGEST_RESUME_DIR = resume.stagingDir;
|
|
} else if (resume.kind === "stale-staging-missing") {
|
|
// The reason distinguishes "actually gone" (disk cleanup / reboot) from
|
|
// "refused as unowned" (#1802 poison: the path may still exist on disk).
|
|
// Logging "gone" for a refused poison path misdirects incident diagnosis.
|
|
const why = resume.reason
|
|
? `staging dir not usable: ${resume.reason}`
|
|
: `staging dir ${resume.stagingDir} gone`;
|
|
console.error(
|
|
`[sync:memory] previous checkpoint stale (${why}), restaging from scratch. ` +
|
|
`Remove ~/.gbrain/import-checkpoint.json to silence.`,
|
|
);
|
|
}
|
|
|
|
const ingestPath = join(import.meta.dir, "gstack-memory-ingest.ts");
|
|
const ingestArgs = ["run", ingestPath];
|
|
if (args.mode === "full") ingestArgs.push("--bulk");
|
|
else ingestArgs.push("--incremental");
|
|
if (args.mode === "full" && consent.affirmative && consent.window !== "recent") ingestArgs.push("--all-history");
|
|
if (args.quiet) ingestArgs.push("--quiet");
|
|
if (selection.sources) ingestArgs.push("--sources", selection.sources.join(","));
|
|
if (!args.quiet) console.error(`[sync:memory] sources: ${selected.join(",")} (${selection.why})`);
|
|
|
|
// Thread the seeded env into the bun grandchild (codex review #7 — the
|
|
// .env.local footgun affects gstack-memory-ingest.ts too, not just the
|
|
// direct gbrain spawns in this file). The grandchild calls gbrain import
|
|
// internally and must see the DATABASE_URL from gbrain's own config.
|
|
const memoryTimeoutMs = resolveStageTimeoutMs(
|
|
process.env.GSTACK_SYNC_MEMORY_TIMEOUT_MS,
|
|
"GSTACK_SYNC_MEMORY_TIMEOUT_MS",
|
|
);
|
|
const result = spawnSync("bun", ingestArgs, {
|
|
encoding: "utf-8",
|
|
timeout: memoryTimeoutMs,
|
|
env: childEnv,
|
|
});
|
|
|
|
// D6: parse [memory-ingest] lines from the child's stderr. ERR-prefixed
|
|
// lines indicate a system-level failure (gbrain crashed or CLI missing)
|
|
// and the child exits non-zero. Per-file failures are summarized in the
|
|
// last non-ERR [memory-ingest] line but do NOT make the verdict ERR.
|
|
const stderrLines = (result.stderr || "").split("\n");
|
|
const memLines = stderrLines.filter((l) => l.includes("[memory-ingest]"));
|
|
const errLine = memLines.find((l) => l.includes("[memory-ingest] ERR"));
|
|
const lastMemLine = memLines.slice(-1)[0];
|
|
const rawSummary = errLine || lastMemLine || "ingest pass complete";
|
|
// Strip the "[memory-ingest] " prefix and any leading "ERR: " for cleaner
|
|
// verdict output. The orchestrator's own formatStage will prefix with OK/ERR.
|
|
const summary = rawSummary
|
|
.replace(/^.*\[memory-ingest\]\s*/, "")
|
|
.replace(/^ERR:\s*/, "");
|
|
|
|
const ok = result.status === 0;
|
|
return {
|
|
name: "memory",
|
|
ran: true,
|
|
ok,
|
|
duration_ms: Date.now() - t0,
|
|
summary: ok
|
|
? summary
|
|
: `${summary}${result.status === null ? " (killed by signal / timeout)" : ` (exit ${result.status})`}`,
|
|
memory_sources: selected,
|
|
transcript_consent: consentRecord,
|
|
};
|
|
}
|
|
|
|
function runBrainSyncPush(args: CliArgs): StageResult {
|
|
const t0 = Date.now();
|
|
|
|
if (args.mode === "dry-run") {
|
|
return { name: "brain-sync", ran: false, ok: true, duration_ms: 0, summary: "would: gstack-brain-sync --discover-new --once" };
|
|
}
|
|
|
|
const brainSyncPath = join(import.meta.dir, "gstack-brain-sync");
|
|
if (!existsSync(brainSyncPath)) {
|
|
return { name: "brain-sync", ran: false, ok: true, duration_ms: 0, summary: "skipped (gstack-brain-sync not installed)" };
|
|
}
|
|
|
|
// gstack-brain-sync is a bash shebang script, so it needs an INTERPRETER, not
|
|
// a shell. #1731 gave it `shell: NEEDS_SHELL_ON_WINDOWS`, which is right for
|
|
// the gbrain.cmd shim and useless here: cmd.exe resolves .cmd/.bat via PATHEXT
|
|
// and rejects an extension-less shebang script outright ("is not recognized as
|
|
// an internal or external command"), so this stage failed on EVERY Windows run
|
|
// while looking like a single red line in an otherwise green report. See
|
|
// bashScriptInvocation.
|
|
const discover = bashScriptInvocation(brainSyncPath, ["--discover-new"]);
|
|
const once = bashScriptInvocation(brainSyncPath, ["--once"]);
|
|
if (!discover || !once) {
|
|
return {
|
|
name: "brain-sync",
|
|
ran: false,
|
|
ok: true,
|
|
duration_ms: Date.now() - t0,
|
|
summary: "skipped (no bash found; set GSTACK_BASH to your Git bash.exe)",
|
|
};
|
|
}
|
|
|
|
const stdio: "ignore"[] | ("ignore" | "inherit")[] = args.quiet
|
|
? ["ignore", "ignore", "ignore"]
|
|
: ["ignore", "inherit", "inherit"];
|
|
|
|
spawnSync(discover.cmd, discover.argv, { stdio, timeout: 60 * 1000, shell: discover.shell });
|
|
const result = spawnSync(once.cmd, once.argv, { stdio, timeout: 60 * 1000, shell: once.shell });
|
|
|
|
if (result.status !== 0) {
|
|
return { name: "brain-sync", ran: true, ok: false, duration_ms: Date.now() - t0, summary: `gstack-brain-sync exited ${result.status}` };
|
|
}
|
|
return { name: "brain-sync", ran: true, duration_ms: Date.now() - t0, ...brainSyncIndexVerdict() };
|
|
}
|
|
|
|
/**
|
|
* Decide whether the dream (call-graph build) cycle should run. PURE so the
|
|
* gate matrix is unit-testable without spawning a real ~35-min dream.
|
|
*
|
|
* - explicit --dream → always run (force), regardless of cycle state / --no-code.
|
|
* - --full → run ONLY when the call graph was never built (cycle === "never"),
|
|
* and only when not opted out via --no-dream / --no-code. "completed" skips
|
|
* (edges already built); "unknown" skips (a flaky doctor must not trigger a
|
|
* surprise 35-min cycle — see gbrain-doctor-overstrict).
|
|
* - everything else → skip.
|
|
*
|
|
* `cycle` is only consulted on the --full auto path; pass null when forcing.
|
|
*/
|
|
export function shouldRunDream(args: CliArgs, cycle: CycleStatus | null): boolean {
|
|
if (args.dream) return true;
|
|
if (args.mode === "full" && !args.noDream && !args.noCode) {
|
|
return cycle === "never";
|
|
}
|
|
return false;
|
|
}
|
|
|
|
/**
|
|
* Run `gbrain dream` — the brain-global maintenance cycle whose
|
|
* resolve_symbol_edges phase builds the call graph. Runs LOCK-FREE (called
|
|
* after the sync lock releases) so it never freezes sibling worktrees; the
|
|
* `.dream-in-progress` marker dedupes concurrent dreams instead.
|
|
*
|
|
* Returns a StageResult (never throws). SKIP (ran:false, ok:true) for: dry-run
|
|
* preview, local engine not ok, or a fresh marker present. ERR (ran:true,
|
|
* ok:false) for: non-zero/timeout exit, or a spawn-setup failure (missing
|
|
* binary / malformed env) — a broken install must be visible, not disguised as
|
|
* optional maintenance.
|
|
*/
|
|
/**
|
|
* A7: detected, not assumed. gbrain validates --phase values while parsing,
|
|
* before --help prints, so a gbrain without the phase exits non-zero and one
|
|
* without --phase prints help that never mentions it.
|
|
*/
|
|
export function gbrainSupportsSymbolEdgePhase(env: NodeJS.ProcessEnv = process.env): boolean {
|
|
const r = spawnGbrain(["dream", "--phase", "resolve_symbol_edges", "--help"], { baseEnv: env, timeout: 15_000 });
|
|
return r.status === 0 && /--phase\b/.test(`${r.stdout || ""}${r.stderr || ""}`);
|
|
}
|
|
|
|
export async function runDream(args: CliArgs): Promise<StageResult> {
|
|
const t0 = Date.now();
|
|
|
|
if (args.mode === "dry-run") {
|
|
const root = repoRoot();
|
|
const sourceId = root ? readPinnedSourceId(root) ?? deriveCodeSourceId(root) : null;
|
|
return {
|
|
name: "dream",
|
|
ran: false,
|
|
ok: true,
|
|
duration_ms: 0,
|
|
summary: sourceId
|
|
? `would: gbrain dream --source ${sourceId} --phase resolve_symbol_edges (build this source's call graph; skipped if gbrain cannot scope the phase)`
|
|
: "would: gbrain dream --phase resolve_symbol_edges (call-graph build; skipped if gbrain cannot scope the phase)",
|
|
};
|
|
}
|
|
|
|
const gbrainEnv = buildGbrainEnv({ announce: !args.quiet });
|
|
const localStatus = localEngineStatus({ noCache: false });
|
|
if (localStatus === "timeout") {
|
|
warnProbeTimeout("dream"); // #1964: slow-but-healthy — proceed
|
|
} else if (localStatus !== "ok") {
|
|
return skipStageForLocalStatus("dream", localStatus, t0);
|
|
}
|
|
|
|
// Dedupe concurrent dreams across worktrees (lock-free path).
|
|
if (!acquireDreamMarker()) {
|
|
const pid = dreamMarkerPid();
|
|
return {
|
|
name: "dream",
|
|
ran: false,
|
|
ok: true,
|
|
duration_ms: Date.now() - t0,
|
|
summary: `dream already running${pid !== null ? ` (pid ${pid})` : ""} — skipped`,
|
|
};
|
|
}
|
|
|
|
try {
|
|
const dreamTimeoutMs = resolveStageTimeoutMs(
|
|
process.env.GSTACK_SYNC_DREAM_TIMEOUT_MS,
|
|
"GSTACK_SYNC_DREAM_TIMEOUT_MS",
|
|
DEFAULT_DREAM_TIMEOUT_MS,
|
|
);
|
|
|
|
// Scope the cycle to THIS worktree's code source: `gbrain dream --source <id>`.
|
|
// Verified empirically (not just from `gbrain --help`): plain `gbrain dream`
|
|
// cycles the brain's default source and never runs the source-scoped `extract`
|
|
// phase for our code source, so the call graph for the pinned source stays
|
|
// empty. `gbrain dream --source <id>` runs the per-source cycle (the form
|
|
// `gbrain doctor` recommends for stale sources) and is what actually populates
|
|
// code-callers/code-callees for this worktree. Falls back to plain `dream`
|
|
// only when we can't derive the source id (not in a git repo).
|
|
const root = repoRoot();
|
|
const sourceId = root ? resolveCodeSourceId(root, gbrainEnv) : null;
|
|
// A7 (#2783): the call graph needs only the resolve_symbol_edges phase. A
|
|
// full `gbrain dream` runs every maintenance phase, LLM ones included
|
|
// (~35 min). Scope it when the installed gbrain can; never fall back to
|
|
// the full cycle on its own.
|
|
if (!gbrainSupportsSymbolEdgePhase()) {
|
|
return {
|
|
name: "dream",
|
|
ran: false,
|
|
ok: true,
|
|
duration_ms: Date.now() - t0,
|
|
summary:
|
|
"skipped — the installed gbrain cannot run only the resolve_symbol_edges phase, and the full dream cycle " +
|
|
`costs about 35 minutes (LLM phases). Upgrade with gstack-gbrain-install, or run it yourself: gbrain dream${sourceId ? ` --source ${sourceId}` : ""}`,
|
|
};
|
|
}
|
|
const dreamArgs = sourceId
|
|
? ["dream", "--source", sourceId, "--phase", "resolve_symbol_edges"]
|
|
: ["dream", "--phase", "resolve_symbol_edges"];
|
|
|
|
// spawnGbrain seeds DATABASE_URL from gbrain's config via buildGbrainEnv.
|
|
//
|
|
// We CAPTURE output (pipe) rather than inherit because `gbrain dream` exits 0
|
|
// even when it SKIPS the cycle — when another cycle already holds gbrain's own
|
|
// DB lock (e.g. a running `gbrain autopilot`), it prints "Skipped: another
|
|
// cycle is already running. (locked)" and exits 0. Trusting the exit code
|
|
// alone would falsely report "call graph built". Trade-off: no live streaming
|
|
// for a long cycle; we echo the captured output afterward instead.
|
|
if (!args.quiet) {
|
|
process.stderr.write("[dream] running gbrain cycle (call-graph build; this can take a few minutes)...\n");
|
|
}
|
|
let result: ReturnType<typeof spawnGbrain>;
|
|
try {
|
|
result = spawnGbrain(dreamArgs, {
|
|
stdio: ["ignore", "pipe", "pipe"],
|
|
timeout: dreamTimeoutMs,
|
|
baseEnv: process.env,
|
|
announce: !args.quiet,
|
|
});
|
|
} catch (err) {
|
|
// Spawn-setup failure (missing binary, bad env): ERR, not a benign skip.
|
|
return {
|
|
name: "dream",
|
|
ran: true,
|
|
ok: false,
|
|
duration_ms: Date.now() - t0,
|
|
summary: `gbrain dream failed to start: ${(err as Error).message}`,
|
|
};
|
|
}
|
|
|
|
if (result.error) {
|
|
const e = result.error as NodeJS.ErrnoException;
|
|
const why = e.code === "ENOENT" ? "gbrain not on PATH" : e.message;
|
|
return {
|
|
name: "dream",
|
|
ran: true,
|
|
ok: false,
|
|
duration_ms: Date.now() - t0,
|
|
summary: `gbrain dream failed to start: ${why}`,
|
|
};
|
|
}
|
|
|
|
const out = `${result.stdout || ""}${result.stderr || ""}`;
|
|
if (!args.quiet && out.trim()) {
|
|
process.stderr.write(out.endsWith("\n") ? out : `${out}\n`);
|
|
}
|
|
|
|
if (result.status !== 0) {
|
|
return {
|
|
name: "dream",
|
|
ran: true,
|
|
ok: false,
|
|
duration_ms: Date.now() - t0,
|
|
summary: `gbrain dream exited ${result.status === null ? "null (killed by signal / timeout)" : result.status}`,
|
|
};
|
|
}
|
|
|
|
// Exit 0 but the cycle was SKIPPED because gbrain's own lock is held by
|
|
// another cycle (typically `gbrain autopilot`). Report SKIP, not "built" —
|
|
// the graph builds on that other cycle, not this invocation.
|
|
if (/already running|\block(?:ed)?\b|Skipped:/i.test(out)) {
|
|
return {
|
|
name: "dream",
|
|
ran: false,
|
|
ok: true,
|
|
duration_ms: Date.now() - t0,
|
|
summary: "skipped — a gbrain cycle is already running (e.g. autopilot); the call graph builds on that cycle",
|
|
};
|
|
}
|
|
|
|
// Exit 0 and the cycle actually ran. Parse the cycle's OWN output to report
|
|
// the truth, not a flat "built": `gbrain dream` exits 0 even when the call
|
|
// graph could not be built, and a misleading "built" turns a multi-minute
|
|
// no-op into a silent dead end. gbrain only surfaces these conditions in the
|
|
// cycle log (there is no pre-flight pack-capability query as of 0.41.x), so
|
|
// string-matching the log is the available signal; an unrecognized log
|
|
// degrades to the generic success summary below.
|
|
const dreamWarn = classifyDreamOutcome(out);
|
|
if (dreamWarn) {
|
|
return {
|
|
name: "dream",
|
|
ran: true,
|
|
ok: true,
|
|
warn: true,
|
|
duration_ms: Date.now() - t0,
|
|
summary: dreamWarn,
|
|
};
|
|
}
|
|
|
|
const edges = parseResolvedEdges(out);
|
|
return {
|
|
name: "dream",
|
|
ran: true,
|
|
ok: true,
|
|
duration_ms: Date.now() - t0,
|
|
summary:
|
|
edges !== null
|
|
? `call graph built (${edges} edge${edges === 1 ? "" : "s"} resolved)`
|
|
: "call graph built (resolve_symbol_edges complete)",
|
|
};
|
|
} finally {
|
|
releaseDreamMarker();
|
|
}
|
|
}
|
|
|
|
/**
|
|
* Parse `<n>` from a `resolve_symbol_edges ... resolved <n>` cycle-log line.
|
|
* Returns null when the line is absent (older gbrain / different pack). The
|
|
* `[^\n]*?` is newline-bounded so it matches the `✓ resolve_symbol_edges ...`
|
|
* summary line, not the bracketed `[cycle.resolve_symbol_edges] start` markers.
|
|
*/
|
|
export function parseResolvedEdges(out: string): number | null {
|
|
const m = out.match(/resolve_symbol_edges\b[^\n]*?\bresolved\s+(\d+)/i);
|
|
return m ? parseInt(m[1], 10) : null;
|
|
}
|
|
|
|
/**
|
|
* Inspect a completed (exit-0) `gbrain dream` log and return a WARN summary when
|
|
* the cycle ran but could not actually build the call graph. Returns null on the
|
|
* happy path (caller emits the normal "call graph built" summary). Order matters:
|
|
* the pack-capability gap is the most actionable, so it wins over a 0-edge count
|
|
* (both appear together when the pack lacks the code-symbol phase).
|
|
*/
|
|
export function classifyDreamOutcome(out: string): string | null {
|
|
// The active schema pack doesn't declare the code-symbol extraction phase, so
|
|
// no symbols are extracted and resolve_symbol_edges has nothing to match.
|
|
// #2341: anchor the match to a GRAPH phase. The bare phrase false-positived
|
|
// on every base-pack brain — gbrain's only emitters of "active pack does not
|
|
// declare this phase" are the CONTENT phases (extract_atoms,
|
|
// synthesize_concepts), which base packs legitimately skip while
|
|
// resolve_symbol_edges still runs and builds the graph. Matching the bare
|
|
// phrase sent users pack-churning ("switch schema packs") for nothing and
|
|
// masked real graph bugs behind a wrong diagnosis.
|
|
if (/(resolve_symbol_edges|extract_code_symbols)[^\n]*does not declare/i.test(out)) {
|
|
return (
|
|
"dream ran, but this source's schema pack does not extract code symbols, " +
|
|
"so the call graph stays empty. Switch this source to a code-aware schema " +
|
|
"pack (`gbrain schema use <pack>`) to enable code-callers/code-callees."
|
|
);
|
|
}
|
|
// The embed phase failed for a missing key; symbols can't index without it.
|
|
if (/embed phase failed/i.test(out) || /requires\s+\S*_API_KEY/i.test(out)) {
|
|
return (
|
|
"dream ran, but the embed phase failed (missing embedding API key), so " +
|
|
"symbols won't index. Ensure the embedding provider's key is set for the " +
|
|
"gbrain process, then re-run /sync-gbrain --dream."
|
|
);
|
|
}
|
|
// Cycle ran and embedded fine, but matched zero call-graph edges.
|
|
if (parseResolvedEdges(out) === 0) {
|
|
return "dream ran but resolved 0 call-graph edges (no code symbols matched for this source yet).";
|
|
}
|
|
return null;
|
|
}
|
|
|
|
// ── State file ─────────────────────────────────────────────────────────────
|
|
|
|
interface SyncState {
|
|
schema_version: 1;
|
|
last_writer: string;
|
|
last_sync?: string;
|
|
last_full_sync?: string;
|
|
last_stages?: StageResult[];
|
|
/** A6: gstack code sources whose path was missing, with consecutive-miss counts. */
|
|
unavailable_sources?: Record<string, UnavailableSource>;
|
|
/** A6: what this machine knew about each code source it synced (ownership proof). */
|
|
code_sources?: Record<string, CodeSourceRecord>;
|
|
}
|
|
|
|
function loadSyncState(): SyncState {
|
|
if (!existsSync(STATE_PATH)) {
|
|
return { schema_version: 1, last_writer: "gstack-gbrain-sync" };
|
|
}
|
|
try {
|
|
const raw = JSON.parse(readFileSync(STATE_PATH, "utf-8")) as SyncState;
|
|
if (raw.schema_version === 1) return raw;
|
|
} catch {
|
|
// fall through
|
|
}
|
|
return { schema_version: 1, last_writer: "gstack-gbrain-sync" };
|
|
}
|
|
|
|
/**
|
|
* Atomic state file write per /plan-eng-review D1: write tmp file then rename.
|
|
* rename(2) is atomic on POSIX filesystems.
|
|
*/
|
|
function saveSyncState(state: SyncState): void {
|
|
try {
|
|
mkdirSync(dirname(STATE_PATH), { recursive: true });
|
|
const tmp = `${STATE_PATH}.tmp.${process.pid}`;
|
|
writeFileSync(tmp, JSON.stringify(state, null, 2), "utf-8");
|
|
renameSync(tmp, STATE_PATH);
|
|
} catch {
|
|
// non-fatal
|
|
}
|
|
}
|
|
|
|
/**
|
|
* Persist the dream stage result with read-modify-write semantics.
|
|
*
|
|
* Dream runs AFTER the sync lock releases, so a sibling worktree may have
|
|
* written newer state in the meantime. Overwriting the whole file with our
|
|
* pre-dream snapshot + dream result would clobber that sibling's sync. Instead
|
|
* re-read the CURRENT state, replace only the `dream` entry in last_stages, and
|
|
* atomic-rename. (Atomic rename alone isn't race-safe; the re-read + targeted
|
|
* merge is what prevents the clobber.)
|
|
*/
|
|
function mergeDreamIntoState(dream: StageResult): void {
|
|
const fresh = loadSyncState();
|
|
const others = (fresh.last_stages || []).filter((s) => s.name !== "dream");
|
|
fresh.last_stages = [...others, dream];
|
|
fresh.last_sync = new Date().toISOString();
|
|
saveSyncState(fresh);
|
|
}
|
|
|
|
// ── Output ─────────────────────────────────────────────────────────────────
|
|
|
|
export function formatStage(s: StageResult): string {
|
|
const status = !s.ran ? "SKIP" : !s.ok ? "ERR" : s.warn ? "WARN" : "OK";
|
|
const dur = s.duration_ms > 0 ? ` (${(s.duration_ms / 1000).toFixed(1)}s)` : "";
|
|
return ` ${status.padEnd(5)} ${s.name.padEnd(12)} ${s.summary}${dur}`;
|
|
}
|
|
|
|
// ── Main ───────────────────────────────────────────────────────────────────
|
|
|
|
// ── Gone worktree sources (A6, #2688) ──────────────────────────────────────
|
|
|
|
function gitCommonDir(root: string): string | null {
|
|
const r = spawnSync("git", ["-C", root, "rev-parse", "--path-format=absolute", "--git-common-dir"], { encoding: "utf-8", timeout: 5000 });
|
|
return r.status === 0 && r.stdout.trim() ? r.stdout.trim() : null;
|
|
}
|
|
|
|
function currentCodeSourceRecord(): CodeSourceRecord | null {
|
|
const root = repoRoot();
|
|
return root ? { path: root, remote: canonicalizeRemote(originUrl()), git_common_dir: gitCommonDir(root) } : null;
|
|
}
|
|
|
|
/** Remember which repository a synced code source belongs to (the prune ownership proof). */
|
|
function recordCodeSource(state: SyncState, stages: StageResult[]): void {
|
|
const code = stages.find((s) => s.name === "code" && s.ran && s.ok);
|
|
const id = code?.detail?.source_id;
|
|
const record = currentCodeSourceRecord();
|
|
if (!id || !record || code?.detail?.source_path !== record.path) return;
|
|
(state.code_sources ??= {})[id] = record;
|
|
}
|
|
|
|
/**
|
|
* Count consecutive syncs that find a gstack code source's path missing, and
|
|
* say so once per source. gstack never removes such a source on its own.
|
|
*/
|
|
function trackGoneSources(state: SyncState, quiet: boolean): void {
|
|
const raw = execGbrainJson(["sources", "list", "--json"], { timeout: 10_000 });
|
|
if (raw === null) return;
|
|
const { next, newlyUnavailable } = trackUnavailableSources(parseSourcesList(raw), state.unavailable_sources ?? {}, existsSync, new Date().toISOString());
|
|
state.unavailable_sources = next;
|
|
for (const id of newlyUnavailable) {
|
|
console.error(
|
|
`[gbrain-sync] gbrain source ${id}: path unavailable (${next[id].path}); gstack skips it. ` +
|
|
`If that worktree was deleted, review removal with: gstack-gbrain-sync --prune-gone-worktrees --dry-run`,
|
|
);
|
|
}
|
|
if (!quiet && newlyUnavailable.length === 0 && Object.keys(next).length > 0) {
|
|
console.error(`[gbrain-sync] ${Object.keys(next).length} gbrain source(s) still have an unavailable path (see --prune-gone-worktrees --dry-run)`);
|
|
}
|
|
}
|
|
|
|
function readableDir(p: string): boolean {
|
|
try {
|
|
readdirSync(p);
|
|
return true;
|
|
} catch {
|
|
return false;
|
|
}
|
|
}
|
|
|
|
function worktreeListed(gitDir: string, path: string): boolean | null {
|
|
const r = spawnSync("git", [`--git-dir=${gitDir}`, "worktree", "list", "--porcelain"], { encoding: "utf-8", timeout: 10_000 });
|
|
if (r.status !== 0) return null;
|
|
return r.stdout.split("\n").some((line) => line === `worktree ${path}`);
|
|
}
|
|
|
|
/**
|
|
* `--prune-gone-worktrees`: remove gstack code sources whose worktree is
|
|
* provably gone (lib/gbrain-sources.ts decidePrune). Prints the plan first;
|
|
* with --dry-run that is all it does. Each removal re-checks the path right
|
|
* before removing and is logged to ~/.gstack/.gbrain-prune.log.
|
|
*/
|
|
function pruneGoneWorktrees(dryRun: boolean): number {
|
|
const raw = execGbrainJson(["sources", "list", "--json"], { timeout: 10_000 });
|
|
if (raw === null) {
|
|
console.error("[prune] gbrain sources list failed; nothing removed. Fix: run /setup-gbrain, then retry.");
|
|
return 1;
|
|
}
|
|
if (!dryRun && !acquireLock()) {
|
|
console.error(`[prune] another /sync-gbrain is running (lock at ${LOCK_PATH}); nothing removed.`);
|
|
return 2;
|
|
}
|
|
try {
|
|
const state = loadSyncState();
|
|
const ctx = {
|
|
unavailable: state.unavailable_sources ?? {},
|
|
records: state.code_sources ?? {},
|
|
current: currentCodeSourceRecord(),
|
|
deriveId: deriveCodeSourceId,
|
|
exists: existsSync,
|
|
readableDir,
|
|
worktreeListed,
|
|
};
|
|
const rows = parseSourcesList(raw).filter((r) => r.id?.startsWith("gstack-code-") && r.local_path && !existsSync(r.local_path));
|
|
if (rows.length === 0) {
|
|
console.log("[prune] no gstack code source has a missing path; nothing to do.");
|
|
return 0;
|
|
}
|
|
const plan = rows.map((r) => ({ id: r.id!, path: r.local_path!, ...decidePrune(r.id!, r.local_path!, ctx) }));
|
|
for (const p of plan) console.log(`[prune]${dryRun ? " (dry run)" : ""} ${p.remove ? "would remove" : "keep"} ${p.id} (${p.path}): ${p.reason}`);
|
|
if (dryRun) return 0;
|
|
let failed = 0;
|
|
for (const p of plan.filter((x) => x.remove)) {
|
|
if (existsSync(p.path)) {
|
|
console.log(`[prune] keep ${p.id}: ${p.path} exists again`);
|
|
continue;
|
|
}
|
|
const r = safeSourcesRemove(p.id);
|
|
const line = `${new Date().toISOString()} ${r.removed ? "removed" : "not removed"} ${p.id} ${p.path}: ${r.removed ? p.reason : r.reason}`;
|
|
console.log(`[prune] ${line}`);
|
|
try {
|
|
appendFileSync(join(GSTACK_HOME, ".gbrain-prune.log"), line + "\n");
|
|
} catch {}
|
|
if (r.removed) {
|
|
delete state.unavailable_sources?.[p.id];
|
|
delete state.code_sources?.[p.id];
|
|
} else failed++;
|
|
}
|
|
saveSyncState(state);
|
|
return failed > 0 ? 1 : 0;
|
|
} finally {
|
|
if (!dryRun) releaseLock();
|
|
}
|
|
}
|
|
|
|
async function main(): Promise<void> {
|
|
const args = parseArgs();
|
|
if (args.pruneGone) process.exit(pruneGoneWorktrees(args.mode === "dry-run"));
|
|
// Read once at sync start: a config change made while the sync runs never
|
|
// adds transcripts to this run.
|
|
const consent = args.noMemory ? null : readTranscriptConsent();
|
|
|
|
if (!args.quiet) {
|
|
const engine = detectEngineTier();
|
|
console.error(`[gbrain-sync] mode=${args.mode} engine=${engine.engine}`);
|
|
}
|
|
|
|
// Acquire lock (skip on dry-run since dry-run never writes).
|
|
const needsLock = args.mode !== "dry-run";
|
|
let haveLock = false;
|
|
if (needsLock) {
|
|
haveLock = acquireLock();
|
|
if (!haveLock) {
|
|
console.error(
|
|
`[gbrain-sync] another /sync-gbrain is running (lock at ${LOCK_PATH}). ` +
|
|
`If that process died, the lock auto-clears after 5 min, or remove it manually.`
|
|
);
|
|
process.exit(2);
|
|
}
|
|
}
|
|
|
|
const cleanup = () => {
|
|
if (haveLock) releaseLock();
|
|
};
|
|
process.on("SIGINT", () => { cleanup(); process.exit(130); });
|
|
process.on("SIGTERM", () => { cleanup(); process.exit(143); });
|
|
|
|
let exitCode = 0;
|
|
const stages: StageResult[] = [];
|
|
try {
|
|
const state = loadSyncState();
|
|
|
|
if (!args.noCode) {
|
|
stages.push(await withErrorContext("sync:code", () => runCodeImport(args), "gstack-gbrain-sync"));
|
|
}
|
|
if (!args.noMemory) {
|
|
stages.push(await withErrorContext("sync:memory", () => runMemoryIngest(args, state, consent!), "gstack-gbrain-sync"));
|
|
}
|
|
if (!args.noBrainSync) {
|
|
stages.push(await withErrorContext("sync:brain-sync", () => runBrainSyncPush(args), "gstack-gbrain-sync"));
|
|
}
|
|
|
|
if (args.mode !== "dry-run") {
|
|
state.last_sync = new Date().toISOString();
|
|
if (args.mode === "full") state.last_full_sync = state.last_sync;
|
|
state.last_stages = stages;
|
|
recordCodeSource(state, stages);
|
|
trackGoneSources(state, args.quiet);
|
|
saveSyncState(state);
|
|
}
|
|
|
|
const anyError = stages.some((s) => s.ran && !s.ok);
|
|
exitCode = anyError ? 1 : 0;
|
|
} finally {
|
|
// Release the sync lock BEFORE the dream cycle. Dream is a source-scoped
|
|
// cycle that can run several minutes; holding the machine-wide lock that
|
|
// long would freeze every other worktree's /sync-gbrain. Dream is guarded
|
|
// by its own marker.
|
|
cleanup();
|
|
}
|
|
|
|
// ── Dream (call-graph build) — LOCK-FREE, after the sync lock releases ─────
|
|
let dreamStage: StageResult | null = null;
|
|
if (args.mode === "dry-run") {
|
|
// Preview only; never probes doctor or spawns. `--dry-run` and `--full` are
|
|
// mutually exclusive modes (last one wins in parseArgs), so the only dream
|
|
// preview that applies to a dry-run is the explicit --dream force.
|
|
if (args.dream) {
|
|
dreamStage = await runDream(args);
|
|
}
|
|
} else {
|
|
// Resolve cycle state only on the --full auto path (perf: the steady-state
|
|
// incremental sync never pays a doctor subprocess). Explicit --dream forces.
|
|
let cycle: CycleStatus | null = null;
|
|
let cycleWhy = "not in a git repo";
|
|
if (!args.dream && args.mode === "full" && !args.noDream && !args.noCode) {
|
|
const root = repoRoot();
|
|
const gbrainEnv = buildGbrainEnv({ announce: !args.quiet });
|
|
const read = root ? readCycleStatus(resolveCodeSourceId(root, gbrainEnv), gbrainEnv) : { status: "unknown" as const };
|
|
cycle = read.status;
|
|
cycleWhy = read.why ?? "gbrain doctor did not say whether this source cycled";
|
|
}
|
|
if (shouldRunDream(args, cycle)) {
|
|
dreamStage = await runDream(args);
|
|
mergeDreamIntoState(dreamStage);
|
|
if (dreamStage.ran && !dreamStage.ok) exitCode = 1;
|
|
} else if (cycle === "unknown") {
|
|
// --full wanted to auto-build but doctor couldn't confirm the graph state.
|
|
// Surface a WARN-style SKIP so the user knows to run --dream if needed,
|
|
// rather than silently doing nothing (a flaky doctor must not trigger a
|
|
// surprise 35-min run — gbrain-doctor-overstrict).
|
|
dreamStage = {
|
|
name: "dream",
|
|
ran: false,
|
|
ok: true,
|
|
duration_ms: 0,
|
|
summary: `call-graph state unknown (${cycleWhy}) — run /sync-gbrain --dream if code-callers returns 0`,
|
|
};
|
|
}
|
|
}
|
|
|
|
if (!args.quiet || args.mode === "dry-run") {
|
|
const allStages = dreamStage ? [...stages, dreamStage] : stages;
|
|
console.log(`\ngstack-gbrain-sync (${args.mode}):`);
|
|
for (const s of allStages) console.log(formatStage(s));
|
|
const okCount = allStages.filter((s) => s.ok).length;
|
|
const errCount = allStages.filter((s) => !s.ok && s.ran).length;
|
|
console.log(`\n ${okCount} ok, ${errCount} error, ${allStages.length - okCount - errCount} skipped`);
|
|
const gone = Object.keys(loadSyncState().unavailable_sources ?? {}).length;
|
|
if (gone > 0) {
|
|
console.log(` ${gone} gbrain source(s) have an unavailable path; review with: gstack-gbrain-sync --prune-gone-worktrees --dry-run`);
|
|
}
|
|
}
|
|
|
|
process.exit(exitCode);
|
|
}
|
|
|
|
if (import.meta.main) {
|
|
main().catch((err) => {
|
|
console.error(`gstack-gbrain-sync fatal: ${err instanceof Error ? err.message : String(err)}`);
|
|
releaseLock();
|
|
process.exit(1);
|
|
});
|
|
}
|