mirror of
https://github.com/garrytan/gstack.git
synced 2026-11-10 02:30:39 +01:00
1b96d9f853
* Make autoplan's plan-approval gate item p1 so gstack-gate accepts it (#4181)
/autoplan Phase 4 told the agent to write a gate item with id `plan` and
to read replies `plana`/`planc`/`pland`/`plane`. gstack-gate only accepts
ids of a lowercase label plus a number, so render refused the gate and the
replies never parsed. Rename it to `p1` (the id lib/autoplan-gate.ts and
docs/unattended.md already use), lower the autoplan size pins by the 10
characters saved, and add a test that builds the gate from the template text
and runs it through bin/gstack-gate render and parse.
Co-authored-by: Eng. Mahmoud Bek ElNemer <83190847+ElNeMeR70@users.noreply.github.com>
Co-authored-by: Yuan S. <3579304+szsunyuan@users.noreply.github.com>
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* Re-ask autoplan gate replies that leave an approval pending (#4181)
Now that the /autoplan Phase 4 gate renders, its reply mapping is reachable.
gstack-gate parse accepts p1a while a User Challenge is still pending, and
treats all as rec, which takes plan-changing recommendations, yet the skill
sent both straight to A (approve as written). Re-present a reply that leaves
an approval item pending, and send a plan change chosen on a d<n> or uc<n>
item, all included, to B or B2. The paragraph is 3 characters shorter, so
the 12 autoplan size pins drop by 3.
Review-Finding: p1/outside-voice#1 reader=outside-voice
Review-Finding: p1/adversarial-native#1 reader=adversarial-native
Review-Finding: p1/adversarial-native#2 reader=adversarial-native
Review-Finding: p1/red-team#1 reader=red-team
Review-Finding: p1/red-team#2 reader=red-team
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* Revert "Re-ask autoplan gate replies that leave an approval pending (#4181)"
This reverts commit b746d50dc5.
---------
Co-authored-by: Eng. Mahmoud Bek ElNemer <83190847+ElNeMeR70@users.noreply.github.com>
Co-authored-by: Yuan S. <3579304+szsunyuan@users.noreply.github.com>
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>