mirror of
https://github.com/garrytan/gstack.git
synced 2026-09-10 23:19:09 +02:00
Garry TanandClaude Fable 5
752aa18a05
- The /conductor/bin/git patch writes tmp-then-rename with a .orig backup — a concurrently spawned git can never exec a truncated shim. - Xvfb running-check looks for the :99 socket, not any-display pgrep. - Xvfb install is dnf-gated so non-dnf distros degrade to a warning instead of aborting the remaining fixes under set -eu. - The bashrc /dev/fd restore uses sudo -n || true — no password prompt at every shell start on non-passwordless machines. - BASH_COMPAT=50 keeps heredoc bodies off the bash pipe window. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
35 lines
1.7 KiB
TypeScript
35 lines
1.7 KiB
TypeScript
/**
|
|
* scripts/sandbox-doctor.sh — static shell sanity (free).
|
|
*
|
|
* The script mutates a live sandbox (sudo mounts, dnf, bashrc), so its
|
|
* behavior can't run under the suite; this pins what CAN be checked for
|
|
* free: it parses as POSIX sh, fails fast, and every mutation is guarded so
|
|
* a re-run is a no-op (its documented contract is "idempotent — run once per
|
|
* sandbox boot").
|
|
*/
|
|
import { describe, test, expect } from 'bun:test';
|
|
import { spawnSync } from 'child_process';
|
|
import * as fs from 'fs';
|
|
import * as path from 'path';
|
|
|
|
const SCRIPT = path.join(import.meta.dir, '..', 'scripts', 'sandbox-doctor.sh');
|
|
|
|
describe('sandbox-doctor.sh', () => {
|
|
test('parses as POSIX sh, fails fast, and guards every mutation for idempotency', () => {
|
|
// Syntax: `sh -n` parses without executing.
|
|
const parse = spawnSync('sh', ['-n', SCRIPT], { encoding: 'utf8' });
|
|
expect(parse.status, parse.stderr).toBe(0);
|
|
|
|
const src = fs.readFileSync(SCRIPT, 'utf-8');
|
|
expect(src.startsWith('#!/bin/sh')).toBe(true);
|
|
expect(src).toContain('set -eu');
|
|
// Idempotency guards: each mutation is conditioned on current state.
|
|
expect(src).toContain('[ ! -e /dev/fd ]'); // /dev/fd restore
|
|
expect(src).toContain('git config --global user.name >/dev/null 2>&1 ||'); // never clobber identity
|
|
expect(src).toContain("grep -q 'GSTACK sandbox test env'"); // bashrc seeded once
|
|
expect(src).toContain('if ! command -v Xvfb >/dev/null 2>&1'); // install only if absent, dnf-gated
|
|
expect(src).toContain('[ ! -e /tmp/.X11-unix/X99 ]'); // :99 socket check, not any-display pgrep
|
|
expect(src).toContain('[ "${shm_kb:-0}" -gt 0 ]'); // missing /dev/shm: skip, not a set -eu abort
|
|
});
|
|
});
|