mirror of
https://github.com/hacksider/Deep-Live-Cam.git
synced 2026-08-10 19:10:23 +02:00
Fix CUDA-graph replay race + many_faces enhancer regression
Two issues surfaced in post-squash review of f65aeae:
1. CUDA-graph replay buffers were shared across threads with no lock.
`_cuda_graph_swap_inference` mutates module-level ort_input/ort_latent
and runs run_with_iobinding — concurrent swap calls on Windows/CUDA
could overwrite each other's bound input buffers before replay,
producing wrong-face output. Added `_cuda_graph_lock` around the
full update/run/read sequence.
2. Face enhancer loop unconditionally broke after the first face, so
`many_faces=True` silently enhanced only one face. Also, the
single-slot temporal cache would paste the same enhancement onto
every target if reused in many-faces mode. Gated the break on
`not many_faces_mode` and disabled the cache path in that mode.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
co-authored by
Claude Opus 4.7
parent
f65aeae5db
commit
4d04e830bc
@@ -168,6 +168,10 @@ _cuda_graph_session = {
|
||||
'ort_latent': None,
|
||||
'recorded': False,
|
||||
}
|
||||
# Serializes CUDA-graph replay. The io_binding + ort_input/ort_latent are
|
||||
# shared across threads and run_with_iobinding mutates GPU-side buffers;
|
||||
# concurrent calls would produce wrong output.
|
||||
_cuda_graph_lock = threading.Lock()
|
||||
|
||||
|
||||
def _init_cuda_graph_session(model_path: str, swapper):
|
||||
@@ -232,10 +236,11 @@ def _init_cuda_graph_session(model_path: str, swapper):
|
||||
def _cuda_graph_swap_inference(blob: np.ndarray, latent: np.ndarray) -> np.ndarray:
|
||||
"""Run swap model via CUDA graph replay — minimal CPU overhead."""
|
||||
cg = _cuda_graph_session
|
||||
cg['ort_input'].update_inplace(blob)
|
||||
cg['ort_latent'].update_inplace(latent)
|
||||
cg['session'].run_with_iobinding(cg['io_binding'])
|
||||
return cg['io_binding'].get_outputs()[0].numpy()
|
||||
with _cuda_graph_lock:
|
||||
cg['ort_input'].update_inplace(blob)
|
||||
cg['ort_latent'].update_inplace(latent)
|
||||
cg['session'].run_with_iobinding(cg['io_binding'])
|
||||
return cg['io_binding'].get_outputs()[0].numpy()
|
||||
|
||||
|
||||
def _fast_paste_back(target_img: Frame, bgr_fake: np.ndarray, aimg: np.ndarray, M: np.ndarray) -> Frame:
|
||||
|
||||
Reference in New Issue
Block a user