From 007faeae6eebd2e7b371ef6e21b7e65da51f7d50 Mon Sep 17 00:00:00 2001
From: Bryan Housel <bryan@mapbox.com>
Date: Tue, 18 Dec 2018 11:31:30 -0500
Subject: [PATCH] Adjust fields, add couplings, simplify labels

---
 data/presets.yaml                             | 39 +++++-------
 data/presets/fields.json                      | 14 ++---
 data/presets/fields/couplings.json            |  7 +++
 .../presets/fields/fire_hydrant/diameter.json |  5 +-
 .../presets/fields/fire_hydrant/position.json | 13 ----
 .../presets/fields/fire_hydrant/pressure.json |  4 +-
 data/presets/fields/fire_hydrant/type.json    | 10 ++--
 data/presets/fields/survey/date.json          |  3 +-
 data/presets/fields/water_source.json         |  3 +-
 data/presets/fields/water_volume.json         |  3 +-
 data/presets/presets.json                     |  2 +-
 .../presets/emergency/fire_hydrant.json       | 14 ++---
 data/taginfo.json                             | 60 ++++---------------
 dist/locales/en.json                          | 35 +++++------
 14 files changed, 77 insertions(+), 135 deletions(-)
 create mode 100644 data/presets/fields/couplings.json
 delete mode 100644 data/presets/fields/fire_hydrant/position.json

diff --git a/data/presets.yaml b/data/presets.yaml
index d55ae922e..ab5770551 100644
--- a/data/presets.yaml
+++ b/data/presets.yaml
@@ -364,6 +364,11 @@ en:
       country:
         # country=*
         label: Country
+      couplings:
+        # couplings=*
+        label: Couplings
+        # couplings field placeholder
+        placeholder: '1, 2, 3...'
       covered:
         # covered=*
         label: Covered
@@ -600,34 +605,22 @@ en:
         label: Type
       fire_hydrant/diameter:
         # 'fire_hydrant:diameter=*'
-        label: 'Nominal diameter (in mm, inches or letters).'
-      fire_hydrant/position:
-        # 'fire_hydrant:position=*'
-        label: Position
-        options:
-          # 'fire_hydrant:position=green'
-          green: in a grassy area
-          # 'fire_hydrant:position=lane'
-          lane: on the side of a road lane
-          # 'fire_hydrant:position=parking_lot'
-          parking_lot: in a parking_lot
-          # 'fire_hydrant:position=sidewalk'
-          sidewalk: on a sidewalk
+        label: 'Diameter (mm, in, or letters)'
       fire_hydrant/pressure:
         # 'fire_hydrant:pressure=*'
-        label: Pressure in bar or suction
+        label: Pressure (bar)
       fire_hydrant/type:
         # 'fire_hydrant:type=*'
-        label: The shape of the hydrant.
+        label: Shape
         options:
           # 'fire_hydrant:type=pillar'
-          pillar: A pillar type hydrant.
+          pillar: Pillar/Aboveground
           # 'fire_hydrant:type=pipe'
-          pipe: 'A simple capped pipe, without the usual hydrant shape.'
+          pipe: Capped Pipe
           # 'fire_hydrant:type=underground'
-          underground: A fire hydrant simple outlet located underground.
+          underground: Underground
           # 'fire_hydrant:type=wall'
-          wall: A wall-mounted fire hydrant.
+          wall: Wall
       fireplace:
         # fireplace=*
         label: Fireplace
@@ -1799,7 +1792,7 @@ en:
         label: Surveillance Zone
       survey/date:
         # 'survey:date=*'
-        label: Date of last site survey (YYYY-MM-DD)
+        label: Last Survey Date
       swimming_pool:
         # swimming_pool=*
         label: Type
@@ -2031,10 +2024,10 @@ en:
         label: Water Point
       water_source:
         # water_source=*
-        label: Water source
+        label: Water Source
       water_volume:
         # water_volume=*
-        label: Volume of the water reserve. Tanks and pools only (default in m^3).
+        label: Water Reserve Volume (m³)
       waterway:
         # waterway=*
         label: Type
@@ -3658,7 +3651,7 @@ en:
       emergency/fire_hydrant:
         # emergency=fire_hydrant
         name: Fire Hydrant
-        # 'terms: fire plug,fire water well'
+        # 'terms: fire plug,fire water well,hydrant'
         terms: '<translate with synonyms or related terms for ''Fire Hydrant'', separated by commas>'
       emergency/first_aid_kit:
         # emergency=first_aid_kit
diff --git a/data/presets/fields.json b/data/presets/fields.json
index b37fa8fec..6c10c0cbf 100644
--- a/data/presets/fields.json
+++ b/data/presets/fields.json
@@ -63,6 +63,7 @@
     "content": {"key": "content", "type": "combo", "label": "Content", "options": ["silage", "water", "oil", "fuel", "slurry", "gas", "manure", "sewage"]},
     "conveying": {"key": "conveying", "type": "typeCombo", "label": "Movement Direction", "strings": {"options": {"forward": "Forward", "backward": "Backward", "reversible": "Reversible"}}},
     "country": {"key": "country", "type": "combo", "label": "Country"},
+    "couplings": {"key": "couplings", "type": "number", "minValue": 1, "label": "Couplings", "placeholder": "1, 2, 3..."},
     "covered": {"key": "covered", "type": "check", "label": "Covered"},
     "craft": {"key": "craft", "type": "typeCombo", "label": "Type"},
     "crane/type": {"key": "crane:type", "type": "combo", "label": "Crane Type", "strings": {"options": {"portal_crane": "Portal Crane", "floor-mounted_crane": "Floor-mounted Crane", "travel_lift": "Travel Lift"}}},
@@ -104,10 +105,9 @@
     "fax": {"key": "fax", "type": "tel", "label": "Fax", "universal": true, "placeholder": "+31 42 123 4567"},
     "fee": {"key": "fee", "type": "check", "label": "Fee"},
     "fence_type": {"key": "fence_type", "type": "combo", "label": "Type"},
-    "fire_hydrant/diameter": {"key": "fire_hydrant:diameter", "type": "text", "label": "Nominal diameter (in mm, inches or letters)."},
-    "fire_hydrant/position": {"key": "fire_hydrant:position", "type": "combo", "label": "Position", "strings": {"options": {"lane": "on the side of a road lane", "parking_lot": "in a parking_lot", "sidewalk": "on a sidewalk", "green": "in a grassy area"}}},
-    "fire_hydrant/pressure": {"key": "fire_hydrant:pressure", "type": "combo", "label": "Pressure in bar or suction", "options": ["#", "yes", "suction"]},
-    "fire_hydrant/type": {"key": "fire_hydrant:type", "type": "combo", "label": "The shape of the hydrant.", "strings": {"options": {"pillar": "A pillar type hydrant.", "underground": "A fire hydrant simple outlet located underground.", "wall": "A wall-mounted fire hydrant.", "pipe": "A simple capped pipe, without the usual hydrant shape."}}},
+    "fire_hydrant/diameter": {"key": "fire_hydrant:diameter", "type": "combo", "label": "Diameter (mm, in, or letters)", "snake_case": false},
+    "fire_hydrant/pressure": {"key": "fire_hydrant:pressure", "type": "combo", "label": "Pressure (bar)", "snake_case": false},
+    "fire_hydrant/type": {"key": "fire_hydrant:type", "type": "combo", "label": "Shape", "strings": {"options": {"pillar": "Pillar/Aboveground", "underground": "Underground", "wall": "Wall", "pipe": "Capped Pipe"}}},
     "fireplace": {"key": "fireplace", "type": "check", "label": "Fireplace"},
     "fitness_station": {"key": "fitness_station", "type": "typeCombo", "label": "Equipment Type"},
     "fixme": {"key": "fixme", "type": "textarea", "label": "Fix Me", "universal": true},
@@ -308,7 +308,7 @@
     "surveillance": {"key": "surveillance", "type": "combo", "label": "Surveillance Kind"},
     "surveillance/type": {"key": "surveillance:type", "type": "combo", "label": "Surveillance Type", "strings": {"options": {"camera": "Camera", "guard": "Guard", "ALPR": "Automatic License Plate Reader"}}},
     "surveillance/zone": {"key": "surveillance:zone", "type": "combo", "label": "Surveillance Zone"},
-    "survey/date": {"key": "survey:date", "type": "text", "universal": true, "label": "Date of last site survey (YYYY-MM-DD)"},
+    "survey/date": {"key": "survey:date", "type": "text", "label": "Last Survey Date"},
     "swimming_pool": {"key": "swimming_pool", "type": "combo", "label": "Type"},
     "switch": {"key": "switch", "type": "combo", "label": "Type", "strings": {"options": {"mechanical": "Mechanical", "circuit_breaker": "Circuit Breaker", "disconnector": "Disconnector", "earthing": "Earthing"}}},
     "tactile_paving": {"key": "tactile_paving", "type": "check", "label": "Tactile Paving"},
@@ -343,8 +343,8 @@
     "voltage/tertiary": {"key": "voltage:tertiary", "type": "combo", "label": "Tertiary Voltage"},
     "wall": {"key": "wall", "type": "combo", "label": "Type"},
     "water_point": {"key": "water_point", "type": "check", "label": "Water Point"},
-    "water_source": {"key": "water_source", "default": "main", "type": "combo", "label": "Water source", "options": ["main", "groundwater", "stream", "river", "canal", "drain", "ditch", "pond", "lake", "water_tank", "swimming_pool"]},
-    "water_volume": {"key": "water_volume", "type": "number", "label": "Volume of the water reserve. Tanks and pools only (default in m^3)."},
+    "water_source": {"key": "water_source", "default": "main", "type": "combo", "label": "Water Source"},
+    "water_volume": {"key": "water_volume", "type": "number", "label": "Water Reserve Volume (m³)", "snake_case": false},
     "water": {"key": "water", "type": "combo", "label": "Type"},
     "waterway": {"key": "waterway", "type": "typeCombo", "label": "Type"},
     "website": {"key": "website", "type": "url", "icon": "website", "placeholder": "http://example.com/", "universal": true, "label": "Website"},
diff --git a/data/presets/fields/couplings.json b/data/presets/fields/couplings.json
new file mode 100644
index 000000000..cf1ab7fc6
--- /dev/null
+++ b/data/presets/fields/couplings.json
@@ -0,0 +1,7 @@
+{
+    "key": "couplings",
+    "type": "number",
+    "minValue": 1,
+    "label": "Couplings",
+    "placeholder": "1, 2, 3..."
+}
diff --git a/data/presets/fields/fire_hydrant/diameter.json b/data/presets/fields/fire_hydrant/diameter.json
index 50ffc101e..4a2bc9010 100644
--- a/data/presets/fields/fire_hydrant/diameter.json
+++ b/data/presets/fields/fire_hydrant/diameter.json
@@ -1,5 +1,6 @@
 {
     "key": "fire_hydrant:diameter",
-    "type": "text",
-    "label": "Nominal diameter (in mm, inches or letters)."
+    "type": "combo",
+    "label": "Diameter (mm, in, or letters)",
+    "snake_case": false
 }
diff --git a/data/presets/fields/fire_hydrant/position.json b/data/presets/fields/fire_hydrant/position.json
deleted file mode 100644
index 6c0e3406b..000000000
--- a/data/presets/fields/fire_hydrant/position.json
+++ /dev/null
@@ -1,13 +0,0 @@
-{
-    "key": "fire_hydrant:position",
-    "type": "combo",
-    "label": "Position",
-    "strings": {
-        "options": {
-            "lane": "on the side of a road lane",
-            "parking_lot": "in a parking_lot",
-            "sidewalk": "on a sidewalk",
-            "green": "in a grassy area"
-        }
-    }
-}
diff --git a/data/presets/fields/fire_hydrant/pressure.json b/data/presets/fields/fire_hydrant/pressure.json
index 78a4b50b6..2c6b0354e 100644
--- a/data/presets/fields/fire_hydrant/pressure.json
+++ b/data/presets/fields/fire_hydrant/pressure.json
@@ -1,6 +1,6 @@
 {
     "key": "fire_hydrant:pressure",
     "type": "combo",
-    "label": "Pressure in bar or suction",
-    "options": [ "#", "yes", "suction" ]
+    "label": "Pressure (bar)",
+    "snake_case": false
 }
diff --git a/data/presets/fields/fire_hydrant/type.json b/data/presets/fields/fire_hydrant/type.json
index 0e3dbae1a..9e787ab12 100644
--- a/data/presets/fields/fire_hydrant/type.json
+++ b/data/presets/fields/fire_hydrant/type.json
@@ -1,13 +1,13 @@
 {
     "key": "fire_hydrant:type",
     "type": "combo",
-    "label": "The shape of the hydrant.",
+    "label": "Shape",
     "strings": {
         "options": {
-            "pillar": "A pillar type hydrant.",
-            "underground": "A fire hydrant simple outlet located underground.",
-            "wall": "A wall-mounted fire hydrant.",
-            "pipe": "A simple capped pipe, without the usual hydrant shape."
+            "pillar": "Pillar/Aboveground",
+            "underground": "Underground",
+            "wall": "Wall",
+            "pipe": "Capped Pipe"
         }
     }
 }
diff --git a/data/presets/fields/survey/date.json b/data/presets/fields/survey/date.json
index 58873b995..e29075eba 100644
--- a/data/presets/fields/survey/date.json
+++ b/data/presets/fields/survey/date.json
@@ -1,6 +1,5 @@
 {
     "key": "survey:date",
     "type": "text",
-    "universal": true,
-    "label": "Date of last site survey (YYYY-MM-DD)"
+    "label": "Last Survey Date"
 }
diff --git a/data/presets/fields/water_source.json b/data/presets/fields/water_source.json
index 91ab2ab97..4768b899d 100644
--- a/data/presets/fields/water_source.json
+++ b/data/presets/fields/water_source.json
@@ -2,6 +2,5 @@
     "key": "water_source",
     "default": "main",
     "type": "combo",
-    "label": "Water source",
-    "options": [ "main", "groundwater", "stream", "river", "canal", "drain", "ditch", "pond", "lake", "water_tank", "swimming_pool" ]
+    "label": "Water Source"
 }
diff --git a/data/presets/fields/water_volume.json b/data/presets/fields/water_volume.json
index 5d5f51bc5..5d5814330 100644
--- a/data/presets/fields/water_volume.json
+++ b/data/presets/fields/water_volume.json
@@ -1,5 +1,6 @@
 {
     "key": "water_volume",
     "type": "number",
-    "label": "Volume of the water reserve. Tanks and pools only (default in m^3)."
+    "label": "Water Reserve Volume (m³)",
+    "snake_case": false
 }
diff --git a/data/presets/presets.json b/data/presets/presets.json
index 9ce393108..4fd66887b 100644
--- a/data/presets/presets.json
+++ b/data/presets/presets.json
@@ -361,7 +361,7 @@
     "emergency/defibrillator": {"icon": "maki-defibrillator", "fields": ["indoor", "ref", "operator"], "geometry": ["point", "vertex"], "terms": ["AED"], "tags": {"emergency": "defibrillator"}, "name": "Defibrillator"},
     "emergency/fire_alarm": {"icon": "fas-bell", "fields": ["indoor", "ref", "operator"], "geometry": ["point", "vertex"], "tags": {"emergency": "fire_alarm_box"}, "name": "Fire Alarm Call Box"},
     "emergency/fire_extinguisher": {"icon": "fas-fire-extinguisher", "fields": ["indoor", "ref", "operator"], "geometry": ["point", "vertex"], "tags": {"emergency": "fire_extinguisher"}, "name": "Fire Extinguisher"},
-    "emergency/fire_hydrant": {"icon": "temaki-fire_hydrant", "fields": ["fire_hydrant/type", "fire_hydrant/pressure", "fire_hydrant/diameter", "water_source", "survey/date", "fire_hydrant/position", "water_volume", "colour", "ref", "name"], "geometry": ["point", "vertex"], "terms": ["fire plug", "fire water well"], "tags": {"emergency": "fire_hydrant"}, "name": "Fire Hydrant"},
+    "emergency/fire_hydrant": {"icon": "temaki-fire_hydrant", "fields": ["ref", "fire_hydrant/type", "colour", "water_source", "fire_hydrant/pressure", "fire_hydrant/diameter", "couplings", "water_volume", "survey/date"], "geometry": ["point", "vertex"], "terms": ["fire plug", "fire water well", "hydrant"], "tags": {"emergency": "fire_hydrant"}, "name": "Fire Hydrant"},
     "emergency/first_aid_kit": {"icon": "fas-medkit", "fields": ["indoor", "ref", "operator"], "geometry": ["point", "vertex"], "terms": ["bandage", "first aid", "med", "med kit", "medic*", "medkit"], "tags": {"emergency": "first_aid_kit"}, "name": "First Aid Kit"},
     "emergency/life_ring": {"icon": "fas-life-ring", "fields": ["ref", "operator"], "geometry": ["point", "vertex"], "terms": ["life buoy", "kisby ring", "kisbie ring", "perry buoy"], "tags": {"emergency": "life_ring"}, "name": "Life Ring"},
     "emergency/lifeguard": {"icon": "fas-life-ring", "fields": ["ref", "operator", "building_area", "opening_hours"], "geometry": ["point", "area"], "terms": ["CPR", "rescue"], "tags": {"emergency": "lifeguard"}, "name": "Lifeguard"},
diff --git a/data/presets/presets/emergency/fire_hydrant.json b/data/presets/presets/emergency/fire_hydrant.json
index 745791474..484713a2e 100644
--- a/data/presets/presets/emergency/fire_hydrant.json
+++ b/data/presets/presets/emergency/fire_hydrant.json
@@ -1,16 +1,15 @@
 {
     "icon": "temaki-fire_hydrant",
     "fields": [
+        "ref",
         "fire_hydrant/type",
+        "colour",
+        "water_source",
         "fire_hydrant/pressure",
         "fire_hydrant/diameter",
-        "water_source",
-        "survey/date",
-        "fire_hydrant/position",
+        "couplings",
         "water_volume",
-        "colour",
-        "ref",
-        "name"             
+        "survey/date"
     ],
     "geometry": [
         "point",
@@ -18,7 +17,8 @@
     ],
     "terms": [
         "fire plug",
-        "fire water well"
+        "fire water well",
+        "hydrant"
     ],
     "tags": {
         "emergency": "fire_hydrant"
diff --git a/data/taginfo.json b/data/taginfo.json
index e93aa7abd..5e9d3173c 100644
--- a/data/taginfo.json
+++ b/data/taginfo.json
@@ -7096,6 +7096,7 @@
       "description": "🄵 Movement Direction"
     },
     {"key": "country", "description": "🄵 Country"},
+    {"key": "couplings", "description": "🄵 Couplings"},
     {"key": "covered", "description": "🄵 Covered"},
     {
       "key": "crane:type",
@@ -7229,52 +7230,17 @@
     {"key": "fence_type", "description": "🄵 Type"},
     {
       "key": "fire_hydrant:diameter",
-      "description": "🄵 Nominal diameter (in mm, inches or letters)."
-    },
-    {
-      "key": "fire_hydrant:position",
-      "value": "lane",
-      "description": "🄵 Position"
-    },
-    {
-      "key": "fire_hydrant:position",
-      "value": "parking_lot",
-      "description": "🄵 Position"
-    },
-    {
-      "key": "fire_hydrant:position",
-      "value": "sidewalk",
-      "description": "🄵 Position"
-    },
-    {
-      "key": "fire_hydrant:position",
-      "value": "green",
-      "description": "🄵 Position"
-    },
-    {
-      "key": "fire_hydrant:pressure",
-      "description": "🄵 Pressure in bar or suction"
-    },
-    {
-      "key": "fire_hydrant:type",
-      "value": "pillar",
-      "description": "🄵 The shape of the hydrant."
+      "description": "🄵 Diameter (mm, in, or letters)"
     },
+    {"key": "fire_hydrant:pressure", "description": "🄵 Pressure (bar)"},
+    {"key": "fire_hydrant:type", "value": "pillar", "description": "🄵 Shape"},
     {
       "key": "fire_hydrant:type",
       "value": "underground",
-      "description": "🄵 The shape of the hydrant."
-    },
-    {
-      "key": "fire_hydrant:type",
-      "value": "wall",
-      "description": "🄵 The shape of the hydrant."
-    },
-    {
-      "key": "fire_hydrant:type",
-      "value": "pipe",
-      "description": "🄵 The shape of the hydrant."
+      "description": "🄵 Shape"
     },
+    {"key": "fire_hydrant:type", "value": "wall", "description": "🄵 Shape"},
+    {"key": "fire_hydrant:type", "value": "pipe", "description": "🄵 Shape"},
     {"key": "fireplace", "description": "🄵 Fireplace"},
     {"key": "fitness_station", "description": "🄵 Equipment Type"},
     {"key": "fixme", "description": "🄵 Fix Me"},
@@ -7943,10 +7909,7 @@
       "description": "🄵 Surveillance Type"
     },
     {"key": "surveillance:zone", "description": "🄵 Surveillance Zone"},
-    {
-      "key": "survey:date",
-      "description": "🄵 Date of last site survey (YYYY-MM-DD)"
-    },
+    {"key": "survey:date", "description": "🄵 Last Survey Date"},
     {"key": "swimming_pool", "description": "🄵 Type"},
     {"key": "switch", "value": "mechanical", "description": "🄵 Type"},
     {"key": "switch", "value": "circuit_breaker", "description": "🄵 Type"},
@@ -8104,11 +8067,8 @@
     {"key": "voltage:tertiary", "description": "🄵 Tertiary Voltage"},
     {"key": "wall", "description": "🄵 Type"},
     {"key": "water_point", "description": "🄵 Water Point"},
-    {"key": "water_source", "description": "🄵 Water source"},
-    {
-      "key": "water_volume",
-      "description": "🄵 Volume of the water reserve. Tanks and pools only (default in m^3)."
-    },
+    {"key": "water_source", "description": "🄵 Water Source"},
+    {"key": "water_volume", "description": "🄵 Water Reserve Volume (m³)"},
     {"key": "water", "description": "🄵 Type"},
     {"key": "website", "description": "🄵 Website"},
     {"key": "wetland", "description": "🄵 Type"},
diff --git a/dist/locales/en.json b/dist/locales/en.json
index 72393f9a4..80e1e7aba 100644
--- a/dist/locales/en.json
+++ b/dist/locales/en.json
@@ -1798,6 +1798,10 @@
                 "country": {
                     "label": "Country"
                 },
+                "couplings": {
+                    "label": "Couplings",
+                    "placeholder": "1, 2, 3..."
+                },
                 "covered": {
                     "label": "Covered"
                 },
@@ -2003,27 +2007,18 @@
                     "label": "Type"
                 },
                 "fire_hydrant/diameter": {
-                    "label": "Nominal diameter (in mm, inches or letters)."
-                },
-                "fire_hydrant/position": {
-                    "label": "Position",
-                    "options": {
-                        "lane": "on the side of a road lane",
-                        "parking_lot": "in a parking_lot",
-                        "sidewalk": "on a sidewalk",
-                        "green": "in a grassy area"
-                    }
+                    "label": "Diameter (mm, in, or letters)"
                 },
                 "fire_hydrant/pressure": {
-                    "label": "Pressure in bar or suction"
+                    "label": "Pressure (bar)"
                 },
                 "fire_hydrant/type": {
-                    "label": "The shape of the hydrant.",
+                    "label": "Shape",
                     "options": {
-                        "pillar": "A pillar type hydrant.",
-                        "underground": "A fire hydrant simple outlet located underground.",
-                        "wall": "A wall-mounted fire hydrant.",
-                        "pipe": "A simple capped pipe, without the usual hydrant shape."
+                        "pillar": "Pillar/Aboveground",
+                        "underground": "Underground",
+                        "wall": "Wall",
+                        "pipe": "Capped Pipe"
                     }
                 },
                 "fireplace": {
@@ -2984,7 +2979,7 @@
                     "label": "Surveillance Zone"
                 },
                 "survey/date": {
-                    "label": "Date of last site survey (YYYY-MM-DD)"
+                    "label": "Last Survey Date"
                 },
                 "swimming_pool": {
                     "label": "Type"
@@ -3169,10 +3164,10 @@
                     "label": "Water Point"
                 },
                 "water_source": {
-                    "label": "Water source"
+                    "label": "Water Source"
                 },
                 "water_volume": {
-                    "label": "Volume of the water reserve. Tanks and pools only (default in m^3)."
+                    "label": "Water Reserve Volume (m³)"
                 },
                 "water": {
                     "label": "Type"
@@ -4666,7 +4661,7 @@
                 },
                 "emergency/fire_hydrant": {
                     "name": "Fire Hydrant",
-                    "terms": "fire plug,fire water well"
+                    "terms": "fire plug,fire water well,hydrant"
                 },
                 "emergency/first_aid_kit": {
                     "name": "First Aid Kit",