From 0085c41876095652184df4267505ddea62e83cdb Mon Sep 17 00:00:00 2001
From: Bryan Housel <bhousel@gmail.com>
Date: Mon, 2 Aug 2021 17:15:25 -0400
Subject: [PATCH] Store whether a result is provisional before filtering it

Filtering returns a new array, which was clobbering the "provisional" flag.
This was causing provisionally results to not be reprocessed later,
which meant that certain "outdated_tags" results would not be in the baseCache.
(cache of issues _before_ user edits).
---
 modules/core/validator.js | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/modules/core/validator.js b/modules/core/validator.js
index 15e059dbb..4f328fd1b 100644
--- a/modules/core/validator.js
+++ b/modules/core/validator.js
@@ -547,10 +547,11 @@ export function coreValidator(context) {
         return;
       }
 
-      const detected = fn(entity, graph).filter(applySeverityOverrides);
+      let detected = fn(entity, graph);
       if (detected.provisional) {  // this validation should be run again later
         result.provisional = true;
       }
+      detected = detected.filter(applySeverityOverrides);
       result.issues = result.issues.concat(detected);
     }