From 01e2370cbd57b55b3383682a2a173824fc3b01e9 Mon Sep 17 00:00:00 2001
From: Quincy Morgan <quincy.morgan@icloud.com>
Date: Thu, 24 Jan 2019 08:37:46 -0500
Subject: [PATCH] Add background color to the issue pane list

---
 css/80_app.css                          | 64 ++++++++++++++-----------
 modules/ui/issues.js                    |  3 +-
 modules/validations/validation_issue.js |  2 +-
 3 files changed, 38 insertions(+), 31 deletions(-)

diff --git a/css/80_app.css b/css/80_app.css
index 6e36b0ab1..6a8e8f831 100644
--- a/css/80_app.css
+++ b/css/80_app.css
@@ -2906,17 +2906,29 @@ div.full-screen > button:hover {
     padding-bottom: 10px;
 }
 
-/* Issues List */
-.issues-list label {
+/* Issues */
+
+.issue {
+    overflow: hidden;
+}
+.issue button {
     padding: 5px;
-}
-.issues-list label > span {
-    display: inline;
-    white-space: normal;
-}
-.issues-list li {
     height: auto;
-    color: inherit;
+    width: 100%;
+    font-weight: inherit;
+    border-radius: 0;
+}
+.issue button.label {
+    text-align: inherit;
+    display: flex;
+}
+.issue.severity-warning,
+.issue.severity-warning li {
+    border-color: #FFDF5C;
+}
+.issue.severity-error,
+.issue.severity-error li {
+    border-color: #f5b0ab;
 }
 
 .issue.severity-warning button {
@@ -2941,6 +2953,20 @@ div.full-screen > button:hover {
     color: #DD1400
 }
 
+/* Issues Pane List */
+
+.issues-list label {
+    padding: 5px;
+}
+.issues-list label > span {
+    display: inline;
+    white-space: normal;
+}
+.issues-list li {
+    height: auto;
+    color: inherit;
+}
+
 /* Entity Issues List */
 
 .entity-issues {
@@ -2950,26 +2976,6 @@ div.full-screen > button:hover {
     border-radius: 4px;
     border-width: 1px;
     border-style: solid;
-    overflow: hidden;
-}
-.entity-issues .issue button {
-    padding: 5px;
-    height: auto;
-    width: 100%;
-    font-weight: inherit;
-    border-radius: 0;
-}
-.entity-issues .issue button.label {
-    text-align: inherit;
-    display: flex;
-}
-.entity-issues .issue.severity-warning,
-.entity-issues .issue.severity-warning li {
-    border-color: #FFDF5C;
-}
-.entity-issues .issue.severity-error,
-.entity-issues .issue.severity-error li {
-    border-color: #f5b0ab;
 }
 .entity-issues .issue:first-of-type {
     margin-top: 5px;
diff --git a/modules/ui/issues.js b/modules/ui/issues.js
index f4401fd34..b4baa1078 100644
--- a/modules/ui/issues.js
+++ b/modules/ui/issues.js
@@ -140,7 +140,8 @@ export function uiIssues(context) {
             });
 
         var label = enter
-            .append('label');
+            .append('button')
+            .attr('class', 'label');
 
         label.each(function(d) {
             var iconSuffix = d.severity === 'warning' ? 'alert' : 'error';
diff --git a/modules/validations/validation_issue.js b/modules/validations/validation_issue.js
index 85c5b063c..ab5ab076f 100644
--- a/modules/validations/validation_issue.js
+++ b/modules/validations/validation_issue.js
@@ -30,7 +30,7 @@ export function validationIssue(attrs) {
         var entityKeys = _map(this.entities, function(entity) {
             return osmEntity.key(entity);
         });
-        return this.type + entityKeys.join();
+        return this.message + this.type + entityKeys.join();
     };
 
     if (!_isObject(attrs)) throw new Error('Input attrs is not an object');