From 0a71fd1e4f394388cd504f5fb0b0a6f5964c9b21 Mon Sep 17 00:00:00 2001
From: Quincy Morgan <quincy.morgan@icloud.com>
Date: Thu, 2 May 2019 12:18:21 -0700
Subject: [PATCH] Fix false positive for impossible oneway when connected way
 is circular

---
 modules/validations/impossible_oneway.js | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/modules/validations/impossible_oneway.js b/modules/validations/impossible_oneway.js
index 2abd4cc70..03443803e 100644
--- a/modules/validations/impossible_oneway.js
+++ b/modules/validations/impossible_oneway.js
@@ -85,7 +85,9 @@ export function validationImpossibleOneway() {
 
         if (attachedOneways.length) {
             var connectedEndpointsOkay = attachedOneways.some(function(attachedOneway) {
-                return (isFirst ? attachedOneway.first() : attachedOneway.last()) !== nodeID;
+                if ((isFirst ? attachedOneway.first() : attachedOneway.last()) !== nodeID) return true;
+                if (nodeOccursMoreThanOnce(attachedOneway, nodeID)) return true;
+                return false;
             });
             if (connectedEndpointsOkay) return [];
         }