From 0a7f05b4a5fda93be10478d0860cd08673b28e3c Mon Sep 17 00:00:00 2001 From: Quincy Morgan Date: Thu, 21 May 2020 13:35:50 -0400 Subject: [PATCH] Fix console error with dragging midpoints --- modules/behavior/drag.js | 28 ++++++++++++++++------------ 1 file changed, 16 insertions(+), 12 deletions(-) diff --git a/modules/behavior/drag.js b/modules/behavior/drag.js index 86eb4d27f..12435b3d7 100644 --- a/modules/behavior/drag.js +++ b/modules/behavior/drag.js @@ -108,19 +108,23 @@ export function behaviorDrag() { started = true; _event({ type: 'start' }); + + // Don't send a `move` event in the same cycle as `start` since dragging + // a midpoint will convert the target to a node. + } else { + + startOrigin = p; + d3_event.stopPropagation(); + d3_event.preventDefault(); + + var dx = p[0] - startOrigin[0]; + var dy = p[1] - startOrigin[1]; + _event({ + type: 'move', + point: [p[0] + offset[0], p[1] + offset[1]], + delta: [dx, dy] + }); } - - startOrigin = p; - d3_event.stopPropagation(); - d3_event.preventDefault(); - - var dx = p[0] - startOrigin[0]; - var dy = p[1] - startOrigin[1]; - _event({ - type: 'move', - point: [p[0] + offset[0], p[1] + offset[1]], - delta: [dx, dy] - }); }