From 0aa3ce2cee5090ecb31c955bec1d0978be610525 Mon Sep 17 00:00:00 2001 From: Quincy Morgan Date: Tue, 5 Feb 2019 16:57:34 -0500 Subject: [PATCH] Fix issue with Issues section appearance if the sidebar was loaded with the section closed --- modules/ui/entity_issues.js | 28 ++++++++++++++-------------- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/modules/ui/entity_issues.js b/modules/ui/entity_issues.js index 5ddb40406..5d61f0ffc 100644 --- a/modules/ui/entity_issues.js +++ b/modules/ui/entity_issues.js @@ -16,35 +16,35 @@ export function uiEntityIssues(context) { var dispatch = d3_dispatch('change'); var _entityID; - context.validator().on('reload.entity_issues', update); + context.validator().on('reload.entity_issues', issuesDidReload); - function update() { + function issuesDidReload() { var selection = d3_select('.entity-issues .disclosure-wrap'); - render(selection); + renderContent(selection); + update(); } function entityIssues(selection) { selection.call(uiDisclosure(context, 'entity_issues', true) - .content(render) + .content(renderContent) ); + update(); } - - function render(selection) { + function update() { var issues = context.validator().getIssuesForEntityWithID(_entityID); - if (issues.length > 0) { - d3_select('.entity-issues') - .style('display', 'block'); - } else { - d3_select('.entity-issues') - .style('display', 'none'); - return; - } + d3_select('.entity-issues') + .classed('hide', issues.length === 0); d3_select('.hide-toggle-entity_issues span') .text(t('issues.list_title', { count: issues.length })); + } + + function renderContent(selection) { + + var issues = context.validator().getIssuesForEntityWithID(_entityID); var items = selection.selectAll('.issue') .data(issues, function(d) {