CalvinBackup/iD
1
0
Fork 0
mirror of https://github.com/FoggedLens/iD.git synced 2026-06-04 05:58:09 +02:00
Code Issues Packages Projects Releases Wiki Activity

Fix bug where highlight would not appear on the first target node when continuing drawing a way

Browse Source
This commit is contained in:
Quincy Morgan
2019-02-15 11:56:31 -05:00
parent 96a1ec92c7
commit 0b86be7bcb
3 changed files with 28 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files
modules/behavior/hover.js
+17 -5
View File
@@ -20,7 +20,8 @@ import { utilKeybinding, utilRebind } from '../util';
export function behaviorHover(context) {
var dispatch = d3_dispatch('hover');
var _selection = d3_select(null);
var _newId = null;
var _newNodeId = null;
var _initialNodeId = null;
var _buttonDown;
var _altDisables;
var _ignoreVertex;
@@ -57,7 +58,13 @@ export function behaviorHover(context) {
function behavior(selection) {
_selection = selection;
_newId = null;
if (_initialNodeId) {
_newNodeId = _initialNodeId;
_initialNodeId = null;
} else {
_newNodeId = null;
}
_selection
.on('mouseover.hover', mouseover)
@@ -134,11 +141,11 @@ export function behaviorHover(context) {
}
// Update hover state and dispatch event
if (entity && entity.id !== _newId) {
if (entity && entity.id !== _newNodeId) {
// If drawing a way, don't hover on a node that was just placed. #3974
var mode = context.mode() && context.mode().id;
if ((mode === 'draw-line' || mode === 'draw-area') && !_newId && entity.type === 'node') {
_newId = entity.id;
if ((mode === 'draw-line' || mode === 'draw-area') && !_newNodeId && entity.type === 'node') {
_newNodeId = entity.id;
return;
}
@@ -187,5 +194,10 @@ export function behaviorHover(context) {
return behavior;
};
behavior.initialNodeId = function(nodeId) {
_initialNodeId = nodeId;
return behavior;
};
return utilRebind(behavior, dispatch, 'on');
}