diff --git a/data/core.yaml b/data/core.yaml index 207073044..216531433 100644 --- a/data/core.yaml +++ b/data/core.yaml @@ -1464,6 +1464,7 @@ en: reference: "Some features should have additional tags." noncanonical_brand: message: "{feature} looks like a brand with nonstandard tags" + message_incomplete: "{feature} looks like a brand with incomplete tags" reference: "All features of the same brand should be tagged the same way." point_as_vertex: message: '{feature} should be a standalone point based on its tags' diff --git a/dist/locales/en.json b/dist/locales/en.json index 5bcfa09fe..8a4788cda 100644 --- a/dist/locales/en.json +++ b/dist/locales/en.json @@ -1813,6 +1813,7 @@ }, "noncanonical_brand": { "message": "{feature} looks like a brand with nonstandard tags", + "message_incomplete": "{feature} looks like a brand with incomplete tags", "reference": "All features of the same brand should be tagged the same way." } }, diff --git a/modules/validations/outdated_tags.js b/modules/validations/outdated_tags.js index aed803451..000484e93 100644 --- a/modules/validations/outdated_tags.js +++ b/modules/validations/outdated_tags.js @@ -173,7 +173,15 @@ export function validationOutdatedTags(context) { var currEntity = context.hasEntity(entity.id); if (!currEntity) return ''; - return t('issues.outdated_tags.' + prefix + 'message', + var messageID = 'issues.outdated_tags.' + prefix + 'message'; + + if (subtype === 'noncanonical_brand' && tagDiff.every(function(d) { + return d.type === '+'; + })) { + messageID += '_incomplete'; + } + + return t(messageID, { feature: utilDisplayLabel(currEntity, context) } ); }