CalvinBackup/iD
1
0
Fork 0
mirror of https://github.com/FoggedLens/iD.git synced 2026-05-22 16:19:48 +02:00
Code Issues Packages Projects Releases Wiki Activity

Don't dispatch 'change' on history.merged, dispatch 'merge' only

Browse Source 
Change performs an expensive immediate redraw, and merge can schedule
a redraw for later.
This commit is contained in:
Bryan Housel
2019-04-12 09:56:18 -04:00
parent 2b050549eb
commit 0dd262d1dd
3 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
test/spec/core/history.js
+5 -5
View File
@@ -28,11 +28,11 @@ describe('iD.coreHistory', function () {
expect(history.graph().entity('n')).to.equal(n);
});
it('emits a change event with the specified extent', function () {
var extent = {};
history.on('change', spy);
history.merge([], extent);
expect(spy).to.have.been.calledWith(undefined, extent);
it('emits a merge event with the new entities', function () {
var n = iD.osmNode({id: 'n'});
history.on('merge', spy);
history.merge([n]);
expect(spy).to.have.been.calledWith([n]);
});
});