From 10d9f05739f72b15a8d7eaca932245f8903e7e5c Mon Sep 17 00:00:00 2001 From: Quincy Morgan Date: Mon, 18 Feb 2019 12:17:52 -0500 Subject: [PATCH] Show the actual deprecated tag value in the issue message rather than the * placeholder --- modules/validations/deprecated_tag.js | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/modules/validations/deprecated_tag.js b/modules/validations/deprecated_tag.js index 8452b32a5..818cd0b4a 100644 --- a/modules/validations/deprecated_tag.js +++ b/modules/validations/deprecated_tag.js @@ -15,7 +15,14 @@ export function validationDeprecatedTag() { if (deprecatedTagsArray.length > 0) { for (var deprecatedTagIndex in deprecatedTagsArray) { var deprecatedTags = deprecatedTagsArray[deprecatedTagIndex]; - var tagsLabel = utilTagText({ tags: deprecatedTags.old }); + var labelTags = _clone(deprecatedTags.old); + for (var key in labelTags) { + if (labelTags[key] === '*') { + // show the user the actual tag, like color=red instead of color=* + labelTags[key] = entity.tags[key]; + } + } + var tagsLabel = utilTagText({ tags: labelTags }); var featureLabel = utilDisplayLabel(entity, context); var isCombo = Object.keys(deprecatedTags.old).length > 1; var messageObj = { feature: featureLabel };