From 12d770a05e048445c8148a871dafed181e6a33f7 Mon Sep 17 00:00:00 2001
From: Quincy Morgan <quincy.morgan@icloud.com>
Date: Tue, 26 Feb 2019 11:00:00 -0500
Subject: [PATCH] Add unit tests for missing role validation

---
 test/index.html                       |   1 +
 test/spec/validations/missing_role.js | 100 ++++++++++++++++++++++++++
 2 files changed, 101 insertions(+)
 create mode 100644 test/spec/validations/missing_role.js

diff --git a/test/index.html b/test/index.html
index 8ac0e0974..62bca52a5 100644
--- a/test/index.html
+++ b/test/index.html
@@ -148,6 +148,7 @@
     <script src='spec/validations/validator.js'></script>
     <script src='spec/validations/deprecated_tag.js'></script>
     <script src='spec/validations/missing_tag.js'></script>
+    <script src='spec/validations/missing_role.js'></script>
     <script src='spec/validations/disconnected_way.js'></script>
     <script src='spec/validations/tag_suggests_area.js'></script>
     <script src='spec/validations/crossing_ways.js'></script>
diff --git a/test/spec/validations/missing_role.js b/test/spec/validations/missing_role.js
new file mode 100644
index 000000000..78a577884
--- /dev/null
+++ b/test/spec/validations/missing_role.js
@@ -0,0 +1,100 @@
+describe('iD.validations.missing_role', function () {
+    var context;
+
+    beforeEach(function() {
+        context = iD.coreContext();
+    });
+
+    function createWay(tags) {
+        var n1 = iD.osmNode({id: 'n-1', loc: [4,4]});
+        var n2 = iD.osmNode({id: 'n-2', loc: [4,5]});
+        var w = iD.osmWay({id: 'w-1', nodes: ['n-1', 'n-2'], tags: tags});
+
+        context.perform(
+            iD.actionAddEntity(n1),
+            iD.actionAddEntity(n2),
+            iD.actionAddEntity(w)
+        );
+    }
+
+    function createRelation(tags, role) {
+        var n1 = iD.osmNode({id: 'n-1', loc: [4,4]});
+        var n2 = iD.osmNode({id: 'n-2', loc: [4,5]});
+        var n3 = iD.osmNode({id: 'n-3', loc: [5,5]});
+        var w = iD.osmWay({id: 'w-1', nodes: ['n-1', 'n-2', 'n-3', 'n-1']});
+        var r = iD.osmRelation({id: 'r-1', members: [{id: 'w-1', role: role}], tags: tags});
+
+        context.perform(
+            iD.actionAddEntity(n1),
+            iD.actionAddEntity(n2),
+            iD.actionAddEntity(n3),
+            iD.actionAddEntity(w),
+            iD.actionAddEntity(r)
+        );
+    }
+
+    function validate() {
+        var validator = iD.validationMissingRole();
+        var changes = context.history().changes();
+        var entities = changes.modified.concat(changes.created);
+        var issues = [];
+        entities.forEach(function(entity) {
+            issues = issues.concat(validator(entity, context));
+        });
+        return issues;
+    }
+
+    it('has no errors on init', function() {
+        var issues = validate();
+        expect(issues).to.have.lengthOf(0);
+    });
+
+    it('ignores way with no relations', function() {
+        createWay({});
+        var issues = validate();
+        expect(issues).to.have.lengthOf(0);
+    });
+
+    it('ignores way with null role in non-multipolygon relation', function() {
+        createRelation({ type: 'boundary' }, null);
+        var issues = validate();
+        expect(issues).to.have.lengthOf(0);
+    });
+
+    it('ignores way with outer role in multipolygon', function() {
+        createRelation({ type: 'multipolygon' }, 'outer');
+        var issues = validate();
+        expect(issues).to.have.lengthOf(0);
+    });
+
+    it('ignores way with inner role in multipolygon', function() {
+        createRelation({ type: 'multipolygon' }, 'inner');
+        var issues = validate();
+        expect(issues).to.have.lengthOf(0);
+    });
+
+    it('flags way with null role in multipolygon', function() {
+        createRelation({ type: 'multipolygon' }, null);
+        var issues = validate();
+        expect(issues).to.have.lengthOf(2);
+        expect(issues[0].id()).to.eql(issues[1].id());
+        var issue = issues[0];
+        expect(issue.type).to.eql('missing_role');
+        expect(issue.entities).to.have.lengthOf(2);
+        expect(issue.entities[0].id).to.eql('r-1');
+        expect(issue.entities[1].id).to.eql('w-1');
+    });
+
+    it('flags way with whitespace string role in multipolygon', function() {
+        createRelation({ type: 'multipolygon' }, '   ');
+        var issues = validate();
+        expect(issues).to.have.lengthOf(2);
+        expect(issues[0].id()).to.eql(issues[1].id());
+        var issue = issues[0];
+        expect(issue.type).to.eql('missing_role');
+        expect(issue.entities).to.have.lengthOf(2);
+        expect(issue.entities[0].id).to.eql('r-1');
+        expect(issue.entities[1].id).to.eql('w-1');
+    });
+
+});