From 154c6ed0ed8a587352d74e9afdf36a3aea2f7367 Mon Sep 17 00:00:00 2001
From: Quincy Morgan <2046746+quincylvania@users.noreply.github.com>
Date: Tue, 27 Oct 2020 09:56:05 -0400
Subject: [PATCH] Fix issue where clicking some buttons would clear the URL
 hash

---
 modules/ui/fields/check.js                        | 1 -
 modules/ui/sections/background_display_options.js | 3 ++-
 modules/ui/sections/map_features.js               | 6 ++++--
 modules/ui/sections/validation_rules.js           | 6 ++++--
 modules/ui/sections/validation_status.js          | 3 ++-
 5 files changed, 12 insertions(+), 7 deletions(-)

diff --git a/modules/ui/fields/check.js b/modules/ui/fields/check.js
index cd247debe..34ace9af9 100644
--- a/modules/ui/fields/check.js
+++ b/modules/ui/fields/check.js
@@ -114,7 +114,6 @@ export function uiFieldCheck(field, context) {
             enter
                 .append('button')
                 .attr('class', 'reverser' + (reverserHidden() ? ' hide' : ''))
-                .attr('href', '#')
                 .append('span')
                 .attr('class', 'reverser-span');
         }
diff --git a/modules/ui/sections/background_display_options.js b/modules/ui/sections/background_display_options.js
index f62871fb7..2e3a44714 100644
--- a/modules/ui/sections/background_display_options.js
+++ b/modules/ui/sections/background_display_options.js
@@ -104,7 +104,8 @@ export function uiSectionBackgroundDisplayOptions(context) {
             .attr('class', 'display-option-resetlink')
             .attr('href', '#')
             .html(t.html('background.reset_all'))
-            .on('click', function() {
+            .on('click', function(d3_event) {
+                d3_event.preventDefault();
                 for (var i = 0; i < _sliders.length; i++) {
                     updateValue(_sliders[i], 1);
                 }
diff --git a/modules/ui/sections/map_features.js b/modules/ui/sections/map_features.js
index da03991dd..33c526ad9 100644
--- a/modules/ui/sections/map_features.js
+++ b/modules/ui/sections/map_features.js
@@ -33,7 +33,8 @@ export function uiSectionMapFeatures(context) {
             .attr('class', 'feature-list-link')
             .attr('href', '#')
             .html(t.html('issues.disable_all'))
-            .on('click', function() {
+            .on('click', function(d3_event) {
+                d3_event.preventDefault();
                 context.features().disableAll();
             });
 
@@ -42,7 +43,8 @@ export function uiSectionMapFeatures(context) {
             .attr('class', 'feature-list-link')
             .attr('href', '#')
             .html(t.html('issues.enable_all'))
-            .on('click', function() {
+            .on('click', function(d3_event) {
+                d3_event.preventDefault();
                 context.features().enableAll();
             });
 
diff --git a/modules/ui/sections/validation_rules.js b/modules/ui/sections/validation_rules.js
index fd49f1412..07858a460 100644
--- a/modules/ui/sections/validation_rules.js
+++ b/modules/ui/sections/validation_rules.js
@@ -46,7 +46,8 @@ export function uiSectionValidationRules(context) {
             .attr('class', 'issue-rules-link')
             .attr('href', '#')
             .html(t.html('issues.disable_all'))
-            .on('click', function() {
+            .on('click', function(d3_event) {
+                d3_event.preventDefault();
                 context.validator().disableRules(_ruleKeys);
             });
 
@@ -55,7 +56,8 @@ export function uiSectionValidationRules(context) {
             .attr('class', 'issue-rules-link')
             .attr('href', '#')
             .html(t.html('issues.enable_all'))
-            .on('click', function() {
+            .on('click', function(d3_event) {
+                d3_event.preventDefault();
                 context.validator().disableRules([]);
             });
 
diff --git a/modules/ui/sections/validation_status.js b/modules/ui/sections/validation_status.js
index 7f6b85ccb..1aa7d9df6 100644
--- a/modules/ui/sections/validation_status.js
+++ b/modules/ui/sections/validation_status.js
@@ -80,7 +80,8 @@ export function uiSectionValidationStatus(context) {
         resetIgnored.select('a')
             .html(t('inspector.title_count', { title: t.html('issues.reset_ignored'), count: ignoredIssues.length }));
 
-        resetIgnored.on('click', function() {
+        resetIgnored.on('click', function(d3_event) {
+            d3_event.preventDefault();
             context.validator().resetIgnoredIssues();
         });
     }