From 163323d3df89c5e94c3e74ffb6a3f0145e8833db Mon Sep 17 00:00:00 2001 From: Bryan Housel Date: Tue, 8 Aug 2017 09:51:57 -0400 Subject: [PATCH] Make sure bool url params actually contain value 'true' (closes #4222) --- modules/behavior/hash.js | 2 +- modules/util/detect.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/modules/behavior/hash.js b/modules/behavior/hash.js index 7d0626680..431594a7c 100644 --- a/modules/behavior/hash.js +++ b/modules/behavior/hash.js @@ -99,7 +99,7 @@ export function behaviorHash(context) { context.storage('commentDate', Date.now()); } - if (q.walkthrough) { + if (q.walkthrough === 'true') { hash.startWalkthrough = true; } diff --git a/modules/util/detect.js b/modules/util/detect.js index c8b24b35f..ed8f3ad2e 100644 --- a/modules/util/detect.js +++ b/modules/util/detect.js @@ -92,7 +92,7 @@ export function utilDetect(force) { // detect text direction var q = utilStringQs(window.location.hash.substring(1)); var lang = dataLocales[detected.locale]; - if ((lang && lang.rtl) || q.hasOwnProperty('rtl')) { + if ((lang && lang.rtl) || (q.rtl === 'true')) { detected.textDirection = 'rtl'; } else { detected.textDirection = 'ltr';