From 165aa9d4887c9d23970b9c72dc54035a010455fb Mon Sep 17 00:00:00 2001 From: Tom MacWright Date: Sat, 12 Jan 2013 01:12:19 -0500 Subject: [PATCH] Faster string building, do not change value if not different. Fixes #390 --- js/id/svg/tag_classes.js | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/js/id/svg/tag_classes.js b/js/id/svg/tag_classes.js index 495c79e47..43562fd5c 100644 --- a/js/id/svg/tag_classes.js +++ b/js/id/svg/tag_classes.js @@ -12,16 +12,20 @@ iD.svg.TagClasses = function() { classes = value.trim().split(/\s+/).filter(function(name) { return name.length && !tagClassRe.test(name); - }); + }).join(' '); var tags = d.tags; for (var k in tags) { if (!keys[k]) continue; - classes.push('tag-' + k); - classes.push('tag-' + k + '-' + tags[k]); + classes += ' tag-' + k + ' ' + + 'tag-' + k + '-' + tags[k]; } - return d3.select(this).attr('class', classes.join(' ')); + classes = classes.trim(); + + if (classes !== value) { + d3.select(this).attr('class', classes); + } }); }; };