From 19dfcc0162da1597c78fb19ccc9de481cacc575c Mon Sep 17 00:00:00 2001 From: Bryan Housel Date: Mon, 14 May 2018 14:00:12 -0400 Subject: [PATCH] Exclude non-administrative boundary from address city suggestions (closes #5034) --- modules/ui/fields/address.js | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/modules/ui/fields/address.js b/modules/ui/fields/address.js index 0a19e999f..04eefbbf7 100644 --- a/modules/ui/fields/address.js +++ b/modules/ui/fields/address.js @@ -82,18 +82,18 @@ export function uiFieldAddress(field, context) { function isAddressable(d) { - if (d.tags.name && - (d.tags.admin_level === '8' || d.tags.border_type === 'city')) - return true; + if (d.tags.name) { + if (d.tags.admin_level === '8' && d.tags.boundary === 'administrative') + return true; + if (d.tags.border_type === 'city') + return true; + if (d.tags.place === 'city' || d.tags.place === 'town' || d.tags.place === 'village') + return true; + } - if (d.tags.place && d.tags.name && ( - d.tags.place === 'city' || - d.tags.place === 'town' || - d.tags.place === 'village')) + if (d.tags['addr:city']) return true; - if (d.tags['addr:city']) return true; - return false; } }