CalvinBackup/iD
1
0
Fork 0
mirror of https://github.com/FoggedLens/iD.git synced 2026-05-24 00:54:03 +02:00
Code Issues Packages Projects Releases Wiki Activity

Hide mapillary-js attribution and just handle it in iD

Browse Source 
(closes #4526)

What we were doing before was d3.selecting the attribution line and
inserting the capture date into it. This was confusing the viewer
(which updates asynchronously) so that the sitelink would never update.
To make things easier, we'll just hide the viewer's built in attribution
and construct the attribution line the way we want it.
This commit is contained in:
Bryan Housel
2017-11-14 11:32:42 -05:00
parent 8cb930a8ce
commit 1dd437a1f2
4 changed files with 83 additions and 56 deletions
Download Patch File Download Diff File Expand all files Collapse all files
test/spec/services/mapillary.js
+4 -3
View File
@@ -66,7 +66,7 @@ describe('iD.serviceMapillary', function() {
describe('#reset', function() {
it('resets cache and image', function() {
mapillary.cache().foo = 'bar';
mapillary.selectImage({key: 'baz'});
mapillary.selectImage({ key: 'baz', loc: [10,0] });
mapillary.reset();
expect(mapillary.cache()).to.not.have.property('foo');
@@ -432,8 +432,9 @@ describe('iD.serviceMapillary', function() {
describe('#selectImage', function() {
it('gets and sets the selected image', function() {
mapillary.selectImage('foo');
expect(mapillary.getSelectedImage()).to.eql('foo');
var d = { key: 'baz', loc: [10,0] };
mapillary.selectImage(d);
expect(mapillary.getSelectedImage()).to.eql(d);
});
});