From 2207a6c3a42130f51c8a3d6a89a41f73cf1e0aea Mon Sep 17 00:00:00 2001 From: Quincy Morgan Date: Wed, 19 Dec 2018 18:35:17 -0500 Subject: [PATCH] Added severity tooltip to issue icon --- data/core.yaml | 3 +++ dist/locales/en.json | 4 ++++ modules/ui/entity_issues.js | 5 ++++- modules/ui/issues.js | 3 +++ 4 files changed, 14 insertions(+), 1 deletion(-) diff --git a/data/core.yaml b/data/core.yaml index 2ba0f89d7..d3478c6b7 100644 --- a/data/core.yaml +++ b/data/core.yaml @@ -895,6 +895,9 @@ en: all: description: All features tooltip: Issues for all loaded features will be flagged + severity: + error: error + warning: warning intro: done: done ok: OK diff --git a/dist/locales/en.json b/dist/locales/en.json index c0da332ce..4b6362c75 100644 --- a/dist/locales/en.json +++ b/dist/locales/en.json @@ -1064,6 +1064,10 @@ "description": "All features", "tooltip": "Issues for all loaded features will be flagged" } + }, + "severity": { + "error": "error", + "warning": "warning" } }, "intro": { diff --git a/modules/ui/entity_issues.js b/modules/ui/entity_issues.js index 8d2792704..37d6d1c0b 100644 --- a/modules/ui/entity_issues.js +++ b/modules/ui/entity_issues.js @@ -49,7 +49,7 @@ export function uiEntityIssues(context) { .placement('bottom') ) .on('click', function(d) { - + }); var label = enter @@ -58,6 +58,9 @@ export function uiEntityIssues(context) { label.each(function(d) { var iconSuffix = d.severity === 'warning' ? 'alert' : 'error'; d3_select(this) + .append('div') + .attr('title', t('issues.severity.'+d.severity)) + .style('display', 'inline') .call(svgIcon('#iD-icon-' + iconSuffix, 'pre-text')); }); diff --git a/modules/ui/issues.js b/modules/ui/issues.js index 13f38cfa1..01be90005 100644 --- a/modules/ui/issues.js +++ b/modules/ui/issues.js @@ -144,6 +144,9 @@ export function uiIssues(context) { label.each(function(d) { var iconSuffix = d.severity === 'warning' ? 'alert' : 'error'; d3_select(this) + .append('div') + .attr('title', t('issues.severity.'+d.severity)) + .style('display', 'inline') .call(svgIcon('#iD-icon-' + iconSuffix, 'pre-text')); });