CalvinBackup/iD
1
0
Fork 0
mirror of https://github.com/FoggedLens/iD.git synced 2026-03-31 01:09:22 +02:00
Code Issues Packages Projects Releases Wiki Activity

Don't tag redundant ignored warnings counts on changesets

Browse Source
This commit is contained in:
Quincy Morgan
2019-04-26 13:02:13 -07:00
parent 228af9a000
commit 239c622044
1 changed files with 3 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
modules/ui/commit.js
View File

@@ -24,7 +24,6 @@ var readOnlyTags = [
/^imagery_used$/,
/^host$/,
/^locale$/,
/^warnings$/,
/^warnings:/
];
@@ -117,7 +116,7 @@ export function uiCommit(context) {
// remove existing warning counts
for (var key in tags) {
if (key === 'warnings' || key.match(/^warnings:/)) {
if (key.match(/^warnings:/)) {
delete tags[key];
}
}
@@ -126,20 +125,17 @@ export function uiCommit(context) {
var warnings = context.validator()
.getIssuesBySeverity({ what: 'edited', where: 'all' }).warning;
if (warnings.length) {
tags.warnings = warnings.length.toString();
}
var warningsByType = utilArrayGroupBy(warnings, 'type');
for (var warningType in warningsByType) {
var warningsOfType = warningsByType[warningType];
tags['warnings:' + warningType] = warningsOfType.length.toString();
if (warningsOfType[0].subtype) {
var warningsBySubtype = utilArrayGroupBy(warningsOfType, 'subtype');
for (var warningSubtype in warningsBySubtype) {
var warningsOfSubtype = warningsBySubtype[warningSubtype];
tags['warnings:' + warningType + ':' + warningSubtype] = warningsOfSubtype.length.toString();
}
} else {
tags['warnings:' + warningType] = warningsOfType.length.toString();
}
}