From 282695325ce51efd4de33ce0c37b5b7ee40059ca Mon Sep 17 00:00:00 2001 From: Martin Raifer Date: Wed, 29 Dec 2021 09:53:52 +0100 Subject: [PATCH] fix html injection in walkthrough closes #8846 --- modules/ui/intro/area.js | 2 +- modules/ui/intro/building.js | 4 ++-- modules/ui/intro/line.js | 2 +- modules/ui/intro/point.js | 4 ++-- 4 files changed, 6 insertions(+), 6 deletions(-) diff --git a/modules/ui/intro/area.js b/modules/ui/intro/area.js index 158daaee1..d20cee392 100644 --- a/modules/ui/intro/area.js +++ b/modules/ui/intro/area.js @@ -432,7 +432,7 @@ export function uiIntroArea(context, reveal) { }); reveal('.entity-editor-pane', - helpHtml('intro.areas.describe_playground', { button: icon('#iD-icon-close', 'inline') }), + helpHtml('intro.areas.describe_playground', { button: { html: icon('#iD-icon-close', 'inline') } }), { duration: 300 } ); diff --git a/modules/ui/intro/building.js b/modules/ui/intro/building.js index 0f058d320..9b858f4c4 100644 --- a/modules/ui/intro/building.js +++ b/modules/ui/intro/building.js @@ -296,7 +296,7 @@ export function uiIntroBuilding(context, reveal) { timeout(function() { reveal('.entity-editor-pane', - helpHtml('intro.buildings.close', { button: icon('#iD-icon-close', 'inline') }) + helpHtml('intro.buildings.close', { button: { html: icon('#iD-icon-close', 'inline') } }) ); }, 500); @@ -624,7 +624,7 @@ export function uiIntroBuilding(context, reveal) { timeout(function() { reveal('.entity-editor-pane', - helpHtml('intro.buildings.close', { button: icon('#iD-icon-close', 'inline') }) + helpHtml('intro.buildings.close', { button: { html: icon('#iD-icon-close', 'inline') } }) ); }, 500); diff --git a/modules/ui/intro/line.js b/modules/ui/intro/line.js index b5143bfcc..c0d997574 100644 --- a/modules/ui/intro/line.js +++ b/modules/ui/intro/line.js @@ -338,7 +338,7 @@ export function uiIntroLine(context, reveal) { timeout(function() { reveal('.entity-editor-pane', - helpHtml('intro.lines.name_road', { button: icon('#iD-icon-close', 'inline') }), + helpHtml('intro.lines.name_road', { button: { html: icon('#iD-icon-close', 'inline') } }), { tooltipClass: 'intro-lines-name_road' } ); }, 500); diff --git a/modules/ui/intro/point.js b/modules/ui/intro/point.js index 26804c3bc..dd8918c1b 100644 --- a/modules/ui/intro/point.js +++ b/modules/ui/intro/point.js @@ -253,7 +253,7 @@ export function uiIntroPoint(context, reveal) { }); reveal('.entity-editor-pane', - helpHtml('intro.points.add_close', { button: icon(href, 'inline') }) + helpHtml('intro.points.add_close', { button: { html: icon(href, 'inline') } }) ); function continueTo(nextStep) { @@ -350,7 +350,7 @@ export function uiIntroPoint(context, reveal) { timeout(function() { reveal('.entity-editor-pane', - helpHtml('intro.points.update_close', { button: icon('#iD-icon-close', 'inline') }) + helpHtml('intro.points.update_close', { button: { html: icon('#iD-icon-close', 'inline') } }) ); }, 500);