From 2aa409d5a9702f3e9c0c7963a530eb6130e73ca6 Mon Sep 17 00:00:00 2001 From: Bryan Housel Date: Thu, 7 Feb 2019 13:48:29 -0500 Subject: [PATCH] Fix crash when deleting rows in raw tag editor (closes #5840) This didn't always trigger a crash, but it can. It attempted to remove the row containing the key/value input fields, however this ilne is unnecessary because the change event will trigger a redraw and d3 will handle the removing milliseconds later. --- modules/ui/raw_tag_editor.js | 1 - 1 file changed, 1 deletion(-) diff --git a/modules/ui/raw_tag_editor.js b/modules/ui/raw_tag_editor.js index 50b37de57..ccf1bde49 100644 --- a/modules/ui/raw_tag_editor.js +++ b/modules/ui/raw_tag_editor.js @@ -347,7 +347,6 @@ export function uiRawTagEditor(context) { var t = {}; t[d.key] = undefined; dispatch.call('change', this, t); - d3_select(this.parentNode).remove(); }