From 2b1559bb96cab5171a8d6aef823faa9fc1744514 Mon Sep 17 00:00:00 2001
From: John Firebaugh <john.firebaugh@gmail.com>
Date: Sun, 2 Dec 2012 14:12:30 -0800
Subject: [PATCH] d3 style map

---
 js/id/id.js           | 18 ++++++----
 js/id/renderer/map.js | 81 +++++++++++++++++++++++++------------------
 test/spec/Map.js      | 11 +++++-
 3 files changed, 68 insertions(+), 42 deletions(-)

diff --git a/js/id/id.js b/js/id/id.js
index 29d2ebd6b..cfbd0a1fc 100644
--- a/js/id/id.js
+++ b/js/id/id.js
@@ -10,14 +10,18 @@ var iD = function(container) {
 
     container = d3.select(container);
 
-    var m = container.append('div')
-            .attr('id', 'map'),
-        connection = iD.Connection()
+    var connection = iD.Connection()
             .url('http://api06.dev.openstreetmap.org'),
-        map = iD.Map(m.node(), connection),
-        controller = iD.Controller(map),
-        bar = container.append('div')
-            .attr('id', 'bar');
+        map = iD.Map()
+            .connection(connection),
+        controller = iD.Controller(map);
+
+    var m = container.append('div')
+        .attr('id', 'map')
+        .call(map);
+
+    var bar = container.append('div')
+        .attr('id', 'bar');
 
     var buttons = bar.selectAll('button.add-button')
         .data([iD.modes.AddPlace, iD.modes.AddRoad, iD.modes.AddArea])
diff --git a/js/id/renderer/map.js b/js/id/renderer/map.js
index 2f768785e..cf64edaa6 100644
--- a/js/id/renderer/map.js
+++ b/js/id/renderer/map.js
@@ -1,10 +1,8 @@
-iD.Map = function(elem, connection) {
-
-    var map = { history: iD.History() },
+iD.Map = function() {
+    var connection,
         dimensions = [],
         dispatch = d3.dispatch('move', 'update'),
         inspector = iD.Inspector(),
-        parent = d3.select(elem),
         selection = null,
         translateStart,
         apiTilesLoaded = {},
@@ -39,39 +37,53 @@ iD.Map = function(elem, connection) {
         },
         getline = function(d) { return d._line; },
         key = function(d) { return d.id; },
-        supersurface = parent.append('div').call(zoom),
-        surface = supersurface.append('svg'),
-        defs = surface.append('defs'),
-        tilegroup = surface.append('g')
-            .on('click', deselectClick),
         background = iD.Background()
             .projection(projection),
-        r = surface.append('g')
-            .on('click', selectClick)
-            .on('mouseover', nameHoverIn)
-            .on('mouseout', nameHoverOut)
-            .attr('clip-path', 'url(#clip)'),
-        g = ['fill', 'casing', 'stroke', 'text', 'hit', 'temp'].reduce(function(mem, i) {
-            return (mem[i] = r.append('g').attr('class', 'layer-g')) && mem;
-        }, {}),
         class_stroke = iD.Style.styleClasses('stroke'),
         class_fill = iD.Style.styleClasses('stroke'),
         class_area = iD.Style.styleClasses('area'),
         class_casing = iD.Style.styleClasses('casing'),
-        alength = (function() {
-            var arrow = surface.append('text').text('►----');
-            var alength = arrow.node().getComputedTextLength();
-            arrow.remove();
-            return alength;
-        })(),
         prefix = prefixMatch(['webkit', 'ms', 'Moz', 'O']),
-        transformProp = prefix + 'transform';
+        transformProp = prefix + 'transform',
+        supersurface, surface, defs, tilegroup, r, g, alength;
 
-    defs.append('clipPath')
-        .attr('id', 'clip')
-        .append('rect')
-        .attr('id', 'clip-rect')
-        .attr({ x: 0, y: 0 });
+    function map() {
+        supersurface = this.append('div').call(zoom);
+
+        surface = supersurface.append('svg')
+            .on('mouseup', resetTransform)
+            .on('touchend', resetTransform);
+
+        defs = surface.append('defs');
+        defs.append('clipPath')
+                .attr('id', 'clip')
+            .append('rect')
+                .attr('id', 'clip-rect')
+                .attr({ x: 0, y: 0 });
+
+        tilegroup = surface.append('g')
+            .on('click', deselectClick);
+
+        r = surface.append('g')
+            .on('click', selectClick)
+            .on('mouseover', nameHoverIn)
+            .on('mouseout', nameHoverOut)
+            .attr('clip-path', 'url(#clip)');
+
+        g = ['fill', 'casing', 'stroke', 'text', 'hit', 'temp'].reduce(function(mem, i) {
+            return (mem[i] = r.append('g').attr('class', 'layer-g')) && mem;
+        }, {});
+
+        var arrow = surface.append('text').text('►----');
+        alength = arrow.node().getComputedTextLength();
+        arrow.remove();
+
+        map.size(this.size());
+
+        hideInspector();
+    };
+
+    map.history = iD.History();
 
     function prefixMatch(p) { // via mbostock
         var i = -1, n = p.length, s = document.body.style;
@@ -409,8 +421,6 @@ iD.Map = function(elem, connection) {
         redraw();
     }
 
-    surface.on('mouseup', resetTransform).on('touchend', resetTransform);
-
     function redraw(only) {
         if (!only) {
             dispatch.move(map);
@@ -515,6 +525,12 @@ iD.Map = function(elem, connection) {
         return map;
     };
 
+    map.connection = function(_) {
+      if (!arguments.length) return connection;
+      connection = _;
+      return map;
+    };
+
     map.surface = surface;
     map.background = background;
     map.projection = projection;
@@ -522,8 +538,5 @@ iD.Map = function(elem, connection) {
     map.selectEntity = selectEntity;
     map.dblclickEnable = dblclickEnable;
 
-    map.size(parent.size());
-    hideInspector();
-
     return d3.rebind(map, dispatch, 'on', 'move', 'update');
 };
diff --git a/test/spec/Map.js b/test/spec/Map.js
index d42d83bf1..53672d318 100644
--- a/test/spec/Map.js
+++ b/test/spec/Map.js
@@ -3,13 +3,22 @@ describe('Map', function() {
 
     beforeEach(function() {
         container = d3.select('body').append('div');
-        map = iD.Map(container.node());
+        map = iD.Map();
+        container.call(map);
     });
 
     afterEach(function() {
         container.remove();
     });
 
+    describe('#connection', function() {
+        it('gets and sets connection', function() {
+            var connection = {};
+            expect(map.connection(connection)).toBe(map);
+            expect(map.connection()).toBe(connection);
+        });
+    });
+
     describe('#zoom', function() {
         it('gets and sets zoom level', function() {
             expect(map.zoom(4)).toEqual(map);