From 2ca52e75ce91fc415eedcceb3edb5b4e160366da Mon Sep 17 00:00:00 2001
From: Martin Raifer <martin@raifer.tech>
Date: Tue, 24 May 2022 14:18:17 +0200
Subject: [PATCH] Do not overwrite existing `*=no` tags by a preset's `addTags`

---
 CHANGELOG.md              | 1 +
 modules/presets/preset.js | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index f6c6bec18..a50a59c6b 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -56,6 +56,7 @@ _Breaking developer changes, which may affect downstream projects or sites that
 * Use value of `vehicle` tag as placeholder value of `access` fields for `motor_vehicle` and `bicycle`
 * Render `golf` features `tee`, `fairway`, `rough` and `green` in green color and using a grass pattern ([#8927])
 * Tweak preset-matching to penalize non-searchable presets when matching OSM objects to presets
+* Do not overwrite existing `*=no` tags by a preset's `addTags`
 #### Other
 * Redact more API tokens from custom imagery sources in changeset metadata tags ([#8976], thanks [@k-yle])
 #### :hammer: Development
diff --git a/modules/presets/preset.js b/modules/presets/preset.js
index 3f9dd1513..9e96e1ae4 100644
--- a/modules/presets/preset.js
+++ b/modules/presets/preset.js
@@ -207,7 +207,7 @@ export function presetPreset(presetID, preset, addable, allFields, allPresets) {
     for (let k in addTags) {
       if (addTags[k] === '*') {
         // if this tag is ancillary, don't override an existing value since any value is okay
-        if (_this.tags[k] || !tags[k] || tags[k] === 'no') {
+        if (_this.tags[k] || !tags[k]) {
           tags[k] = 'yes';
         }
       } else {