From 2d8969dbe3d5c15240b6b3666ce355c3630e0f0c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Minh=20Nguy=E1=BB=85n?= Date: Sun, 14 Jun 2015 17:11:27 -0700 Subject: [PATCH] Fixed test & lint errors The anchor may not always be present. --- js/id/ui/preset/wikipedia.js | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/js/id/ui/preset/wikipedia.js b/js/id/ui/preset/wikipedia.js index dbc0f5217..732211e20 100644 --- a/js/id/ui/preset/wikipedia.js +++ b/js/id/ui/preset/wikipedia.js @@ -98,7 +98,7 @@ iD.ui.preset.wikipedia = function(field, context) { } catch (e) { anchor = decodeURIComponent(m[3]); } - value += "#" + anchor.replace(/_/g, ' '); + value += '#' + anchor.replace(/_/g, ' '); } value = value.slice(0, 1).toUpperCase() + value.slice(1); lang.value(l[1]); @@ -120,11 +120,13 @@ iD.ui.preset.wikipedia = function(field, context) { if (l) { lang.value(l[1]); title.value(m[2] + (anchor ? ('#' + anchor) : '')); - try { - // Best-effort `anchorencode:` implementation - anchor = encodeURIComponent(anchor.replace(/ /g, '_')).replace(/%/g, '.'); - } catch (e) { - anchor = anchor.replace(/ /g, '_'); + if (anchor) { + try { + // Best-effort `anchorencode:` implementation + anchor = encodeURIComponent(anchor.replace(/ /g, '_')).replace(/%/g, '.'); + } catch (e) { + anchor = anchor.replace(/ /g, '_'); + } } link.attr('href', 'http://' + m[1] + '.wikipedia.org/wiki/' + m[2].replace(/ /g, '_') + (anchor ? ('#' + anchor) : ''));