From 2da011c3ca35c8b1d7088ccde632cdb6fdfd5da3 Mon Sep 17 00:00:00 2001 From: Quincy Morgan Date: Wed, 27 Feb 2019 12:20:23 -0500 Subject: [PATCH] Remove unused string Don't show preset browser when adding a favorite point Don't automatically open the sidebar when selecting a non-new feature --- data/core.yaml | 1 - dist/locales/en.json | 3 +-- modules/modes/add_point.js | 4 ++-- modules/ui/sidebar.js | 6 ++++-- 4 files changed, 7 insertions(+), 7 deletions(-) diff --git a/data/core.yaml b/data/core.yaml index cc680cab8..ca8a5340b 100644 --- a/data/core.yaml +++ b/data/core.yaml @@ -49,7 +49,6 @@ en: vertex: Added a node to a way. relation: Added a relation. note: Added a note. - title: Add start: annotation: line: Started a line. diff --git a/dist/locales/en.json b/dist/locales/en.json index a1dee379d..b41a90abf 100644 --- a/dist/locales/en.json +++ b/dist/locales/en.json @@ -64,8 +64,7 @@ "vertex": "Added a node to a way.", "relation": "Added a relation.", "note": "Added a note." - }, - "title": "Add" + } }, "start": { "annotation": { diff --git a/modules/modes/add_point.js b/modules/modes/add_point.js index e5c77d0cf..c50b287ba 100644 --- a/modules/modes/add_point.js +++ b/modules/modes/add_point.js @@ -36,7 +36,7 @@ export function modeAddPoint(context, customMode) { ); context.enter( - modeSelect(context, [node.id]).newFeature(true) + modeSelect(context, [node.id]).newFeature(!mode.preset) ); } @@ -50,7 +50,7 @@ export function modeAddPoint(context, customMode) { ); context.enter( - modeSelect(context, [node.id]).newFeature(true) + modeSelect(context, [node.id]).newFeature(!mode.preset) ); } diff --git a/modules/ui/sidebar.js b/modules/ui/sidebar.js index 25d8abd62..b33943003 100644 --- a/modules/ui/sidebar.js +++ b/modules/ui/sidebar.js @@ -215,8 +215,10 @@ export function uiSidebar(context) { var entity = context.entity(id); // uncollapse the sidebar if (selection.classed('collapsed')) { - var extent = entity.extent(context.graph()); - sidebar.expand(sidebar.intersects(extent)); + if (newFeature) { + var extent = entity.extent(context.graph()); + sidebar.expand(sidebar.intersects(extent)); + } } featureListWrap