Restore tooltips on rule checkboxes, separate 'tip' and 'reference'

Reference will show on clicking info button, and can contain more
useful information than a tooltip can.

modules/ui/issues.js

@@ -305,16 +305,19 @@ export function uiIssues(context) {
         updateRulesList();
     }
 
+
     function updateRulesList() {
         var ruleKeys = context.validator().getRuleKeys();
         _rulesList
             .call(drawListItems, ruleKeys, 'checkbox', 'rule', toggleRule, isRuleEnabled);
     }
 
+
     function isRuleEnabled(d) {
         return context.validator().isRuleEnabled(d);
     }
 
+
     function toggleRule(d) {
         context.validator().toggleRule(d);
     }
@@ -398,6 +401,14 @@ export function uiIssues(context) {
         var enter = items.enter()
             .append('li');
 
+        if (name === 'rule') {
+            enter
+                .call(tooltip()
+                    .title(function(d) { return t('issues.' + d + '.tip'); })
+                    .placement('top')
+                );
+        }
+
         var label = enter
             .append('label');
 

modules/validations/almost_junction.js

@@ -111,7 +111,7 @@ export function validationAlmostJunction() {
                 .enter()
                 .append('div')
                 .attr('class', 'issue-reference')
-                .text(t('issues.almost_junction.highway-highway.tip'));
+                .text(t('issues.almost_junction.highway-highway.reference'));
         }
 
 

modules/validations/crossing_ways.js

@@ -517,7 +517,7 @@ export function validationCrossingWays() {
                 .enter()
                 .append('div')
                 .attr('class', 'issue-reference')
-                .text(t('issues.crossing_ways.' + crossingTypeID + '.tip'));
+                .text(t('issues.crossing_ways.' + crossingTypeID + '.reference'));
         }
     }
 

modules/validations/disconnected_way.js

@@ -89,7 +89,7 @@ export function validationDisconnectedWay() {
                 .enter()
                 .append('div')
                 .attr('class', 'issue-reference')
-                .text(t('issues.disconnected_way.highway.tip'));
+                .text(t('issues.disconnected_way.highway.reference'));
         }
 
 

modules/validations/generic_name.js

@@ -84,7 +84,7 @@ export function validationGenericName() {
                 .enter()
                 .append('div')
                 .attr('class', 'issue-reference')
-                .text(t('issues.generic_name.tip'));
+                .text(t('issues.generic_name.reference'));
         }
     };
 

modules/validations/incompatible_source.js

@@ -43,7 +43,7 @@ export function validationIncompatibleSource() {
                     .enter()
                     .append('div')
                     .attr('class', 'issue-reference')
-                    .text(t('issues.incompatible_source.' + id + '.tip'));
+                    .text(t('issues.incompatible_source.' + id + '.reference'));
             };
         }
     };

modules/validations/missing_role.js

@@ -72,7 +72,7 @@ export function validationMissingRole() {
                 .enter()
                 .append('div')
                 .attr('class', 'issue-reference')
-                .text(t('issues.missing_role.multipolygon.tip'));
+                .text(t('issues.missing_role.multipolygon.reference'));
         }
     }
 

modules/validations/missing_tag.js

@@ -102,7 +102,7 @@ export function validationMissingTag() {
                 .enter()
                 .append('div')
                 .attr('class', 'issue-reference')
-                .text(t('issues.missing_tag.tip'));
+                .text(t('issues.missing_tag.reference'));
         }
     };
 

modules/validations/old_multipolygon.js

@@ -57,7 +57,7 @@ export function validationOldMultipolygon() {
                 .enter()
                 .append('div')
                 .attr('class', 'issue-reference')
-                .text(t('issues.old_multipolygon.tip'));
+                .text(t('issues.old_multipolygon.reference'));
         }
     };
 

modules/validations/outdated_tags.js

@@ -88,7 +88,7 @@ export function validationOutdatedTags() {
             enter
                 .append('div')
                 .attr('class', 'issue-reference')
-                .text(t('issues.outdated_tags.tip'));
+                .text(t('issues.outdated_tags.reference'));
 
             enter
                 .append('strong')

modules/validations/private_data.js

@@ -96,7 +96,7 @@ export function validationPrivateData() {
             enter
                 .append('div')
                 .attr('class', 'issue-reference')
-                .text(t('issues.private_data.tip'));
+                .text(t('issues.private_data.reference'));
 
             enter
                 .append('strong')

modules/validations/tag_suggests_area.js

@@ -107,7 +107,7 @@ export function validationTagSuggestsArea() {
                 .enter()
                 .append('div')
                 .attr('class', 'issue-reference')
-                .text(t('issues.tag_suggests_area.tip'));
+                .text(t('issues.tag_suggests_area.reference'));
         }
     };
 

modules/validations/unknown_road.js

@@ -54,7 +54,7 @@ export function validationUnknownRoad() {
                 .enter()
                 .append('div')
                 .attr('class', 'issue-reference')
-                .text(t('issues.unknown_road.tip'));
+                .text(t('issues.unknown_road.reference'));
         }
     };