diff --git a/CHANGELOG.md b/CHANGELOG.md index c43eba89d..ed3308514 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -54,6 +54,7 @@ _Breaking developer changes, which may affect downstream projects or sites that * The Suspicious Names validator warning now compares the Name field to the preset’s name in the user’s language, not just the raw tag value (typically in British English). ([#9522], thanks [@k-yle]) * Revalidate ways that are connected to the currently edited way to also properly update/catch _disconnected way_s and _impossible oneway_ errors ([#8911], thanks [@andrewpmk]) * Preserve `crossing:markings` tag when fixing missing connection of crossing path and road ([#9586], thanks [@jtracey]) +* Add a dedicated description to fix waterway-road intersections by adding a _culvert_ ([#10778], thanks [@matkoniecz]) #### :bug: Bugfixes * Prevent degenerate ways caused by deleting a corner of a triangle ([#10003], thanks [@k-yle]) * Fix briefly disappearing data layer during background layer tile layer switching transition ([#10748]) @@ -67,7 +68,7 @@ _Breaking developer changes, which may affect downstream projects or sites that * Add `housename` to address format in Bolivia ([#10727]) #### :hourglass: Performance #### :mortar_board: Walkthrough / Help -* Fix walkthrough from not correctly registering deleted ways in "Lines" step ([#10776]) +* Fix walkthrough from not correctly registering deleted ways in "Lines" step ([#10776]) #### :rocket: Presets #### :hammer: Development * Enable Intellisense (IDE auto-completion) for the main classes ([#10618], thanks [@k-yle]) @@ -93,6 +94,7 @@ _Breaking developer changes, which may affect downstream projects or sites that [#10764]: https://github.com/openstreetmap/iD/issues/10764 [#10766]: https://github.com/openstreetmap/iD/pull/10766 [#10776]: https://github.com/openstreetmap/iD/issues/10776 +[#10778]: https://github.com/openstreetmap/iD/issues/10778 [@hlfan]: https://github.com/hlfan [@Deeptanshu-sankhwar]: https://github.com/Deeptanshu-sankhwar [@draunger]: https://github.com/draunger diff --git a/data/core.yaml b/data/core.yaml index 8605daa88..656c89145 100644 --- a/data/core.yaml +++ b/data/core.yaml @@ -1967,6 +1967,9 @@ en: add_a_tunnel: title: Add a tunnel annotation: Added a tunnel. + add_a_culvert: + title: Add a culvert + annotation: Added a culvert. address_the_concern: title: Address the concern connect_almost_junction: diff --git a/modules/validations/crossing_ways.js b/modules/validations/crossing_ways.js index 5c7751dbf..f4085f941 100644 --- a/modules/validations/crossing_ways.js +++ b/modules/validations/crossing_ways.js @@ -505,7 +505,12 @@ export function validationCrossingWays(context) { // don't recommend adding tunnels under waterways since they're uncommon var skipTunnelFix = otherFeatureType === 'waterway' && selectedFeatureType !== 'waterway'; if (allowsTunnel(selectedFeatureType) && !skipTunnelFix) { - fixes.push(makeAddBridgeOrTunnelFix('add_a_tunnel', 'temaki-tunnel', 'tunnel')); + if (selectedFeatureType === 'waterway') { + // naming piped waterway "tunnel" is a confusing osmism, culvert should be more clear + fixes.push(makeAddBridgeOrTunnelFix('add_a_culvert', 'temaki-waste', 'tunnel')); + } else { + fixes.push(makeAddBridgeOrTunnelFix('add_a_tunnel', 'temaki-tunnel', 'tunnel')); + } } }