CalvinBackup/iD
1
0
Fork 0
mirror of https://github.com/FoggedLens/iD.git synced 2026-05-19 23:14:47 +02:00
Code Issues Packages Projects Releases Wiki Activity

Drop more/less toggle and just use a scrollbar for long comments

Browse Source
This commit is contained in:
Bryan Housel
2018-07-11 16:00:54 -04:00
parent e9e2f9ba8f
commit 3454753bf6
4 changed files with 9 additions and 50 deletions
Download Patch File Download Diff File Expand all files Collapse all files
modules/ui/note_comments.js
+2 -43
View File
@@ -67,55 +67,14 @@ export function uiNoteComments() {
mainEnter
.append('div')
.attr('class', function(d) {
var trunc = (d.text.length > commentLimit);
return 'comment-text' + (trunc ? ' truncated' : '');
})
.text(function(d) {
var trunc = (d.text.length > commentLimit);
return trunc ? d.text.slice(0, commentLimit) + '…' : d.text;
});
mainEnter
.each(function(d) {
var selection = d3_select(this);
var trunc = (d.text.length > commentLimit);
if (!trunc) return;
selection
.append('a')
.attr('class', 'comment-toggle-more')
.attr('href', '#')
.attr('tabindex', -1)
.attr('target', '_blank')
.text(t('note.more'))
.on('click', toggleMore);
});
.attr('class', 'comment-text')
.text(function(d) { return d.text; });
comments
.call(replaceAvatars);
}
function toggleMore() {
d3_event.preventDefault();
var selection = d3_select(this.parentNode); // select .comment-main
var commentText = selection.selectAll('.comment-text');
var commentToggle = selection.selectAll('.comment-toggle-more');
var trunc = !commentText.classed('truncated');
commentText
.classed('truncated', trunc)
.text(function(d) {
return trunc ? d.text.slice(0, commentLimit) + '…' : d.text;
});
commentToggle
.text(t('note.' + (trunc ? 'more' : 'less')));
}
function replaceAvatars(selection) {
var osm = services.osm;
if (!osm) return;