From 36a564f453ce1ab9bcd1f093275e9c09d82dc7d0 Mon Sep 17 00:00:00 2001 From: Quincy Morgan Date: Fri, 10 May 2019 12:14:29 -0400 Subject: [PATCH] Add explicit check for very close nodes with an identical location --- modules/validations/close_nodes.js | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/modules/validations/close_nodes.js b/modules/validations/close_nodes.js index f664870ad..ad9d9d990 100644 --- a/modules/validations/close_nodes.js +++ b/modules/validations/close_nodes.js @@ -84,11 +84,15 @@ export function validationCloseNodes() { function getIssueIfAny(node1, node2, way, context) { if (node1.id === node2.id || - (node1.hasInterestingTags() && node2.hasInterestingTags()) || - geoSphericalDistance(node1.loc, node2.loc) >= thresholdMeters) { + (node1.hasInterestingTags() && node2.hasInterestingTags())) { return null; } + var nodesAreVeryClose = node1.loc === node2.loc || + geoSphericalDistance(node1.loc, node2.loc) < thresholdMeters; + + if (!nodesAreVeryClose) return null; + return new validationIssue({ type: type, severity: 'warning',