From 3917f02067fe8bcc8a70ff16d2748203b6c41535 Mon Sep 17 00:00:00 2001 From: Bryan Housel Date: Fri, 2 Mar 2018 00:42:24 -0500 Subject: [PATCH] When combobox is attached to textarea, let user up/down arrow (closes #4750) --- modules/lib/d3.combobox.js | 3 +++ 1 file changed, 3 insertions(+) diff --git a/modules/lib/d3.combobox.js b/modules/lib/d3.combobox.js index 60c2ecbdc..a33ba9e1c 100644 --- a/modules/lib/d3.combobox.js +++ b/modules/lib/d3.combobox.js @@ -36,6 +36,7 @@ export function d3combobox() { .selectAll('div.combobox') .filter(function(d) { return d === input.node(); }); var shown = !wrapper.empty(); + var tagName = input.node() ? input.node().tagName.toLowerCase() : ''; input .classed('combobox-input', true) @@ -139,11 +140,13 @@ export function d3combobox() { break; // up arrow case 38: + if (tagName === 'textarea' && !shown) return; nav(-1); d3_event.preventDefault(); break; // down arrow case 40: + if (tagName === 'textarea' && !shown) return; nav(+1); d3_event.preventDefault(); break;