Avoid creating comboboxes

(closes #5568)

Several strategies in here:
- Move uiCombobox() from inside the render function to class variable
- Don't render stuff like the raw tag editor when it's collapsed
- Don't show as many fields/combos on hover
- Don't instantiate fields (like universal/more) until they're actually shown
- Bind the combo on enter selection not on update selection
This commit is contained in:
Bryan Housel
2018-12-11 16:07:00 -05:00
parent 222b3f1b04
commit 39b3f1df68
16 changed files with 135 additions and 115 deletions
+2 -2
View File
@@ -11,6 +11,7 @@ import { utilRebind, utilTriggerEvent } from '../util';
export function uiChangesetEditor(context) {
var dispatch = d3_dispatch('change');
var formFields = uiFormFields(context);
var commentCombo = uiCombobox(context, 'comment').caseSensitive(true);
var _fieldsArr;
var _tags;
var _changesetID;
@@ -78,8 +79,7 @@ export function uiChangesetEditor(context) {
});
commentField
.call(uiCombobox(context)
.caseSensitive(true)
.call(commentCombo
.data(_uniqBy(comments, 'title'))
);
});