From 424f6ca72d238875db207bb6f592181e059c0528 Mon Sep 17 00:00:00 2001
From: Quincy Morgan <quincy.morgan@icloud.com>
Date: Thu, 2 May 2019 11:51:01 -0700
Subject: [PATCH] Don't skip other validations even if there are missing tag
 issues

---
 modules/core/validator.js | 26 ++++++++++++--------------
 1 file changed, 12 insertions(+), 14 deletions(-)

diff --git a/modules/core/validator.js b/modules/core/validator.js
index 7ddf18a5f..a0014eb2d 100644
--- a/modules/core/validator.js
+++ b/modules/core/validator.js
@@ -240,6 +240,8 @@ export function coreValidator(context) {
             return !detected.length;
         }
 
+        // run some validations manually to control the order and to skip some
+
         runValidation('missing_role');
 
         if (entity.type === 'relation') {
@@ -249,26 +251,22 @@ export function coreValidator(context) {
             }
         }
 
-        // other _rules require feature to be tagged
-        if (!runValidation('missing_tag')) return entityIssues;
+        runValidation('missing_tag');
 
-        // run outdated_tags early
         runValidation('outdated_tags');
 
-        if (entity.type === 'way') {
-            runValidation('crossing_ways');
-            runValidation('almost_junction');
+        runValidation('crossing_ways');
+        runValidation('almost_junction');
 
-            // only check impossible_oneway if no disconnected_way issues
-            if (runValidation('disconnected_way')) {
-                runValidation('impossible_oneway');
-            } else {
-                ran.impossible_oneway = true;
-            }
-
-            runValidation('tag_suggests_area');
+        // only check impossible_oneway if no disconnected_way issues
+        if (runValidation('disconnected_way')) {
+            runValidation('impossible_oneway');
+        } else {
+            ran.impossible_oneway = true;
         }
 
+        runValidation('tag_suggests_area');
+
         // run all rules not yet run
         Object.keys(_rules).forEach(runValidation);