From 460ea42c952430a5801744d0946f285c38dbd32b Mon Sep 17 00:00:00 2001 From: Bryan Housel Date: Tue, 27 Sep 2016 00:12:37 -0400 Subject: [PATCH] Fix enter/update selections for multicombo chips --- modules/ui/fields/combo.js | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/modules/ui/fields/combo.js b/modules/ui/fields/combo.js index 1b230bb48..b08a9972a 100644 --- a/modules/ui/fields/combo.js +++ b/modules/ui/fields/combo.js @@ -301,7 +301,11 @@ export function combo(field, context) { // Render chips - var chips = container.selectAll('.chips').data(multiData); + var chips = container.selectAll('.chips') + .data(multiData); + + chips.exit() + .remove(); var enter = chips.enter() .insert('li', 'input') @@ -310,6 +314,8 @@ export function combo(field, context) { enter.append('span'); enter.append('a'); + chips = chips.merge(enter); + chips.select('span') .text(function(d) { return d.value; }); @@ -318,9 +324,6 @@ export function combo(field, context) { .attr('class', 'remove') .text('×'); - chips.exit() - .remove(); - } else { getSetValue(input, displayValue(tags[field.key])); }