Fix error reporting urls and make sure sidebar not showing stale data

This commit is contained in:
Bryan Housel
2019-01-03 11:37:14 -05:00
parent 0256ad7f0d
commit 46ebce2d6f
14 changed files with 72 additions and 75 deletions
+7 -3
View File
@@ -71,8 +71,12 @@ export function uiKeepRightEditor(context) {
function keepRightSaveSection(selection) {
var isSelected = (_error && _error.id === context.selectedErrorID());
var isShown = (_error && (isSelected || _error.newComment || _error.comment));
var saveSection = selection.selectAll('.error-save')
.data((isSelected ? [_error] : []), function(d) { return d.status + d.id; });
.data(
(isShown ? [_error] : []),
function(d) { return d.id + '-' + (d.status || 0); }
);
// exit
saveSection.exit()
@@ -206,9 +210,9 @@ export function uiKeepRightEditor(context) {
}
keepRightEditor.error = function(_) {
keepRightEditor.error = function(val) {
if (!arguments.length) return _error;
_error = _;
_error = val;
return keepRightEditor;
};